[Libreoffice-commits] core.git: 19 commits - filter/source lotuswordpro/source svx/source sw/source tools/source

Caolán McNamara caolanm at redhat.com
Fri Apr 11 06:11:50 PDT 2014


 filter/source/graphicfilter/iras/iras.cxx       |   10 +++
 lotuswordpro/source/filter/localtime.hxx        |   12 ++++
 lotuswordpro/source/filter/lwpbasetype.hxx      |   14 ++++
 lotuswordpro/source/filter/lwpsdwdrawheader.hxx |   71 ++++++++++++++++++++++--
 svx/source/gallery2/galtheme.cxx                |   17 +++--
 svx/source/inc/fmexpl.hxx                       |    5 +
 svx/source/svdraw/svddrgmt.cxx                  |    6 +-
 svx/source/svdraw/svdotext.cxx                  |    2 
 svx/source/svdraw/svdundo.cxx                   |    7 +-
 sw/source/core/tox/tox.cxx                      |    2 
 sw/source/core/undo/unnum.cxx                   |    9 ++-
 sw/source/core/view/vprint.cxx                  |    1 
 tools/source/generic/bigint.cxx                 |    1 
 13 files changed, 134 insertions(+), 23 deletions(-)

New commits:
commit 999377f113fc8f4af4f08b7285658c8c081f6c0b
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 13:54:01 2014 +0100

    coverity#738639 Uninitialized scalar field
    
    Change-Id: Ib7c75d87237113641fd80e5a87dc08cbf1910a55

diff --git a/filter/source/graphicfilter/iras/iras.cxx b/filter/source/graphicfilter/iras/iras.cxx
index 0d26b51..705381a 100644
--- a/filter/source/graphicfilter/iras/iras.cxx
+++ b/filter/source/graphicfilter/iras/iras.cxx
@@ -69,7 +69,17 @@ RASReader::RASReader(SvStream &rRAS)
     : m_rRAS(rRAS)
     , mbStatus(sal_True)
     , mpAcc(NULL)
+    , mnWidth(0)
+    , mnHeight(0)
+    , mnDstBitsPerPix(0)
+    , mnDstColors(0)
+    , mnDepth(0)
+    , mnImageDatSize(0)
+    , mnType(0)
+    , mnColorMapType(0)
+    , mnColorMapSize(0)
     , mnRepCount(0)
+    , mnRepVal(0)
     , mbPalette(sal_False)
 {
 }
commit 01dca77a77118bf95f0948d38b26088e9b2357b3
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 13:48:59 2014 +0100

    coverity#738684 Uninitialized scalar field
    
    Change-Id: I07b698a72ada7a56fb8b63232f25ee5a5edfc185

diff --git a/lotuswordpro/source/filter/lwpbasetype.hxx b/lotuswordpro/source/filter/lwpbasetype.hxx
index 9f83d51..7ca08e1 100644
--- a/lotuswordpro/source/filter/lwpbasetype.hxx
+++ b/lotuswordpro/source/filter/lwpbasetype.hxx
@@ -75,7 +75,19 @@
 class LwpPanoseNumber
 {
 public:
-    LwpPanoseNumber(){}
+    LwpPanoseNumber()
+        : m_nFamilyType(0)
+        , m_nSerifStyle(0)
+        , m_nWeight(0)
+        , m_nProportion(0)
+        , m_nContrast(0)
+        , m_nStrokeVariation(0)
+        , m_nArmStyle(0)
+        , m_nLetterform(0)
+        , m_nMidline(0)
+        , m_nXHeight(0)
+    {
+    }
     ~LwpPanoseNumber(){}
 public:
     void Read(LwpObjectStream *pStrm);
commit 46575addc41f13d92f1320a819e8c7ef766974d4
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 13:45:22 2014 +0100

    coverity#738695 Uninitialized scalar field
    
    Change-Id: I5a96a726d956f0eac0a7e5441e6fcbb2fd0ae204

diff --git a/lotuswordpro/source/filter/localtime.hxx b/lotuswordpro/source/filter/localtime.hxx
index 85b000c..e392029 100644
--- a/lotuswordpro/source/filter/localtime.hxx
+++ b/lotuswordpro/source/filter/localtime.hxx
@@ -67,6 +67,18 @@ struct LtTm
     long tm_wday;    /* days since Sunday - [0,6] */
     long tm_yday;    /* days since January 1 - [0,365] */
     long tm_isdst;   /* daylight savings time flag */
+    LtTm()
+        : tm_sec(0)
+        , tm_min(0)
+        , tm_hour(0)
+        , tm_mday(0)
+        , tm_mon(0)
+        , tm_year(0)
+        , tm_wday(0)
+        , tm_yday(0)
+        , tm_isdst(0)
+    {
+    }
 };
 bool LtgGmTime(long rtime,LtTm& rtm);
 bool LtgLocalTime(long rtime,LtTm& rtm);
commit 2e87d4241f36b66a1628b0f8c7bb610c63b8c450
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 13:41:35 2014 +0100

    coverity#738696 Uninitialized scalar field
    
    Change-Id: I96fd8829d8854e3d3412ef4a0ba9fadf838e0f48

diff --git a/lotuswordpro/source/filter/lwpsdwdrawheader.hxx b/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
index a755dfa..af6ae5f 100644
--- a/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
+++ b/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
@@ -257,6 +257,12 @@ struct SdwArcRecord
     sal_uInt8 nLineEnd;
     sal_uInt8 nLineStyle;
     SdwColor aPenColor;
+    SdwArcRecord()
+        : nLineWidth(0)
+        , nLineEnd(0)
+        , nLineStyle(0)
+    {
+    }
 };
 
 struct SdwTextBoxRecord
commit 711470cdee4019180150dccbdb7b826f678ad025
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 13:38:46 2014 +0100

    coverity#738697 Uninitialized scalar field
    
    Change-Id: I5edf11a51b4d32a1a7257857b03ce7814af442e3

diff --git a/lotuswordpro/source/filter/lwpsdwdrawheader.hxx b/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
index 5194113..a755dfa 100644
--- a/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
+++ b/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
@@ -187,19 +187,30 @@ struct SdwClosedObjStyleRec
     SdwColor aBackColor;
     sal_uInt16 nFillType;
     sal_uInt8 pFillPattern[8];
+    SdwClosedObjStyleRec()
+        : nLineWidth(0)
+        , nLineStyle(0)
+        , nFillType(0)
+    {
+        memset(pFillPattern, 0, sizeof(pFillPattern));
+    }
 };
 
 struct SdwDrawObjHeader
 {
-//  sal_uInt8 nType
-//  sal_uInt8 nFlags;
     sal_uInt16 nRecLen;
     sal_Int16 nLeft;
     sal_Int16 nTop;
     sal_Int16 nRight;
     sal_Int16 nBottom;
-//  sal_uInt16 nextObj;
-//  sal_uInt16 prevObj;
+    SdwDrawObjHeader()
+        : nRecLen(0)
+        , nLeft(0)
+        , nTop(0)
+        , nRight(0)
+        , nBottom(0)
+    {
+    }
 };
 
 struct SdwLineRecord
commit 013cca1e82c5cbb2a8940bc6b51b39a05371cef1
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 13:35:44 2014 +0100

    coverity#738698 Uninitialized scalar field
    
    Change-Id: I6eb0d07acb807407712aac0c09e032dcc4d62dc3

diff --git a/lotuswordpro/source/filter/lwpsdwdrawheader.hxx b/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
index d3daa66..5194113 100644
--- a/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
+++ b/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
@@ -212,6 +212,16 @@ struct SdwLineRecord
     sal_uInt8 nLineEnd;
     sal_uInt8 nLineStyle;
     SdwColor aPenColor;
+    SdwLineRecord()
+        : nStartX(0)
+        , nStartY(0)
+        , nEndX(0)
+        , nEndY(0)
+        , nLineWidth(0)
+        , nLineEnd(0)
+        , nLineStyle(0)
+    {
+    }
 };
 
 struct SdwPolyLineRecord
commit 33770af00eb6bc7367661148dbfe5d517e3f8231
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 13:33:49 2014 +0100

    coverity#738699 Uninitialized scalar field
    
    Change-Id: I54a649f077ce41354a8aac60e39b7d81de239f33

diff --git a/lotuswordpro/source/filter/lwpsdwdrawheader.hxx b/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
index 7a9fcd4..d3daa66 100644
--- a/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
+++ b/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
@@ -282,6 +282,12 @@ struct SdwBmpRecord
     sal_uInt16 nTranslation;
     sal_uInt16 nRotation;
     sal_uInt32 nFileSize;
+    SdwBmpRecord()
+        : nTranslation(0)
+        , nRotation(0)
+        , nFileSize(0)
+    {
+    }
 };
 
 struct BmpInfoHeader
commit 7f64da067644972ea7990977e1f45ab588166c15
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 13:32:12 2014 +0100

    coverity#738702 Uninitialized scalar field
    
    Change-Id: I7187d110c52af5f333fe627270f1dc1a578da8bf

diff --git a/lotuswordpro/source/filter/lwpsdwdrawheader.hxx b/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
index 8ccbcebc..7a9fcd4 100644
--- a/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
+++ b/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
@@ -156,6 +156,11 @@ struct SdwPoint
 {
     sal_Int16 x;
     sal_Int16 y;
+    SdwPoint()
+        : x(0)
+        , y(0)
+    {
+    }
 };
 
 struct SdwColor
@@ -251,6 +256,11 @@ struct SdwFMPATH
 {
     sal_uInt16 n;
     SdwPoint* pPts;
+    SdwFMPATH()
+        : n(0)
+        , pPts(NULL)
+    {
+    }
 };
 
 struct SdwTextArt : public SdwTextBoxRecord
@@ -259,6 +269,12 @@ struct SdwTextArt : public SdwTextBoxRecord
     sal_Int16 nRotation;
     sal_uInt16 nTextLen;
     SdwFMPATH aPath[2];
+    SdwTextArt()
+        : nIndex(0)
+        , nRotation(0)
+        , nTextLen(0)
+    {
+    }
 };
 
 struct SdwBmpRecord
commit 3b404264a8724a945dc1d87f995d611eccaf8870
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 13:27:56 2014 +0100

    coverity#738704 Uninitialized scalar field
    
    Change-Id: I1556fbc14f616c883f3a6ed9f96aadd718530196

diff --git a/lotuswordpro/source/filter/lwpsdwdrawheader.hxx b/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
index 4fc28c8..8ccbcebc 100644
--- a/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
+++ b/lotuswordpro/source/filter/lwpsdwdrawheader.hxx
@@ -164,6 +164,13 @@ struct SdwColor
     sal_uInt8 nG;
     sal_uInt8 nB;
     sal_uInt8 unused;
+    SdwColor()
+        : nR(0)
+        , nG(0)
+        , nB(0)
+        , unused(0)
+    {
+    }
 };
 
 struct SdwClosedObjStyleRec
@@ -209,6 +216,13 @@ struct SdwPolyLineRecord
     sal_uInt8 nLineStyle;
     SdwColor aPenColor;
     sal_uInt16 nNumPoints;
+    SdwPolyLineRecord()
+        : nLineWidth(0)
+        , nLineEnd(0)
+        , nLineStyle(0)
+        , nNumPoints(0)
+    {
+    }
 };
 
 struct SdwArcRecord
commit 2696a2da53c7a8d8d8ae3de01e45be1439323050
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 13:24:33 2014 +0100

    coverity#984163 Uninitialized scalar field
    
    Change-Id: I3ad2a8d22ef274a63de5c01cc74c7d46f947f861

diff --git a/tools/source/generic/bigint.cxx b/tools/source/generic/bigint.cxx
index 47fb346..26117ce 100644
--- a/tools/source/generic/bigint.cxx
+++ b/tools/source/generic/bigint.cxx
@@ -484,6 +484,7 @@ BigInt::BigInt( const BigInt& rBigInt )
 }
 
 BigInt::BigInt( const OUString& rString )
+    : nLen(0)
 {
     bIsSet = true;
     bIsNeg = false;
commit 434bc3f6576ffb94b407d62ab5af9dc08b33d059
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 11:36:32 2014 +0100

    coverity#708478 Uninitialized scalar field
    
    Change-Id: I88b1393222678dfd6d6ee8a8a9f77870837615ab

diff --git a/sw/source/core/view/vprint.cxx b/sw/source/core/view/vprint.cxx
index 5f3cdfc..74841b5 100644
--- a/sw/source/core/view/vprint.cxx
+++ b/sw/source/core/view/vprint.cxx
@@ -600,6 +600,7 @@ sal_Bool SwViewShell::IsAnyFieldInDoc() const
 ///  Saves some settings at the draw view
 SwDrawViewSave::SwDrawViewSave( SdrView* pSdrView )
     : pDV( pSdrView )
+    , bPrintControls(true)
 {
     if ( pDV )
     {
commit 7fb95fbebb241b47cd55b6f68a8f3a46c99f64a3
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 11:35:11 2014 +0100

    coverity#708473 Uninitialized scalar field
    
    Change-Id: Iebc1fcf15aebb59d685e71f3b1e7927dee19ff9e

diff --git a/sw/source/core/undo/unnum.cxx b/sw/source/core/undo/unnum.cxx
index d3c9f35..c192b55 100644
--- a/sw/source/core/undo/unnum.cxx
+++ b/sw/source/core/undo/unnum.cxx
@@ -339,9 +339,12 @@ SwUndoNumRuleStart::SwUndoNumRuleStart( const SwPosition& rPos, sal_Bool bFlg )
 }
 
 SwUndoNumRuleStart::SwUndoNumRuleStart( const SwPosition& rPos, sal_uInt16 nStt )
-    : SwUndo( UNDO_SETNUMRULESTART ),
-    nIdx( rPos.nNode.GetIndex() ),
-    nOldStt( USHRT_MAX ), nNewStt( nStt ), bSetSttValue( sal_True )
+    : SwUndo(UNDO_SETNUMRULESTART)
+    , nIdx(rPos.nNode.GetIndex())
+    , nOldStt(USHRT_MAX)
+    , nNewStt(nStt)
+    , bSetSttValue(true)
+    , bFlag(false)
 {
     SwTxtNode* pTxtNd = rPos.nNode.GetNode().GetTxtNode();
     if ( pTxtNd )
commit e49b7f49825d4f36787538e6d634f2d4da553f5f
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 11:33:41 2014 +0100

    coverity#708466 Uninitialized scalar field
    
    Change-Id: I72ad2f25cffa5be14d7450c89fb55277e61232a7

diff --git a/sw/source/core/tox/tox.cxx b/sw/source/core/tox/tox.cxx
index 4567345..00a38b5 100644
--- a/sw/source/core/tox/tox.cxx
+++ b/sw/source/core/tox/tox.cxx
@@ -135,7 +135,7 @@ SwTOXMark::SwTOXMark()
     : SfxPoolItem( RES_TXTATR_TOXMARK )
     , SwModify( 0 )
     ,
-    pTxtAttr( 0 ),
+    pTxtAttr( 0 ), nLevel( 0 ),
     bAutoGenerated(sal_False),
     bMainEntry(sal_False)
 {
commit 4ec90e47b32b6666dbe7a3a496eeb1686e688103
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 11:32:18 2014 +0100

    coverity#708384 Uninitialized scalar field
    
    Change-Id: I105bcadd8f088e2047dc39af6bd8968261ddc64b

diff --git a/svx/source/svdraw/svdundo.cxx b/svx/source/svdraw/svdundo.cxx
index f7fca4d..ac5919a 100644
--- a/svx/source/svdraw/svdundo.cxx
+++ b/svx/source/svdraw/svdundo.cxx
@@ -1725,8 +1725,9 @@ OUString SdrUndoSetPageNum::GetComment() const
 }
 
 SdrUndoPageMasterPage::SdrUndoPageMasterPage(SdrPage& rChangedPage)
-:   SdrUndoPage(rChangedPage),
-    mbOldHadMasterPage(mrPage.TRG_HasMasterPage())
+    : SdrUndoPage(rChangedPage)
+    , mbOldHadMasterPage(mrPage.TRG_HasMasterPage())
+    , maOldMasterPageNumber(0)
 {
     // get current state from page
     if(mbOldHadMasterPage)
@@ -1740,8 +1741,6 @@ SdrUndoPageMasterPage::~SdrUndoPageMasterPage()
 {
 }
 
-
-
 SdrUndoPageRemoveMasterPage::SdrUndoPageRemoveMasterPage(SdrPage& rChangedPage)
 :   SdrUndoPageMasterPage(rChangedPage)
 {
commit 36ab95b518508b6eae39aa4927fc9080acb1ec54
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 11:29:57 2014 +0100

    coverity#708381 Uninitialized scalar field
    
    Change-Id: Idf23cde1b33b4ef11c9dc2275593ab49621e9a91

diff --git a/svx/source/svdraw/svdotext.cxx b/svx/source/svdraw/svdotext.cxx
index 3f709c0..c276697 100644
--- a/svx/source/svdraw/svdotext.cxx
+++ b/svx/source/svdraw/svdotext.cxx
@@ -169,6 +169,7 @@ SdrTextObj::SdrTextObj(SdrObjKind eNewTextKind, const Rectangle& rNewRect)
 {
     bTextSizeDirty=false;
     bTextFrame=true;
+    bPortionInfoChecked=false;
     bNoShear=true;
     bNoRotate=false;
     bNoMirror=true;
commit 89361bebfe3d69b9f20c281e17c4613f5b3a6cdc
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 11:29:05 2014 +0100

    coverity#708380 Uninitialized scalar field
    
    Change-Id: Ibf6a6c13c40f503c070dc2f0d3d9b64687a9a993

diff --git a/svx/source/svdraw/svdotext.cxx b/svx/source/svdraw/svdotext.cxx
index acfbe91..3f709c0 100644
--- a/svx/source/svdraw/svdotext.cxx
+++ b/svx/source/svdraw/svdotext.cxx
@@ -143,6 +143,7 @@ SdrTextObj::SdrTextObj(SdrObjKind eNewTextKind)
 {
     bTextSizeDirty=false;
     bTextFrame=true;
+    bPortionInfoChecked=false;
     bNoShear=true;
     bNoRotate=false;
     bNoMirror=true;
commit 7cb1e9524c401fbec11e809680a75f66305cdf4a
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 11:27:56 2014 +0100

    coverity#708369 Uninitialized scalar field
    
    Change-Id: Ia790356cdbddd1db06f04eef4515d120b8344d37

diff --git a/svx/source/svdraw/svddrgmt.cxx b/svx/source/svdraw/svddrgmt.cxx
index bbb6c47..34be0e1 100644
--- a/svx/source/svdraw/svddrgmt.cxx
+++ b/svx/source/svdraw/svddrgmt.cxx
@@ -1513,7 +1513,11 @@ void SdrDragMove::applyCurrentTransformationToSdrObject(SdrObject& rTarget)
 }
 
 SdrDragMove::SdrDragMove(SdrDragView& rNewView)
-:   SdrDragMethod(rNewView)
+    : SdrDragMethod(rNewView)
+    , nBestXSnap(0)
+    , nBestYSnap(0)
+    , bXSnapped(false)
+    , bYSnapped(false)
 {
     setMoveOnly(true);
 }
commit ae8c9fc30708f5f34158daebf23830e6bd401067
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 11:26:31 2014 +0100

    708360 Uninitialized scalar field
    
    Change-Id: Ic315129b26a7884fc980b215a1e85cf307da6cd0

diff --git a/svx/source/inc/fmexpl.hxx b/svx/source/inc/fmexpl.hxx
index bec8c84..548b7fd 100644
--- a/svx/source/inc/fmexpl.hxx
+++ b/svx/source/inc/fmexpl.hxx
@@ -226,7 +226,10 @@ class FmNavRequestSelectHint : public SfxHint
     sal_Bool                m_bMixedSelection;
 public:
     TYPEINFO_OVERRIDE();
-    FmNavRequestSelectHint() { }
+    FmNavRequestSelectHint()
+        : m_bMixedSelection(sal_False)
+    {
+    }
     virtual ~FmNavRequestSelectHint() {}
 
     void SetMixedSelection(sal_Bool bMixedSelection) { m_bMixedSelection = bMixedSelection; }
commit d730fd358e0890174358002ac147a0168e873f93
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Apr 11 11:25:16 2014 +0100

    coverity#708359 Uninitialized scalar field
    
    Change-Id: Ic65d9682fa145198c6ce663dc655d56570388638

diff --git a/svx/source/gallery2/galtheme.cxx b/svx/source/gallery2/galtheme.cxx
index 2650811..6a9a317 100644
--- a/svx/source/gallery2/galtheme.cxx
+++ b/svx/source/gallery2/galtheme.cxx
@@ -60,15 +60,16 @@ using namespace ::com::sun::star;
 // - SgaTheme -
 
 
-GalleryTheme::GalleryTheme( Gallery* pGallery, GalleryThemeEntry* pThemeEntry ) :
-        pParent               ( pGallery ),
-        pThm                  ( pThemeEntry ),
-        mnThemeLockCount      ( 0 ),
-        mnBroadcasterLockCount( 0 ),
-        nDragPos              ( 0 ),
-        bDragging             ( false )
+GalleryTheme::GalleryTheme( Gallery* pGallery, GalleryThemeEntry* pThemeEntry )
+    : m_bDestDirRelative(false)
+    , pParent(pGallery)
+    , pThm(pThemeEntry)
+    , mnThemeLockCount(0)
+    , mnBroadcasterLockCount(0)
+    , nDragPos(0)
+    , bDragging(false)
+    , bAbortActualize(false)
 {
-
     ImplCreateSvDrawStorage();
 }
 


More information about the Libreoffice-commits mailing list