[Libreoffice-commits] core.git: vcl/source

Julien Nabet serval2412 at yahoo.fr
Sat Apr 12 08:48:11 PDT 2014


 vcl/source/gdi/pdfwriter_impl.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2ae639af5ac5e76b6ecbb7e8fb92d32b1ce002ae
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Sat Apr 12 17:47:44 2014 +0200

    cppcheck: Possible inefficient checking for emptiness
    
    Change-Id: I2b353435b29046b05acbb1193fda168309e01f4b

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx b/vcl/source/gdi/pdfwriter_impl.cxx
index 4f054a6..88cdf39 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -2712,7 +2712,7 @@ sal_Int32 PDFWriterImpl::emitStructure( PDFStructureElement& rEle )
             aLine.append( "\n" );
         }
     }
-    if( ! rEle.m_aBBox.IsEmpty() || rEle.m_aAttributes.size() )
+    if( (! rEle.m_aBBox.IsEmpty()) || (! rEle.m_aAttributes.empty()) )
     {
         OString aAttribs =  emitStructureAttributes( rEle );
         if( !aAttribs.isEmpty() )


More information about the Libreoffice-commits mailing list