[Libreoffice-commits] core.git: 16 commits - include/svx include/tools scaddins/source sc/source starmath/inc svtools/source svx/source
Caolán McNamara
caolanm at redhat.com
Tue Apr 22 03:39:49 PDT 2014
include/svx/svdtrans.hxx | 14 ++-
include/tools/bigint.hxx | 98 +++++++++++-----------
sc/source/filter/xml/XMLTrackedChangesContext.cxx | 3
sc/source/ui/view/viewdata.cxx | 21 ++++
scaddins/source/analysis/analysishelper.cxx | 5 -
starmath/inc/node.hxx | 12 +-
svtools/source/misc/imap3.cxx | 8 +
svtools/source/misc/svtaccessiblefactory.cxx | 1
svtools/source/svrtf/parrtf.cxx | 6 -
svtools/source/svrtf/svparser.cxx | 13 ++
svx/source/table/tableundo.hxx | 12 ++
11 files changed, 132 insertions(+), 61 deletions(-)
New commits:
commit 0060649399eb130848a79b224ddc39a81721249b
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 22 10:59:25 2014 +0100
coverity#708389 Uninitialized scalar field
Change-Id: If4b05a34b77cc0b6366880ad65132e801b297a62
diff --git a/svx/source/table/tableundo.hxx b/svx/source/table/tableundo.hxx
index 2b5779c..85c7978 100644
--- a/svx/source/table/tableundo.hxx
+++ b/svx/source/table/tableundo.hxx
@@ -67,7 +67,17 @@ private:
::sal_Int32 mnRowSpan;
::sal_Int32 mnColSpan;
- Data() : mpProperties(NULL), mpOutlinerParaObject(NULL), mfValue(0) {};
+ Data()
+ : mpProperties(NULL)
+ , mpOutlinerParaObject(NULL)
+ , mnCellContentType(CellContentType_EMPTY)
+ , mfValue(0)
+ , mnError(0)
+ , mbMerged(false)
+ , mnRowSpan(0)
+ , mnColSpan(0)
+ {
+ }
};
void setDataToCell( const Data& rData );
commit d52b0640f413521a782673834f1142bcf3053e70
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 22 10:56:50 2014 +0100
coverity#708340 Uninitialized scalar field
Change-Id: I1ad1777492f94e7a4162382d9d68e0032aaee460
diff --git a/include/svx/svdtrans.hxx b/include/svx/svdtrans.hxx
index 3cd736c..fa6319f 100644
--- a/include/svx/svdtrans.hxx
+++ b/include/svx/svdtrans.hxx
@@ -280,7 +280,19 @@ private:
SVX_DLLPRIVATE void Undirty();
SVX_DLLPRIVATE void ForceUndirty() const { if (bDirty) ((SdrFormatter*)this)->Undirty(); }
public:
- SdrFormatter(MapUnit eSrc, MapUnit eDst) { eSrcMU=eSrc; bSrcFU=false; eDstMU=eDst; bDstFU=false; bDirty=true; }
+ SdrFormatter(MapUnit eSrc, MapUnit eDst)
+ : nMul_(0)
+ , nDiv_(0)
+ , nKomma_(0)
+ , bSrcFU(false)
+ , bDstFU(false)
+ , bDirty(true)
+ , eSrcMU(eSrc)
+ , eDstMU(eDst)
+ , eSrcFU(FUNIT_NONE)
+ , eDstFU(FUNIT_NONE)
+ {
+ }
SdrFormatter(MapUnit eSrc, FieldUnit eDst) { eSrcMU=eSrc; bSrcFU=false; eDstFU=eDst; bDstFU=true; bDirty=true; }
SdrFormatter(FieldUnit eSrc, MapUnit eDst) { eSrcFU=eSrc; bSrcFU=true; eDstMU=eDst; bDstFU=false; bDirty=true; }
SdrFormatter(FieldUnit eSrc, FieldUnit eDst) { eSrcFU=eSrc; bSrcFU=true; eDstFU=eDst; bDstFU=true; bDirty=true; }
commit 10382948e636072cd31900f8ae8c74f29887633a
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 22 10:54:20 2014 +0100
coverity#708335 Uninitialized scalar field
Change-Id: I14ce77fe16acdf6491ce49cdbe7550ef303f0ff9
diff --git a/svtools/source/svrtf/svparser.cxx b/svtools/source/svrtf/svparser.cxx
index 0ecdca4..670b5b1 100644
--- a/svtools/source/svrtf/svparser.cxx
+++ b/svtools/source/svrtf/svparser.cxx
@@ -40,8 +40,17 @@ struct SvParser_Impl
rtl_TextToUnicodeConverter hConv;
rtl_TextToUnicodeContext hContext;
- SvParser_Impl() :
- nTokenValue(0), nToken(0), nSaveToken(0), hConv( 0 ), hContext( (rtl_TextToUnicodeContext)1 )
+ SvParser_Impl()
+ : nFilePos(0)
+ , nlLineNr(0)
+ , nlLinePos(0)
+ , nTokenValue(0)
+ , bTokenHasValue(false)
+ , nToken(0)
+ , nNextCh(0)
+ , nSaveToken(0)
+ , hConv( 0 )
+ , hContext( (rtl_TextToUnicodeContext)1 )
{
}
commit bbe00527f0529ce8b2295df4a914a954e090c2d2
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 22 10:52:41 2014 +0100
coverity#708334 Uninitialized scalar field
Change-Id: I01e8a8b18d07e035a57fbc731b4666c98148c102
diff --git a/svtools/source/svrtf/parrtf.cxx b/svtools/source/svrtf/parrtf.cxx
index 62ddfeb..7a09a7b 100644
--- a/svtools/source/svrtf/parrtf.cxx
+++ b/svtools/source/svrtf/parrtf.cxx
@@ -35,8 +35,10 @@ const int MAX_TOKEN_LEN = 128;
SvRTFParser::SvRTFParser( SvStream& rIn, sal_uInt8 nStackSize )
: SvParser( rIn, nStackSize ),
- eUNICodeSet( RTL_TEXTENCODING_MS_1252 ), // default ist ANSI-CodeSet
- nUCharOverread( 1 )
+ , nOpenBrakets(0)
+ , eCodeSet(RTL_TEXTENCODING_MS_1252)
+ , eUNICodeSet(RTL_TEXTENCODING_MS_1252) // default ist ANSI-CodeSet
+ , nUCharOverread(1)
{
// default ist ANSI-CodeSet
SetSrcEncoding( RTL_TEXTENCODING_MS_1252 );
commit 8a5dbd8c75b099ca50080237742ae72c34c3668c
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 22 09:16:41 2014 +0100
coverity#708324 Uninitialized m_refCount
Change-Id: I1a8e548605570eb18ed455282d8f329a3f026409
diff --git a/svtools/source/misc/svtaccessiblefactory.cxx b/svtools/source/misc/svtaccessiblefactory.cxx
index 431ecec..4704e4f 100644
--- a/svtools/source/misc/svtaccessiblefactory.cxx
+++ b/svtools/source/misc/svtaccessiblefactory.cxx
@@ -205,6 +205,7 @@ namespace svt
AccessibleDummyFactory::AccessibleDummyFactory()
+ : m_refCount(0)
{
}
commit 7b659719b0447644e0dbf39f5de3341673b6f392
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 22 09:15:29 2014 +0100
coverity#708323 Uninitialized scalar field
Change-Id: Iea430ce93ac1add2be76222b8ee9ae6c0da53ff6
diff --git a/svtools/source/misc/imap3.cxx b/svtools/source/misc/imap3.cxx
index cc7f745..8cb3e8d 100644
--- a/svtools/source/misc/imap3.cxx
+++ b/svtools/source/misc/imap3.cxx
@@ -28,9 +28,11 @@
|*
\******************************************************************************/
-IMapCompat::IMapCompat( SvStream& rStm, const sal_uInt16 nStreamMode ) :
- pRWStm ( &rStm ),
- nStmMode ( nStreamMode )
+IMapCompat::IMapCompat( SvStream& rStm, const sal_uInt16 nStreamMode )
+ : pRWStm(&rStm)
+ , nCompatPos(0)
+ , nTotalSize(0)
+ , nStmMode(nStreamMode)
{
DBG_ASSERT( nStreamMode == STREAM_READ || nStreamMode == STREAM_WRITE, "Wrong Mode!" );
commit 8c432e5e5982f28c514bbfafb2d155720d0d5bcd
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 22 09:13:51 2014 +0100
coverity#708229 Uninitialized scalar field
Change-Id: Id8925dd1ef73ad0fa18ff3f103441f30ba7bb5c0
diff --git a/starmath/inc/node.hxx b/starmath/inc/node.hxx
index 68282d0..220e30d 100644
--- a/starmath/inc/node.hxx
+++ b/starmath/inc/node.hxx
@@ -608,8 +608,10 @@ class SmRootSymbolNode : public SmMathSymbolNode
public:
SmRootSymbolNode(const SmToken &rNodeToken)
- : SmMathSymbolNode(NROOTSYMBOL, rNodeToken)
- {}
+ : SmMathSymbolNode(NROOTSYMBOL, rNodeToken)
+ , nBodyWidth(0)
+ {
+ }
sal_uLong GetBodyWidth() const {return nBodyWidth;};
virtual void AdaptToX(const OutputDevice &rDev, sal_uLong nHeight) SAL_OVERRIDE;
commit 6320d1efa39152e8fe0e9ff2f49ecdca112b5995
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 22 09:13:13 2014 +0100
coverity#708228 Uninitialized scalar field
Change-Id: I742c2eeaa539b9e8557821e15910d0c739e51891
diff --git a/starmath/inc/node.hxx b/starmath/inc/node.hxx
index b81a948..68282d0 100644
--- a/starmath/inc/node.hxx
+++ b/starmath/inc/node.hxx
@@ -701,8 +701,10 @@ class SmTableNode : public SmStructureNode
long nFormulaBaseline;
public:
SmTableNode(const SmToken &rNodeToken)
- : SmStructureNode(NTABLE, rNodeToken)
- {}
+ : SmStructureNode(NTABLE, rNodeToken)
+ , nFormulaBaseline(0)
+ {
+ }
using SmNode::GetLeftMost;
virtual SmNode * GetLeftMost() SAL_OVERRIDE;
commit 0526aa64c2eba08b218f3811866ab0cc507ac99b
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 22 09:09:20 2014 +0100
coverity#708207 Uninitialized scalar field
Change-Id: I8d74ddcf551e4a853dcf04a4ba1f33a46579ed06
diff --git a/include/tools/bigint.hxx b/include/tools/bigint.hxx
index 387d663..e90f91b 100644
--- a/include/tools/bigint.hxx
+++ b/include/tools/bigint.hxx
@@ -58,7 +58,14 @@ private:
TOOLS_DLLPRIVATE bool ABS_IsLess(BigInt const &) const;
public:
- BigInt();
+ BigInt()
+ : nVal(0)
+ , nLen(0)
+ , bIsNeg(false)
+ , bIsBig(false)
+ , bIsSet(false)
+ {
+ }
BigInt(short nValue)
: nVal(nValue)
@@ -86,14 +93,24 @@ public:
, bIsSet(true)
{
}
- BigInt( double nVal );
- BigInt( sal_uInt16 nVal );
- BigInt( sal_uInt32 nVal );
- BigInt( const BigInt& rBigInt );
- BigInt( const OUString& rString );
+
+ BigInt( double nVal );
+
+ BigInt(sal_uInt16 nValue)
+ : nVal(nValue)
+ , nLen(0)
+ , bIsNeg(false)
+ , bIsBig(false)
+ , bIsSet(true)
+ {
+ }
+
+ BigInt( sal_uInt32 nVal );
+ BigInt( const BigInt& rBigInt );
+ BigInt( const OUString& rString );
#ifdef _TLBIGINT_INT64
- BigInt( const SbxINT64 &r );
- BigInt( const SbxUINT64 &r );
+ BigInt( const SbxINT64 &r );
+ BigInt( const SbxUINT64 &r );
#endif
operator short() const;
@@ -144,20 +161,6 @@ public:
friend class Fraction;
};
-inline BigInt::BigInt()
-{
- bIsSet = false;
- bIsBig = false;
- nVal = 0;
-}
-
-inline BigInt::BigInt( sal_uInt16 nValue )
-{
- bIsSet = true;
- bIsBig = false;
- nVal = nValue;
-}
-
inline BigInt::operator short() const
{
if ( !bIsBig && nVal >= SHRT_MIN && nVal <= SHRT_MAX )
commit be48b0eb62d730c3534c6950613e99157806d897
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 22 09:08:07 2014 +0100
coverity#708205 Uninitialized scalar field
Change-Id: I9facdfaefcfa79c56b1db9e62b861cf425d5726f
diff --git a/include/tools/bigint.hxx b/include/tools/bigint.hxx
index 095f756..387d663 100644
--- a/include/tools/bigint.hxx
+++ b/include/tools/bigint.hxx
@@ -59,7 +59,16 @@ private:
public:
BigInt();
- BigInt( short nVal );
+
+ BigInt(short nValue)
+ : nVal(nValue)
+ , nLen(0)
+ , bIsNeg(false)
+ , bIsBig(false)
+ , bIsSet(true)
+ {
+ }
+
BigInt(long nValue)
: nVal(nValue)
, nLen(0)
@@ -142,13 +151,6 @@ inline BigInt::BigInt()
nVal = 0;
}
-inline BigInt::BigInt( short nValue )
-{
- bIsSet = true;
- bIsBig = false;
- nVal = nValue;
-}
-
inline BigInt::BigInt( sal_uInt16 nValue )
{
bIsSet = true;
commit 53d230c9e48ad3cf96c4cf6d8ed301cec906db01
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 22 09:06:55 2014 +0100
coverity#708204 Uninitialized scalar field
Change-Id: I0f54051e41b98275608e0056a587c9e7fbeee0dd
diff --git a/include/tools/bigint.hxx b/include/tools/bigint.hxx
index 501d986..095f756 100644
--- a/include/tools/bigint.hxx
+++ b/include/tools/bigint.hxx
@@ -60,7 +60,15 @@ private:
public:
BigInt();
BigInt( short nVal );
- BigInt( long nVal );
+ BigInt(long nValue)
+ : nVal(nValue)
+ , nLen(0)
+ , bIsNeg(false)
+ , bIsBig(false)
+ , bIsSet(true)
+ {
+ }
+
BigInt(int nValue)
: nVal(nValue)
, nLen(0)
@@ -141,13 +149,6 @@ inline BigInt::BigInt( short nValue )
nVal = nValue;
}
-inline BigInt::BigInt( long nValue )
-{
- bIsSet = true;
- bIsBig = false;
- nVal = nValue;
-}
-
inline BigInt::BigInt( sal_uInt16 nValue )
{
bIsSet = true;
commit d1f47efbc1cd38feaffa681a43624693dabccbc7
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 22 09:05:25 2014 +0100
coverity#708203 Uninitialized scalar field
Change-Id: Id72f198b69a319b93a67f2e98a706f4e45fc576f
diff --git a/include/tools/bigint.hxx b/include/tools/bigint.hxx
index 6d52b60..501d986 100644
--- a/include/tools/bigint.hxx
+++ b/include/tools/bigint.hxx
@@ -61,7 +61,14 @@ public:
BigInt();
BigInt( short nVal );
BigInt( long nVal );
- BigInt( int nVal );
+ BigInt(int nValue)
+ : nVal(nValue)
+ , nLen(0)
+ , bIsNeg(false)
+ , bIsBig(false)
+ , bIsSet(true)
+ {
+ }
BigInt( double nVal );
BigInt( sal_uInt16 nVal );
BigInt( sal_uInt32 nVal );
@@ -141,13 +148,6 @@ inline BigInt::BigInt( long nValue )
nVal = nValue;
}
-inline BigInt::BigInt( int nValue )
-{
- bIsSet = true;
- bIsBig = false;
- nVal = nValue;
-}
-
inline BigInt::BigInt( sal_uInt16 nValue )
{
bIsSet = true;
commit 853f97410d005742d8c7093a721225069e104ac4
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 22 09:03:09 2014 +0100
coverity#708114 Uninitialized scalar field
Change-Id: I4f77230f64d90841cbf218b259dc1377d8658ba8
diff --git a/scaddins/source/analysis/analysishelper.cxx b/scaddins/source/analysis/analysishelper.cxx
index 81399525..1876968 100644
--- a/scaddins/source/analysis/analysishelper.cxx
+++ b/scaddins/source/analysis/analysishelper.cxx
@@ -2831,8 +2831,9 @@ sal_Bool ScaDate::operator<( const ScaDate& rCmp ) const
-ScaAnyConverter::ScaAnyConverter( const uno::Reference< uno::XComponentContext >& xContext ) :
- bHasValidFormat( sal_False )
+ScaAnyConverter::ScaAnyConverter( const uno::Reference< uno::XComponentContext >& xContext )
+ : nDefaultFormat(0)
+ , bHasValidFormat(false)
{
xFormatter = util::NumberFormatter::create(xContext);
}
commit ec6531370a276a6247e95fa6ad481ec3c41a7e32
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 22 09:02:02 2014 +0100
coverity#708110 Uninitialized scalar field
Change-Id: Iab15f5bd188c404eec9633d23e5877ee6eab4b8d
diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx
index 7609820..dbb9bc2 100644
--- a/sc/source/ui/view/viewdata.cxx
+++ b/sc/source/ui/view/viewdata.cxx
@@ -390,6 +390,17 @@ ScViewData::ScViewData( const ScViewData& rViewData ) :
eRefType ( SC_REFTYPE_NONE ),
nTabNo ( rViewData.nTabNo ),
nRefTabNo ( rViewData.nTabNo ), // no RefMode
+ nRefStartX(0),
+ nRefStartY(0),
+ nRefStartZ(0),
+ nRefEndX(0),
+ nRefEndY(0),
+ nRefEndZ(0),
+ nFillStartX(0),
+ nFillStartY(0),
+ nFillEndX(0),
+ nFillEndY(0),
+ nPasteFlags ( SC_PASTE_NONE ),
eEditActivePart( rViewData.eEditActivePart ),
nFillMode ( SC_FILL_NONE ),
bActive ( true ), // how to initialize?
commit 626bd1dc06c82f78b5195f20694ae6741380f594
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 22 09:00:11 2014 +0100
coverity#708109 Uninitialized scalar field
Change-Id: I013b8b45751ec8a604fb9df941813e283e3b8b45
diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx
index a619eb9..7609820 100644
--- a/sc/source/ui/view/viewdata.cxx
+++ b/sc/source/ui/view/viewdata.cxx
@@ -308,6 +308,16 @@ ScViewData::ScViewData( ScDocShell* pDocSh, ScTabViewShell* pViewSh ) :
eRefType ( SC_REFTYPE_NONE ),
nTabNo ( 0 ),
nRefTabNo ( 0 ),
+ nRefStartX(0),
+ nRefStartY(0),
+ nRefStartZ(0),
+ nRefEndX(0),
+ nRefEndY(0),
+ nRefEndZ(0),
+ nFillStartX(0),
+ nFillStartY(0),
+ nFillEndX(0),
+ nFillEndY(0),
nPasteFlags ( SC_PASTE_NONE ),
eEditActivePart( SC_SPLIT_BOTTOMLEFT ),
nFillMode ( SC_FILL_NONE ),
commit d361293f3cfc6725b7589dd900bb1e1ed1ec422f
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 22 08:56:07 2014 +0100
coverity#708070 Uninitialized scalar field
Change-Id: If5cf306f749f3996d9972bc2b0e71b4101c00837
diff --git a/sc/source/filter/xml/XMLTrackedChangesContext.cxx b/sc/source/filter/xml/XMLTrackedChangesContext.cxx
index 53afc73..e158e35 100644
--- a/sc/source/filter/xml/XMLTrackedChangesContext.cxx
+++ b/sc/source/filter/xml/XMLTrackedChangesContext.cxx
@@ -724,10 +724,12 @@ ScXMLCellContentDeletionContext::ScXMLCellContentDeletionContext( ScXMLImport&
const uno::Reference<xml::sax::XAttributeList>& xAttrList,
ScXMLChangeTrackingImportHelper* pTempChangeTrackingImportHelper) :
SvXMLImportContext( rImport, nPrfx, rLName ),
+ fValue(0.0),
pChangeTrackingImportHelper(pTempChangeTrackingImportHelper),
nID(0),
nMatrixCols(0),
nMatrixRows(0),
+ eGrammar( formula::FormulaGrammar::GRAM_STORAGE_DEFAULT),
nType(NUMBERFORMAT_ALL),
nMatrixFlag(MM_NONE),
bBigRange(false),
@@ -1261,6 +1263,7 @@ ScXMLPreviousContext::ScXMLPreviousContext( ScXMLImport& rImport,
const uno::Reference<xml::sax::XAttributeList>& xAttrList,
ScXMLChangeTrackingImportHelper* pTempChangeTrackingImportHelper ) :
SvXMLImportContext( rImport, nPrfx, rLName ),
+ fValue(0.0),
pChangeTrackingImportHelper(pTempChangeTrackingImportHelper),
nID(0),
nMatrixCols(0),
More information about the Libreoffice-commits
mailing list