[Libreoffice-commits] core.git: 13 commits - filter/source framework/source sc/source

Caolán McNamara caolanm at redhat.com
Wed Apr 23 06:28:40 PDT 2014


 filter/source/graphicfilter/ipcd/ipcd.cxx      |   13 +++++++-
 filter/source/graphicfilter/itiff/ccidecom.cxx |    7 +++-
 filter/source/msfilter/msdffimp.cxx            |    2 +
 filter/source/msfilter/svdfppt.cxx             |   39 ++++++++++++++++---------
 filter/source/svg/svgwriter.cxx                |    3 +
 filter/source/svg/svgwriter.hxx                |    3 -
 framework/source/loadenv/loadenv.cxx           |    7 +++-
 sc/source/core/tool/compiler.cxx               |    2 +
 sc/source/ui/view/gridwin.cxx                  |   10 ++++++
 9 files changed, 65 insertions(+), 21 deletions(-)

New commits:
commit 2fd883932f2de94ed106485df9234a35d9ca517b
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Apr 23 14:11:18 2014 +0100

    coverity#708017 Uninitialized scalar field
    
    Change-Id: I5dbb5bab307195f6328b5322b35385632f35aa43

diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 924a70a..884b870 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -1531,6 +1531,7 @@ ScCompiler::ScCompiler( ScDocument* pDocument, const ScAddress& rPos,ScTokenArra
         pDoc( pDocument ),
         aPos( rPos ),
         mpFormatter(pDoc->GetFormatTable()),
+        nSrcPos(0),
         pCharClass( ScGlobal::pCharClass ),
         mnPredetectedReference(0),
         mnRangeOpPosInSymbol(-1),
commit cce9c76409affdec3960aa5d047de6fd68363e81
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Apr 23 14:06:56 2014 +0100

    coverity#708016 Uninitialized scalar field
    
    Change-Id: Ibf3bd2befb30222d5a0998dd563ce90855c5fb8a

diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index aee961e..924a70a 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -1564,6 +1564,7 @@ ScCompiler::ScCompiler( ScDocument* pDocument, const ScAddress& rPos)
         pDoc( pDocument ),
         aPos( rPos ),
         mpFormatter(pDoc ? pDoc->GetFormatTable() : NULL),
+        nSrcPos(0),
         pCharClass( ScGlobal::pCharClass ),
         mnPredetectedReference(0),
         mnRangeOpPosInSymbol(-1),
commit cffe7a15b09bf23b6aae7e919059e0e7f9b7131e
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Apr 23 13:34:44 2014 +0100

    coverity#707880 Uninitialized scalar field
    
    Change-Id: Id58c2e45ba5043228da617eeb3bb84ef21d0f59e

diff --git a/framework/source/loadenv/loadenv.cxx b/framework/source/loadenv/loadenv.cxx
index b4f1a8e..9d0c445 100644
--- a/framework/source/loadenv/loadenv.cxx
+++ b/framework/source/loadenv/loadenv.cxx
@@ -125,7 +125,12 @@ class LoadEnvListener : public ::cppu::WeakImplHelper2< css::frame::XLoadEventLi
 
 LoadEnv::LoadEnv(const css::uno::Reference< css::uno::XComponentContext >& xContext)
     throw(LoadEnvException, css::uno::RuntimeException)
-    : m_xContext    (xContext)
+    : m_xContext(xContext)
+    , m_nSearchFlags(0)
+    , m_eFeature(E_NO_FEATURE)
+    , m_eContentType(E_UNSUPPORTED_CONTENT)
+    , m_bCloseFrameOnError(false)
+    , m_bReactivateControllerOnError(false)
     , m_pQuietInteraction( 0 )
 {
 }
commit c91e07e45bc5b742d7bfe8a572fb44682c78e2ac
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Apr 23 12:59:46 2014 +0100

    coverity#707858 Uninitialized scalar field
    
    Change-Id: I098842dcf6bbee41d3ef9d2b17bcb94e2cc65bf6

diff --git a/filter/source/svg/svgwriter.cxx b/filter/source/svg/svgwriter.cxx
index 79a7e82..913f252 100644
--- a/filter/source/svg/svgwriter.cxx
+++ b/filter/source/svg/svgwriter.cxx
@@ -1642,7 +1642,8 @@ SVGActionWriter::SVGActionWriter( SVGExport& rExport, SVGFontExport& rFontExport
     mpContext( NULL ),
     maTextWriter( rExport ),
     mnInnerMtfCount( 0 ),
-    mbClipAttrChanged( false )
+    mbClipAttrChanged( false ),
+    mbIsPlacehlolderShape( false )
 {
     mpVDev = new VirtualDevice;
     mpVDev->EnableOutput( false );
diff --git a/filter/source/svg/svgwriter.hxx b/filter/source/svg/svgwriter.hxx
index d824132..d77e2f5 100644
--- a/filter/source/svg/svgwriter.hxx
+++ b/filter/source/svg/svgwriter.hxx
@@ -317,9 +317,6 @@ private:
     VirtualDevice*                              mpVDev;
     MapMode                                     maTargetMapMode;
     sal_uInt32                                  mnInnerMtfCount;
-    bool                                    mbDestroyVDev;
-    bool                                    mbPaintAttrChanged;
-    bool                                    mbFontAttrChanged;
     bool                                    mbClipAttrChanged;
     bool                                    mbIsPlacehlolderShape;
 
commit ac3b825a3c282704c07c9faba1101c494b8ca204
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Apr 23 12:55:19 2014 +0100

    coverity#707854 Uninitialized scalar field
    
    Change-Id: I06948ae34c55482405983b613d1ab44ba10ed905

diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx
index 17c2ed2..7458873 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -3301,14 +3301,14 @@ PPTExtParaProv::~PPTExtParaProv()
 }
 
 PPTNumberFormatCreator::PPTNumberFormatCreator( PPTExtParaProv* pParaProv )
-    : pExtParaProv(pParaProv)
-    , nIsBullet(0)
+    : nIsBullet(0)
     , nBulletChar(0)
     , nBulletFont(0)
     , nBulletHeight(0)
     , nBulletColor(0)
     , nTextOfs(0)
     , nBulletOfs(0)
+    , pExtParaProv(pParaProv)
 {
 }
 
@@ -4348,7 +4348,7 @@ PPTParaPropSet& PPTParaPropSet::operator=( PPTParaPropSet& rParaPropSet )
     return *this;
 }
 
-PPTCharPropSet::PPTCharPropSet( sal_uInt32 nParagraph ) :
+PPTCharPropSet::PPTCharPropSet(sal_uInt32 nParagraph)
     : mnOriginalTextPos(0)
     , mnParagraph(nParagraph)
     , mpFieldItem(NULL)
@@ -4588,10 +4588,13 @@ PPTTextRulerInterpreter::~PPTTextRulerInterpreter()
         delete mpImplRuler;
 }
 
-PPTTextCharacterStyleAtomInterpreter::PPTTextCharacterStyleAtomInterpreter() :
-    nFlags1 ( 0 ),
-    nFlags2 ( 0 ),
-    nFlags3 ( 0 )
+PPTTextCharacterStyleAtomInterpreter::PPTTextCharacterStyleAtomInterpreter()
+    : nFlags1(0)
+    , nFlags2(0)
+    , nFlags3(0)
+    , n1(0)
+    , nFontHeight(0)
+    , nFontColor(0)
 {
 }
 
commit 7ad8842ca8d7cd4536d31fda3b3d7b9d31c8959b
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Apr 23 12:54:03 2014 +0100

    coverity#707853 Uninitialized scalar field
    
    Change-Id: I6a406a990a114ba8c0d92b92bd4a5cb256954303

diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx
index 0caeafb..17c2ed2 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -3300,8 +3300,15 @@ PPTExtParaProv::~PPTExtParaProv()
     aBuGraList.clear();
 }
 
-PPTNumberFormatCreator::PPTNumberFormatCreator( PPTExtParaProv* pParaProv ) :
-    pExtParaProv ( pParaProv )
+PPTNumberFormatCreator::PPTNumberFormatCreator( PPTExtParaProv* pParaProv )
+    : pExtParaProv(pParaProv)
+    , nIsBullet(0)
+    , nBulletChar(0)
+    , nBulletFont(0)
+    , nBulletHeight(0)
+    , nBulletColor(0)
+    , nTextOfs(0)
+    , nBulletOfs(0)
 {
 }
 
commit fb3fdc66b5656b62cf6111f7a5a80820b7a6c945
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Apr 23 12:53:06 2014 +0100

    coverity#707850 Uninitialized scalar field
    
    Change-Id: Ib10e9265a6eaac8544fb6ee0cee0d606a83e15fd

diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx
index ff87c09..0caeafb 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -5648,7 +5648,8 @@ PPTParagraphObj::PPTParagraphObj( const PPTStyleSheet& rStyleSheet, sal_uInt32 n
     PPTNumberFormatCreator  ( NULL ),
     mrStyleSheet            ( rStyleSheet ),
     mnInstance              ( nInstance ),
-    mbTab                   ( true )       // style sheets always have to get the right tabulator setting
+    mbTab                   ( true ),      // style sheets always have to get the right tabulator setting
+    mnCurrentObject         ( 0 )
 {
     if ( nDepth > 4 )
         nDepth = 4;
commit 8012b4a3408ba6b296b21ea3f6aba1a578e3d34d
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Apr 23 12:43:22 2014 +0100

    coverity#707849 Uninitialized scalar field
    
    Change-Id: I614a25d3988f741a2744b9e7cb1e170ddd3b2dbf

diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx
index b55f926..ff87c09 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -4306,8 +4306,9 @@ PPTStyleSheet::~PPTStyleSheet()
     }
 }
 
-PPTParaPropSet::PPTParaPropSet() :
-    pParaSet( new ImplPPTParaPropSet )
+PPTParaPropSet::PPTParaPropSet()
+    : mnOriginalTextPos(0)
+    , pParaSet( new ImplPPTParaPropSet )
 {
     pParaSet->mnHasAnm = 1;
 }
commit f897842614886d0585660827a45298f1ed995917
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Apr 23 12:42:35 2014 +0100

    coverity#707848 Uninitialized scalar field
    
    Change-Id: Iee18d10819ca351525fd121347ffd1478b502765

diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx
index 8157cbf..b55f926 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -4341,9 +4341,10 @@ PPTParaPropSet& PPTParaPropSet::operator=( PPTParaPropSet& rParaPropSet )
 }
 
 PPTCharPropSet::PPTCharPropSet( sal_uInt32 nParagraph ) :
-    mnParagraph     ( nParagraph ),
-    mpFieldItem     ( NULL ),
-    pCharSet        ( new ImplPPTCharPropSet )
+    : mnOriginalTextPos(0)
+    , mnParagraph(nParagraph)
+    , mpFieldItem(NULL)
+    , pCharSet(new ImplPPTCharPropSet)
 {
     mnHylinkOrigColor = 0;
     mbIsHyperlink = false;
commit 3e5e3defcffaac34350eeb609d9455d515b6fb09
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Apr 23 11:38:21 2014 +0100

    coverity#707841 Uninitialized scalar field
    
    and coverity#707840
    
    Change-Id: Idf6e7a3f51ce148fd935b75fa63b931d9200d568

diff --git a/filter/source/msfilter/msdffimp.cxx b/filter/source/msfilter/msdffimp.cxx
index 337a3c9..ab401ac 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -7214,6 +7214,7 @@ SvxMSDffImportRec::SvxMSDffImportRec()
       nYAlign( 0 ), // position n cm below
       pYRelTo( NULL ), //   relative to paragraph
       nLayoutInTableCell( 0 ), // element is laid out in table cell
+      nFlags( 0 ),
       nTextRotationAngle( 0 ),
       nDxTextLeft( 144 ),
       nDyTextTop( 72 ),
@@ -7254,6 +7255,7 @@ SvxMSDffImportRec::SvxMSDffImportRec(const SvxMSDffImportRec& rCopy)
       nYAlign( rCopy.nYAlign ),
       pYRelTo( NULL ),
       nLayoutInTableCell( rCopy.nLayoutInTableCell ),
+      nFlags( rCopy.nFlags ),
       nTextRotationAngle( rCopy.nTextRotationAngle ),
       nDxTextLeft( rCopy.nDxTextLeft    ),
       nDyTextTop( rCopy.nDyTextTop ),
commit 5de69f0ff2ffdf4fdd5e95a6398a60f68adb6cf0
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Apr 23 11:34:36 2014 +0100

    coverity#707832 Uninitialized scalar field
    
    Change-Id: I49220146ea83b04371d80f94dbf1405b0a7aea9d

diff --git a/filter/source/graphicfilter/itiff/ccidecom.cxx b/filter/source/graphicfilter/itiff/ccidecom.cxx
index 6a7a144..f0b6353 100644
--- a/filter/source/graphicfilter/itiff/ccidecom.cxx
+++ b/filter/source/graphicfilter/itiff/ccidecom.cxx
@@ -570,9 +570,14 @@ CCIDecompressor::CCIDecompressor( sal_uLong nOpts, sal_uInt32 nImageWidth ) :
     bStatus     ( false ),
     pByteSwap   ( NULL ),
     pIStream    ( NULL ),
+    nEOLCount   ( 0 ),
     nWidth      ( nImageWidth ),
     nOptions    ( nOpts ),
-    pLastLine   ( NULL )
+    bFirstEOL   ( false ),
+    nInputBitsBuf( 0 ),
+    nInputBitsBufSize( 0 ),
+    pLastLine   ( NULL ),
+    nLastLineSize( 0 )
 {
     if ( nOpts & CCI_OPTION_INVERSEBITORDER )
     {
commit a22ca0f7e098af161969ce7aa29e1d0110e2a435
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Apr 23 11:27:43 2014 +0100

    coverity#738811 Uninitialized pointer field
    
    Change-Id: I26ecc8bb911906681ec21174f703c536d9f9a83b

diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 69202b5..9e88a0b 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -447,8 +447,17 @@ ScGridWindow::ScGridWindow( Window* pParent, ScViewData* pData, ScSplitPos eWhic
             nButtonDown( 0 ),
             nMouseStatus( SC_GM_NONE ),
             nNestedButtonState( SC_NESTEDBUTTON_NONE ),
+            nDPField( 0 ),
+            pDragDPObj( NULL ),
+            nRFIndex( 0 ),
+            nRFAddX( 0 ),
+            nRFAddY( 0 ),
             nPagebreakMouse( SC_PD_NONE ),
+            nPagebreakBreak( 0 ),
+            nPagebreakPrev( 0 ),
             nPageScript( 0 ),
+            nLastClickX( 0 ),
+            nLastClickY( 0 ),
             nDragStartX( -1 ),
             nDragStartY( -1 ),
             nDragEndX( -1 ),
@@ -458,6 +467,7 @@ ScGridWindow::ScGridWindow( Window* pParent, ScViewData* pData, ScSplitPos eWhic
             aComboButton( this ),
             aCurMousePos( 0,0 ),
             nPaintCount( 0 ),
+            aRFSelectedCorned( NONE ),
             bEEMouse( false ),
             bDPMouse( false ),
             bRFMouse( false ),
commit b7fde5468d179e4ba162baccd1fe56ff6d7a8e48
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Apr 23 10:03:48 2014 +0100

    coverity#738636 Uninitialized pointer field
    
    Change-Id: I577775d6b7c2bbdbe8c6503b2454dbaec1dceadb

diff --git a/filter/source/graphicfilter/ipcd/ipcd.cxx b/filter/source/graphicfilter/ipcd/ipcd.cxx
index 6a2220e..ee50d7e 100644
--- a/filter/source/graphicfilter/ipcd/ipcd.cxx
+++ b/filter/source/graphicfilter/ipcd/ipcd.cxx
@@ -79,10 +79,19 @@ private:
 public:
 
     PCDReader(SvStream &rStream)
-        : m_rPCD(rStream)
+        : bStatus(false)
+        , nLastPercent(0)
+        , m_rPCD(rStream)
+        , mpAcc(NULL)
+        , nOrientation(0)
+        , eResolution(PCDRES_BASE16)
+        , nWidth(0)
+        , nHeight(0)
+        , nImagePos(0)
+        , nBMPWidth(0)
+        , nBMPHeight(0)
     {
     }
-    ~PCDReader() {}
 
     bool ReadPCD( Graphic & rGraphic, FilterConfigItem* pConfigItem );
 };


More information about the Libreoffice-commits mailing list