[Libreoffice-commits] core.git: chart2/source
Tor Lillqvist
tml at collabora.com
Fri Apr 25 10:18:12 PDT 2014
chart2/source/view/main/ChartView.cxx | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
New commits:
commit 9a587bf74f74c8f9b18c6fe1be28e1f1c3032820
Author: Tor Lillqvist <tml at collabora.com>
Date: Fri Apr 25 20:13:43 2014 +0300
No need for XShape dumping (for unit testing) for non-desktop
We don't do unit testing when cross-compiling anyway. (And even if we
did, in some magic fashion, I don't think we would want
debugging/testing functionality like this dumping thing to be dragged
in into a production build of an app. It's not a huge amount of code,
but still.)
Change-Id: I12bc552b10452263572074aae865138ff30fbfc8
diff --git a/chart2/source/view/main/ChartView.cxx b/chart2/source/view/main/ChartView.cxx
index 8bb5b2f..fe5d38c 100644
--- a/chart2/source/view/main/ChartView.cxx
+++ b/chart2/source/view/main/ChartView.cxx
@@ -3055,6 +3055,9 @@ uno::Sequence< OUString > ChartView::getAvailableServiceNames() throw (uno::Runt
OUString ChartView::dump() throw (uno::RuntimeException, std::exception)
{
+#if HAVE_FEATURE_DESKTOP
+ // Used for unit tests only, no need to drag in this when cross-compiling
+ // for non-desktop
impl_updateView();
if(!mxRootShape.is())
mxRootShape = AbstractShapeFactory::getOrCreateShapeFactory(m_xShapeFactory)
@@ -3067,7 +3070,9 @@ OUString ChartView::dump() throw (uno::RuntimeException, std::exception)
XShapeDumper dumper;
return dumper.dump(mxRootShape);
}
-
+#else
+ return OUString();
+#endif
}
void ChartView::setViewDirty()
More information about the Libreoffice-commits
mailing list