[Libreoffice-commits] core.git: 18 commits - cppcanvas/source filter/source sc/source sw/source vcl/source

Caolán McNamara caolanm at redhat.com
Mon Apr 28 02:31:33 PDT 2014


 cppcanvas/source/mtfrenderer/emfplus.cxx        |   59 ++++++++++++++++++------
 cppcanvas/source/mtfrenderer/implrenderer.cxx   |   26 ++++++++--
 filter/source/graphicfilter/ios2met/ios2met.cxx |   34 +++++++++++++
 sc/source/filter/excel/excrecds.cxx             |    8 ++-
 sc/source/filter/excel/xestream.cxx             |    1 
 sc/source/filter/excel/xestyle.cxx              |    2 
 sc/source/filter/excel/xeview.cxx               |    8 +--
 sc/source/filter/excel/xlchart.cxx              |   12 ++--
 sc/source/filter/excel/xlview.cxx               |    1 
 sc/source/filter/inc/lotrange.hxx               |    2 
 sw/source/core/undo/undobj1.cxx                 |    7 ++
 sw/source/core/undo/unmove.cxx                  |    9 ++-
 vcl/source/filter/wmf/winmtf.hxx                |   25 ++++------
 vcl/source/gdi/pdfextoutdevdata.cxx             |    2 
 vcl/source/gdi/pdfwriter_impl.hxx               |   14 ++++-
 15 files changed, 157 insertions(+), 53 deletions(-)

New commits:
commit 4ccdf41bd03a756c0e8d598fb3788e63433872c8
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Apr 28 09:53:55 2014 +0100

    coverity#708631 Uninitialized scalar field
    
    Change-Id: Ie95fe7f64e9f60500748511aa1e55c430f0a6641

diff --git a/vcl/source/gdi/pdfwriter_impl.hxx b/vcl/source/gdi/pdfwriter_impl.hxx
index 4cab95c..7f1b358 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -475,6 +475,7 @@ public:
                   m_nTextStyle( 0 ),
                   m_nFlags( 0 ),
                   m_nParent( 0 ),
+                  m_nTabOrder( 0 ),
                   m_nRadioGroup( -1 ),
                   m_nMaxLen( 0 ),
                   m_bSubmit( false ),
commit 94fcab784bad15022481d5acf1c8c7803d7c2611
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Apr 28 09:52:58 2014 +0100

    coverity#708630 Uninitialized scalar field
    
    Change-Id: Iaab1985c5db6482578d66abf224248da38db1624

diff --git a/vcl/source/gdi/pdfwriter_impl.hxx b/vcl/source/gdi/pdfwriter_impl.hxx
index 66d5105..4cab95c 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -222,7 +222,12 @@ public:
         sal_Int32           m_nObject;
         bool                m_bTrueColor;
 
-        JPGEmit() : m_pStream( NULL ), m_bTrueColor( false ) {}
+        JPGEmit()
+            : m_pStream(NULL)
+            , m_nObject(0)
+            , m_bTrueColor(false)
+        {
+        }
         ~JPGEmit() { delete m_pStream; }
     };
 
commit bedf2d65ca9e77f2072354fe1561a9cd047b0bd1
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Apr 28 09:51:47 2014 +0100

    coverity#708629 Uninitialized scalar field
    
    Change-Id: Ia570a267732a4f7d76f1873563f6db1eb884dc56

diff --git a/vcl/source/gdi/pdfwriter_impl.hxx b/vcl/source/gdi/pdfwriter_impl.hxx
index 07fab7f..66d5105 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -207,7 +207,11 @@ public:
         sal_Int32   m_nObject;
         bool        m_bDrawMask;
 
-        BitmapEmit() : m_bDrawMask( false ) {}
+        BitmapEmit()
+            : m_nObject(0)
+            , m_bDrawMask(false)
+        {
+        }
     };
 
     struct JPGEmit
commit d085620d0306f7e9a0346950259c8770f067595a
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Apr 28 09:49:28 2014 +0100

    coverity#708627 Uninitialized scalar field
    
    Change-Id: I729eab07b6de04be07e8495f28d14bcf1191e00d

diff --git a/vcl/source/gdi/pdfextoutdevdata.cxx b/vcl/source/gdi/pdfextoutdevdata.cxx
index 7a1f437..da71065 100644
--- a/vcl/source/gdi/pdfextoutdevdata.cxx
+++ b/vcl/source/gdi/pdfextoutdevdata.cxx
@@ -499,6 +499,8 @@ PDFExtOutDevData::PDFExtOutDevData( const OutputDevice& rOutDev ) :
     mbTransitionEffects     ( true ),
     mbUseLosslessCompression( true ),
     mbReduceImageResolution ( false ),
+    mbExportFormFields      ( false ),
+    mbExportBookmarks       ( false ),
     mbExportHiddenSlides    ( false ),
     mbExportNDests          ( false ),
     mnFormsFormat           ( 0 ),
commit c7a53e6320d6b21ad29a0572f87d8ccc36549c15
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Apr 28 09:47:46 2014 +0100

    coverity#708319 Uninitialized scalar field
    
    Change-Id: I8f817ba8fc286979f666ad06f4fe21f4703b4652

diff --git a/vcl/source/filter/wmf/winmtf.hxx b/vcl/source/filter/wmf/winmtf.hxx
index 52b1848..dfda459 100644
--- a/vcl/source/filter/wmf/winmtf.hxx
+++ b/vcl/source/filter/wmf/winmtf.hxx
@@ -775,7 +775,7 @@ protected:
 class EnhWMFReader : public WinMtf
 {
     bool        bRecordPath;
-    sal_Int32       nRecordCount;
+    sal_Int32   nRecordCount;
     bool        bEMFPlus;
 
     bool        ReadHeader();
@@ -783,18 +783,17 @@ class EnhWMFReader : public WinMtf
     Rectangle       ReadRectangle( sal_Int32, sal_Int32, sal_Int32, sal_Int32 );
 
 public:
-                    EnhWMFReader(
-                        SvStream& rStreamWMF,
-                        GDIMetaFile& rGDIMetaFile,
-                        FilterConfigItem* pConfigItem = NULL
-                    )
-                        : WinMtf( new WinMtfOutput( rGDIMetaFile )
-                        , rStreamWMF
-                        , pConfigItem )
-                        , bRecordPath( false )
-                        , bEMFPlus( false )
-                    {};
-                    ~EnhWMFReader();
+    EnhWMFReader(
+        SvStream& rStreamWMF,
+        GDIMetaFile& rGDIMetaFile,
+        FilterConfigItem* pConfigItem = NULL)
+        : WinMtf(new WinMtfOutput(rGDIMetaFile), rStreamWMF , pConfigItem)
+        , bRecordPath(false)
+        , nRecordCount(0)
+        , bEMFPlus(false)
+    {
+    }
+    ~EnhWMFReader();
 
     bool        ReadEnhWMF();
     void            ReadEMFPlusComment(sal_uInt32 length, bool& bHaveDC);
commit ce728a2ffa50455453ef83edf75112c525473a2d
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Apr 28 09:45:24 2014 +0100

    coverity#708472 Uninitialized scalar field
    
    Change-Id: I105021ff2c65af7811a5a4a040b2ed6333215db6

diff --git a/sw/source/core/undo/unmove.cxx b/sw/source/core/undo/unmove.cxx
index 6dc4a05..1ec0e5a 100644
--- a/sw/source/core/undo/unmove.cxx
+++ b/sw/source/core/undo/unmove.cxx
@@ -95,9 +95,12 @@ SwUndoMove::SwUndoMove( const SwPaM& rRange, const SwPosition& rMvPos )
 
 SwUndoMove::SwUndoMove( SwDoc* pDoc, const SwNodeRange& rRg,
                         const SwNodeIndex& rMvPos )
-    : SwUndo( UNDO_MOVE ),
-    nMvDestNode( rMvPos.GetIndex() ),
-    bMoveRedlines( false )
+    : SwUndo(UNDO_MOVE)
+    , nDestSttNode(0)
+    , nDestEndNode(0)
+    , nInsPosNode(0)
+    , nMvDestNode(rMvPos.GetIndex())
+    , bMoveRedlines(false)
 {
     bMoveRange = sal_True;
     bJoinNext = bJoinPrev = sal_False;
commit d2b58b6a3bf1430a06bca6f6b9c238614f7b959c
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Apr 28 09:43:15 2014 +0100

    coverity#708471 Uninitialized scalar field
    
    Change-Id: I5c9f97cb99490e5b068edc91fbfe0a39ecf9cfa4

diff --git a/sw/source/core/undo/undobj1.cxx b/sw/source/core/undo/undobj1.cxx
index 9537429..6a17bef 100644
--- a/sw/source/core/undo/undobj1.cxx
+++ b/sw/source/core/undo/undobj1.cxx
@@ -39,7 +39,12 @@
 #include <ndole.hxx>
 
 SwUndoFlyBase::SwUndoFlyBase( SwFrmFmt* pFormat, SwUndoId nUndoId )
-    : SwUndo( nUndoId ), pFrmFmt( pFormat )
+    : SwUndo(nUndoId)
+    , pFrmFmt(pFormat)
+    , nNdPgPos(0)
+    , nCntPos(0)
+    , nRndId(0)
+    , bDelFmt(false)
 {
 }
 
commit 64bc19eeb569d3bbb040dc9650b15476386c0e80
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Apr 28 09:40:06 2014 +0100

    coverity#708052 Uninitialized scalar field
    
    Change-Id: I6ef481d08d357d62e1a7931b2f43fb7cb5b55b7c

diff --git a/sc/source/filter/inc/lotrange.hxx b/sc/source/filter/inc/lotrange.hxx
index 8e3c932..f7c42b0 100644
--- a/sc/source/filter/inc/lotrange.hxx
+++ b/sc/source/filter/inc/lotrange.hxx
@@ -53,10 +53,12 @@ public:
 
 inline void LotusRange::Copy( const LotusRange& rCpy )
 {
+    nHash = rCpy.nHash;
     nColStart = rCpy.nColStart;
     nRowStart = rCpy.nRowStart;
     nColEnd = rCpy.nColEnd;
     nRowEnd = rCpy.nRowEnd;
+    nId = rCpy.nId;
 }
 
 inline void LotusRange::SetId( LR_ID nNewId )
commit c68d420614a1512ac3dd663f80c8559e3228a4e6
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Apr 28 09:38:14 2014 +0100

    coverity#708039 Uninitialized scalar field
    
    Change-Id: I8a7d3e4ec136c72385f4b4010e08d436aea9c776

diff --git a/sc/source/filter/excel/xeview.cxx b/sc/source/filter/excel/xeview.cxx
index c2da6ee..08e1216 100644
--- a/sc/source/filter/excel/xeview.cxx
+++ b/sc/source/filter/excel/xeview.cxx
@@ -29,10 +29,10 @@ using namespace ::oox;
 
 // Workbook view settings records =============================================
 
-XclExpWindow1::XclExpWindow1( const XclExpRoot& rRoot ) :
-    XclExpRecord( EXC_ID_WINDOW1, 18 ),
-    mnFlags( 0 ),
-    mnTabBarSize( 600 )
+XclExpWindow1::XclExpWindow1( const XclExpRoot& rRoot )
+    : XclExpRecord(EXC_ID_WINDOW1, 18)
+    , mnFlags(0)
+    , mnTabBarSize(600)
 {
     const ScViewOptions& rViewOpt = rRoot.GetDoc().GetViewOptions();
     ::set_flag( mnFlags, EXC_WIN1_HOR_SCROLLBAR,    rViewOpt.GetOption( VOPT_HSCROLL ) );
diff --git a/sc/source/filter/excel/xlview.cxx b/sc/source/filter/excel/xlview.cxx
index eb540a6..a0a3230 100644
--- a/sc/source/filter/excel/xlview.cxx
+++ b/sc/source/filter/excel/xlview.cxx
@@ -65,6 +65,7 @@ void XclTabViewData::SetDefaults()
     mbShowFormulas = false;
     mbShowGrid = mbShowHeadings = mbShowZeros = mbShowOutline = true;
     maTabBgColor.SetColor( COL_AUTO );
+    mnTabBgColorId = 0;
 }
 
 bool XclTabViewData::IsSplit() const
commit 6da7bf8ca7c3b7f3918a10cb42b7268f23a12cd9
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Apr 28 09:36:57 2014 +0100

    coverity#708038 Uninitialized scalar field
    
    Change-Id: I0954b9e1bc2ec845ac978acbdc4f48b405a0d3c8

diff --git a/sc/source/filter/excel/xlchart.cxx b/sc/source/filter/excel/xlchart.cxx
index 4c35925..58ccbae 100644
--- a/sc/source/filter/excel/xlchart.cxx
+++ b/sc/source/filter/excel/xlchart.cxx
@@ -1219,11 +1219,13 @@ EXC_DEFINEFUNC_GETAXISTITLESHAPE( lclGetSecYAxisTitleShape, XSecondAxisTitleSupp
 
 } // namespace
 
-XclChRootData::XclChRootData() :
-    mxTypeInfoProv( new XclChTypeInfoProvider ),
-    mxFmtInfoProv( new XclChFormatInfoProvider ),
-    mnBorderGapX( 0 ),
-    mnBorderGapY( 0 )
+XclChRootData::XclChRootData()
+    : mxTypeInfoProv(new XclChTypeInfoProvider)
+    , mxFmtInfoProv(new XclChFormatInfoProvider)
+    , mnBorderGapX(0)
+    , mnBorderGapY(0)
+    , mfUnitSizeX(0.0)
+    , mfUnitSizeY(0.0)
 {
     // remember some title shape getter functions
     maGetShapeFuncs[ XclChTextKey( EXC_CHTEXTTYPE_TITLE ) ] = lclGetMainTitleShape;
commit 1c843ef7bf2c4bf1c981b4f1e81e6c8cd2106513
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Apr 28 09:34:46 2014 +0100

    coverity#708033 Uninitialized scalar field
    
    Change-Id: Ia38eb70180ba783c72f2e91fc1c5792cbb88d8f9

diff --git a/sc/source/filter/excel/xestyle.cxx b/sc/source/filter/excel/xestyle.cxx
index 848d2c2..18b4d84 100644
--- a/sc/source/filter/excel/xestyle.cxx
+++ b/sc/source/filter/excel/xestyle.cxx
@@ -1207,7 +1207,7 @@ XclExpNumFmtBuffer::XclExpNumFmtBuffer( const XclExpRoot& rRoot ) :
     {
         case EXC_BIFF5: mnXclOffset = EXC_FORMAT_OFFSET5;   break;
         case EXC_BIFF8: mnXclOffset = EXC_FORMAT_OFFSET8;   break;
-        default:        DBG_ERROR_BIFF();
+        default:        mnXclOffset = 0; DBG_ERROR_BIFF();
     }
 
     mxFormatter->FillKeywordTable( *mpKeywordTable, LANGUAGE_ENGLISH_US );
commit d9f95530630bef21c2b0e9e6c226c9508daa7aa0
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Apr 28 09:33:34 2014 +0100

    coverity#708032 Uninitialized scalar field
    
    Change-Id: I681ade0c8a7fd45dc9ed3555ef8ca1d60f5741ee

diff --git a/sc/source/filter/excel/xestream.cxx b/sc/source/filter/excel/xestream.cxx
index 9ca1a47..946e05f 100644
--- a/sc/source/filter/excel/xestream.cxx
+++ b/sc/source/filter/excel/xestream.cxx
@@ -80,6 +80,7 @@ using namespace ::oox;
 XclExpStream::XclExpStream( SvStream& rOutStrm, const XclExpRoot& rRoot, sal_uInt16 nMaxRecSize ) :
     mrStrm( rOutStrm ),
     mrRoot( rRoot ),
+    mbUseEncrypter( false ),
     mnMaxRecSize( nMaxRecSize ),
     mnCurrMaxSize( 0 ),
     mnMaxSliceSize( 0 ),
commit 12217f1b2a66db791c0837b70413523b0852e4c6
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Apr 28 09:31:26 2014 +0100

    coverity#708027 Uninitialized scalar field
    
    Change-Id: If09859accf441b4e0f7f04ba87c8ad71155cda5f

diff --git a/sc/source/filter/excel/excrecds.cxx b/sc/source/filter/excel/excrecds.cxx
index 674861f..4f37aac 100644
--- a/sc/source/filter/excel/excrecds.cxx
+++ b/sc/source/filter/excel/excrecds.cxx
@@ -188,9 +188,11 @@ sal_Size ExcBoolRecord::GetLen( void ) const
 
 //--------------------------------------------------------- class ExcBof_Base -
 
-ExcBof_Base::ExcBof_Base() :
-    nRupBuild( 0x096C ),    // copied from Excel
-    nRupYear( 0x07C9 )      // copied from Excel
+ExcBof_Base::ExcBof_Base()
+    : nDocType(0)
+    , nVers(0)
+    , nRupBuild(0x096C)    // copied from Excel
+    , nRupYear(0x07C9)      // copied from Excel
 {
 }
 
commit a385c1072315c56928ac3515935b517c93f14da1
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Apr 28 09:25:59 2014 +0100

    coverity#707821 Uninitialized scalar field
    
    Change-Id: I47bb8d7f5d465b5507a17ea6e87728c5bbdd6c1c

diff --git a/filter/source/graphicfilter/ios2met/ios2met.cxx b/filter/source/graphicfilter/ios2met/ios2met.cxx
index fff7578..aed623e 100644
--- a/filter/source/graphicfilter/ios2met/ios2met.cxx
+++ b/filter/source/graphicfilter/ios2met/ios2met.cxx
@@ -249,7 +249,8 @@ struct OSBitmap {
     sal_uLong  nMapPos;
 };
 
-struct OSAttr {
+struct OSAttr
+{
     OSAttr *   pSucc;
     sal_uInt16 nPushOrder;
     sal_uInt8  nIvAttrA, nIvAttrP; // special variables for the Order "GOrdPIvAtr"
@@ -303,6 +304,37 @@ struct OSAttr {
 //  sal_uInt8     nTxtAlignHor,nTxtAlignVer;
 //  //...    aViewTransform;
 //  //...    aViewWindow;
+
+    OSAttr()
+        : pSucc(NULL)
+        , nPushOrder(0)
+        , nIvAttrA(0)
+        , nIvAttrP(0)
+        , eLinMix(ROP_OVERPAINT)
+        , eLinBgMix(ROP_OVERPAINT)
+        , eChrMix(ROP_OVERPAINT)
+        , eChrBgMix(ROP_OVERPAINT)
+        , eMrkMix(ROP_OVERPAINT)
+        , eMrkBgMix(ROP_OVERPAINT)
+        , ePatMix(ROP_OVERPAINT)
+        , ePatBgMix(ROP_OVERPAINT)
+        , eImgMix(ROP_OVERPAINT)
+        , eImgBgMix(ROP_OVERPAINT)
+        , nArcP(0)
+        , nArcQ(0)
+        , nArcR(0)
+        , nArcS(0)
+        , nChrAng(0)
+        , nChrSet(0)
+        , eLinStyle(PEN_NULL)
+        , nLinWidth(0)
+        , nMrkPrec(0)
+        , nMrkSet(0)
+        , nMrkSymbol(0)
+        , bFill(false)
+        , nStrLinWidth(0)
+    {
+    }
 };
 
 class OS2METReader {
commit 9f1e44e190f699751b0bfc6438fa2de9f51fd5aa
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Apr 28 09:20:39 2014 +0100

    coverity#738576 Uninitialized pointer field
    
    Change-Id: Id945cf9549b7f633f7deb1f237a2bf6536f221c1

diff --git a/cppcanvas/source/mtfrenderer/implrenderer.cxx b/cppcanvas/source/mtfrenderer/implrenderer.cxx
index 4b5935a..839aa40 100644
--- a/cppcanvas/source/mtfrenderer/implrenderer.cxx
+++ b/cppcanvas/source/mtfrenderer/implrenderer.cxx
@@ -2865,10 +2865,27 @@ namespace cppcanvas
 
         ImplRenderer::ImplRenderer( const CanvasSharedPtr&  rCanvas,
                                     const GDIMetaFile&      rMtf,
-                                    const Parameters&       rParams ) :
-            CanvasGraphicHelper( rCanvas ),
-            maActions()
+                                    const Parameters&       rParams )
+            : CanvasGraphicHelper(rCanvas)
+            , maActions()
+            , fPageScale(0.0)
+            , nOriginX(0)
+            , nOriginY(0)
+            , nHDPI(0)
+            , nVDPI(0)
+            , nFrameLeft(0)
+            , nFrameTop(0)
+            , nFrameRight(0)
+            , nFrameBottom(0)
+            , nPixX(0)
+            , nPixY(0)
+            , nMmX(0)
+            , nMmY(0)
+            , mbMultipart(false)
+            , mMFlags(0)
         {
+            memset (aObjects, 0, sizeof (aObjects));
+
             SAL_INFO( "cppcanvas.emf", "::cppcanvas::internal::ImplRenderer::ImplRenderer(mtf)" );
 
             OSL_ENSURE( rCanvas.get() != NULL && rCanvas->getUNOCanvas().is(),
@@ -2970,9 +2987,6 @@ namespace cppcanvas
             }
 
             /* EMF+ */
-            memset (aObjects, 0, sizeof (aObjects));
-            mbMultipart = false;
-
             createActions( const_cast<GDIMetaFile&>(rMtf), // HACK(Q2):
                                                            // we're
                                                            // changing
commit 76f74ef908a50ac3b63d0b3a190f17dce33cbd0f
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Apr 28 09:16:18 2014 +0100

    coverity#738575 Uninitialized pointer field
    
    Change-Id: Ib65f0e95ef2a837b6c5791d9e2dce5fe8025da33

diff --git a/cppcanvas/source/mtfrenderer/emfplus.cxx b/cppcanvas/source/mtfrenderer/emfplus.cxx
index 5774eb6..4ff1ea2 100644
--- a/cppcanvas/source/mtfrenderer/emfplus.cxx
+++ b/cppcanvas/source/mtfrenderer/emfplus.cxx
@@ -360,13 +360,24 @@ namespace cppcanvas
 
         public:
             EMFPBrush ()
+                : type(0)
+                , additionalFlags(0)
+                , wrapMode(0)
+                , areaX(0.0)
+                , areaY(0.0)
+                , areaWidth(0.0)
+                , areaHeight(0.0)
+                , hasTransformation(false)
+                , blendPoints(0)
+                , blendPositions(NULL)
+                , blendFactors(NULL)
+                , colorblendPoints(0)
+                , colorblendPositions(NULL)
+                , colorblendColors(NULL)
+                , surroundColorsNumber(0)
+                , surroundColors(NULL)
+                , path(NULL)
             {
-                blendPositions = NULL;
-                colorblendPositions = NULL;
-                colorblendColors = NULL;
-                surroundColors = NULL;
-                path = NULL;
-                hasTransformation = false;
             }
 
             virtual ~EMFPBrush ()
commit b3e332b4a70658548c4560c2bc460143548559df
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sun Apr 27 15:50:59 2014 +0100

    coverity#738574 Uninitialized scalar field
    
    Change-Id: Ia7cca6e2a2bc3240a32509697a999461491a2747

diff --git a/cppcanvas/source/mtfrenderer/emfplus.cxx b/cppcanvas/source/mtfrenderer/emfplus.cxx
index a34b4d3..5774eb6 100644
--- a/cppcanvas/source/mtfrenderer/emfplus.cxx
+++ b/cppcanvas/source/mtfrenderer/emfplus.cxx
@@ -769,15 +769,29 @@ namespace cppcanvas
             EMFPCustomLineCap *customEndCap;
 
         public:
-            EMFPPen () : EMFPBrush ()
+            EMFPPen ()
+                : EMFPBrush()
+                , width(0.0)
+                , startCap(0)
+                , endCap(0)
+                , lineJoin(0)
+                , mitterLimit(0.0)
+                , dashStyle(0)
+                , dashCap(0)
+                , dashOffset(0.0)
+                , dashPatternLen(0)
+                , dashPattern(NULL)
+                , alignment(0)
+                , compoundArrayLen(0)
+                , compoundArray(NULL)
+                , customStartCapLen(0)
+                , customStartCap(NULL)
+                , customEndCapLen(0)
+                , customEndCap(NULL)
             {
-                dashPattern = NULL;
-                compoundArray = NULL;
-                customStartCap = NULL;
-                customEndCap = NULL;
             }
 
-            virtual ~EMFPPen ()
+            virtual ~EMFPPen()
             {
                 delete[] dashPattern;
                 delete[] compoundArray;
commit 766d5e4ec0182ecbeaac9475dedad9a631f9cf47
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sun Apr 27 15:22:57 2014 +0100

    coverity#738573 Uninitialized scalar field
    
    Change-Id: I8b112fa0095cc6ed15c9198a312a0b6fce3a8d28

diff --git a/cppcanvas/source/mtfrenderer/emfplus.cxx b/cppcanvas/source/mtfrenderer/emfplus.cxx
index 8310f40..a34b4d3 100644
--- a/cppcanvas/source/mtfrenderer/emfplus.cxx
+++ b/cppcanvas/source/mtfrenderer/emfplus.cxx
@@ -287,9 +287,15 @@ namespace cppcanvas
             float ix, iy, iw, ih;
 
             EMFPRegion ()
+                : parts(0)
+                , combineMode(NULL)
+                , initialState(0)
+                , initialPath(NULL)
+                , ix(0.0)
+                , iy(0.0)
+                , iw(0.0)
+                , ih(0.0)
             {
-                combineMode = NULL;
-                initialPath = NULL;
             }
 
             virtual ~EMFPRegion ()


More information about the Libreoffice-commits mailing list