[Libreoffice-commits] core.git: 26 commits - avmedia/source cui/source dbaccess/source filter/source include/svx reportdesign/source sc/source sd/source sfx2/source sw/source unoidl/source vcl/source writerfilter/source
Caolán McNamara
caolanm at redhat.com
Tue Apr 29 03:41:03 PDT 2014
avmedia/source/opengl/oglplayer.cxx | 1
avmedia/source/viewer/mediawindow_impl.cxx | 1
cui/source/options/optdict.cxx | 3
dbaccess/source/ui/inc/directsql.hxx | 1
filter/source/pdf/impdialog.cxx | 8 -
include/svx/hdft.hxx | 1
reportdesign/source/ui/inc/DateTime.hxx | 3
reportdesign/source/ui/inc/PageNumber.hxx | 3
sc/source/ui/StatisticsDialogs/SamplingDialog.cxx | 1
sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx | 1
sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx | 1
sc/source/ui/dbgui/PivotLayoutDialog.cxx | 3
sc/source/ui/dbgui/consdlg.cxx | 3
sc/source/ui/dbgui/validate.cxx | 1
sc/source/ui/inc/filtdlg.hxx | 2
sc/source/ui/miscdlgs/datafdlg.cxx | 1
sd/source/ui/inc/unoaprms.hxx | 47 ++++++++--
sfx2/source/dialog/basedlgs.cxx | 4
sfx2/source/dialog/dinfdlg.cxx | 11 +-
sfx2/source/dialog/tabdlg.cxx | 2
sw/source/ui/fldui/flddb.cxx | 2
sw/source/ui/misc/docfnote.cxx | 6 +
sw/source/ui/table/tabledlg.cxx | 25 ++---
unoidl/source/unoidlprovider.cxx | 2
vcl/source/opengl/OpenGLContext.cxx | 1
writerfilter/source/dmapper/PropertyMap.hxx | 2
26 files changed, 91 insertions(+), 45 deletions(-)
New commits:
commit d5d55b84f686ec7ba835105356f32f5a0ac1cf3e
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:34:17 2014 +0100
coverity#1210178 Uninitialized scalar field
Change-Id: I4bbd62b153f7e4b7769b1e1eeb65ce801e57ff5b
diff --git a/cui/source/options/optdict.cxx b/cui/source/options/optdict.cxx
index e0f46bd..6047228 100644
--- a/cui/source/options/optdict.cxx
+++ b/cui/source/options/optdict.cxx
@@ -228,7 +228,8 @@ SvxEditDictionaryDialog::SvxEditDictionaryDialog(
xSpell ( xSpl ),
nOld ( NOACTDICT ),
bFirstSelect (true),
- bDoNothing (false)
+ bDoNothing (false),
+ bDicIsReadonly (false)
{
get(pAllDictsLB,"book");
commit 7e487c1959f5a2b74dae656e3f012bab8a908151
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:33:21 2014 +0100
coverity#1210179 Uninitialized pointer field
Change-Id: I09534eab67c0ae38cd6965c3b63227d92b72c646
diff --git a/unoidl/source/unoidlprovider.cxx b/unoidl/source/unoidlprovider.cxx
index 2e7ac09..68d5ebc 100644
--- a/unoidl/source/unoidlprovider.cxx
+++ b/unoidl/source/unoidlprovider.cxx
@@ -165,7 +165,7 @@ private:
const;
};
-MappedFile::MappedFile(OUString const & fileUrl): uri(fileUrl) {
+MappedFile::MappedFile(OUString const & fileUrl): uri(fileUrl), handle(0) {
oslFileError e = osl_openFile(uri.pData, &handle, osl_File_OpenFlag_Read);
switch (e) {
case osl_File_E_None:
commit 3c6e2a2bd3f0472830864aa0e5f4458d9b3182b0
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:32:05 2014 +0100
coverity#1210180 Uninitialized pointer field
Change-Id: Ice39630a7991bf037842557e76bfb95600c57ea3
diff --git a/avmedia/source/viewer/mediawindow_impl.cxx b/avmedia/source/viewer/mediawindow_impl.cxx
index 46900ed..96f7a46 100644
--- a/avmedia/source/viewer/mediawindow_impl.cxx
+++ b/avmedia/source/viewer/mediawindow_impl.cxx
@@ -161,6 +161,7 @@ MediaWindowImpl::MediaWindowImpl( Window* pParent, MediaWindow* pMediaWindow, bo
DropTargetHelper( this ),
DragSourceHelper( this ),
mpMediaWindow( pMediaWindow ),
+ mpEvents( NULL ),
mpMediaWindowControl( bInternalMediaControl ? new MediaWindowControl( this ) : NULL ),
mpEmptyBmpEx( NULL ),
mpAudioBmpEx( NULL )
commit 0283251f58d2717d78bf522f38d25a04489040a3
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:30:24 2014 +0100
coverity#1210181 Uninitialized scalar field
Change-Id: I30c9449901cd96b74141dd511cabff3c5b9201bc
diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx
index 8072fe6..0825ea0 100644
--- a/filter/source/pdf/impdialog.cxx
+++ b/filter/source/pdf/impdialog.cxx
@@ -985,9 +985,9 @@ IMPL_LINK( ImpPDFTabOpnFtrPage, ToggleRbMagnHdl, void*, )
// The Viewer preferences tab page
ImpPDFTabViewerPage::ImpPDFTabViewerPage( Window* pParent,
- const SfxItemSet& rCoreSet ) :
- SfxTabPage( pParent, "PdfUserInterfacePage","filter/ui/pdfuserinterfacepage.ui", rCoreSet )
-
+ const SfxItemSet& rCoreSet )
+ : SfxTabPage(pParent, "PdfUserInterfacePage","filter/ui/pdfuserinterfacepage.ui", rCoreSet)
+ , mbIsPresentation(false)
{
get(m_pCbResWinInit,"resize");
get(m_pCbCenterWindow,"center");
@@ -1005,12 +1005,10 @@ ImpPDFTabViewerPage::ImpPDFTabViewerPage( Window* pParent,
m_pRbVisibleBookmarkLevels->SetToggleHdl( LINK( this, ImpPDFTabViewerPage, ToggleRbBookmarksHdl ) );
}
-
ImpPDFTabViewerPage::~ImpPDFTabViewerPage()
{
}
-
IMPL_LINK( ImpPDFTabViewerPage, ToggleRbBookmarksHdl, void*, )
{
m_pNumBookmarkLevels->Enable( m_pRbVisibleBookmarkLevels->IsChecked() );
commit 17d785e97232a613f7b25473829ecd39bd27dc65
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:28:02 2014 +0100
coverity#1210182 Uninitialized scalar field
Change-Id: I2611c840e572d1b46deefc5ce888721820a2bd40
diff --git a/include/svx/hdft.hxx b/include/svx/hdft.hxx
index c6cd5ca..b840ada 100644
--- a/include/svx/hdft.hxx
+++ b/include/svx/hdft.hxx
@@ -80,7 +80,6 @@ protected:
SfxItemSet* pBBSet;
bool bDisableQueryBox;
bool bEnableBackgroundSelector;
- bool bInReset;
void InitHandler();
DECL_LINK( TurnOnHdl, CheckBox*);
commit 322c3e6222142c821cc0c34cc8c6b8bbfbcc0518
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:26:45 2014 +0100
coverity#1210183 Uninitialized pointer field
Change-Id: I9a86030d988473ac56ee1c6c1325b1eede2ba010
diff --git a/sw/source/ui/misc/docfnote.cxx b/sw/source/ui/misc/docfnote.cxx
index adb22ef..76ee933 100644
--- a/sw/source/ui/misc/docfnote.cxx
+++ b/sw/source/ui/misc/docfnote.cxx
@@ -74,6 +74,12 @@ SwEndNoteOptionPage::SwEndNoteOptionPage(Window *pParent, bool bEN,
bEN ? OString("EndnotePage") : OString("FootnotePage"),
bEN ? OUString("modules/swriter/ui/endnotepage.ui") : OUString("modules/swriter/ui/footnotepage.ui"),
rSet)
+ , m_pNumCountBox(NULL)
+ , m_pPosFT(NULL)
+ , m_pPosPageBox(NULL)
+ , m_pPosChapterBox(NULL)
+ , m_pContEdit(NULL)
+ , m_pContFromEdit(NULL)
, pSh(0)
, bPosDoc(false)
, bEndNote(bEN)
commit 9c6f93e44fdbb5ac5f0e636521080fd4b1f36a59
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:22:28 2014 +0100
coverity#1210184 Uninitialized scalar field
Change-Id: Ic632e75e35bc14b714a30e71eb9957d3f949cbf5
diff --git a/sfx2/source/dialog/dinfdlg.cxx b/sfx2/source/dialog/dinfdlg.cxx
index df43353..2dc137c 100644
--- a/sfx2/source/dialog/dinfdlg.cxx
+++ b/sfx2/source/dialog/dinfdlg.cxx
@@ -2160,11 +2160,14 @@ CmisYesNo::CmisYesNo( Window* pParent, bool bValue )
}
// struct CmisPropertyLine ---------------------------------------------
-CmisPropertyLine::CmisPropertyLine( Window* pParent )
+CmisPropertyLine::CmisPropertyLine(Window* pParent)
+ : m_sType(CMIS_TYPE_STRING)
+ , m_bUpdatable(false)
+ , m_bRequired(false)
+ , m_bMultiValued(false)
+ , m_bOpenChoice(false)
+ , m_nNumValue(1)
{
- m_nNumValue = 1;
- m_sId = "";
- m_sType = CMIS_TYPE_STRING;
m_pUIBuilder = new VclBuilder( pParent, getUIRootDir(), "sfx/ui/cmisline.ui");
get( m_pFrame, "CmisFrame" );
get( m_aName, "name" );
commit 80c61632a62e0335397d417e991db7f6999a3f0a
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:20:27 2014 +0100
coverity#1210185 Uninitialized pointer field
Change-Id: I837094aaf9f04c189296417d77391e3f56604616
diff --git a/sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx b/sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx
index bcc8687..fa9ce72 100644
--- a/sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx
@@ -34,6 +34,7 @@ ScStatisticsTwoVariableDialog::ScStatisticsTwoVariableDialog(
mDocument ( pViewData->GetDocument() ),
mAddressDetails ( mDocument->GetAddressConvention(), 0, 0 ),
mGroupedBy ( BY_COLUMN ),
+ mpActiveEdit ( NULL ),
mCurrentAddress ( pViewData->GetCurX(), pViewData->GetCurY(), pViewData->GetTabNo() ),
mDialogLostFocus( false )
{
commit cb2488b4a6bc83aa5586162592c80fb584160650
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:19:37 2014 +0100
coverity#1210186 Uninitialized pointer field
Change-Id: Ia74bb69ec3ed269d4a73633d470b2d3247741d58
diff --git a/sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx b/sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx
index 787f17b..0b20ae0 100644
--- a/sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx
@@ -62,6 +62,7 @@ ScStatisticsInputOutputDialog::ScStatisticsInputOutputDialog(
mDocument ( pViewData->GetDocument() ),
mAddressDetails ( mDocument->GetAddressConvention(), 0, 0 ),
mGroupedBy ( BY_COLUMN ),
+ mpActiveEdit ( NULL ),
mCurrentAddress ( pViewData->GetCurX(), pViewData->GetCurY(), pViewData->GetTabNo() ),
mDialogLostFocus( false )
{
commit cd911048ac0f1dd986849f2a4c6a5e0c9654bfa6
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:18:23 2014 +0100
coverity#1210187 Uninitialized pointer field
Change-Id: Ib4de734a2703060174f618a8a2b313cd92e82cf2
diff --git a/sc/source/ui/inc/filtdlg.hxx b/sc/source/ui/inc/filtdlg.hxx
index 51ff29c..330a426 100644
--- a/sc/source/ui/inc/filtdlg.hxx
+++ b/sc/source/ui/inc/filtdlg.hxx
@@ -91,7 +91,6 @@ private:
ScrollBar* pScrollBar;
VclExpander* pExpander;
- HelpButton* pBtnHelp;
OKButton* pBtnOk;
CancelButton* pBtnCancel;
@@ -194,7 +193,6 @@ private:
OKButton* pBtnOk;
CancelButton* pBtnCancel;
- HelpButton* pBtnHelp;
ScFilterOptionsMgr* pOptionsMgr;
commit a822a53b0b2de391b76324de47dc5cc0e0613a5a
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:17:46 2014 +0100
coverity#1210188 Uninitialized pointer field
Change-Id: I7b0eab57b6822f8429dd275ed4cb8c40ffc71e50
diff --git a/avmedia/source/opengl/oglplayer.cxx b/avmedia/source/opengl/oglplayer.cxx
index 5c8bbea..08c9d30 100644
--- a/avmedia/source/opengl/oglplayer.cxx
+++ b/avmedia/source/opengl/oglplayer.cxx
@@ -24,6 +24,7 @@ namespace avmedia { namespace ogl {
OGLPlayer::OGLPlayer()
: Player_BASE(m_aMutex)
+ , m_pHandle(NULL)
, m_bIsPlayingTmp(false)
{
}
commit 1545a28e5e85f2f3ff6a19dd49a45b1dd2a1a497
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:16:56 2014 +0100
coverity#1210189 Uninitialized pointer field
Change-Id: I47707799510a20918403ee6b66f4a4c2f01f5b22
diff --git a/sfx2/source/dialog/basedlgs.cxx b/sfx2/source/dialog/basedlgs.cxx
index f461a4b..9bebf9d 100644
--- a/sfx2/source/dialog/basedlgs.cxx
+++ b/sfx2/source/dialog/basedlgs.cxx
@@ -710,6 +710,7 @@ IMPL_LINK_NOARG(SfxSingleTabDialog, OKHdl_Impl)
SfxSingleTabDialog::SfxSingleTabDialog(Window *pParent, const SfxItemSet& rSet,
const OString& rID, const OUString& rUIXMLDescription)
: SfxModalDialog(pParent, rID, rUIXMLDescription)
+ , fnGetRanges(NULL)
, pImpl(new SingleTabDlgImpl)
{
get(pOKBtn, "ok");
commit 01f23b8b8d319e7eac92bfed328b0e393d029f1e
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:16:28 2014 +0100
coverity#1210190 Uninitialized pointer field
Change-Id: Ie1843391868c4804cde1d110476d17f34aa2c69b
diff --git a/sfx2/source/dialog/basedlgs.cxx b/sfx2/source/dialog/basedlgs.cxx
index c3bd05b..f461a4b 100644
--- a/sfx2/source/dialog/basedlgs.cxx
+++ b/sfx2/source/dialog/basedlgs.cxx
@@ -722,6 +722,7 @@ SfxSingleTabDialog::SfxSingleTabDialog(Window *pParent, const SfxItemSet& rSet,
SfxSingleTabDialog::SfxSingleTabDialog(Window* pParent, const SfxItemSet* pInSet,
const OString& rID, const OUString& rUIXMLDescription)
: SfxModalDialog(pParent, rID, rUIXMLDescription)
+ , fnGetRanges(NULL)
, pImpl(new SingleTabDlgImpl)
{
get(pOKBtn, "ok");
@@ -731,8 +732,6 @@ SfxSingleTabDialog::SfxSingleTabDialog(Window* pParent, const SfxItemSet* pInSet
SetInputSet( pInSet );
}
-
-
SfxSingleTabDialog::~SfxSingleTabDialog()
{
delete pImpl->m_pSfxPage;
diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx
index 044241d..2f2c6f9 100644
--- a/sfx2/source/dialog/tabdlg.cxx
+++ b/sfx2/source/dialog/tabdlg.cxx
@@ -728,8 +728,6 @@ void SfxTabDialog::AddTabPage
new Data_Impl( nId, pCreateFunc, pRangesFunc, bItemsOnDemand ) );
}
-
-
void SfxTabDialog::RemoveTabPage( sal_uInt16 nId )
/* [Description]
commit 43c2f73fad937976b6ba0df5965988656a0ba037
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:13:11 2014 +0100
coverity#1210191 Uninitialized pointer field
Change-Id: I7b4161217ccd70d00bd43740719825ba19058bf7
diff --git a/sc/source/ui/dbgui/PivotLayoutDialog.cxx b/sc/source/ui/dbgui/PivotLayoutDialog.cxx
index 4acc758..4b74fca 100644
--- a/sc/source/ui/dbgui/PivotLayoutDialog.cxx
+++ b/sc/source/ui/dbgui/PivotLayoutDialog.cxx
@@ -69,9 +69,12 @@ ScPivotLayoutDialog::ScPivotLayoutDialog(
ScViewData* pViewData, const ScDPObject* pPivotTableObject, bool bNewPivotTable) :
ScAnyRefDlg (pSfxBindings, pChildWindow, pParent, "PivotTableLayout", "modules/scalc/ui/pivottablelayoutdialog.ui"),
maPivotTableObject (*pPivotTableObject),
+ mpPreviouslyFocusedListBox(NULL),
+ mpCurrentlyFocusedListBox(NULL),
mpViewData (pViewData),
mpDocument (pViewData->GetDocument()),
mbNewPivotTable (bNewPivotTable),
+ mpActiveEdit (NULL),
maAddressDetails (mpDocument->GetAddressConvention(), 0, 0),
mbDialogLostFocus (false)
{
commit 9827b60c53f2ae57947507140dd908927412a260
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:11:11 2014 +0100
coverity#1210192 Uninitialized pointer field
Change-Id: I836170b6eb6edce6d9fb0827e40c72d9ab979f4f
diff --git a/sc/source/ui/StatisticsDialogs/SamplingDialog.cxx b/sc/source/ui/StatisticsDialogs/SamplingDialog.cxx
index a252ba8..3602376 100644
--- a/sc/source/ui/StatisticsDialogs/SamplingDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/SamplingDialog.cxx
@@ -32,6 +32,7 @@ ScSamplingDialog::ScSamplingDialog(
Window* pParent, ScViewData* pViewData ) :
ScAnyRefDlg ( pSfxBindings, pChildWindow, pParent,
"SamplingDialog", "modules/scalc/ui/samplingdialog.ui" ),
+ mpActiveEdit ( NULL ),
mViewData ( pViewData ),
mDocument ( pViewData->GetDocument() ),
mAddressDetails ( mDocument->GetAddressConvention(), 0, 0 ),
commit 9bd7e8f1d6a755f5d99c95c3aa2270197f238eb9
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:09:05 2014 +0100
coverity#1210193 Uninitialized pointer field
Change-Id: I8d9ee48fa7fb08aa7488d891121078024b13bd71
diff --git a/vcl/source/opengl/OpenGLContext.cxx b/vcl/source/opengl/OpenGLContext.cxx
index 477fd62..ba27e9d 100644
--- a/vcl/source/opengl/OpenGLContext.cxx
+++ b/vcl/source/opengl/OpenGLContext.cxx
@@ -21,6 +21,7 @@ using namespace com::sun::star;
OpenGLContext::OpenGLContext():
mpWindow(NULL),
+ m_pChildWindow(NULL),
mbInitialized(false)
{
}
commit 4a1bcd90b93f6ceb78c9181f2ebbd0f47d71eeb4
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:05:59 2014 +0100
coverity#1210194 Uninitialized scalar field
Change-Id: I6572f70c1c0eaa149759189c6b196281e74e218d
diff --git a/sc/source/ui/dbgui/consdlg.cxx b/sc/source/ui/dbgui/consdlg.cxx
index 8b9e99b..0f8e328 100644
--- a/sc/source/ui/dbgui/consdlg.cxx
+++ b/sc/source/ui/dbgui/consdlg.cxx
@@ -78,7 +78,8 @@ ScConsolidateDlg::ScConsolidateDlg( SfxBindings* pB, SfxChildWindow* pCW, Window
pRangeUtil ( new ScRangeUtil ),
pAreaData ( NULL ),
nAreaDataCount ( 0 ),
- nWhichCons ( rArgSet.GetPool()->GetWhich( SID_CONSOLIDATE ) )
+ nWhichCons ( rArgSet.GetPool()->GetWhich( SID_CONSOLIDATE ) ),
+ bDlgLostFocus ( false )
{
get(pLbFunc,"func");
get(pLbConsAreas,"consareas");
commit b4464c79afa19fba75aad5fa5c2c5ba67c6f657d
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:03:32 2014 +0100
coverity#1210195 Uninitialized scalar field
Change-Id: I7f5b9c42c58ebd4b0fbcf456e83573465799b0c5
diff --git a/sw/source/ui/fldui/flddb.cxx b/sw/source/ui/fldui/flddb.cxx
index 6612249..40b1f68 100644
--- a/sw/source/ui/fldui/flddb.cxx
+++ b/sw/source/ui/fldui/flddb.cxx
@@ -36,6 +36,8 @@
SwFldDBPage::SwFldDBPage(Window* pParent, const SfxItemSet& rCoreSet)
: SwFldPage(pParent, "FldDbPage",
"modules/swriter/ui/flddbpage.ui", rCoreSet)
+ , m_nOldFormat(0)
+ , m_nOldSubType(0)
{
get(m_pTypeLB, "type");
m_pTypeLB->SetStyle(m_pTypeLB->GetStyle() | WB_SORT);
commit 2472da5ef635acc2d516c01a094cf77a8a39fb0d
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:02:28 2014 +0100
coverity#1210196 Uninitialized pointer field
Change-Id: Ib6add605efa2588ac357185687b22c2a6b8863ca
diff --git a/reportdesign/source/ui/inc/DateTime.hxx b/reportdesign/source/ui/inc/DateTime.hxx
index 439fb41..759b091 100644
--- a/reportdesign/source/ui/inc/DateTime.hxx
+++ b/reportdesign/source/ui/inc/DateTime.hxx
@@ -47,9 +47,6 @@ class ODateTimeDialog : public ModalDialog
FixedText* m_pFTTimeFormat;
ListBox* m_pTimeListBox;
OKButton* m_pPB_OK;
- CancelButton* m_pPB_CANCEL;
- HelpButton* m_pPB_Help;
-
svt::ControlDependencyManager m_aDateControlling;
svt::ControlDependencyManager m_aTimeControlling;
commit 677e7718ca917929048ae7befe09780ac0c9ef27
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:01:33 2014 +0100
coverity#1210197 Uninitialized pointer field
Change-Id: If0d9996c570d892713b23102f280a96449921d95
diff --git a/dbaccess/source/ui/inc/directsql.hxx b/dbaccess/source/ui/inc/directsql.hxx
index 5cdab0e..36e74cc 100644
--- a/dbaccess/source/ui/inc/directsql.hxx
+++ b/dbaccess/source/ui/inc/directsql.hxx
@@ -52,7 +52,6 @@ namespace dbaui
VclMultiLineEdit* m_pStatus;
CheckBox* m_pShowOutput;
VclMultiLineEdit* m_pOutput;
- HelpButton* m_pHelp;
PushButton* m_pClose;
typedef ::std::deque< OUString > StringQueue;
commit d1324645f57d567c2a79e4fea95b79a36caa3a93
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 11:00:20 2014 +0100
coverity#1210198 Uninitialized pointer field
Change-Id: If72fff8b6cc7e5e55e1f395ddc34b4c5810faff3
diff --git a/sc/source/ui/dbgui/validate.cxx b/sc/source/ui/dbgui/validate.cxx
index a89fa81..6a93378 100644
--- a/sc/source/ui/dbgui/validate.cxx
+++ b/sc/source/ui/dbgui/validate.cxx
@@ -317,6 +317,7 @@ ScTPValidationValue::ScTPValidationValue( Window* pParent, const SfxItemSet& rAr
, maStrValue(ScResId(SCSTR_VALID_VALUE))
, maStrRange(ScResId(SCSTR_VALID_RANGE))
, maStrList(ScResId(SCSTR_VALID_LIST))
+ , m_pRefEdit(NULL)
{
get(m_pLbAllow, "allow");
get(m_pCbAllow, "allowempty");
commit f6b53bb08e5c5ebdf20c2312ab067598bcd13f4c
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 10:59:17 2014 +0100
coverity#1210199 Uninitialized scalar field
Change-Id: Ia07d39191a4676f0ba2381bde0a03925bb6c8931
diff --git a/sc/source/ui/miscdlgs/datafdlg.cxx b/sc/source/ui/miscdlgs/datafdlg.cxx
index f9e4639..b4ad28d 100644
--- a/sc/source/ui/miscdlgs/datafdlg.cxx
+++ b/sc/source/ui/miscdlgs/datafdlg.cxx
@@ -24,6 +24,7 @@
ScDataFormDlg::ScDataFormDlg(Window* pParent, ScTabViewShell* pTabViewShellOri)
: ModalDialog(pParent, "DataFormDialog", "modules/scalc/ui/dataform.ui")
, pTabViewShell(pTabViewShellOri)
+ , bNoSelection(false)
{
get(m_pBtnNew, "new");
get(m_pBtnDelete, "delete");
commit faaa1aab3837c909b89dd28460d72a575c0c5fd4
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 10:58:28 2014 +0100
coverity#1210200 Uninitialized pointer field
Change-Id: I29792702565f19e0aae6d7b52eedd695caab97f5
diff --git a/sd/source/ui/inc/unoaprms.hxx b/sd/source/ui/inc/unoaprms.hxx
index 8d8b967..0c1526d 100644
--- a/sd/source/ui/inc/unoaprms.hxx
+++ b/sd/source/ui/inc/unoaprms.hxx
@@ -81,12 +81,47 @@ class SdAnimationPrmsUndoAction : public SdUndoAction
public:
TYPEINFO_OVERRIDE();
- SdAnimationPrmsUndoAction(SdDrawDocument* pTheDoc, SdrObject* pObj,
- bool bCreated):
- SdUndoAction (pTheDoc),
- pObject (pObj),
- bInfoCreated (bCreated)
- {}
+ SdAnimationPrmsUndoAction(SdDrawDocument* pTheDoc, SdrObject* pObj,
+ bool bCreated)
+ : SdUndoAction(pTheDoc)
+ , pObject(pObj)
+ , bOldActive(false)
+ , bNewActive(false)
+ , bOldDimPrevious(false)
+ , bNewDimPrevious(false)
+ , bOldDimHide(false)
+ , bNewDimHide(false)
+ , bOldSoundOn(false)
+ , bNewSoundOn(false)
+ , bOldSecondSoundOn(false)
+ , bNewSecondSoundOn(false)
+ , bOldPlayFull(false)
+ , bNewPlayFull(false)
+ , bOldSecondPlayFull(false)
+ , bNewSecondPlayFull(false)
+ , eOldEffect(css::presentation::AnimationEffect_NONE)
+ , eNewEffect(css::presentation::AnimationEffect_NONE)
+ , eOldTextEffect(css::presentation::AnimationEffect_NONE)
+ , eNewTextEffect(css::presentation::AnimationEffect_NONE)
+ , eOldSpeed(css::presentation::AnimationSpeed_SLOW)
+ , eNewSpeed(css::presentation::AnimationSpeed_SLOW)
+ , eOldSecondEffect(css::presentation::AnimationEffect_NONE)
+ , eNewSecondEffect(css::presentation::AnimationEffect_NONE)
+ , eOldSecondSpeed(css::presentation::AnimationSpeed_SLOW)
+ , eNewSecondSpeed(css::presentation::AnimationSpeed_SLOW)
+ , pOldPathObj(NULL)
+ , pNewPathObj(NULL)
+ , eOldClickAction(css::presentation::ClickAction_NONE)
+ , eNewClickAction(css::presentation::ClickAction_NONE)
+ , bOldInvisibleInPres(false)
+ , bNewInvisibleInPres(false)
+ , nOldVerb(0)
+ , nNewVerb(0)
+ , nOldPresOrder(0)
+ , nNewPresOrder(0)
+ , bInfoCreated(bCreated)
+ {
+ }
void SetActive(bool bTheOldActive, bool bTheNewActive)
{ bOldActive = bTheOldActive; bNewActive = bTheNewActive; }
commit 9b8fd6df0e4bba8d3104650418262b6e1e7f8b46
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 10:45:50 2014 +0100
coverity#1210201 Uninitialized pointer field
Change-Id: I94c4853524eea306dd53a7a747f94735e0be0752
diff --git a/reportdesign/source/ui/inc/PageNumber.hxx b/reportdesign/source/ui/inc/PageNumber.hxx
index 19a1b6c..f90377b 100644
--- a/reportdesign/source/ui/inc/PageNumber.hxx
+++ b/reportdesign/source/ui/inc/PageNumber.hxx
@@ -45,9 +45,6 @@ class OPageNumberDialog : public ModalDialog
ListBox* m_pAlignmentLst;
CheckBox* m_pShowNumberOnFirstPage;
- OKButton* m_pPB_OK;
- CancelButton* m_pPB_CANCEL;
- HelpButton* m_pPB_Help;
::rptui::OReportController* m_pController;
::com::sun::star::uno::Reference< ::com::sun::star::report::XReportDefinition>
commit c1a55709361abcfe10fccfdd2e21580be01a57f6
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 10:44:49 2014 +0100
coverity#1210202 Uninitialized pointer field
Change-Id: If364402a0cb304e2109c2c5792847639c15b1b5c
diff --git a/sw/source/ui/table/tabledlg.cxx b/sw/source/ui/table/tabledlg.cxx
index d317eb3..71a7d22 100644
--- a/sw/source/ui/table/tabledlg.cxx
+++ b/sw/source/ui/table/tabledlg.cxx
@@ -711,6 +711,7 @@ int SwFormatTablePage::DeactivatePage( SfxItemSet* _pSet )
SwTableColumnPage::SwTableColumnPage(Window* pParent, const SfxItemSet& rSet)
: SfxTabPage(pParent, "TableColumnPage",
"modules/swriter/ui/tablecolumnpage.ui", rSet)
+ , pTblData(0)
, nTableWidth(0)
, nMinWidth(MINLAY)
, nNoOfCols(0)
@@ -745,18 +746,18 @@ SwTableColumnPage::SwTableColumnPage(Window* pParent, const SfxItemSet& rSet)
const SfxPoolItem* pItem;
Init((SFX_ITEM_SET == rSet.GetItemState( SID_HTML_MODE, false,&pItem )
&& ((const SfxUInt16Item*)pItem)->GetValue() & HTMLMODE_ON));
+}
-};
//Description: Page column configuration
SwTableColumnPage::~SwTableColumnPage()
{
-};
+}
SfxTabPage* SwTableColumnPage::Create( Window* pParent,
const SfxItemSet& rAttrSet)
{
return new SwTableColumnPage( pParent, rAttrSet );
-};
+}
void SwTableColumnPage::Reset( const SfxItemSet& )
{
@@ -800,7 +801,7 @@ void SwTableColumnPage::Reset( const SfxItemSet& )
}
ActivatePage(rSet);
-};
+}
void SwTableColumnPage::Init(sal_Bool bWeb)
{
@@ -825,7 +826,7 @@ void SwTableColumnPage::Init(sal_Bool bWeb)
aLk = LINK( this, SwTableColumnPage, ModeHdl );
m_pModifyTableCB->SetClickHdl( aLk );
m_pProportionalCB->SetClickHdl( aLk );
-};
+}
IMPL_LINK( SwTableColumnPage, AutoClickHdl, CheckBox *, pBox )
{
@@ -863,14 +864,14 @@ IMPL_LINK( SwTableColumnPage, AutoClickHdl, CheckBox *, pBox )
m_pUpBtn->Enable(aValueTbl[ MET_FIELDS -1 ] < nNoOfVisibleCols -1 );
UpdateCols(0);
return 0;
-};
+}
IMPL_LINK_INLINE_START( SwTableColumnPage, UpHdl, MetricField*, pEdit )
{
bModified = sal_True;
ModifyHdl( pEdit );
return 0;
-};
+}
IMPL_LINK_INLINE_END( SwTableColumnPage, UpHdl, MetricField*, pEdit )
IMPL_LINK_INLINE_START( SwTableColumnPage, DownHdl, MetricField*, pEdit )
@@ -878,7 +879,7 @@ IMPL_LINK_INLINE_START( SwTableColumnPage, DownHdl, MetricField*, pEdit )
bModified = sal_True;
ModifyHdl( pEdit );
return 0;
-};
+}
IMPL_LINK_INLINE_END( SwTableColumnPage, DownHdl, MetricField*, pEdit )
IMPL_LINK_INLINE_START( SwTableColumnPage, LoseFocusHdl, MetricField*, pEdit )
@@ -889,7 +890,7 @@ IMPL_LINK_INLINE_START( SwTableColumnPage, LoseFocusHdl, MetricField*, pEdit )
ModifyHdl( pEdit );
}
return 0;
-};
+}
IMPL_LINK_INLINE_END( SwTableColumnPage, LoseFocusHdl, MetricField*, pEdit )
IMPL_LINK( SwTableColumnPage, ModeHdl, CheckBox*, pBox )
@@ -902,7 +903,7 @@ IMPL_LINK( SwTableColumnPage, ModeHdl, CheckBox*, pBox )
m_pModifyTableCB->Enable(!bCheck && bModifyTbl);
}
return 0;
-};
+}
bool SwTableColumnPage::FillItemSet( SfxItemSet& )
{
@@ -920,7 +921,7 @@ bool SwTableColumnPage::FillItemSet( SfxItemSet& )
pTblData->SetColsChanged();
}
return bModified;
-};
+}
void SwTableColumnPage::ModifyHdl( MetricField* pField )
{
@@ -945,7 +946,7 @@ void SwTableColumnPage::ModifyHdl( MetricField* pField )
SetVisibleWidth(aValueTbl[i], static_cast< SwTwips >(pEdit->DenormalizePercent(pEdit->GetValue( FUNIT_TWIP ))) );
UpdateCols( aValueTbl[i] );
-};
+}
void SwTableColumnPage::UpdateCols( sal_uInt16 nAktPos )
{
commit a9dde7c69bfef7fd6092c4903befbccfa7af3c5d
Author: Caolán McNamara <caolanm at redhat.com>
Date: Tue Apr 29 10:42:06 2014 +0100
coverity#1210401 Non-virtual destructor
Change-Id: I6ec9104fc1ec5f2fff951b6a06df7865941cafb4
diff --git a/writerfilter/source/dmapper/PropertyMap.hxx b/writerfilter/source/dmapper/PropertyMap.hxx
index 1769d5b..571181f 100644
--- a/writerfilter/source/dmapper/PropertyMap.hxx
+++ b/writerfilter/source/dmapper/PropertyMap.hxx
@@ -322,7 +322,7 @@ class ParagraphProperties
public:
ParagraphProperties();
ParagraphProperties(const ParagraphProperties&);
- ~ParagraphProperties();
+ virtual ~ParagraphProperties();
bool operator==(const ParagraphProperties&); //does not compare the starting/ending range, m_sParaStyleName and m_nDropCapLength
More information about the Libreoffice-commits
mailing list