[Libreoffice-commits] core.git: 13 commits - chart2/source cui/source sw/qa sw/source
Caolán McNamara
caolanm at redhat.com
Wed Apr 30 13:03:26 PDT 2014
chart2/source/controller/dialogs/tp_AxisPositions.cxx | 2
chart2/source/controller/dialogs/tp_SeriesToAxis.cxx | 12 ++-
cui/source/customize/cfg.cxx | 2
cui/source/tabpages/autocdlg.cxx | 4 +
cui/source/tabpages/connect.cxx | 13 +---
cui/source/tabpages/grfpage.cxx | 3
cui/source/tabpages/measure.cxx | 1
cui/source/tabpages/transfrm.cxx | 57 +++++++-----------
sw/qa/core/uwriter.cxx | 5 +
sw/source/core/text/txtfly.cxx | 24 ++++---
sw/source/ui/misc/insfnote.cxx | 11 +--
11 files changed, 74 insertions(+), 60 deletions(-)
New commits:
commit d1ffea3a272d61f1343047e86b4eeabe032aa352
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Apr 30 20:59:54 2014 +0100
coverity#738909 Uninitialized scalar field
Change-Id: I332d57bd7a82a734e509afe24c0c716ce8a4e455
diff --git a/sw/source/ui/misc/insfnote.cxx b/sw/source/ui/misc/insfnote.cxx
index de9b9bf..cacc4eb 100644
--- a/sw/source/ui/misc/insfnote.cxx
+++ b/sw/source/ui/misc/insfnote.cxx
@@ -167,11 +167,12 @@ IMPL_LINK( SwInsFootNoteDlg, NextPrevHdl, Button *, pBtn )
return 0;
}
-SwInsFootNoteDlg::SwInsFootNoteDlg(Window *pParent, SwWrtShell &rShell, bool bEd) :
- SvxStandardDialog(pParent, "InsertFootnoteDialog", "modules/swriter/ui/insertfootnote.ui"),
- rSh(rShell),
- bExtCharAvailable(false),
- bEdit(bEd)
+SwInsFootNoteDlg::SwInsFootNoteDlg(Window *pParent, SwWrtShell &rShell, bool bEd)
+ : SvxStandardDialog(pParent, "InsertFootnoteDialog", "modules/swriter/ui/insertfootnote.ui")
+ , rSh(rShell)
+ , eCharSet(RTL_TEXTENCODING_DONTKNOW)
+ , bExtCharAvailable(false)
+ , bEdit(bEd)
{
get(m_pNumberFrame, "numberingframe");
get(m_pNumberAutoBtn, "automatic");
commit 858292697c3624556922852d88623aaf72e0fccd
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Apr 30 20:57:23 2014 +0100
coverity#708465 Uninitialized scalar field
Change-Id: I56bc0398a6c61c128a3fc07ab7761bd3bc70250d
diff --git a/sw/source/core/text/txtfly.cxx b/sw/source/core/text/txtfly.cxx
index d4cd734..fb122fd 100644
--- a/sw/source/core/text/txtfly.cxx
+++ b/sw/source/core/text/txtfly.cxx
@@ -310,15 +310,21 @@ const SwRect SwContourCache::ContourRect( const SwFmt* pFmt,
return aRet;
}
-SwTxtFly::SwTxtFly() :
- pPage(0),
- mpCurrAnchoredObj(0),
- pCurrFrm(0),
- pMaster(0),
- mpAnchoredObjList(0),
- nMinBottom(0),
- nNextTop(0),
- nIndex(0)
+SwTxtFly::SwTxtFly()
+ : pPage(0)
+ , mpCurrAnchoredObj(0)
+ , pCurrFrm(0)
+ , pMaster(0)
+ , mpAnchoredObjList(0)
+ , nMinBottom(0)
+ , nNextTop(0)
+ , nIndex(0)
+ , bOn(false)
+ , bTopRule(false)
+ , mbIgnoreCurrentFrame(false)
+ , mbIgnoreContour(false)
+ , mbIgnoreObjsInHeaderFooter(false)
+
{
}
commit 3124c258716a6483000d9e217b0e300326683cfe
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Apr 30 20:56:50 2014 +0100
coverity#738881 Uninitialized pointer field
Change-Id: Iecf88297963bd4bf0a5f69f7090ed0bbeb393c89
diff --git a/sw/qa/core/uwriter.cxx b/sw/qa/core/uwriter.cxx
index f17ffca..bd6e000 100644
--- a/sw/qa/core/uwriter.cxx
+++ b/sw/qa/core/uwriter.cxx
@@ -62,6 +62,11 @@ using namespace ::com::sun::star;
class SwDocTest : public test::BootstrapFixture
{
public:
+ SwDocTest()
+ : m_pDoc(NULL)
+ {
+ }
+
virtual void setUp() SAL_OVERRIDE;
virtual void tearDown() SAL_OVERRIDE;
commit 503f6b4878562fbd629742ee98d374c2b6f6979b
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Apr 30 20:53:58 2014 +0100
coverity#738609 Uninitialized pointer field
Change-Id: I63718d125c166b31a5980b34d4070e6fd8e89f50
diff --git a/cui/source/tabpages/transfrm.cxx b/cui/source/tabpages/transfrm.cxx
index ee299bc..eef82e8 100644
--- a/cui/source/tabpages/transfrm.cxx
+++ b/cui/source/tabpages/transfrm.cxx
@@ -613,19 +613,19 @@ void SvxSlantTabPage::PointChanged( Window* , RECT_POINT )
|* Dialog for changing position and size of graphic objects
|*
\************************************************************************/
-
-SvxPositionSizeTabPage::SvxPositionSizeTabPage( Window* pParent, const SfxItemSet& rInAttrs ) :
- SvxTabPage ( pParent
- ,"PositionAndSize"
- ,"cui/ui/possizetabpage.ui"
- , rInAttrs ),
-
- mrOutAttrs ( rInAttrs ),
- mnProtectSizeState( TRISTATE_FALSE ),
- mbPageDisabled ( false ),
- mbProtectDisabled( false ),
- mbSizeDisabled( false ),
- mbAdjustDisabled( true )
+SvxPositionSizeTabPage::SvxPositionSizeTabPage(Window* pParent, const SfxItemSet& rInAttrs)
+ : SvxTabPage(pParent,"PositionAndSize","cui/ui/possizetabpage.ui", rInAttrs)
+ , mrOutAttrs(rInAttrs)
+ , mpView(NULL)
+ , meDlgUnit(FUNIT_NONE)
+ , meMapUnit(MAP_100TH_MM)
+ , mnProtectSizeState(TRISTATE_FALSE)
+ , mbPageDisabled(false)
+ , mbProtectDisabled(false)
+ , mbSizeDisabled(false)
+ , mbAdjustDisabled(true)
+ , mfOldWidth(0.0)
+ , mfOldHeight(0.0)
{
get(m_pFlPosition, "FL_POSITION");
@@ -675,8 +675,6 @@ SvxPositionSizeTabPage::SvxPositionSizeTabPage( Window* pParent, const SfxItemSe
}
-
-
void SvxPositionSizeTabPage::Construct()
{
// get range and work area
commit ddf6eac1b63123c937891adbe760e5dec8fcc73e
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Apr 30 20:50:57 2014 +0100
coverity#738608 Uninitialized pointer field
Change-Id: If4d3260d1f7875f6d22b752e0e52e66cc4e666b7
diff --git a/cui/source/tabpages/transfrm.cxx b/cui/source/tabpages/transfrm.cxx
index 24d0d0e..ee299bc 100644
--- a/cui/source/tabpages/transfrm.cxx
+++ b/cui/source/tabpages/transfrm.cxx
@@ -432,13 +432,12 @@ void SvxAngleTabPage::PointChanged(Window* pWindow, RECT_POINT eRP)
|* dialog for changing slant and corner radius
|*
\************************************************************************/
-
-SvxSlantTabPage::SvxSlantTabPage( Window* pParent, const SfxItemSet& rInAttrs ) :
- SvxTabPage ( pParent
- ,"SlantAndCornerRadius"
- ,"cui/ui/slantcornertabpage.ui"
- , rInAttrs ),
- rOutAttrs ( rInAttrs )
+SvxSlantTabPage::SvxSlantTabPage(Window* pParent, const SfxItemSet& rInAttrs)
+ : SvxTabPage( pParent,"SlantAndCornerRadius","cui/ui/slantcornertabpage.ui",
+ rInAttrs)
+ , rOutAttrs(rInAttrs)
+ , pView(NULL)
+ , eDlgUnit(FUNIT_NONE)
{
get(m_pFlRadius, "FL_RADIUS");
get(m_pMtrRadius, "MTR_FLD_RADIUS");
@@ -454,8 +453,6 @@ SvxSlantTabPage::SvxSlantTabPage( Window* pParent, const SfxItemSet& rInAttrs )
ePoolUnit = pPool->GetMetric( SID_ATTR_TRANSFORM_POS_X );
}
-
-
void SvxSlantTabPage::Construct()
{
// get the range
commit b4884b45fab389e8fa7d52a2487be82266167042
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Apr 30 20:47:16 2014 +0100
coverity#738607 Uninitialized pointer field
Change-Id: I333e7a6d06c47771ccd4a0bc937a833ae871a5c5
diff --git a/cui/source/tabpages/transfrm.cxx b/cui/source/tabpages/transfrm.cxx
index 291bea7..24d0d0e 100644
--- a/cui/source/tabpages/transfrm.cxx
+++ b/cui/source/tabpages/transfrm.cxx
@@ -198,13 +198,11 @@ void SvxTransformTabDialog::SetValidateFramePosLink(const Link& rLink)
|* angle and the rotation angle of the graphic objects
|*
\************************************************************************/
-
-SvxAngleTabPage::SvxAngleTabPage( Window* pParent, const SfxItemSet& rInAttrs ) :
- SvxTabPage ( pParent
- ,"Rotation"
- ,"cui/ui/rotationtabpage.ui"
- , rInAttrs ),
- rOutAttrs ( rInAttrs )
+SvxAngleTabPage::SvxAngleTabPage(Window* pParent, const SfxItemSet& rInAttrs)
+ : SvxTabPage( pParent,"Rotation","cui/ui/rotationtabpage.ui", rInAttrs)
+ , rOutAttrs(rInAttrs)
+ , pView(NULL)
+ , eDlgUnit(FUNIT_NONE)
{
get(m_pFlPosition, "FL_POSITION");
get(m_pMtrPosX, "MTR_FLD_POS_X");
@@ -223,8 +221,6 @@ SvxAngleTabPage::SvxAngleTabPage( Window* pParent, const SfxItemSet& rInAttrs )
m_pCtlAngle->SetLinkedField( m_pNfAngle, 2 );
}
-
-
void SvxAngleTabPage::Construct()
{
DBG_ASSERT(pView, "No valid view (!)");
commit 61fb42950d0b04d3f576bc2aacf72771dba722db
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Apr 30 16:13:59 2014 +0100
coverity#738594 Uninitialized scalar field
Change-Id: Ib8a7c8d6fb610715015e533b9e5f473cb4a4e145
diff --git a/cui/source/tabpages/measure.cxx b/cui/source/tabpages/measure.cxx
index 4dc2937..8982ed8 100644
--- a/cui/source/tabpages/measure.cxx
+++ b/cui/source/tabpages/measure.cxx
@@ -88,6 +88,7 @@ SvxMeasurePage::SvxMeasurePage( Window* pWindow, const SfxItemSet& rInAttrs ) :
rOutAttrs ( rInAttrs ),
aAttrSet ( *rInAttrs.GetPool() ),
pView( 0 ),
+ eUnit( SFX_MAPUNIT_100TH_MM ),
bPositionModified ( false )
{
get(m_pMtrFldLineDist, "MTR_LINE_DIST");
commit c6c90e40b89b003bcaaa1dac0e809c107318d43a
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Apr 30 16:01:10 2014 +0100
coverity#738592 Uninitialized scalar field
Change-Id: Ie4479033a256344784d03640e9c18412986c20a3
diff --git a/cui/source/tabpages/grfpage.cxx b/cui/source/tabpages/grfpage.cxx
index 3beb9a7..2a11e2c 100644
--- a/cui/source/tabpages/grfpage.cxx
+++ b/cui/source/tabpages/grfpage.cxx
@@ -51,6 +51,9 @@ static inline long lcl_GetValue( MetricField& rMetric, FieldUnit eUnit )
SvxGrfCropPage::SvxGrfCropPage ( Window *pParent, const SfxItemSet &rSet )
: SfxTabPage(pParent, "CropPage", "cui/ui/croppage.ui", rSet)
, pLastCropField(0)
+ , nOldWidth(0)
+ , nOldHeight(0)
+ , bReset(false)
, bInitialized(false)
, bSetOrigSize(false)
{
commit 880a542a527e6c3d76f15f13bd336403a53dc435
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Apr 30 15:57:37 2014 +0100
coverity#738591 Uninitialized pointer field
Change-Id: I066b6af6a1576e741c099a5961c2d4d0f2e16927
diff --git a/cui/source/tabpages/connect.cxx b/cui/source/tabpages/connect.cxx
index 0728184..fd2b449 100644
--- a/cui/source/tabpages/connect.cxx
+++ b/cui/source/tabpages/connect.cxx
@@ -80,13 +80,12 @@ SvxConnectionDialog::~SvxConnectionDialog()
|*
\************************************************************************/
-SvxConnectionPage::SvxConnectionPage( Window* pWindow, const SfxItemSet& rInAttrs ) :
- SfxTabPage ( pWindow
- ,"ConnectorTabPage"
- ,"cui/ui/connectortabpage.ui"
- ,rInAttrs ),
- rOutAttrs ( rInAttrs ),
- aAttrSet ( *rInAttrs.GetPool() )
+SvxConnectionPage::SvxConnectionPage( Window* pWindow, const SfxItemSet& rInAttrs )
+ : SfxTabPage(pWindow ,"ConnectorTabPage" ,"cui/ui/connectortabpage.ui"
+ ,rInAttrs)
+ , rOutAttrs(rInAttrs)
+ , aAttrSet(*rInAttrs.GetPool())
+ , pView(NULL)
{
get(m_pLbType,"LB_TYPE");
commit ce4e4c9dd59affcab2a5162161283fd42ab592ef
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Apr 30 15:55:56 2014 +0100
coverity#738590 Uninitialized scalar field
Change-Id: I527c06f5cac8795191f2244aa2a31ed4f1c35ef7
diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/tabpages/autocdlg.cxx
index d4dc261..db8330c 100644
--- a/cui/source/tabpages/autocdlg.cxx
+++ b/cui/source/tabpages/autocdlg.cxx
@@ -1744,6 +1744,10 @@ OfaQuoteTabPage::OfaQuoteTabPage(Window* pParent, const SfxItemSet& rSet)
, sNonBrkSpace(CUI_RESSTR(RID_SVXSTR_NON_BREAK_SPACE))
, sOrdinal(CUI_RESSTR(RID_SVXSTR_ORDINAL))
, pCheckButtonData(NULL)
+ , cSglStartQuote(0)
+ , cSglEndQuote(0)
+ , cStartQuote(0)
+ , cEndQuote(0)
{
get(m_pCheckLB, "checklist");
commit 667772760aaba490f58af3bf0cb076cb3b0c4eb9
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Apr 30 15:52:50 2014 +0100
coverity#738577 Uninitialized pointer field
Change-Id: I2a1c99b368ae970a63545cea4d750711baa4ad55
diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx
index c9a485b..5a591ef 100644
--- a/cui/source/customize/cfg.cxx
+++ b/cui/source/customize/cfg.cxx
@@ -2649,6 +2649,8 @@ SvxMainMenuOrganizerDialog::SvxMainMenuOrganizerDialog(
}
else
{
+ pNewMenuEntry = NULL;
+
// hide name label and textfield
m_pMenuBox->Hide();
// change the title
commit 8608dd317975e39088b82bc8f1ec8c42d01fa1fc
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Apr 30 15:51:19 2014 +0100
coverity#738569 Uninitialized scalar field
Change-Id: I1e6c3f30f1760ff72aae935d79291e4f910d132b
diff --git a/chart2/source/controller/dialogs/tp_SeriesToAxis.cxx b/chart2/source/controller/dialogs/tp_SeriesToAxis.cxx
index 683fdc1..c358597 100644
--- a/chart2/source/controller/dialogs/tp_SeriesToAxis.cxx
+++ b/chart2/source/controller/dialogs/tp_SeriesToAxis.cxx
@@ -32,13 +32,15 @@
namespace chart
{
-SchOptionTabPage::SchOptionTabPage(Window* pWindow,const SfxItemSet& rInAttrs) :
- SfxTabPage(pWindow,
+SchOptionTabPage::SchOptionTabPage(Window* pWindow,const SfxItemSet& rInAttrs)
+ : SfxTabPage(pWindow,
"TP_OPTIONS",
"modules/schart/ui/tp_SeriesToAxis.ui",
- rInAttrs),
- m_bProvidesSecondaryYAxis(true),
- m_bProvidesOverlapAndGapWidth(false)
+ rInAttrs)
+ , m_nAllSeriesAxisIndex(0)
+ , m_bProvidesSecondaryYAxis(true)
+ , m_bProvidesOverlapAndGapWidth(false)
+ , m_bProvidesBarConnectors(false)
{
get(m_pGrpAxis,"frameGrpAxis");
get(m_pRbtAxis1,"RBT_OPT_AXIS_1");
commit 9a7ae56a887537009ee88dbaed1a42f6d0060c6c
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Apr 30 15:31:30 2014 +0100
coverity#738568 Uninitialized scalar field
Change-Id: I0243a52daa67054b8f7fe33ccdd5c149fb35411e
diff --git a/chart2/source/controller/dialogs/tp_AxisPositions.cxx b/chart2/source/controller/dialogs/tp_AxisPositions.cxx
index a0e28ca..1dfe618 100644
--- a/chart2/source/controller/dialogs/tp_AxisPositions.cxx
+++ b/chart2/source/controller/dialogs/tp_AxisPositions.cxx
@@ -50,6 +50,7 @@ AxisPositionsTabPage::AxisPositionsTabPage(Window* pWindow,const SfxItemSet& rIn
, m_pNumFormatter(NULL)
, m_bCrossingAxisIsCategoryAxis(false)
, m_aCategories()
+ , m_bSupportAxisPositioning(false)
{
get(m_pFL_AxisLine, "FL_AXIS_LINE");
get(m_pLB_CrossesAt,"LB_CROSSES_OTHER_AXIS_AT");
@@ -82,7 +83,6 @@ AxisPositionsTabPage::AxisPositionsTabPage(Window* pWindow,const SfxItemSet& rIn
m_pLB_PlaceLabels->SetSelectHdl( LINK( this, AxisPositionsTabPage, PlaceLabelsSelectHdl ) );
m_pLB_PlaceLabels->SetDropDownLineCount( m_pLB_PlaceLabels->GetEntryCount() );
m_pLB_PlaceTicks->SetDropDownLineCount( m_pLB_PlaceTicks->GetEntryCount() );
-
}
SfxTabPage* AxisPositionsTabPage::Create(Window* pWindow,const SfxItemSet& rOutAttrs)
More information about the Libreoffice-commits
mailing list