[Libreoffice-commits] core.git: sfx2/source

[Markus Mohrhard]

 sfx2/source/appl/appuno.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 955c5539a1ea5e971f111989d6c5bec11d936416
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Sun Aug 3 22:47:27 2014 +0200

    avoid buffer overflow by using wrong buffer
    
    Found by Asan.
    
    (regression from CWS mba34issues01)
    
    Change-Id: Ia7159c9bed9d7f823448acd02e18568a5f3f2093
    Reviewed-on: https://gerrit.libreoffice.org/10717
    Reviewed-by: Michael Stahl <mstahl at redhat.com>
    Tested-by: Michael Stahl <mstahl at redhat.com>

diff --git a/sfx2/source/appl/appuno.cxx b/sfx2/source/appl/appuno.cxx
index 8f44b07..a16ab3e 100644
--- a/sfx2/source/appl/appuno.cxx
+++ b/sfx2/source/appl/appuno.cxx
@@ -972,7 +972,7 @@ void TransformItems( sal_uInt16 nSlotId, const SfxItemSet& rSet, uno::Sequence<b
         for ( sal_uInt16 nArg=0; nArg<nFormalArgs; ++nArg )
         {
             // check every formal argument of the method
-            const SfxFormalArgument &rArg = pSlot->GetFormalArgument( nArg );
+            const SfxFormalArgument &rArg = bIsMediaDescriptor ? aFormalArgs[nArg] : pSlot->GetFormalArgument( nArg );
 
             sal_uInt16 nWhich = rSet.GetPool()->GetWhich( rArg.nSlotId );
             if ( rSet.GetItemState( nWhich ) == SFX_ITEM_SET ) //???