[Libreoffice-commits] core.git: sd/source

Stephan Bergmann sbergman at redhat.com
Tue Aug 5 05:17:52 PDT 2014


 sd/source/core/sdpage.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 7627008b0671f16cf84a3f552e3316ab8d803ebb
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue Aug 5 14:14:16 2014 +0200

    Clear() an SdPage while it is still an SdPage
    
    ... because when Clear() is later called in the SdrObjList sub-object dtor,
    freed SdrObject dtors may call back via SdrObject::SendUserCall into this
    virtual SdPage::Changed, but then this is only an SdrObjList, causing undef
    behavior.
    
    Change-Id: I09a2d1445a51a70e8f795ff869027899ad0f528b

diff --git a/sd/source/core/sdpage.cxx b/sd/source/core/sdpage.cxx
index 8f8f6e6..9e368eb 100644
--- a/sd/source/core/sdpage.cxx
+++ b/sd/source/core/sdpage.cxx
@@ -147,6 +147,8 @@ SdPage::~SdPage()
 
     if( mpItems )
         delete mpItems;
+
+    Clear();
 }
 
 struct OrdNumSorter


More information about the Libreoffice-commits mailing list