[Libreoffice-commits] core.git: Changes to 'feature/gsoc14-personas2'
Rachit Gupta
rachitgupta1792 at gmail.com
Tue Aug 5 10:31:05 PDT 2014
New branch 'feature/gsoc14-personas2' available with the following commits:
commit be5b98f43526c9ab8bd0436a5fbd568b252cb8e4
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Tue Aug 5 22:49:22 2014 +0530
Removed hardcoded strings.
Replaced the hardcoded strings with their CUI_RES equivalents.
Change-Id: I1f4e0451839cd9fe10aa9d1c5ae82af9fa13dc4e
commit add94e482716809ca667b494eba15d145e7abdc6
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Tue Aug 5 21:27:20 2014 +0530
Changed Select Persona Dialog.
The result buttons are visible initially but are disabled. These get
enabled when the results are available.
A little code clean up.
Change-Id: I6217d59220d871909bd001a6c7f3636b05cdf911
commit 7809ac111d78c64a46d87266a40acdde677c2609
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Tue Jul 29 19:39:57 2014 +0530
Added title to the Select Persona Dialog.
Change-Id: Ia54e94c84e71fb794e7dec67f89306a5dd465f68
commit d0f95525cbc7000669a18541f478d6e9c5d2be30
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Fri Jul 11 21:50:54 2014 +0530
Fixed crash when cancel is clicked without searching.
Change-Id: I67ca901270874794ec55d5b7db2cd18e6d3a997d
commit ff1e7a1df34e26b0e6b4a0d7694e1efa4d4bf1f0
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Thu Jul 10 23:23:12 2014 +0530
Fixed thread related issues.
Added a data member m_bExecute which defaults to true but is set to
false when StopExecution is called. During execution, the member's value
is checked at various positions, if it is false, the execution is stopped
by returning from the execute method.
Following issues have been resolved:
* Multiple searches can be performed. The previous search is halted.
* Cancel button can be pressed in between any search or application of
the persona.
* A theme can be selected and applied by clicking on OK while the search
is being done.
Change-Id: Ic76c224ca0d317a6e1a44b3e8933a3ba50b371cb
commit 7c41f8cbc8396b755eb3280d6c22f6c9420f49ae
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Tue Jul 8 22:09:30 2014 +0530
The "Select personas installed via extensions" label is invisible by default.
The label is not shown if there are no persona extensions installed.
Change-Id: I758bb7ff7f22d56bfb7fe212908f9f5f1f3e7979
commit c7aeada5f674618c0a5e9e8d9bc01bcf1f159b83
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Tue Jul 8 21:53:28 2014 +0530
Improved UI: Large buttons are not shown.
* In the Personalization Tab Page, the button sizes are not affected
by the presence of the preview buttons. THey remain their original
size.
* Added some padding and spacing to avoid cluttering of the widgets.
Change-Id: Iea919b9fbfce4a7bfc82f73ccb49f94aa10ec804
commit defdb9e435643b597b5af02e3dbe51b45f9a5ac9
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Wed Jul 2 14:01:59 2014 +0530
Added feature of clearing the registry in case something goes wrong.
If the installed extension is removed, then the persona settings in
the registry are cleared to avoid odd look in the UI.
Change-Id: Iaa99f4c87ec6ce4a663e1a3cebb3f8ff45e02079
commit 8f066be6fab69721c872e442c794c97942837b4c
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Wed Jul 2 10:11:04 2014 +0530
Minor fix: Own persona selected when user selects installed persona.
Change-Id: I5ecd9e3b4a9b878cf5aeb2ccce2e51b45ce9a70a
commit 6cd70e51ef0cf4520a1068e35349df2ec8d722f8
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Tue Jul 1 18:27:42 2014 +0530
Changed Personas installed through extensions procedure.
The UI now consists of a TreeView that lists all the personas that were
installed through extensions. When the user selects any name from the
list, the preview is shown in a button besides the list.
If there are no extensions installed, the list stays hidden.
Change-Id: I030d99549fd5b15d1104224116257ad62cdd1891
commit a774e913dc698048c13e7d6b7dc0f2fee359467f
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Tue Jul 1 15:30:44 2014 +0530
Moved the personas installed through extensions handling to 'own'.
Change-Id: I12baaf22bfad73e228d3ed55dcf365f8eba9cf0a
commit de1422dd9fabf04d9edf5bcc28aa8a58ddee56c8
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Tue Jul 1 13:34:39 2014 +0530
Fixed Bug: Persona info is deleted if No Persona is selected.
If the user selects 'Plain look..' and clicks OK, the previous persona
information is removed from the registry so that if the user selects either
of the other option and clicks OK, the previous theme is not applied.
Change-Id: I5f6a707e5f2724d2a3c39965d155cf47c898d392
commit 43d91a59e9be02a02a13600fb0084e8938988edb
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Mon Jun 30 18:46:47 2014 +0530
Dropped 'Persona' from the properties in PersonasEntry template.
Change-Id: Ic662f59c084eacc7e99762c3e94fbcc191629557
commit 4d8e67296ec380a6c8f57a4ac808f67916692aa0
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Mon Jun 30 15:28:05 2014 +0530
Changed application of personas through extensions procedure.
The PersonasEntry template in the registry now stores the setting as
splitted values rather than ';' separated terms. The corresponding ';'
separated setting is prepared and stored.
Change-Id: I154d519c475a48763a75b5c35ad20f170c1d7996
commit 880afa2225bf1524f088d91ad82606309edd3ccc
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Fri Jun 27 23:52:42 2014 +0530
The Personas can be install through oxt extensions.
The user can install an oxt extension and choose his/her theme from
the Personalization page.
* Created a template in Common.xcs registry to hold the values for the
PersonasList set.
* Added 3 buttons to personalization_tab.ui to incorporate the latest 3
personas installed through extensions.
* Currently, only 3 installed personas are shown alongwith the default
available personas.
Change-Id: I30a40ae48d17f4ed8caef33854ef88afcbec5a54
commit 4275619c59efbb4549823314c11792800446c4c4
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Sat Jun 21 09:16:16 2014 +0530
Fixed Typo.
Change-Id: I8d0b34e0c34c349baaa7c9a56fd1e6cfe3ad6934
commit ea80471a5e8d54338df8cd4715985e7f44526e17
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Fri Jun 20 21:20:37 2014 +0530
Added some pre-defined search terms.
The user can now enter his/her own search term or can use the commonly
used search terms to browse for themes.
Change-Id: Ife4ad6b820784a6321f5b916a0069a915c114c7e
commit 99ebf4f1c2b53448a7090939e0c1bbb64e104460
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Fri Jun 20 15:38:26 2014 +0530
Improved search: the images are displayed as they are downloaded.
Previously, all the search result images were displayed in one go,
but now the images are shown as they are downloaded.
Change-Id: I95990f36c242a0c90bd2b2fd65fd76953f46bcc2
commit 6825d2a70bdcab5813b6c642468375424c0790dd
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Thu Jun 19 18:49:36 2014 +0530
Added functionality to apply default themes.
* The themes are stored in the share folder under the personas directory
in the gallery. The information is stored in a personas_list.txt which
contains the info in the form headerFile;footerFile;textColor;AccentColor
for the default themes.
* Changed the personalization_tab.ui to include _three_ buttons to show
the default images.
* Changed the vcl/source/app/settings.cxx to read the persona information
properly in the case of default personas.
* Some variable name changes.
Change-Id: Ib5f2167729a5fb7eb8061925679560accb934a44
commit 6f4501e741ef79e093923a090c2413da595a18aa
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Wed Jun 18 12:09:56 2014 +0530
The selected theme is shown in the progress label.
The name of the theme is displayed in the progress label whenever
the user clicks on one of the results.
Change-Id: I4810c9e5faec1b1a5156716b9a62b1256951425c
commit 39b63ab981fc36e6f78c493e9c437073e5d3a8d2
Author: Jan Holesovsky <kendy at collabora.com>
Date: Mon Jun 16 12:07:39 2014 +0200
personas: Minor tweaks in the selection dialog.
* make the buttons scaling
* [Search] next to the input line
* mnemonic widget setting
Change-Id: Ia175ba33077bd87fc9cf2b87ed5aeda2b9fc7848
commit 33ebccfed2174adfa393e796a4b26ff402879dce
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Wed Jun 18 11:13:43 2014 +0530
Code cleanup.
Change-Id: Ifefc528b425ed9ae7f1cdba47282a4f0875bd728
commit f626a974b318cdb8bcdff115be4b9e748f092e24
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Tue Jun 17 18:08:55 2014 +0530
Minor Fixes.
Changed number of search results from 1 (development code) to
9 (production code).
Change-Id: I9229f1db1df21bde3df60fd9d80e02307286b305
commit b211be65baeb81a42c08f78f81fdfd019804500e
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Sun Jun 15 10:56:16 2014 +0530
Fixed Bug: SelectPersonaDialog was not closing on clicking OK.
The dialog did not close on clicking OK if nothing was selected or if
nothing was searched. It does now.
Change-Id: I92f777bca8f306fea8da3ebd18ca41c34443a733
commit 84ed4753596e5e9bf9f96bf5ffe3af3b0adda640
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Sun Jun 15 10:05:34 2014 +0530
Added check for no results.
The XML root node contains total_results attribute. If there are no
results matching the search term, then the user is notified of it.
Change-Id: I4b2ae5efe4af700dbc7a554a22a558f94c56e3bc
commit 8ef0b7b0e2da4b2c524c3f971b56e6eb44f45bf1
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Sat Jun 14 21:30:20 2014 +0530
Added error message to the progess label if something goes wrong.
Change-Id: If9e7a76bea49fa681e3fc7b3586b04fbbcbe279d
commit 61702f063c701497dbb95835586b33756750785e
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Fri Jun 13 22:54:45 2014 +0530
Moved the application of persona process to SelectPersonaDialog.
The theme is downloaded now when the user clicks OK on
SelectPersonaDialog instead of SvxPersonalizationTabPage. The task
is done in a separate thread.
Change-Id: I93173cce2ae9030ee8e271bd53b40e713c560731
commit 3dda4a4241886051c5aa685c90c16b1ae9f03271
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Fri Jun 13 19:27:45 2014 +0530
Fixed Bug: Small buttons are not visible initially.
Small ugly buttons were visible before searching. Their default
visibility is set to false.
Change-Id: I54baf50e4ffd7749391fbc0a48a07d7a1ffd5433
commit 48d759ecb557833291f70449896ad8b2eca25f57
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Fri Jun 13 13:42:25 2014 +0530
Fixed Bug: Multiple searches result in correct theme to be applied.
The vector that stores the persona settings is cleared every time a
new search is performed. This results in the correct theme being
selected for downloading and applying.
Change-Id: I8c0413a117c5a7ed660cd785c292c2fad4abd486
commit 5373bee534006f9e8b207f93b8696389821d08a8
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Fri Jun 13 11:34:59 2014 +0530
Fixed Bug: Progress label was not shown after another search.
If another search was performed with the same instance of the dialog,
then the progress label was not visible. It is visible now.
Change-Id: Ic9526248d4f79585f59f24197aac832a0bcaaeb9
commit 4808f3fb7feb28cb57a5a68251e679fca5d0a8b6
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Thu Jun 12 17:13:33 2014 +0530
The theme is download and applied in a separate thread.
Changed the SearchAndPersonaThread to include an instance of
SvxPersonalizationTabPage along with an instance of
SelectPersonaDialog. The constructor sets one of the instance and
the other one as null. In the execute() method, whichever instance
is null, the other one's process is done in the thread.
Change-Id: Iabfbdba63ce532ab794d3697977b6fab3fdaa832
commit d2296197a2bb7bd48e132cc2c9b0f1583b6097ce
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Wed Jun 11 22:42:12 2014 +0530
Changed the Persona application process a bit.
The header and footer files of the selected theme are downloaded and
saved in the Theme's own folder and applied.
Change-Id: Ie974c9bedc01a20c70cb342196fb60550cb39a0f
commit 3a4e02f785da17b6c41f50d4197bc13047c4760b
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Sun Jun 8 20:33:50 2014 +0530
The selected theme is now applied to the suite.
1. Added IMPL_LINKs for the result buttons.
2. Created a vector to store the temporary persona settings in the
format: name;headerURL;footerURL;textColor;accentColor.
3. When a button is clicked, the corresponding setting is copied to
m_aPersonaSetting.
4. The persona setting is parsed in CopyPersonaToGallery and the
header and footer images are downloaded.
Change-Id: Ib83016ad5bdfa83963843146ef6a4674fcd73868
commit 27f4978a89ed7a13913da4749cd69f70f16084bd
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Sat Jun 7 13:01:29 2014 +0530
Little code cleanup.
Changed a little bit of documentation and some variable names.
Change-Id: I292bf63b41c2b7d0a5ee7f03eb8ca49bf42b64ee
commit 3947154c0cdef20ba6567348bfd3d20502402be1
Author: Jan Holesovsky <kendy at collabora.com>
Date: Sun Jun 1 13:15:02 2014 +0200
Acquire the solar mutex, otherwise we cannot access vcl in the thread.
Change-Id: I02fdbbfd4c9516597df395163e28f1d616aa390d
commit 91249abbf0136096f6fc0b5b31575dd666e2cb7a
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Mon Jun 2 23:26:11 2014 +0530
Changed images to buttons so they are clickable.
Changed some variable names too.
Change-Id: I166d996389c84d00782cba42169c991f8f0f923e
commit 4c4c1d492d1181f3c691283a9935eddb2a01b0a5
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Sun May 25 17:29:21 2014 +0530
Added setOptimalLayoutSize() to resize the dialog after images load.
Change-Id: If85d4baacbffb6b7e6bf8feceb9c58697ee158d8
commit d54e825861f821851b848b92cb03a6688daeedc6
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Thu May 22 20:48:34 2014 +0530
The search result images are shown in the dialog.
1. Changed the UI to include a 3x3 grid of images
2. The preview images are downloaded in the thread
3. The images are downloaded in their respective folders
4. A progress label is shown
Change-Id: Id87e72343d28e03b37e0c422e5ebfe1a9a37c1b5
commit 83122eee143caf8518a4b76864aa6ac808458bee
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Wed May 21 11:38:21 2014 +0530
Added SearchAndParseThread.
The search results data is retrieved and parsed in a separate
thread so that the UI doesn't hang awkwardly.
Change-Id: I51437edd4cfbd45f5fb7e487ad2baf5dba6618a4
commit 7d872cee67833a082432c33657a50e00f69971d4
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Mon May 19 19:56:44 2014 +0530
Moved definition of SelectPersonaDialog to personalization.hxx
Change-Id: Ic6ffcfb394e36d4d9ce9825b26095fe2a0f34fdd
commit 392fc78f47e09ce565f8a25cf10adaf8f836e9bb
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Mon May 19 18:56:24 2014 +0530
Changed license and added #ifdef.
Change-Id: If1b0d447eba7c7afdc28aa4246556d14e2fcc98e
commit 44ff129fe9dd884b93a20b7d8897b158a283aaf3
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Tue May 13 22:16:05 2014 +0530
Created std::vector to store learnmore URLs.
For now, we have to parse the HTML and display the images as the
result XML does not contain the header and footer URLs.
Change-Id: Ie95a75e218bc3da12802c971ea744fb38951e574
commit 3174d1cf2d16630a1761a10520b929dbd269d1c9
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Thu May 1 23:55:41 2014 +0530
select_persona_dialog.ui changed to include search.
The entered text is searched on Mozilla's test server and the result is parsed.
Change-Id: I2be660b0f7f60d2bdb2c54cbc958084b87ad1e05
commit f881ae0465186a03a66748d8a1dd8ac550ff54f4
Author: Rachit Gupta <rachitgupta1792 at gmail.com>
Date: Tue Apr 29 19:48:48 2014 +0530
Created basic architecture for PersonasDocHandler.
Change-Id: Ic1454344756c48090ebe821799d10dd6ace0264c
More information about the Libreoffice-commits
mailing list