[Libreoffice-commits] core.git: sd/source setup_native/source

Julien Nabet serval2412 at yahoo.fr
Thu Aug 7 11:37:00 PDT 2014


 sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c              |    1 +
 setup_native/source/win32/customactions/reg4allmsdoc/reg4allmsi.cxx      |    1 +
 setup_native/source/win32/customactions/shellextensions/checkpatches.cxx |    1 +
 setup_native/source/win32/customactions/shellextensions/vistaspecial.cxx |    1 +
 setup_native/source/win32/customactions/tools/checkversion.cxx           |    1 +
 setup_native/source/win32/customactions/tools/seterror.cxx               |    1 +
 6 files changed, 6 insertions(+)

New commits:
commit 47999a4304cdb72ee1e78d223e671d17f240bd61
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Thu Aug 7 20:36:00 2014 +0200

    cppcheck: va_list 'args' was opened but not closed by va_end()
    
    Change-Id: Id7602dd19ac142dbe2680ddf7eab308a087e971a

diff --git a/sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c b/sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c
index 0aa0717..3e5a181 100644
--- a/sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c
+++ b/sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c
@@ -76,6 +76,7 @@ static void syslog( int priority, const char * message, ...)
     buffer = malloc( len * sizeof(char) );
     if ( buffer ) { vsprintf( buffer, message, args ); OutputDebugString( buffer ); free( buffer ); }
     WSASetLastError( err );
+    va_end(args);
 }
 #else
 
diff --git a/setup_native/source/win32/customactions/reg4allmsdoc/reg4allmsi.cxx b/setup_native/source/win32/customactions/reg4allmsdoc/reg4allmsi.cxx
index 40ed84b..728121b 100644
--- a/setup_native/source/win32/customactions/reg4allmsdoc/reg4allmsi.cxx
+++ b/setup_native/source/win32/customactions/reg4allmsdoc/reg4allmsi.cxx
@@ -80,6 +80,7 @@ inline void OutputDebugStringFormat( LPCSTR pFormat, ... )
     va_start( args, pFormat );
     StringCchVPrintfA( buffer, sizeof(buffer), pFormat, args );
     OutputDebugStringA( buffer );
+    va_end(args);
 }
 #else
 static inline void OutputDebugStringFormat( LPCSTR, ... )
diff --git a/setup_native/source/win32/customactions/shellextensions/checkpatches.cxx b/setup_native/source/win32/customactions/shellextensions/checkpatches.cxx
index d76b764..33ad29f 100644
--- a/setup_native/source/win32/customactions/shellextensions/checkpatches.cxx
+++ b/setup_native/source/win32/customactions/shellextensions/checkpatches.cxx
@@ -54,6 +54,7 @@ inline void OutputDebugStringFormat( LPCSTR pFormat, ... )
     va_start( args, pFormat );
     StringCchVPrintfA( buffer, sizeof(buffer), pFormat, args );
     OutputDebugStringA( buffer );
+    va_end(args);
 }
 #else
 static inline void OutputDebugStringFormat( LPCSTR, ... )
diff --git a/setup_native/source/win32/customactions/shellextensions/vistaspecial.cxx b/setup_native/source/win32/customactions/shellextensions/vistaspecial.cxx
index 5253b41..ab039e2 100644
--- a/setup_native/source/win32/customactions/shellextensions/vistaspecial.cxx
+++ b/setup_native/source/win32/customactions/shellextensions/vistaspecial.cxx
@@ -55,6 +55,7 @@ inline void OutputDebugStringFormat( LPCSTR pFormat, ... )
     va_start( args, pFormat );
     StringCchVPrintfA( buffer, sizeof(buffer), pFormat, args );
     OutputDebugStringA( buffer );
+    va_end(args);
 }
 #else
 static inline void OutputDebugStringFormat( LPCSTR, ... )
diff --git a/setup_native/source/win32/customactions/tools/checkversion.cxx b/setup_native/source/win32/customactions/tools/checkversion.cxx
index 526cc76..fb6f77d 100644
--- a/setup_native/source/win32/customactions/tools/checkversion.cxx
+++ b/setup_native/source/win32/customactions/tools/checkversion.cxx
@@ -64,6 +64,7 @@ inline void OutputDebugStringFormat( LPCTSTR pFormat, ... )
     va_start( args, pFormat );
     StringCchVPrintf( buffer, sizeof(buffer), pFormat, args );
     OutputDebugString( buffer );
+    va_end(args);
 }
 #else
 static inline void OutputDebugStringFormat( LPCTSTR, ... )
diff --git a/setup_native/source/win32/customactions/tools/seterror.cxx b/setup_native/source/win32/customactions/tools/seterror.cxx
index c7de7b7..a9af467 100644
--- a/setup_native/source/win32/customactions/tools/seterror.cxx
+++ b/setup_native/source/win32/customactions/tools/seterror.cxx
@@ -44,6 +44,7 @@ inline void OutputDebugStringFormat( LPCTSTR pFormat, ... )
     va_start( args, pFormat );
     StringCchVPrintf( buffer, sizeof(buffer), pFormat, args );
     OutputDebugString( buffer );
+    va_end(args);
 }
 #else
 static inline void OutputDebugStringFormat( LPCTSTR, ... )


More information about the Libreoffice-commits mailing list