[Libreoffice-commits] core.git: 2 commits - include/test test/source

Matteo Casalin matteo.casalin at yahoo.com
Sat Aug 16 15:32:34 PDT 2014


 include/test/primitive2dxmldump.hxx |    2 +-
 test/source/primitive2dxmldump.cxx  |   10 +++++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

New commits:
commit ed8c68726508112e30f178f1ce31f421cddb4d87
Author: Matteo Casalin <matteo.casalin at yahoo.com>
Date:   Sun Aug 17 00:31:19 2014 +0200

    Fix: reference to 'Primitive2DSequence' is ambiguous
    
    Change-Id: Ic6cf4bc6dab4b9e2610aebdc42e3df7b56eda59d

diff --git a/test/source/primitive2dxmldump.cxx b/test/source/primitive2dxmldump.cxx
index da6f4e2..afa26fe 100644
--- a/test/source/primitive2dxmldump.cxx
+++ b/test/source/primitive2dxmldump.cxx
@@ -59,7 +59,9 @@ void Primitive2dXmlDump::filterAllActionTypes()
     maFilter.assign(constMaxActionType, true);
 }
 
-xmlDocPtr Primitive2dXmlDump::dumpAndParse(const Primitive2DSequence& rPrimitive2DSequence, const OUString& rTempStreamName)
+xmlDocPtr Primitive2dXmlDump::dumpAndParse(
+    const drawinglayer::primitive2d::Primitive2DSequence& rPrimitive2DSequence,
+    const OUString& rTempStreamName)
 {
     boost::scoped_ptr<SvStream> pStream;
 
@@ -84,7 +86,9 @@ xmlDocPtr Primitive2dXmlDump::dumpAndParse(const Primitive2DSequence& rPrimitive
     return pDoc;
 }
 
-void Primitive2dXmlDump::decomposeAndWrite(const Primitive2DSequence& rPrimitive2DSequence, XmlWriter& rWriter)
+void Primitive2dXmlDump::decomposeAndWrite(
+    const drawinglayer::primitive2d::Primitive2DSequence& rPrimitive2DSequence,
+    XmlWriter& rWriter)
 {
     for (int i = 0; i < rPrimitive2DSequence.getLength(); i++)
     {
commit fb1f710d3f58337e8a05e476326453b584e87fa2
Author: Matteo Casalin <matteo.casalin at yahoo.com>
Date:   Sun Aug 17 00:27:24 2014 +0200

    loplugin:passstuffbyref (Primitive2DSequence)
    
    Change-Id: I3d9c6daa09d71ca872021fe13405b08050e191d9

diff --git a/include/test/primitive2dxmldump.hxx b/include/test/primitive2dxmldump.hxx
index 6a94960..a578e60 100644
--- a/include/test/primitive2dxmldump.hxx
+++ b/include/test/primitive2dxmldump.hxx
@@ -39,7 +39,7 @@ public:
         pTempStreamName - this is useful when creating the test, to dump the
         file for examination.
     */
-    xmlDocPtr dumpAndParse(drawinglayer::primitive2d::Primitive2DSequence aPrimitive2DSequence, const OUString& rTempStreamName = OUString());
+    xmlDocPtr dumpAndParse(const drawinglayer::primitive2d::Primitive2DSequence& aPrimitive2DSequence, const OUString& rTempStreamName = OUString());
 };
 
 #endif // INCLUDED_TEST_PRIMITIVE2DXMLDUMP_HXX
diff --git a/test/source/primitive2dxmldump.cxx b/test/source/primitive2dxmldump.cxx
index ea12562..da6f4e2 100644
--- a/test/source/primitive2dxmldump.cxx
+++ b/test/source/primitive2dxmldump.cxx
@@ -59,7 +59,7 @@ void Primitive2dXmlDump::filterAllActionTypes()
     maFilter.assign(constMaxActionType, true);
 }
 
-xmlDocPtr Primitive2dXmlDump::dumpAndParse(Primitive2DSequence aPrimitive2DSequence, const OUString& rTempStreamName)
+xmlDocPtr Primitive2dXmlDump::dumpAndParse(const Primitive2DSequence& rPrimitive2DSequence, const OUString& rTempStreamName)
 {
     boost::scoped_ptr<SvStream> pStream;
 
@@ -72,7 +72,7 @@ xmlDocPtr Primitive2dXmlDump::dumpAndParse(Primitive2DSequence aPrimitive2DSeque
     aWriter.startDocument();
     aWriter.startElement("primitive2D");
 
-    decomposeAndWrite(aPrimitive2DSequence, aWriter);
+    decomposeAndWrite(rPrimitive2DSequence, aWriter);
 
     aWriter.endElement();
     aWriter.endDocument();


More information about the Libreoffice-commits mailing list