[Libreoffice-commits] core.git: sw/source
Matteo Casalin
matteo.casalin at yahoo.com
Mon Aug 18 11:27:11 PDT 2014
sw/source/core/frmedt/feshview.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 5d5c102e36bcc7eac6ae89d44a635e5d9b680e40
Author: Matteo Casalin <matteo.casalin at yahoo.com>
Date: Mon Aug 18 20:18:40 2014 +0200
Typo: loop on all Marks instead of processing Mark(0) over and over
See:
http://nabble.documentfoundation.org/Suspicious-loop-any-idea-td4119239.html
Since the code was like this since initial import (2000), if this patch proves
to be wrong then the other option could be to just don't loop and process
Mark(0) just once.
Change-Id: I41ac18604e916740dcc68bf69af37529842f774d
diff --git a/sw/source/core/frmedt/feshview.cxx b/sw/source/core/frmedt/feshview.cxx
index 49dd779..97c064c 100644
--- a/sw/source/core/frmedt/feshview.cxx
+++ b/sw/source/core/frmedt/feshview.cxx
@@ -731,7 +731,7 @@ static void lcl_NotifyNeighbours( const SdrMarkList *pLst )
bool bCheckNeighbours = false;
sal_Int16 aHori = text::HoriOrientation::NONE;
SwRect aRect;
- SdrObject *pO = pLst->GetMark( 0 )->GetMarkedSdrObj();
+ SdrObject *pO = pLst->GetMark( j )->GetMarkedSdrObj();
if ( pO->ISA(SwVirtFlyDrawObj) )
{
SwFlyFrm *pFly = ((SwVirtFlyDrawObj*)pO)->GetFlyFrm();
More information about the Libreoffice-commits
mailing list