[Libreoffice-commits] core.git: vcl/source

Tor Lillqvist tml at collabora.com
Tue Dec 2 09:58:54 PST 2014


 vcl/source/gdi/pdfwriter_impl.cxx |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit db6f9fbc755e342c4fa3f3cd14e42d9ea0424505
Author: Tor Lillqvist <tml at collabora.com>
Date:   Tue Dec 2 19:56:02 2014 +0200

    Add a few questions as comments
    
    Change-Id: I7bc2a725bbcc215a40a3c20567aaa1c1187c3b34

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx b/vcl/source/gdi/pdfwriter_impl.cxx
index ad68895..5f77f88 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -93,6 +93,9 @@ using namespace vcl;
 #endif
 
 #if !defined(ANDROID) && !defined(IOS)
+// Is this length truly the maximum possible, or just a number that
+// seemed large enough when the author tested this (with some type of
+// certificates)? I suspect the latter.
 #define MAX_SIGNATURE_CONTENT_LENGTH 0x4000
 #endif
 
@@ -1783,6 +1786,7 @@ void PDFWriterImpl::PDFPage::appendWaveLine( sal_Int32 nWidth, sal_Int32 nY, sal
     m_aDigest = rtl_digest_createMD5();
 
     /* the size of the Codec default maximum */
+    /* is this 0x4000 required to be the same as MAX_SIGNATURE_CONTENT_LENGTH or just coincidentally the same at the moment? */
     if (!checkEncryptionBufferSize(0x4000))
     {
         m_aFile.close();


More information about the Libreoffice-commits mailing list