[Libreoffice-commits] core.git: unodevtools/source

Stephan Bergmann sbergman at redhat.com
Wed Dec 3 23:23:22 PST 2014


 unodevtools/source/skeletonmaker/cppcompskeleton.cxx  |   16 ++++++++--------
 unodevtools/source/skeletonmaker/javacompskeleton.cxx |    8 ++++----
 2 files changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 7d4a6946500100966b34b162c150994a017b9238
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Dec 4 08:22:55 2014 +0100

    unodevtools: loplugin:cstylecast
    
    Change-Id: Id4bd8bb8361204ae281a090840b08c502e5b4a7a

diff --git a/unodevtools/source/skeletonmaker/cppcompskeleton.cxx b/unodevtools/source/skeletonmaker/cppcompskeleton.cxx
index df64f1d..d8441c7 100644
--- a/unodevtools/source/skeletonmaker/cppcompskeleton.cxx
+++ b/unodevtools/source/skeletonmaker/cppcompskeleton.cxx
@@ -1056,16 +1056,16 @@ void generateSkeleton(ProgramOptions const & options,
             *pofs << (nm > 0 ? "// closing namespace\n\n" : "\n");
         }
 
-        if ( !standardout && pofs && ((std::ofstream*)pofs)->is_open()) {
-            ((std::ofstream*)pofs)->close();
+        if ( !standardout && pofs && static_cast<std::ofstream*>(pofs)->is_open()) {
+            static_cast<std::ofstream*>(pofs)->close();
             delete pofs;
             OSL_VERIFY(makeValidTypeFile(compFileName, tmpFileName, false));
         }
     } catch (CannotDumpException & e) {
         std::cerr << "ERROR: " << e.getMessage() << "\n";
         if ( !standardout ) {
-            if (pofs && ((std::ofstream*)pofs)->is_open()) {
-                ((std::ofstream*)pofs)->close();
+            if (pofs && static_cast<std::ofstream*>(pofs)->is_open()) {
+                static_cast<std::ofstream*>(pofs)->close();
                 delete pofs;
             }
             // remove existing type file if something goes wrong to ensure
@@ -1219,16 +1219,16 @@ void generateCalcAddin(ProgramOptions const & options,
 
         generateCompFunctions(*pofs, nmspace);
 
-        if ( !standardout && pofs && ((std::ofstream*)pofs)->is_open()) {
-            ((std::ofstream*)pofs)->close();
+        if ( !standardout && pofs && static_cast<std::ofstream*>(pofs)->is_open()) {
+            static_cast<std::ofstream*>(pofs)->close();
             delete pofs;
             OSL_VERIFY(makeValidTypeFile(compFileName, tmpFileName, false));
         }
     } catch (CannotDumpException & e) {
         std::cerr << "ERROR: " << e.getMessage() << "\n";
         if ( !standardout ) {
-            if (pofs && ((std::ofstream*)pofs)->is_open()) {
-                ((std::ofstream*)pofs)->close();
+            if (pofs && static_cast<std::ofstream*>(pofs)->is_open()) {
+                static_cast<std::ofstream*>(pofs)->close();
                 delete pofs;
             }
             // remove existing type file if something goes wrong to ensure
diff --git a/unodevtools/source/skeletonmaker/javacompskeleton.cxx b/unodevtools/source/skeletonmaker/javacompskeleton.cxx
index 44c9201..8edb92c 100644
--- a/unodevtools/source/skeletonmaker/javacompskeleton.cxx
+++ b/unodevtools/source/skeletonmaker/javacompskeleton.cxx
@@ -911,16 +911,16 @@ void generateSkeleton(ProgramOptions const & options,
                                 interfaces, properties, attributes, propertyhelper,
                                 supportxcomponent);
 
-        if ( !standardout && pofs && ((std::ofstream*)pofs)->is_open()) {
-            ((std::ofstream*)pofs)->close();
+        if ( !standardout && pofs && static_cast<std::ofstream*>(pofs)->is_open()) {
+            static_cast<std::ofstream*>(pofs)->close();
             delete pofs;
             OSL_VERIFY(makeValidTypeFile(compFileName, tmpFileName, false));
         }
     } catch (CannotDumpException & e) {
         std::cerr << "ERROR: " << e.getMessage() << "\n";
         if ( !standardout ) {
-            if (pofs && ((std::ofstream*)pofs)->is_open()) {
-                ((std::ofstream*)pofs)->close();
+            if (pofs && static_cast<std::ofstream*>(pofs)->is_open()) {
+                static_cast<std::ofstream*>(pofs)->close();
                 delete pofs;
             }
             // remove existing type file if something goes wrong to ensure


More information about the Libreoffice-commits mailing list