[Libreoffice-commits] core.git: 4 commits - desktop/source sc/source sd/source sw/source

Caolán McNamara caolanm at redhat.com
Mon Dec 8 05:49:37 PST 2014


 desktop/source/lib/init.cxx    |    1 +
 sc/source/core/data/table3.cxx |    1 +
 sd/source/core/sdpage2.cxx     |    2 ++
 sw/source/core/crsr/viscrs.cxx |    2 +-
 4 files changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 9215ab03476f56f626f926702208f62b9bf2e16d
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Dec 8 13:45:56 2014 +0000

    coverity#1257107 Unchecked dynamic_cast
    
    Change-Id: Ica45049aa7e6656c0882484ffa4ff80b6d699373

diff --git a/sw/source/core/crsr/viscrs.cxx b/sw/source/core/crsr/viscrs.cxx
index bf8da34..80af294 100644
--- a/sw/source/core/crsr/viscrs.cxx
+++ b/sw/source/core/crsr/viscrs.cxx
@@ -539,7 +539,7 @@ void SwShellCrsr::FillRects()
 void SwShellCrsr::Show()
 {
     for(SwPaM& rTmp : GetRingContainer())
-        dynamic_cast<SwShellCrsr*>(&rTmp)->SwSelPaintRects::Show();
+        dynamic_cast<SwShellCrsr&>(rTmp).SwSelPaintRects::Show();
 }
 
 // This rectangle gets painted anew, therefore the SSelection in this
commit 32e38e1ec703dcdcff484eae3634a69e0d9c864e
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Dec 8 13:44:25 2014 +0000

    coverity#1257111 Uninitialized pointer field
    
    Change-Id: I82c771f0ca7d2593a6f34dd84689cf055f9cf3f3

diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx
index 04e9d08..f520cd6 100644
--- a/sc/source/core/data/table3.cxx
+++ b/sc/source/core/data/table3.cxx
@@ -868,6 +868,7 @@ class ListenerStartAction : public sc::ColumnSpanSet::ColumnAction
 
 public:
     ListenerStartAction( ScDocument& rDoc ) :
+        mpCol(0),
         mpPosSet(new sc::ColumnBlockPositionSet(rDoc)),
         maStartCxt(rDoc, mpPosSet),
         maEndCxt(rDoc, mpPosSet) {}
commit d15d0ec6de566f8a2dc2e9c575ecf4e19c070ade
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Dec 8 13:43:56 2014 +0000

    coverity#1257112 Uninitialized scalar field
    
    Change-Id: I79063c103707e91f04c22a284f7af035fef6d21d

diff --git a/sd/source/core/sdpage2.cxx b/sd/source/core/sdpage2.cxx
index 57f4699..5b4987f 100644
--- a/sd/source/core/sdpage2.cxx
+++ b/sd/source/core/sdpage2.cxx
@@ -402,6 +402,8 @@ SdPage::SdPage(const SdPage& rSrcPage)
     meOrientation        = rSrcPage.meOrientation;
 
     mpPageLink           = NULL;    // is set when inserting via ConnectLink()
+
+    mbIsPrecious         = false;
 }
 
 void SdPage::lateInit(const SdPage& rSrcPage)
commit f137588d0d8605ab48e2a7a8675784f965a230a7
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Dec 8 13:41:35 2014 +0000

    coverity#1257113 Uninitialized scalar field
    
    Change-Id: Ie813165995df47d466eaef09720901a33362fd23

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 61a715a..c12bf46 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -251,6 +251,7 @@ struct LibLibreOffice_Impl : public _LibreOfficeKit
     pthread_t maThread;
 
     LibLibreOffice_Impl()
+        : maThread(0)
     {
         if(!(m_pOfficeClass = gOfficeClass.lock())) {
             m_pOfficeClass.reset(new LibreOfficeKitClass);


More information about the Libreoffice-commits mailing list