[Libreoffice-commits] core.git: slideshow/source

Caolán McNamara caolanm at redhat.com
Mon Dec 8 09:11:12 PST 2014


 slideshow/source/engine/shapes/drawshape.cxx |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit dde94c73483af85cd3d8feed3282e785b80c988a
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Dec 8 16:53:07 2014 +0000

    coverity#1257110 Big parameter passed by value
    
    and
    
    coverity#1186125 Big parameter passed by value
    
    Change-Id: I6cb6863645647edf4fba114059195582679c30c4

diff --git a/slideshow/source/engine/shapes/drawshape.cxx b/slideshow/source/engine/shapes/drawshape.cxx
index d7ef2b4..a3b89b7 100644
--- a/slideshow/source/engine/shapes/drawshape.cxx
+++ b/slideshow/source/engine/shapes/drawshape.cxx
@@ -168,6 +168,7 @@ namespace slideshow
             }
 
             // redraw all view shapes, by calling their update() method
+            ViewShape::RenderArgs renderArgs( getViewRenderArgs() );
             if( ::std::count_if( maViewShapes.begin(),
                                  maViewShapes.end(),
                                  ::boost::bind<bool>(
@@ -178,7 +179,7 @@ namespace slideshow
                                                                              // the extra mem_fn. WTF.
                                      _1,
                                      ::boost::cref( mpCurrMtf ),
-                                     getViewRenderArgs(),
+                                     ::boost::cref( renderArgs ),
                                      nUpdateFlags,
                                      isVisible() ) )
                 != static_cast<ViewShapeVector::difference_type>(maViewShapes.size()) )


More information about the Libreoffice-commits mailing list