[Libreoffice-commits] core.git: 3 commits - canvas/source sc/source sw/qa

Caolán McNamara caolanm at redhat.com
Thu Dec 11 12:52:56 PST 2014


 canvas/source/vcl/canvashelper.cxx         |    1 -
 sc/source/core/data/column.cxx             |    8 ++++++--
 sw/qa/extras/globalfilter/globalfilter.cxx |    1 +
 3 files changed, 7 insertions(+), 3 deletions(-)

New commits:
commit 067b560335195b24eeedc4514956029ea975fbbf
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 11 20:51:38 2014 +0000

    stray debugging code
    
    Change-Id: I953389e236739c01226365c33ab777fc3972b69d

diff --git a/canvas/source/vcl/canvashelper.cxx b/canvas/source/vcl/canvashelper.cxx
index c9fe640..7b9c9ce 100644
--- a/canvas/source/vcl/canvashelper.cxx
+++ b/canvas/source/vcl/canvashelper.cxx
@@ -1296,7 +1296,6 @@ namespace vclcanvas
 
         OutputDevice& rOutDev( mpOutDev->getOutDev() );
 
-        rOutDev.SetClipRegion(vcl::Region(true));
         setupOutDevState( viewState, renderState, TEXT_COLOR );
 
         CanvasFont* pFont = dynamic_cast< CanvasFont* >( xFont.get() );
commit 6aa1232e17b84c38bb411014315c3b3a2c35dff5
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 11 20:47:48 2014 +0000

    coverity#1257737 Dereference null return value
    
    Change-Id: Idc4dfb74734f1203586b04ea86a05905f5dac694

diff --git a/sw/qa/extras/globalfilter/globalfilter.cxx b/sw/qa/extras/globalfilter/globalfilter.cxx
index 43b213b..49c01f9 100644
--- a/sw/qa/extras/globalfilter/globalfilter.cxx
+++ b/sw/qa/extras/globalfilter/globalfilter.cxx
@@ -165,6 +165,7 @@ void Test::testLinkedGraphicRT()
             if( aNodes[nIndex]->IsGrfNode() )
             {
                 SwGrfNode* pGrfNode = aNodes[nIndex]->GetGrfNode();
+                CPPUNIT_ASSERT(pGrfNode);
                 // RT via DOCX makes linked graphic embedded?!
                 if( aFilterNames[nFilter] != "Office Open XML Text" )
                 {
commit e830390562fa6e772022391eceb8652191b4a020
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Dec 11 20:46:53 2014 +0000

    coverity#1257741 Uninitialized scalar field
    
    Change-Id: I8b977766e694ab449d612322138f5baa23fef29b

diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index 549a433..d7597e6 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -3071,8 +3071,12 @@ class BroadcastBroadcastersHandler
     bool        mbBroadcasted;
 
 public:
-    explicit BroadcastBroadcastersHandler( ScHint& rHint ) :
-        mrHint(rHint), mrAddress(mrHint.GetAddress()) {}
+    explicit BroadcastBroadcastersHandler( ScHint& rHint )
+        : mrHint(rHint)
+        , mrAddress(mrHint.GetAddress())
+        , mbBroadcasted(false)
+    {
+    }
 
     void operator() ( size_t nRow, SvtBroadcaster* pBroadcaster )
     {


More information about the Libreoffice-commits mailing list