[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - chart2/source

Markus Mohrhard markus.mohrhard at collabora.co.uk
Fri Dec 12 07:12:20 PST 2014


 chart2/source/controller/dialogs/tp_DataSource.cxx |   11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

New commits:
commit ddcf6367240d564e7daf4078e0a4caf0adde9043
Author: Markus Mohrhard <markus.mohrhard at collabora.co.uk>
Date:   Thu Jun 19 15:34:50 2014 +0200

    fix range input in chart data source dialog
    
    Change-Id: I9c139c6298d25c7a7072d0d0538f1945518d36f2
    Reviewed-on: https://gerrit.libreoffice.org/13402
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/chart2/source/controller/dialogs/tp_DataSource.cxx b/chart2/source/controller/dialogs/tp_DataSource.cxx
index 99903a2..f8c93b4 100644
--- a/chart2/source/controller/dialogs/tp_DataSource.cxx
+++ b/chart2/source/controller/dialogs/tp_DataSource.cxx
@@ -725,8 +725,17 @@ IMPL_LINK_NOARG(DataSourceTabPage, DownButtonClickedHdl)
 
 IMPL_LINK( DataSourceTabPage, RangeModifiedHdl, Edit*, pEdit )
 {
+    // note: isValid sets the color of the edit field
     if( isRangeFieldContentValid( *pEdit ))
+    {
         setDirty();
+        updateModelFromControl( pEdit );
+        if( pEdit == m_pEDT_RANGE )
+        {
+            if( ! lcl_UpdateCurrentSeriesName( *m_pLB_SERIES ))
+                fillSeriesListBox();
+        }
+    }
 
     // enable/disable OK button
     isValid();
@@ -741,7 +750,7 @@ IMPL_LINK( DataSourceTabPage, RangeUpdateDataHdl, Edit*, pEdit )
     {
         setDirty();
         updateModelFromControl( pEdit );
-        if( pEdit== m_pEDT_RANGE )
+        if( pEdit == m_pEDT_RANGE )
         {
             if( ! lcl_UpdateCurrentSeriesName( *m_pLB_SERIES ))
                 fillSeriesListBox();


More information about the Libreoffice-commits mailing list