[Libreoffice-commits] core.git: 3 commits - chart2/source reportdesign/source

[Lionel Elie Mamane]

 chart2/source/model/template/XYDataInterpreter.cxx        |    2 +-
 reportdesign/source/ui/inspection/DataProviderHandler.cxx |    1 +
 reportdesign/source/ui/inspection/GeometryHandler.cxx     |    1 -
 3 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d95df6d12c8191f2c97719b59420c49651b5d8ac
Author: Lionel Elie Mamane <lionel at mamane.lu>
Date:   Thu Dec 18 06:39:20 2014 +0100

    LEM TODO note
    
    Change-Id: If082f723383da72eac75ca660203aea2a33a7526

diff --git a/reportdesign/source/ui/inspection/DataProviderHandler.cxx b/reportdesign/source/ui/inspection/DataProviderHandler.cxx
index 30c3047..396daaa 100644
--- a/reportdesign/source/ui/inspection/DataProviderHandler.cxx
+++ b/reportdesign/source/ui/inspection/DataProviderHandler.cxx
@@ -174,6 +174,7 @@ uno::Any SAL_CALL DataProviderHandler::getPropertyValue(const OUString & Propert
     {
         case PROPERTY_ID_CHARTTYPE:
             // TODO: We need a possibility to get the UI of the selected chart type
+            // LEM: this business of ignoring ChartType seems very fishy!
             //if( m_xChartModel.is() )
             //{
             //    uno::Reference< chart2::XDiagram > xDiagram( m_xChartModel->getFirstDiagram() );
commit cf4347aa515872454404e73f07cc4b0b9d61bd8b
Author: Lionel Elie Mamane <lionel at mamane.lu>
Date:   Thu Dec 18 06:38:35 2014 +0100

    bCategoriesUsed is always false at this point
    
    Change-Id: I7e6851ce3f24ef3c5051eb7431b6aa1df845836d

diff --git a/chart2/source/model/template/XYDataInterpreter.cxx b/chart2/source/model/template/XYDataInterpreter.cxx
index 8bf2b03..44705c1 100644
--- a/chart2/source/model/template/XYDataInterpreter.cxx
+++ b/chart2/source/model/template/XYDataInterpreter.cxx
@@ -68,7 +68,7 @@ chart2::InterpretedData SAL_CALL XYDataInterpreter::interpretDataSource(
 
     // parse data
     bool bCategoriesUsed = false;
-    bool bSetXValues = aData.getLength()>(bCategoriesUsed?2:1);
+    bool bSetXValues = aData.getLength()>1;
     for( sal_Int32 nDataIdx= 0; nDataIdx < aData.getLength(); ++nDataIdx )
     {
         try
commit 8a5891450c38de50d7d48d78e9b398f07cf94d0a
Author: Lionel Elie Mamane <lionel at mamane.lu>
Date:   Thu Dec 18 06:37:27 2014 +0100

    fdo#76780 don't limit PositionY to available width
    
    Change-Id: I3a429d0a6f771f6bfde2331ddc8544c92d8147f7

diff --git a/reportdesign/source/ui/inspection/GeometryHandler.cxx b/reportdesign/source/ui/inspection/GeometryHandler.cxx
index decfeeb..c95f3c4 100644
--- a/reportdesign/source/ui/inspection/GeometryHandler.cxx
+++ b/reportdesign/source/ui/inspection/GeometryHandler.cxx
@@ -881,7 +881,6 @@ inspection::LineDescriptor SAL_CALL GeometryHandler::describePropertyLine(const
                 switch(nId)
                 {
                     case PROPERTY_ID_POSITIONX:
-                    case PROPERTY_ID_POSITIONY:
                     case PROPERTY_ID_WIDTH:
                         if ( bSetMin )
                             xNumericControl->setMinValue(beans::Optional<double>(sal_True,0.0));