[Libreoffice-commits] core.git: 5 commits - filter/source include/filter

Norbert Thiebaud nthiebaud at gmail.com
Sat Feb 8 10:51:09 PST 2014


 filter/source/flash/swfexporter.cxx  |   13 ++++++++----
 include/filter/msfilter/msdffimp.hxx |   15 ++++++++++++--
 include/filter/msfilter/svdfppt.hxx  |   37 +++++++++++++++++++++++++++++++----
 3 files changed, 55 insertions(+), 10 deletions(-)

New commits:
commit 2d04286f258603a7fbb1d63cccaa7f1f81b22075
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Fri Feb 7 23:38:23 2014 -0600

    coverity#707788 Unitialized scalar field
    
    Change-Id: I0098ef6ca7f2463f9de7bada44272507c3b6e104

diff --git a/filter/source/flash/swfexporter.cxx b/filter/source/flash/swfexporter.cxx
index 1c9b715..f672697 100644
--- a/filter/source/flash/swfexporter.cxx
+++ b/filter/source/flash/swfexporter.cxx
@@ -61,10 +61,15 @@ using com::sun::star::lang::XServiceInfo;
 // -----------------------------------------------------------------------------
 
 PageInfo::PageInfo()
-:       meFadeEffect( FadeEffect_NONE ),
-        meFadeSpeed( AnimationSpeed_MEDIUM ),
-        mnDuration( 0 ),
-        mnChange( 0 )
+        : meFadeEffect( FadeEffect_NONE )
+        , meFadeSpeed( AnimationSpeed_MEDIUM )
+        , mnDuration( 0 )
+        , mnChange( 0 )
+        , mnBackgroundID( 0 )
+        , mnObjectsID( 0)
+        , mnForegroundID( 0)
+        , mbBackgroundVisible( sal_False )
+        , mbBackgroundObjectsVisible( sal_False )
 {
 }
 
commit 7ab03b245d255a66678bda4c622af3096fd4e5aa
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Fri Feb 7 23:26:52 2014 -0600

    coverity#707785 Unitialized scalar field
    
    Change-Id: If3a54628ae6dc0deb605ff075695147d6a58762b

diff --git a/include/filter/msfilter/svdfppt.hxx b/include/filter/msfilter/svdfppt.hxx
index b37bcb0..2e9f099 100644
--- a/include/filter/msfilter/svdfppt.hxx
+++ b/include/filter/msfilter/svdfppt.hxx
@@ -891,8 +891,19 @@ struct ImplPPTParaPropSet
     sal_uInt32  nDontKnow2;
     sal_uInt16  nDontKnow2bit06;
 
-                ImplPPTParaPropSet()
-                { mnRefCount = 1; mnAttrSet = 0; mnExtParagraphMask = 0; mnDepth = 0; };
+    ImplPPTParaPropSet()
+        : mnRefCount( 1 )
+        , mnDepth( 0 )
+        , mnAttrSet( 0 )
+        , mnBulletColor( 0 )
+        , mnExtParagraphMask( 0 )
+        , mnAnmScheme( 0 )
+        , mnHasAnm( 0 )
+        , mnBuBlip( 0 )
+        , nDontKnow1( 0 )
+        , nDontKnow2( 0 )
+        , nDontKnow2bit06( 0 )
+        { }
 };
 
 struct PPTParaPropSet
commit 618891adc69a27e9461bbc6ba69f4168426223ef
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Fri Feb 7 23:21:21 2014 -0600

    coverity#707784 Unitialized scalar field
    
    Change-Id: Iac0a1bb3dd01cc51d17e040a96a8c866fac01058

diff --git a/include/filter/msfilter/svdfppt.hxx b/include/filter/msfilter/svdfppt.hxx
index a64e05a..b37bcb0 100644
--- a/include/filter/msfilter/svdfppt.hxx
+++ b/include/filter/msfilter/svdfppt.hxx
@@ -921,7 +921,17 @@ struct ImplPPTCharPropSet
     sal_uInt16  mnEscapement;
     sal_uInt16  mnSymbolFont;
 
-    ImplPPTCharPropSet(){ mnRefCount = 1; mnAttrSet = 0; };
+    ImplPPTCharPropSet()
+        : mnRefCount ( 1 )
+        , mnAttrSet( 0 )
+        , mnFlags( 0 )
+        , mnFont( 0 )
+        , mnAsianOrComplexFont( 0 )
+        , mnANSITypeface( 0 )
+        , mnFontHeight( 0 )
+        , mnEscapement( 0 )
+        , mnSymbolFont( 0)
+        { }
 };
 
 struct PPTCharPropSet
commit 47a82e10ca56a09846b275c0cf5af036791d31b0
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Fri Feb 7 23:14:58 2014 -0600

    coverity#707783 Unitialized scalar field
    
    Change-Id: I7d294c217da28b45fd94fb256d8f990d0f9427f5

diff --git a/include/filter/msfilter/svdfppt.hxx b/include/filter/msfilter/svdfppt.hxx
index 286c1a0..a64e05a 100644
--- a/include/filter/msfilter/svdfppt.hxx
+++ b/include/filter/msfilter/svdfppt.hxx
@@ -286,7 +286,15 @@ struct PptUserEditAtom
     sal_Int16           eLastViewType;           // enum view type
 
 public:
-    PptUserEditAtom() : nOffsetPersistDirectory( 0 ) {}
+    PptUserEditAtom()
+        : nLastSlideID( 0 )
+        , nVersion( 0 )
+        , nOffsetLastEdit( 0 )
+        , nOffsetPersistDirectory( 0 )
+        , nDocumentRef( 0 )
+        , nMaxPersistWritten( 0 )
+        , eLastViewType( 0 )
+        {}
 
     friend SvStream& ReadPptUserEditAtom( SvStream& rIn, PptUserEditAtom& rAtom );
 };
commit bfcd369f9b9072494b893dbdeee09f5e4341deac
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Fri Feb 7 21:24:04 2014 -0600

    coverity#707774: Uninitialized scalar value
    
    Change-Id: Icba50e53a162276b90c1602d22f28fa3ef42f05d

diff --git a/include/filter/msfilter/msdffimp.hxx b/include/filter/msfilter/msdffimp.hxx
index c2bf039..0460830 100644
--- a/include/filter/msfilter/msdffimp.hxx
+++ b/include/filter/msfilter/msdffimp.hxx
@@ -176,8 +176,19 @@ struct SvxMSDffConnectorRule
     SdrObject*  pBObj;     ///< pPtr of object (corresponding to shape B)
     SdrObject*  pCObj;     ///< pPtr of connector object
 
-    SvxMSDffConnectorRule() : nSpFlagsA( 0 ), nSpFlagsB( 0 ), pAObj( NULL ),
-                              pBObj( NULL ), pCObj( NULL ) {};
+    SvxMSDffConnectorRule()
+        : nRuleId(0)
+        , nShapeA(0)
+        , nShapeB(0)
+        , nShapeC(0)
+        , ncptiA(0)
+        , ncptiB(0)
+        , nSpFlagsA( 0 )
+        , nSpFlagsB( 0 )
+        , pAObj( NULL )
+        , pBObj( NULL )
+        , pCObj( NULL )
+        {};
 
     friend SvStream& ReadSvxMSDffConnectorRule( SvStream& rIn, SvxMSDffConnectorRule& rAtom );
 };


More information about the Libreoffice-commits mailing list