[Libreoffice-commits] core.git: 8 commits - binaryurp/source chart2/source connectivity/source editeng/source svtools/source

Noel Grandin noel at peralex.com
Wed Feb 12 05:14:43 PST 2014


 binaryurp/source/binaryany.cxx                                           |    3 +++
 chart2/source/controller/chartapiwrapper/WrappedNumberFormatProperty.cxx |    1 +
 connectivity/source/drivers/mozab/bootstrap/MMozillaBootstrap.cxx        |    3 ++-
 connectivity/source/drivers/odbc/OConnection.cxx                         |    1 +
 editeng/source/editeng/impedit2.cxx                                      |    2 +-
 svtools/source/svhtml/parhtml.cxx                                        |    4 +++-
 6 files changed, 11 insertions(+), 3 deletions(-)

New commits:
commit 025a77f794c87b602921bc583f1133268980b761
Author: Noel Grandin <noel at peralex.com>
Date:   Wed Feb 12 13:43:46 2014 +0200

    cid#705996 unintended sign extension
    
    Change-Id: I07f357b069bd8ae31049f049163c0e20e7361f79

diff --git a/editeng/source/editeng/impedit2.cxx b/editeng/source/editeng/impedit2.cxx
index eab034b..854c6ed 100644
--- a/editeng/source/editeng/impedit2.cxx
+++ b/editeng/source/editeng/impedit2.cxx
@@ -3601,7 +3601,7 @@ Range ImpEditEngine::GetInvalidYOffsets( ParaPortion* pPortion )
                 ( rLSItem.GetPropLineSpace() < 100 ) )
             {
                 const EditLine* pL = pPortion->GetLines()[nFirstInvalid];
-                long n = pL->GetTxtHeight() * ( 100 - rLSItem.GetPropLineSpace() );
+                long n = pL->GetTxtHeight() * ( 100L - rLSItem.GetPropLineSpace() );
                 n /= 100;
                 aRange.Min() -= n;
                 aRange.Max() += n;
commit 639f35e22f5b61920fdd2662b230467fad39c123
Author: Noel Grandin <noel at peralex.com>
Date:   Wed Feb 12 13:27:16 2014 +0200

    cid#707705 uninitialized pointer field
    
    Change-Id: I80679a2cb99cdc912ed021cf993adeb3478355c4

diff --git a/connectivity/source/drivers/odbc/OConnection.cxx b/connectivity/source/drivers/odbc/OConnection.cxx
index 0a35a58..03942e5 100644
--- a/connectivity/source/drivers/odbc/OConnection.cxx
+++ b/connectivity/source/drivers/odbc/OConnection.cxx
@@ -48,6 +48,7 @@ using namespace com::sun::star::sdbc;
 OConnection::OConnection(const SQLHANDLE _pDriverHandle,ODBCDriver* _pDriver)
                          : OSubComponent<OConnection, OConnection_BASE>((::cppu::OWeakObject*)_pDriver, this)
                          ,m_pDriver(_pDriver)
+                         ,m_aConnectionHandle(NULL)
                          ,m_pDriverHandleCopy(_pDriverHandle)
                          ,m_nStatementCount(0)
                          ,m_bClosed(sal_True)
commit 326f1ccb17ec2c1466d029545fd0d9000458339f
Author: Noel Grandin <noel at peralex.com>
Date:   Wed Feb 12 12:40:24 2014 +0200

    cid#707669 uninitialized pointer field
    
    Change-Id: I11cc753d83d97a5e1d9373cc5a1fe504b5abe0dd

diff --git a/connectivity/source/drivers/mozab/bootstrap/MMozillaBootstrap.cxx b/connectivity/source/drivers/mozab/bootstrap/MMozillaBootstrap.cxx
index b9c4629..d97e4a6 100644
--- a/connectivity/source/drivers/mozab/bootstrap/MMozillaBootstrap.cxx
+++ b/connectivity/source/drivers/mozab/bootstrap/MMozillaBootstrap.cxx
@@ -47,7 +47,8 @@ extern "C" SAL_DLLPUBLIC_EXPORT void*  SAL_CALL OMozillaBootstrap_CreateInstance
 
 MozillaBootstrap::MozillaBootstrap(
     const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory >& _rxFactory)
-    : OMozillaBootstrap_BASE(m_aMutex), m_xMSFactory( _rxFactory )
+    : OMozillaBootstrap_BASE(m_aMutex), m_xMSFactory( _rxFactory ),
+      m_ProfileAccess(NULL), m_ProfileManager(NULL)
 {
 }
 // -----------------------------------------------------------------------------
commit a1b1625cfdf5cd86de72f60915f0874a93e96240
Author: Noel Grandin <noel at peralex.com>
Date:   Wed Feb 12 12:38:18 2014 +0200

    cid#707669 uninitialized pointer value
    
    Change-Id: I252f88ba76d9b927d472655d2bee71cc85b22452

diff --git a/chart2/source/controller/chartapiwrapper/WrappedNumberFormatProperty.cxx b/chart2/source/controller/chartapiwrapper/WrappedNumberFormatProperty.cxx
index a4010a8..ce73ee3 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedNumberFormatProperty.cxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedNumberFormatProperty.cxx
@@ -32,6 +32,7 @@ namespace wrapper
 WrappedNumberFormatProperty::WrappedNumberFormatProperty( ::boost::shared_ptr< Chart2ModelContact > spChart2ModelContact )
         : WrappedDirectStateProperty( "NumberFormat", "NumberFormat" )
         , m_spChart2ModelContact(spChart2ModelContact)
+        , m_pWrappedLinkNumberFormatProperty(NULL)
 {
     m_aOuterValue = getPropertyDefault( 0 );
 }
commit 571d116d2805827bdef7d32983697bcdc5f9c78e
Author: Noel Grandin <noel at peralex.com>
Date:   Wed Feb 12 12:35:38 2014 +0200

    cid#707663 uninitialized pointer field
    
    Change-Id: I4864042da995e70fd050584341960e58c4cddec2

diff --git a/binaryurp/source/binaryany.cxx b/binaryurp/source/binaryany.cxx
index 6540fc3..66a1a38 100644
--- a/binaryurp/source/binaryany.cxx
+++ b/binaryurp/source/binaryany.cxx
@@ -31,6 +31,7 @@ namespace binaryurp {
 
 BinaryAny::BinaryAny() throw () {
     uno_any_construct(&data_, 0, 0, 0);
+    data_.pReserved = NULL;
 }
 
 BinaryAny::BinaryAny(css::uno::TypeDescription const & type, void * value)
commit 5523275482686d1e49e9b5dcf70b1c8451628f6c
Author: Noel Grandin <noel at peralex.com>
Date:   Wed Feb 12 12:34:58 2014 +0200

    cid#707662 uninitialized pointer field
    
    Change-Id: I031497ef2f789a87724357b28e5fed70afa46dcc

diff --git a/binaryurp/source/binaryany.cxx b/binaryurp/source/binaryany.cxx
index 6ca4e69..6540fc3 100644
--- a/binaryurp/source/binaryany.cxx
+++ b/binaryurp/source/binaryany.cxx
@@ -51,6 +51,7 @@ BinaryAny::BinaryAny(uno_Any const & raw) throw () {
 
 BinaryAny::BinaryAny(BinaryAny const & other) throw () {
     uno_type_any_construct(&data_, other.data_.pData, other.data_.pType, 0);
+    data_.pReserved = NULL;
 }
 
 BinaryAny::~BinaryAny() throw () {
commit e453ba963e624eb6829abc28beb0abe4c92be30c
Author: Noel Grandin <noel at peralex.com>
Date:   Wed Feb 12 12:27:42 2014 +0200

    cid#707661 uninitialized pointer field
    
    Change-Id: I6fee8665ce1875ffa8e01bd395bb91a3d2bb40c8

diff --git a/binaryurp/source/binaryany.cxx b/binaryurp/source/binaryany.cxx
index a56663a..6ca4e69 100644
--- a/binaryurp/source/binaryany.cxx
+++ b/binaryurp/source/binaryany.cxx
@@ -38,6 +38,7 @@ BinaryAny::BinaryAny(css::uno::TypeDescription const & type, void * value)
 {
     assert(type.is());
     uno_any_construct(&data_, value, type.get(), 0);
+    data_.pReserved = NULL;
 }
 
 BinaryAny::BinaryAny(uno_Any const & raw) throw () {
commit de476d0146dfecf04f7d1630a771751e3f27ced9
Author: Noel Grandin <noel at peralex.com>
Date:   Wed Feb 12 10:11:18 2014 +0200

    cid#1103689 missing break in switch
    
    Change-Id: I28338145fdd71ec25b9c6d291e445d35636e43a9

diff --git a/svtools/source/svhtml/parhtml.cxx b/svtools/source/svhtml/parhtml.cxx
index 5b45f94..942e881 100644
--- a/svtools/source/svhtml/parhtml.cxx
+++ b/svtools/source/svhtml/parhtml.cxx
@@ -353,8 +353,10 @@ int HTMLParser::FilterToken( int nToken )
 
     case HTML_HEAD_OFF:
         bIsInBody = true;
+        bIsInHeader = false;
+        break;
     case HTML_HEAD_ON:
-        bIsInHeader = HTML_HEAD_ON == nToken;
+        bIsInHeader = true;
         break;
 
     case HTML_BODY_ON:


More information about the Libreoffice-commits mailing list