[Libreoffice-commits] core.git: shell/source

Julien Nabet serval2412 at yahoo.fr
Sun Feb 16 11:46:17 CET 2014


 shell/source/win32/shlxthandler/shlxthdl.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit eeee164f6796274fb6858026bdee5607a6a578b1
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Sat Feb 1 19:11:26 2014 +0100

    cppcheck: redundantAssignment
    
    Let's not forget the result of RegDeleteValueA call
    
    Change-Id: I9458040bc3a8960ab740ee3c5211eaa9ba24b1aa
    Reviewed-on: https://gerrit.libreoffice.org/7772
    Tested-by: David Tardon <dtardon at redhat.com>
    Reviewed-by: David Tardon <dtardon at redhat.com>

diff --git a/shell/source/win32/shlxthandler/shlxthdl.cxx b/shell/source/win32/shlxthandler/shlxthdl.cxx
index 03f07af..a2f8a1d 100644
--- a/shell/source/win32/shlxthandler/shlxthdl.cxx
+++ b/shell/source/win32/shlxthandler/shlxthdl.cxx
@@ -289,7 +289,7 @@ namespace /* private */
                 hkey,
                 ClsidToString(Clsid).c_str());
 
-            rc = RegCloseKey(hkey);
+            rc |= RegCloseKey(hkey);
         }
 
         return rc == ERROR_SUCCESS ? S_OK : E_FAIL;


More information about the Libreoffice-commits mailing list