[Libreoffice-commits] core.git: 4 commits - filter/source hwpfilter/source i18npool/source include/package

Norbert Thiebaud nthiebaud at gmail.com
Tue Feb 18 09:55:50 CET 2014


 filter/source/svg/svgwriter.cxx                         |   12 ++++----
 hwpfilter/source/hbox.cxx                               |    6 ++--
 i18npool/source/breakiterator/breakiterator_unicode.cxx |   24 +++++++++-------
 include/package/Inflater.hxx                            |    2 -
 4 files changed, 26 insertions(+), 18 deletions(-)

New commits:
commit 6891ed67285aec21a0e761d129910bd236eb039e
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Tue Feb 18 01:29:10 2014 -0600

    coverity#984093 Uninitialized scalar field
    
    Change-Id: I60233fdc8d03e2d0dae03eaa8f3ef47ad8bdf43e

diff --git a/filter/source/svg/svgwriter.cxx b/filter/source/svg/svgwriter.cxx
index 19691fe..3aa687e 100644
--- a/filter/source/svg/svgwriter.cxx
+++ b/filter/source/svg/svgwriter.cxx
@@ -91,11 +91,13 @@ static const char aOOOAttrNumberingType[] = NSPREFIX "numbering-type";
 static sal_Char const XML_UNO_NAME_NRULE_NUMBERINGTYPE[] = "NumberingType";
 static sal_Char const XML_UNO_NAME_NRULE_BULLET_CHAR[] = "BulletChar";
 
-SVGAttributeWriter::SVGAttributeWriter( SVGExport& rExport, SVGFontExport& rFontExport ) :
-    mrExport( rExport ),
-    mrFontExport( rFontExport ),
-    mpElemFont( NULL ),
-    mpElemPaint( NULL )
+SVGAttributeWriter::SVGAttributeWriter( SVGExport& rExport, SVGFontExport& rFontExport )
+    : mrExport( rExport )
+    , mrFontExport( rFontExport )
+    , mpElemFont( NULL )
+    , mpElemPaint( NULL )
+    , maLineJoin(basegfx::B2DLINEJOIN_NONE)
+    , maLineCap(css::drawing::LineCap_BUTT)
 {
 }
 
commit b8d8bb8e0db51b45adf1c798dc77b6eb580d2003
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Tue Feb 18 01:22:02 2014 -0600

    coverity#984094 Uninitialized scalar field
    
    Change-Id: I114abdb07760e128e40a6e4a82d276584aabed97

diff --git a/hwpfilter/source/hbox.cxx b/hwpfilter/source/hbox.cxx
index 033df90..c3b9d60 100644
--- a/hwpfilter/source/hbox.cxx
+++ b/hwpfilter/source/hbox.cxx
@@ -78,9 +78,11 @@ hunit HBox::Height(CharShape *csty)
 
 
 // skip block
-SkipData::SkipData(hchar hch):HBox(hch)
+SkipData::SkipData(hchar hch)
+    : HBox(hch)
+    , data_block_len(0)
+    , data_block(0)
 {
-    data_block = 0;
 }
 
 
commit 313ea4b2c386d93c548442a8f14265a93a5819f1
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Tue Feb 18 01:05:18 2014 -0600

    coverity#984096 Uninitialized scalar field
    
    Change-Id: If67e1c48fba43fabcaffef92d96bc1377b4d1dd8

diff --git a/i18npool/source/breakiterator/breakiterator_unicode.cxx b/i18npool/source/breakiterator/breakiterator_unicode.cxx
index e46dedc..f0a6cb7 100644
--- a/i18npool/source/breakiterator/breakiterator_unicode.cxx
+++ b/i18npool/source/breakiterator/breakiterator_unicode.cxx
@@ -40,11 +40,12 @@ using namespace ::com::sun::star::lang;
 namespace com { namespace sun { namespace star { namespace i18n {
 
 
-BreakIterator_Unicode::BreakIterator_Unicode() :
-    cBreakIterator( "com.sun.star.i18n.BreakIterator_Unicode" ),    // implementation name
-    wordRule( "word" ),
-    lineRule( "line" ),
-    icuBI( NULL )
+BreakIterator_Unicode::BreakIterator_Unicode()
+    : cBreakIterator( "com.sun.star.i18n.BreakIterator_Unicode" )    // implementation name
+    , wordRule( "word" )
+    , lineRule( "line" )
+    , icuBI( NULL )
+    , aBreakType(0)
 {
 }
 
@@ -61,14 +62,17 @@ BreakIterator_Unicode::~BreakIterator_Unicode()
     Wrapper class to provide public access to the RuleBasedBreakIterator's
     setbreakType method.
 */
-class OOoRuleBasedBreakIterator : public RuleBasedBreakIterator {
+class OOoRuleBasedBreakIterator : public RuleBasedBreakIterator
+{
     public:
-        inline void publicSetBreakType(int32_t type) {
+    inline void publicSetBreakType(int32_t type)
+        {
             setBreakType(type);
         };
-        OOoRuleBasedBreakIterator(UDataMemory* image,
-                UErrorCode &status) :
-            RuleBasedBreakIterator(image, status) { };
+    OOoRuleBasedBreakIterator(UDataMemory* image,
+                              UErrorCode &status)
+        : RuleBasedBreakIterator(image, status)
+        { };
 
 };
 
commit 0f9c938fa2bf11e031fb2f6d9beebfeda264bec6
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Tue Feb 18 00:40:17 2014 -0600

    coverity#984100 Uninitialized scalar field
    
    Change-Id: I6a90bbc1fc2faa379a72dd0a61dd96a829676e2c

diff --git a/include/package/Inflater.hxx b/include/package/Inflater.hxx
index c3575b9..9f54b49 100644
--- a/include/package/Inflater.hxx
+++ b/include/package/Inflater.hxx
@@ -32,7 +32,7 @@ class DLLPUBLIC_PACKAGE Inflater
     typedef struct z_stream_s z_stream;
 
 protected:
-    sal_Bool                bFinish, bFinished, bSetParams, bNeedDict;
+    sal_Bool                bFinished, bSetParams, bNeedDict;
     sal_Int32               nOffset, nLength, nLastInflateError;
     z_stream*               pStream;
     com::sun::star::uno::Sequence < sal_Int8 >  sInBuffer;


More information about the Libreoffice-commits mailing list