[Libreoffice-commits] core.git: cui/source include/svx include/vcl sc/source

Stephan Bergmann sbergman at redhat.com
Tue Jan 14 06:00:05 PST 2014


 cui/source/dialogs/passwdomdlg.cxx |    2 +-
 cui/source/factory/dlgfact.cxx     |    4 ++--
 cui/source/factory/dlgfact.hxx     |    2 +-
 cui/source/tabpages/autocdlg.cxx   |    2 +-
 include/svx/svxdlg.hxx             |    2 +-
 include/vcl/window.hxx             |    2 +-
 sc/source/ui/miscdlgs/mvtabdlg.cxx |    4 ++--
 7 files changed, 9 insertions(+), 9 deletions(-)

New commits:
commit b32b45c50cc7b782554b0da722913f697434647d
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue Jan 14 14:56:42 2014 +0100

    nFlags parameter to Window::Hide appears effectively unused
    
    ...there was a handful of Hide(true) calls, which would happen to actually mean
    
      Show(false, SHOW_NOPARENTUPDATE)
    
    but I assume those were typos rather than genuine requests for
    SHOW_NOPARENTUPDATE.
    
    Change-Id: I20310d58437bb556f95965885f82784f855b517d

diff --git a/cui/source/dialogs/passwdomdlg.cxx b/cui/source/dialogs/passwdomdlg.cxx
index b73b71d..30e3300 100644
--- a/cui/source/dialogs/passwdomdlg.cxx
+++ b/cui/source/dialogs/passwdomdlg.cxx
@@ -163,7 +163,7 @@ PasswordToOpenModifyDialog_Impl::PasswordToOpenModifyDialog_Impl(
 
     m_aMoreFewerOptionsBTN.Enable( bIsPasswordToModify );
     if (!bIsPasswordToModify)
-        m_aMoreFewerOptionsBTN.Hide( sal_True );
+        m_aMoreFewerOptionsBTN.Hide();
 }
 
 
diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx
index 3ab8e86..2090e59 100644
--- a/cui/source/factory/dlgfact.cxx
+++ b/cui/source/factory/dlgfact.cxx
@@ -543,9 +543,9 @@ OUString AbstractURLDlg_Impl::GetName() const
     return pDlg->GetName();
 }
 
-void AbstractSvxHlinkDlgMarkWnd_Impl::Hide( sal_uInt16 nFlags )
+void AbstractSvxHlinkDlgMarkWnd_Impl::Hide()
 {
-    ((Window*)pDlg)->Hide( nFlags );
+    ((Window*)pDlg)->Hide();
 }
 
 void AbstractSvxHlinkDlgMarkWnd_Impl::SetSizePixel( const Size& rNewSize )
diff --git a/cui/source/factory/dlgfact.hxx b/cui/source/factory/dlgfact.hxx
index cee1226..0d17161 100644
--- a/cui/source/factory/dlgfact.hxx
+++ b/cui/source/factory/dlgfact.hxx
@@ -278,7 +278,7 @@ class SvxHlinkDlgMarkWnd;
 class AbstractSvxHlinkDlgMarkWnd_Impl : public AbstractSvxHlinkDlgMarkWnd
 {
     DECL_ABSTDLG_BASE(AbstractSvxHlinkDlgMarkWnd_Impl,SvxHlinkDlgMarkWnd)
-    virtual void                Hide( sal_uInt16 nFlags = 0 );
+    virtual void                Hide() SAL_OVERRIDE;
     virtual sal_Bool            IsVisible() const ;
     virtual void                Invalidate( sal_uInt16 nFlags = 0 );
     virtual void                SetSizePixel( const Size& rNewSize );
diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/tabpages/autocdlg.cxx
index 5f5c69e..c4e7f9e 100644
--- a/cui/source/tabpages/autocdlg.cxx
+++ b/cui/source/tabpages/autocdlg.cxx
@@ -1778,7 +1778,7 @@ OfaQuoteTabPage::OfaQuoteTabPage(Window* pParent, const SfxItemSet& rSet)
         sHeader += "\t";
         m_pSwCheckLB->InsertHeaderEntry( sHeader, HEADERBAR_APPEND,
                         HIB_CENTER | HIB_VCENTER | HIB_FIXEDPOS | HIB_FIXED);
-        m_pCheckLB->Hide(true);
+        m_pCheckLB->Hide();
     }
     else
     {
diff --git a/include/svx/svxdlg.hxx b/include/svx/svxdlg.hxx
index 34ae403..4d51d1c 100644
--- a/include/svx/svxdlg.hxx
+++ b/include/svx/svxdlg.hxx
@@ -140,7 +140,7 @@ public:
     // in class Window
     virtual void    SetSizePixel( const Size& rNewSize ) = 0;
     virtual Size    GetSizePixel() const = 0;
-    virtual void    Hide( sal_uInt16 nFlags = 0 ) = 0;
+    virtual void    Hide() = 0;
     virtual sal_Bool    IsVisible() const = 0;
     virtual void    Invalidate( sal_uInt16 nFlags = 0 ) = 0;
 };
diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx
index fc7e2e0..991daf6 100644
--- a/include/vcl/window.hxx
+++ b/include/vcl/window.hxx
@@ -721,7 +721,7 @@ public:
     Dialog*             GetParentDialog() const;
 
     void                Show( sal_Bool bVisible = sal_True, sal_uInt16 nFlags = 0 );
-    void                Hide( sal_uInt16 nFlags = 0 ) { Show( sal_False, nFlags ); }
+    void                Hide() { Show( sal_False ); }
     sal_Bool                IsVisible() const;
     sal_Bool                IsReallyVisible() const;
     sal_Bool                IsReallyShown() const;
diff --git a/sc/source/ui/miscdlgs/mvtabdlg.cxx b/sc/source/ui/miscdlgs/mvtabdlg.cxx
index 7c169ba..97f2258 100644
--- a/sc/source/ui/miscdlgs/mvtabdlg.cxx
+++ b/sc/source/ui/miscdlgs/mvtabdlg.cxx
@@ -196,7 +196,7 @@ void ScMoveTableDlg::CheckNewTabName()
     }
     else
     {
-        pFtWarn->Hide(sal_True);
+        pFtWarn->Hide();
         pFtWarn->SetControlBackground();
         pFtWarn->SetText(OUString());
         pBtnOk->Enable();
@@ -225,7 +225,7 @@ void ScMoveTableDlg::Init()
     pBtnMove->Check( true );
     pBtnCopy->Check( false );
     pEdTabName->Enable(false);
-    pFtWarn->Hide(sal_True);
+    pFtWarn->Hide();
     InitDocListBox();
     SelHdl( pLbDoc );
 }


More information about the Libreoffice-commits mailing list