[Libreoffice-commits] core.git: android/sdremote

[Christian Lohmaier]

 android/sdremote/res/layout-land/fragment_slides_pager.xml |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

New commits:
commit 4bddd280f204f1036f9933a4b683a0b20a7d85a0
Author: Christian Lohmaier <lohmaier+LibreOffice at googlemail.com>
Date:   Mon Dec 30 01:23:49 2013 +0100

    tweak paddings in landcape mode (maximize space for preview & notes)
    
    add minimal padding around slide preview (to not touch actionbar and
    bottom of screen - horizontal whitespace will be larger becasue height
    is limiting factor anyway)
    
    avoid adding two left-paddings for the notes - the Text is "indented"
    compared to the notes area already, so margin implied by the layout
    weight distribution and the text indent is enough to separate it from
    the preview.
    
    avoid adding two right paddings for the note-text, as the text is not
    justified and the word-break itself will account for a "padding" at the
    edge, and the container already has a right-padding (that was reduced,
    since the word-padding as well as centering in the unused space will
    increase the effective margin)
    
    Change-Id: I2a4605ba5a98eeed93a01db16d3d86c90df56470
    Reviewed-on: https://gerrit.libreoffice.org/7230
    Reviewed-by: Andrzej Hunt <andrzej.hunt at collabora.com>
    Tested-by: Andrzej Hunt <andrzej.hunt at collabora.com>

diff --git a/android/sdremote/res/layout-land/fragment_slides_pager.xml b/android/sdremote/res/layout-land/fragment_slides_pager.xml
index 340a462..e3e3c9b 100644
--- a/android/sdremote/res/layout-land/fragment_slides_pager.xml
+++ b/android/sdremote/res/layout-land/fragment_slides_pager.xml
@@ -25,14 +25,14 @@
     <android.support.v4.view.ViewPager
         android:id="@+id/pager_slides"
         android:layout_weight="2"
+        android:padding="@dimen/padding_slide"
         android:layout_width="0dp"
         android:layout_height="match_parent"/>
 
     <LinearLayout
         android:id="@+id/layout_notes"
         android:orientation="vertical"
-        android:paddingLeft="@dimen/padding_slides_pager"
-        android:paddingRight="@dimen/padding_slides_pager"
+        android:paddingRight="@dimen/padding_slide_notes"
         android:layout_weight="1"
         android:layout_width="0dp"
         android:layout_height="match_parent">
@@ -45,6 +45,8 @@
 
         <ScrollView
             android:id="@+id/scroll_notes"
+            android:paddingTop="@dimen/padding_slide_notes"
+            android:paddingLeft="@dimen/padding_slide_notes"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content">
 
@@ -53,9 +55,6 @@
                 android:inAnimation="@android:anim/fade_in"
                 android:outAnimation="@android:anim/fade_out"
                 android:measureAllChildren="false"
-                android:paddingTop="@dimen/padding_slide_notes"
-                android:paddingLeft="@dimen/padding_slide_notes"
-                android:paddingRight="@dimen/padding_slide_notes"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content">