[Libreoffice-commits] core.git: 4 commits - sc/inc sc/source xmlreader/source
Caolán McNamara
caolanm at redhat.com
Thu Jan 23 09:23:51 PST 2014
sc/inc/viewuno.hxx | 2 +-
sc/source/ui/Accessibility/AccessibleCell.cxx | 4 ++--
sc/source/ui/Accessibility/AccessibleContextBase.cxx | 4 ++--
sc/source/ui/Accessibility/AccessiblePreviewTable.cxx | 3 ++-
sc/source/ui/inc/AccessibleCell.hxx | 4 ++--
sc/source/ui/inc/AccessibleContextBase.hxx | 4 ++--
sc/source/ui/inc/AccessiblePreviewTable.hxx | 2 +-
sc/source/ui/unoobj/viewuno.cxx | 4 ++--
xmlreader/source/xmlreader.cxx | 2 ++
9 files changed, 16 insertions(+), 13 deletions(-)
New commits:
commit 194cfbfa2a5fb7b8a4598729aede48d5a221f61c
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jan 23 17:22:05 2014 +0000
coverity#1158407 Uncaught exception
Change-Id: Ib8830798250b9c4f143743de4389260fceb44aa3
diff --git a/sc/source/ui/Accessibility/AccessiblePreviewTable.cxx b/sc/source/ui/Accessibility/AccessiblePreviewTable.cxx
index 42b14f4..09a852e 100644
--- a/sc/source/ui/Accessibility/AccessiblePreviewTable.cxx
+++ b/sc/source/ui/Accessibility/AccessiblePreviewTable.cxx
@@ -647,7 +647,8 @@ Rectangle ScAccessiblePreviewTable::GetBoundingBoxOnScreen() const throw (uno::R
return aCellRect;
}
-Rectangle ScAccessiblePreviewTable::GetBoundingBox() const throw (uno::RuntimeException)
+Rectangle ScAccessiblePreviewTable::GetBoundingBox() const
+ throw (uno::RuntimeException, std::exception)
{
FillTableInfo();
diff --git a/sc/source/ui/inc/AccessiblePreviewTable.hxx b/sc/source/ui/inc/AccessiblePreviewTable.hxx
index 795badc..5840702 100644
--- a/sc/source/ui/inc/AccessiblePreviewTable.hxx
+++ b/sc/source/ui/inc/AccessiblePreviewTable.hxx
@@ -156,7 +156,7 @@ protected:
virtual OUString SAL_CALL createAccessibleName(void) throw (::com::sun::star::uno::RuntimeException);
virtual Rectangle GetBoundingBoxOnScreen(void) const throw(::com::sun::star::uno::RuntimeException);
- virtual Rectangle GetBoundingBox(void) const throw (::com::sun::star::uno::RuntimeException);
+ virtual Rectangle GetBoundingBox() const throw (::com::sun::star::uno::RuntimeException, std::exception);
private:
ScPreviewShell* mpViewShell;
commit a5c401df84df2be26a6a2351a7d5c9d65524d8a9
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jan 23 17:20:06 2014 +0000
coverity#1158408 Uncaught exception
Change-Id: Ie0a3cfeedeb386e72749997e6a4bdf8b6c515be2
diff --git a/sc/inc/viewuno.hxx b/sc/inc/viewuno.hxx
index eddaed3..fc97d4b 100644
--- a/sc/inc/viewuno.hxx
+++ b/sc/inc/viewuno.hxx
@@ -80,7 +80,7 @@ public:
// XViewPane
virtual sal_Int32 SAL_CALL getFirstVisibleColumn() throw(::com::sun::star::uno::RuntimeException);
virtual void SAL_CALL setFirstVisibleColumn( sal_Int32 nFirstVisibleColumn )
- throw(::com::sun::star::uno::RuntimeException);
+ throw(::com::sun::star::uno::RuntimeException, std::exception);
virtual sal_Int32 SAL_CALL getFirstVisibleRow() throw(::com::sun::star::uno::RuntimeException);
virtual void SAL_CALL setFirstVisibleRow( sal_Int32 nFirstVisibleRow )
throw(::com::sun::star::uno::RuntimeException);
diff --git a/sc/source/ui/unoobj/viewuno.cxx b/sc/source/ui/unoobj/viewuno.cxx
index 3095a78..369cb4e 100644
--- a/sc/source/ui/unoobj/viewuno.cxx
+++ b/sc/source/ui/unoobj/viewuno.cxx
@@ -206,8 +206,8 @@ sal_Int32 SAL_CALL ScViewPaneBase::getFirstVisibleColumn() throw(uno::RuntimeExc
return 0;
}
-void SAL_CALL ScViewPaneBase::setFirstVisibleColumn( sal_Int32 nFirstVisibleColumn )
- throw(uno::RuntimeException)
+void SAL_CALL ScViewPaneBase::setFirstVisibleColumn(sal_Int32 nFirstVisibleColumn)
+ throw(uno::RuntimeException, std::exception)
{
SolarMutexGuard aGuard;
if (pViewShell)
commit 98a3def98cd6e43dcce51de9694dcc895ad7a36a
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jan 23 17:16:19 2014 +0000
coverity#1158410 Uncaught exception
mdds::general_error is thrown but is luckily inherited from std::exception so
use the new ability of 0bc89aac4c64bb833e387657f680e194c26aef97 "cppumaker:
Allow UNO interface functions to throw std::exception."
Change-Id: I2c1d30e0806281d43c7bec103d4c85e1799c5b4f
diff --git a/sc/source/ui/Accessibility/AccessibleCell.cxx b/sc/source/ui/Accessibility/AccessibleCell.cxx
index 742496c..cb319a4 100644
--- a/sc/source/ui/Accessibility/AccessibleCell.cxx
+++ b/sc/source/ui/Accessibility/AccessibleCell.cxx
@@ -166,8 +166,8 @@ Rectangle ScAccessibleCell::GetBoundingBoxOnScreen(void) const
return aCellRect;
}
-Rectangle ScAccessibleCell::GetBoundingBox(void) const
- throw (uno::RuntimeException)
+Rectangle ScAccessibleCell::GetBoundingBox() const
+ throw (uno::RuntimeException, std::exception)
{
Rectangle aCellRect;
if (mpViewShell)
diff --git a/sc/source/ui/Accessibility/AccessibleContextBase.cxx b/sc/source/ui/Accessibility/AccessibleContextBase.cxx
index d81cacb..662a190 100644
--- a/sc/source/ui/Accessibility/AccessibleContextBase.cxx
+++ b/sc/source/ui/Accessibility/AccessibleContextBase.cxx
@@ -580,8 +580,8 @@ Rectangle ScAccessibleContextBase::GetBoundingBoxOnScreen(void) const
return Rectangle();
}
-Rectangle ScAccessibleContextBase::GetBoundingBox(void) const
- throw (uno::RuntimeException)
+Rectangle ScAccessibleContextBase::GetBoundingBox() const
+ throw (uno::RuntimeException, std::exception)
{
OSL_FAIL("not implemented");
return Rectangle();
diff --git a/sc/source/ui/inc/AccessibleCell.hxx b/sc/source/ui/inc/AccessibleCell.hxx
index dd53521..90cde3e 100644
--- a/sc/source/ui/inc/AccessibleCell.hxx
+++ b/sc/source/ui/inc/AccessibleCell.hxx
@@ -101,8 +101,8 @@ protected:
throw (::com::sun::star::uno::RuntimeException);
/// Return the object's current bounding box relative to the parent object.
- virtual Rectangle GetBoundingBox(void) const
- throw (::com::sun::star::uno::RuntimeException);
+ virtual Rectangle GetBoundingBox() const
+ throw (::com::sun::star::uno::RuntimeException, std::exception);
public:
///===== XAccessibleContext ==============================================
diff --git a/sc/source/ui/inc/AccessibleContextBase.hxx b/sc/source/ui/inc/AccessibleContextBase.hxx
index b90d1c4..6b06ba6 100644
--- a/sc/source/ui/inc/AccessibleContextBase.hxx
+++ b/sc/source/ui/inc/AccessibleContextBase.hxx
@@ -274,8 +274,8 @@ protected:
throw (::com::sun::star::uno::RuntimeException);
/// Return the object's current bounding box relative to the parent object.
- virtual Rectangle GetBoundingBox(void) const
- throw (::com::sun::star::uno::RuntimeException);
+ virtual Rectangle GetBoundingBox() const
+ throw (::com::sun::star::uno::RuntimeException, std::exception);
public:
/// Calls all Listener to tell they the change.
commit 472bc326305eb4e3a866d189a643ea1c7cb43925
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jan 23 17:07:52 2014 +0000
coverity#1158416 Uninitialized pointer field
Change-Id: I5c1b07bd3898e89141fe3c3c8f8b63b81513a97e
diff --git a/xmlreader/source/xmlreader.cxx b/xmlreader/source/xmlreader.cxx
index 3e1d24e..81e7a38 100644
--- a/xmlreader/source/xmlreader.cxx
+++ b/xmlreader/source/xmlreader.cxx
@@ -57,6 +57,8 @@ bool isSpace(char c) {
XmlReader::XmlReader(char const *sStr, size_t nLength)
: fileUrl_("stream")
, fileHandle_(0)
+ , fileSize_(0)
+ , fileAddress_(0)
{
namespaceIris_.push_back(Span("http://www.w3.org/XML/1998/namespace"));
namespaces_.push_back(NamespaceData(Span("xml"), NAMESPACE_XML));
More information about the Libreoffice-commits
mailing list