[Libreoffice-commits] core.git: 3 commits - svtools/source svx/source

[Norbert Thiebaud]

 svtools/source/contnr/ivctrl.cxx |   22 ++++++++++++---------
 svx/source/tbxctrls/layctrl.cxx  |   23 ++++++++++++----------
 svx/source/tbxctrls/tbcontrl.cxx |   40 ++++++++++++++++++---------------------
 3 files changed, 45 insertions(+), 40 deletions(-)

New commits:
commit e0696359a0b4a9ac2e3f1a84d69e8f43488aea3b
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Mon Jan 27 00:57:56 2014 -0600

    coverity#1079289 : Uninitialized scalar field
    
    Change-Id: I4663e3d0c5f0fe4288fba1ba4203e2de5ba4e986

diff --git a/svtools/source/contnr/ivctrl.cxx b/svtools/source/contnr/ivctrl.cxx
index 09f46ca..f3512a54 100644
--- a/svtools/source/contnr/ivctrl.cxx
+++ b/svtools/source/contnr/ivctrl.cxx
@@ -31,16 +31,20 @@ using namespace ::com::sun::star::accessibility;
 |
 \*****************************************************************************/
 
-SvxIconChoiceCtrlEntry::SvxIconChoiceCtrlEntry( const OUString& rText, const Image& rImage, sal_uInt16 _nFlags )
+SvxIconChoiceCtrlEntry::SvxIconChoiceCtrlEntry( const OUString& rText,
+                                                const Image& rImage,
+                                                sal_uInt16 _nFlags )
+    : aImage(rImage)
+    , aText(rText)
+    , pUserData(NULL)
+    , nPos(0)
+    , pblink(0)
+    , pflink(0)
+    , eTextMode(IcnShowTextShort)
+    , nX(0)
+    , nY(0)
+    , nFlags(_nFlags)
 {
-    aText = rText;
-    aImage = rImage;
-    pUserData = NULL;
-
-    nFlags = _nFlags;
-    eTextMode = IcnShowTextShort;
-    pblink = 0;
-    pflink = 0;
 }
 
 OUString SvxIconChoiceCtrlEntry::GetDisplayText() const
commit 7d6fbec1378cfc304ff36c46d24764aeec501887
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Mon Jan 27 00:46:59 2014 -0600

    coverity#1103750 : Uninitialized scalar field
    
    Change-Id: Id7c5f53f604240b85ab6b48f641c57f31e74c08a

diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index 725c50c0..a2369dc 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -327,27 +327,25 @@ class SfxStyleControllerItem_Impl : public SfxStatusListener
 // class SvxStyleBox_Impl -----------------------------------------------------
 //========================================================================
 
-SvxStyleBox_Impl::SvxStyleBox_Impl(
-    Window*                                 pParent,
-    const OUString&                         rCommand,
-    SfxStyleFamily                          eFamily,
-    const Reference< XDispatchProvider >&   rDispatchProvider,
-    const Reference< XFrame >&              _xFrame,
-    const OUString&                         rClearFormatKey,
-    const OUString&                         rMoreKey,
-    bool                                    bInSpec) :
-
-    ComboBox( pParent, SVX_RES( RID_SVXTBX_STYLE ) ),
-
-    eStyleFamily( eFamily ),
-    bRelease    ( true ),
-    bVisible(false),
-    m_xDispatchProvider( rDispatchProvider ),
-    m_xFrame(_xFrame),
-    m_aCommand  ( rCommand ),
-    aClearFormatKey ( rClearFormatKey ),
-    aMoreKey        ( rMoreKey ),
-    bInSpecialMode  ( bInSpec )
+SvxStyleBox_Impl::SvxStyleBox_Impl(Window* pParent,
+                                   const OUString& rCommand,
+                                   SfxStyleFamily eFamily,
+                                   const Reference< XDispatchProvider >& rDispatchProvider,
+                                   const Reference< XFrame >& _xFrame,
+                                   const OUString& rClearFormatKey,
+                                   const OUString& rMoreKey,
+                                   bool bInSpec)
+    : ComboBox( pParent, SVX_RES( RID_SVXTBX_STYLE ) )
+    , eStyleFamily( eFamily )
+    , nCurSel(0)
+    , bRelease( true )
+    , bVisible(false)
+    , m_xDispatchProvider( rDispatchProvider )
+    , m_xFrame(_xFrame)
+    , m_aCommand( rCommand )
+    , aClearFormatKey( rClearFormatKey )
+    , aMoreKey( rMoreKey )
+    , bInSpecialMode( bInSpec )
 {
     aLogicalSize = PixelToLogic( GetSizePixel(), MAP_APPFONT );
     EnableAutocomplete( sal_True );
commit d57fad937caff40819afddeadfd8b36b8d27e418
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Mon Jan 27 00:40:47 2014 -0600

    coverity#1103751 : Uninitialized scalar field
    
    Change-Id: I33d7da5199ffb4f5372bfa4c16a1a7b566ef5a9f

diff --git a/svx/source/tbxctrls/layctrl.cxx b/svx/source/tbxctrls/layctrl.cxx
index 2c2b1e2..6a91397 100644
--- a/svx/source/tbxctrls/layctrl.cxx
+++ b/svx/source/tbxctrls/layctrl.cxx
@@ -107,16 +107,19 @@ IMPL_LINK_NOARG(TableWindow, SelectHdl)
 
 // -----------------------------------------------------------------------
 
-TableWindow::TableWindow( sal_uInt16 nSlotId, const OUString& rCmd, const OUString& rText, ToolBox& rParentTbx, const Reference< XFrame >& rFrame ) :
-    SfxPopupWindow( nSlotId, rFrame, WinBits( WB_STDPOPUP ) ),
-    aTableButton( this ),
-    nCol( 0 ),
-    nLine( 0 ),
-    rTbx(rParentTbx),
-    mxFrame( rFrame ),
-    maCommand( rCmd ),
-    mnTablePosX(2),
-    mnTablePosY(2)
+TableWindow::TableWindow( sal_uInt16 nSlotId, const OUString& rCmd, const OUString& rText,
+                          ToolBox& rParentTbx, const Reference< XFrame >& rFrame )
+    : SfxPopupWindow( nSlotId, rFrame, WinBits( WB_STDPOPUP ) )
+    , aTableButton( this )
+    , nCol( 0 )
+    , nLine( 0 )
+    , bInitialKeyInput(false)
+    , m_bMod1(false)
+    , rTbx(rParentTbx)
+    , mxFrame( rFrame )
+    , maCommand( rCmd )
+    , mnTablePosX(2)
+    , mnTablePosY(2)
 {
     mnTableCellWidth  = 15 * GetDPIScaleFactor();
     mnTableCellHeight = 15 * GetDPIScaleFactor();