[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - sc/source

Kohei Yoshida kohei.yoshida at collabora.com
Mon Jan 27 18:51:17 PST 2014


 sc/source/core/data/column.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 795c5e629987906dea66c690313b3aa1590d7887
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date:   Mon Jan 27 19:16:30 2014 -0500

    fdo#69244: Avoid putting these cells in formula tree prematurely.
    
    Marking the cell dirty alone appears to be sufficient to trigger resetting
    of number format. SetDirty() would mark it dirty *and* put the cell into
    formula tree, which would prevent proper value propagation as seen in the
    bug report.
    
    Change-Id: Ib4000e955dec43ba976d1486e1e80d7b64197c80
    Reviewed-on: https://gerrit.libreoffice.org/7708
    Tested-by: Markus Mohrhard <markus.mohrhard at googlemail.com>
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>

diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index 984633c..c6b55a1 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -2268,7 +2268,7 @@ void ScColumn::CompileXML( ScProgress& rProgress )
                 if( (nCellFormat % SV_COUNTRY_LANGUAGE_OFFSET) != 0)
                     pFCell->SetNeedNumberFormat(false);
                 else
-                    pFCell->SetDirty(true);
+                    pFCell->SetDirtyVar();
 
                 pFCell->CompileXML( rProgress );
                 if ( nRow != maItems[i].nRow )


More information about the Libreoffice-commits mailing list