[Libreoffice-commits] core.git: 5 commits - chart2/source codemaker/source reportdesign/source

Norbert Thiebaud nthiebaud at gmail.com
Fri Jan 31 22:12:10 PST 2014


 chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx |   21 +++++-----
 chart2/source/controller/dialogs/tp_3D_SceneAppearance.cxx          |    9 ++--
 codemaker/source/javamaker/classfile.cxx                            |    7 ++-
 reportdesign/source/core/api/FixedLine.cxx                          |    2 
 reportdesign/source/ui/report/ReportController.cxx                  |    8 ++-
 5 files changed, 28 insertions(+), 19 deletions(-)

New commits:
commit 2c8193137abf7bb59e854f0aa675dfdad126974e
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Sat Feb 1 00:10:27 2014 -0600

    coverity#707676 : Uninitialized scalar field
    
    Change-Id: I546c3f497dc98c88a0d678622c20cced387a4ab2

diff --git a/codemaker/source/javamaker/classfile.cxx b/codemaker/source/javamaker/classfile.cxx
index c427e96..6673b2f 100644
--- a/codemaker/source/javamaker/classfile.cxx
+++ b/codemaker/source/javamaker/classfile.cxx
@@ -431,8 +431,11 @@ ClassFile::Code::Position ClassFile::Code::getPosition() const {
     return m_code.size();
 }
 
-ClassFile::Code::Code(ClassFile & classFile):
-    m_classFile(classFile), m_exceptionTableLength(0)
+ClassFile::Code::Code(ClassFile & classFile)
+    : m_classFile(classFile)
+    , m_maxStack(0)
+    , m_maxLocals(0)
+    , m_exceptionTableLength(0)
 {}
 
 void ClassFile::Code::ldc(sal_uInt16 index) {
commit 498c878ddc197c7b7da775f81f25aefa772c2df1
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Fri Jan 31 23:54:18 2014 -0600

    coverity#707670 : Uninitialized scalar field
    
    Change-Id: I8815381cc1a9801ff5f5ecfac06ada234d5bc363

diff --git a/chart2/source/controller/dialogs/tp_3D_SceneAppearance.cxx b/chart2/source/controller/dialogs/tp_3D_SceneAppearance.cxx
index f051b5f..7bc3a64 100644
--- a/chart2/source/controller/dialogs/tp_3D_SceneAppearance.cxx
+++ b/chart2/source/controller/dialogs/tp_3D_SceneAppearance.cxx
@@ -36,10 +36,11 @@ struct lcl_ModelProperties
     sal_Int32                 m_nObjectLines;
     ::chart::ThreeDLookScheme m_eScheme;
 
-    lcl_ModelProperties() :
-            m_nRoundedEdges(-1),
-            m_nObjectLines(-1),
-            m_eScheme(::chart::ThreeDLookScheme_Unknown)
+    lcl_ModelProperties()
+        : m_aShadeMode(drawing::ShadeMode_FLAT)
+        , m_nRoundedEdges(-1)
+        , m_nObjectLines(-1)
+        , m_eScheme(::chart::ThreeDLookScheme_Unknown)
     {}
 };
 
commit c74006b1c8420143679a6057c92942fa8a3a65ef
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Fri Jan 31 23:41:52 2014 -0600

    coverity#707668 : Uninitialized scalar field
    
    Change-Id: I3527de5f4a00d2fa2aa3b01a82d7c91a24547b86

diff --git a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
index 9b5b622..21b269a 100644
--- a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
@@ -484,16 +484,17 @@ void SAL_CALL DataSeriesPointWrapper::initialize( const uno::Sequence< uno::Any
         m_eType = DATA_SERIES;
 }
 
-DataSeriesPointWrapper::DataSeriesPointWrapper( eType _eType
-            , sal_Int32 nSeriesIndexInNewAPI
-            , sal_Int32 nPointIndex //ignored for series
-            , ::boost::shared_ptr< Chart2ModelContact > spChart2ModelContact )
-        : m_spChart2ModelContact( spChart2ModelContact )
-        , m_aEventListenerContainer( m_aMutex )
-        , m_eType( _eType )
-        , m_nSeriesIndexInNewAPI( nSeriesIndexInNewAPI )
-        , m_nPointIndex( (_eType == DATA_POINT) ? nPointIndex : -1 )
-        , m_xDataSeries(0)
+DataSeriesPointWrapper::DataSeriesPointWrapper( eType _eType,
+                                                sal_Int32 nSeriesIndexInNewAPI ,
+                                                sal_Int32 nPointIndex, //ignored for series
+                                                ::boost::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+    : m_spChart2ModelContact( spChart2ModelContact )
+    , m_aEventListenerContainer( m_aMutex )
+    , m_eType( _eType )
+    , m_nSeriesIndexInNewAPI( nSeriesIndexInNewAPI )
+    , m_nPointIndex( (_eType == DATA_POINT) ? nPointIndex : -1 )
+    , m_bLinesAllowed( sal_False )
+    , m_xDataSeries(0)
 {
 }
 
commit f68d5d5c8c7d865db0fbb7562ddd03076fbe605f
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Fri Jan 31 21:49:06 2014 -0600

    coverity#738780-79 : Uninitialized scalar field
    
    Change-Id: Ie8a986bb633a7d81f95b81eac5bf2879ccba2cb9

diff --git a/reportdesign/source/core/api/FixedLine.cxx b/reportdesign/source/core/api/FixedLine.cxx
index b3d0332..2b40055 100644
--- a/reportdesign/source/core/api/FixedLine.cxx
+++ b/reportdesign/source/core/api/FixedLine.cxx
@@ -131,6 +131,7 @@ OFixedLine::OFixedLine(uno::Reference< uno::XComponentContext > const & _xContex
 :FixedLineBase(m_aMutex)
 ,FixedLinePropertySet(_xContext,static_cast< Implements >(IMPLEMENTS_PROPERTY_SET),lcl_getLineOptionals())
 ,m_aProps(m_aMutex,static_cast< container::XContainer*>( this ),_xContext)
+,m_LineStyle( drawing::LineStyle_NONE )
 ,m_nOrientation(1)
 ,m_LineColor(0)
 ,m_LineTransparence(0)
@@ -147,6 +148,7 @@ OFixedLine::OFixedLine(uno::Reference< uno::XComponentContext > const & _xContex
 :FixedLineBase(m_aMutex)
 ,FixedLinePropertySet(_xContext,static_cast< Implements >(IMPLEMENTS_PROPERTY_SET),lcl_getLineOptionals())
 ,m_aProps(m_aMutex,static_cast< container::XContainer*>( this ),_xContext)
+,m_LineStyle( drawing::LineStyle_NONE )
 ,m_nOrientation(_nOrientation)
 ,m_LineColor(0)
 ,m_LineTransparence(0)
commit 11dc5895596b92fb34f99d2fdb7d1b266a51e9af
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Fri Jan 31 21:39:04 2014 -0600

    coverity#738781 : Uninitialized scalar field
    
    Change-Id: I85875bd817a94f7c1b457a85780329cf85a1c71d

diff --git a/reportdesign/source/ui/report/ReportController.cxx b/reportdesign/source/ui/report/ReportController.cxx
index bbaf748..5ff6428 100644
--- a/reportdesign/source/ui/report/ReportController.cxx
+++ b/reportdesign/source/ui/report/ReportController.cxx
@@ -282,9 +282,11 @@ OReportController::OReportController(Reference< XComponentContext > const & xCon
     ,m_aSelectionListeners( getMutex() )
     ,m_pClipbordNotifier(NULL)
     ,m_pGroupsFloater(NULL)
+    ,m_sMode("normal")
     ,m_nSplitPos(-1)
     ,m_nPageNum(-1)
     ,m_nSelectionCount(0)
+    ,m_nAspect(0)
     ,m_nZoomValue(100)
     ,m_eZoomType(SVX_ZOOM_PERCENT)
     ,m_bShowRuler(sal_True)
@@ -300,9 +302,9 @@ OReportController::OReportController(Reference< XComponentContext > const & xCon
     // new Observer
     m_pReportControllerObserver = new OXReportControllerObserver(*this);
     m_pReportControllerObserver->acquire();
-
-    m_sMode = "normal";
-    registerProperty(OUString("ZoomValue"),PROPERTY_ID_ZOOMVALUE,beans::PropertyAttribute::BOUND| beans::PropertyAttribute::TRANSIENT,&m_nZoomValue,::getCppuType(static_cast< sal_Int16*>(0)));
+    registerProperty(OUString("ZoomValue"), PROPERTY_ID_ZOOMVALUE,
+                     beans::PropertyAttribute::BOUND | beans::PropertyAttribute::TRANSIENT,
+                     &m_nZoomValue, ::getCppuType(static_cast< sal_Int16*>(0)));
 
 }
 // -----------------------------------------------------------------------------


More information about the Libreoffice-commits mailing list