[Libreoffice-commits] mso-dumper.git: msodumper/xlsrecord.py

[Kohei Yoshida]

 msodumper/xlsrecord.py |   14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

New commits:
commit 74da3c1eb42590856f286091b55ce13dd7c03fc3
Author: Kohei Yoshida <kohei.yoshida at gmail.com>
Date:   Fri Jul 11 20:58:24 2014 -0400

    Bit of cleanup.

diff --git a/msodumper/xlsrecord.py b/msodumper/xlsrecord.py
index 81c42f1..b41be00 100644
--- a/msodumper/xlsrecord.py
+++ b/msodumper/xlsrecord.py
@@ -4229,6 +4229,7 @@ class RRDChgCell(BaseRecordHandler):
             # TODO : Parse DXFN
             return
 
+        # old value
         if self.vtOld == RRDChgCell.CellType.Blank:
             pass
         elif self.vtOld == RRDChgCell.CellType.RKNumber:
@@ -4241,10 +4242,8 @@ class RRDChgCell(BaseRecordHandler):
             self.besOld = Bes(self)
         elif self.vtOld == RRDChgCell.CellType.CellParsedFormula:
             self.xpeOld = CellParsedFormula(self)
-        else:
-            # TODO : Handle other value types.
-            return
 
+        # new value
         if self.vt == RRDChgCell.CellType.Blank:
             pass
         elif self.vt == RRDChgCell.CellType.RKNumber:
@@ -4257,9 +4256,6 @@ class RRDChgCell(BaseRecordHandler):
             self.bes = Bes(self)
         elif self.vt == RRDChgCell.CellType.CellParsedFormula:
             self.xpe = CellParsedFormula(self)
-        else:
-            # TODO : Handle other value types.
-            return
 
     def parseBytes (self):
         self.__parseBytes()
@@ -4285,6 +4281,7 @@ class RRDChgCell(BaseRecordHandler):
             # TODO : Parse DXFN.
             return
 
+        # old value
         if self.vtOld == RRDChgCell.CellType.Blank:
             self.appendLine("old value: blank")
         elif self.vtOld == RRDChgCell.CellType.RKNumber:
@@ -4297,9 +4294,8 @@ class RRDChgCell(BaseRecordHandler):
             self.appendLineString("old value", self.besOld.toString())
         elif self.vtOld == RRDChgCell.CellType.CellParsedFormula:
             self.appendLineString("old value", self.xpeOld.toString())
-        else:
-            return
 
+        # new value
         if self.vt == RRDChgCell.CellType.Blank:
             self.appendLine("new value: blank")
         elif self.vt == RRDChgCell.CellType.RKNumber:
@@ -4312,8 +4308,6 @@ class RRDChgCell(BaseRecordHandler):
             self.appendLineString("new value", self.bes.toString())
         elif self.vt == RRDChgCell.CellType.CellParsedFormula:
             self.appendLineString("new value", self.xpe.toString())
-        else:
-            return
 
 
 class RRDInsDel(BaseRecordHandler):