[Libreoffice-commits] core.git: Branch 'libreoffice-4-3-0' - sc/source

Kohei Yoshida kohei.yoshida at collabora.com
Tue Jul 15 09:08:03 PDT 2014


 sc/source/ui/docshell/dbdocfun.cxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 628f27b42a5911288e15ae9edf182578dd32a4da
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date:   Sat Jul 12 21:46:13 2014 -0400

    fdo#80462: Don't always increment the start row position.
    
    Sometimes someone might attempt to sort only a single row.
    
    Change-Id: Ie29d4cf7ec0bd3a5c945997083368b6ef6074268
    (cherry picked from commit 5902dcf0995cdd0a6c1dbd1f9c21b0b2b3f5609f)
    Reviewed-on: https://gerrit.libreoffice.org/10259
    Reviewed-by: Eike Rathke <erack at redhat.com>
    Tested-by: Eike Rathke <erack at redhat.com>
    (cherry picked from commit ee5895488c43954b25b26076ec9241e7c741cffd)
    Reviewed-on: https://gerrit.libreoffice.org/10273
    Reviewed-by: Muthu Subramanian K <muthusuba at gmail.com>
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>
    Tested-by: Markus Mohrhard <markus.mohrhard at googlemail.com>

diff --git a/sc/source/ui/docshell/dbdocfun.cxx b/sc/source/ui/docshell/dbdocfun.cxx
index deaf244..8238b9a 100644
--- a/sc/source/ui/docshell/dbdocfun.cxx
+++ b/sc/source/ui/docshell/dbdocfun.cxx
@@ -490,7 +490,9 @@ bool ScDBDocFunc::Sort( SCTAB nTab, const ScSortParam& rSortParam,
 
     WaitObject aWait( rDocShell.GetActiveDialogParent() );
 
-    SCROW nStartRow = aLocalParam.nRow1 + (aLocalParam.bHasHeader ? 1 : 0);
+    SCROW nStartRow = aLocalParam.nRow1;
+    if (aLocalParam.bByRow && aLocalParam.bHasHeader && nStartRow < aLocalParam.nRow2)
+        ++nStartRow;
 
     // Calculate the script types for all cells in the sort range beforehand.
     // This will speed up the row height adjustment that takes place after the


More information about the Libreoffice-commits mailing list