[Libreoffice-commits] core.git: Changes to 'feature/calctiledrendering5'

Andrzej Hunt andrzej.hunt at collabora.com
Sat Jul 26 06:54:22 PDT 2014


New branch 'feature/calctiledrendering5' available with the following commits:
commit d3fca838b2af585a38f48ae4c389e15075e766a6
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Fri Jul 25 21:03:19 2014 +0200

    Make sure LOK is actually headless.
    
    This prevents e.g. the document recovery dialog from trying to be shown.
    
    Change-Id: I253720f7fa1abd1c053670434f8394473517b670

commit 579b5a3da20218cf786ee0cc17feec7c1a26e3e4
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Fri Jul 25 20:56:18 2014 +0200

    Don't fail on --protector.
    
    If we have any "unknown" command line arguments Desktop init will fail,
    however our LOK Tiled Rendering test uses Desktop (via soffice_main).
    (Other unit tests don't use soffice_main hence this check never
    comes into play.) It looks like it's most reliable simply to ignore
    --protector here, rather than try to filter it out elsewhere (which
    is difficult as it is passed to osl via SAL_IMPLEMENT_MAIN).
    
    Change-Id: I95d047892851ba2cf9edd2e26bacc6efa0320f71

commit 54e6731ac839250ab2dba68cfaae4489067f21fc
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Fri Jul 25 20:54:40 2014 +0200

    Revert "DON'T USE: ignore unknown args instead of failure."
    
    This reverts commit 8ffe7f2b93620112319981957ab6bc27c0d4738d.

commit 3e49397b1a76b00209e5887b8c2f5119b8082e32
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Thu Jul 24 21:38:12 2014 +0200

    We're using the same rectangle for both calls, lets reuse it.
    
    Change-Id: I884832fc92e0fe9c10711d9fdaf103076a05f721

commit 799d1a7c36e3a031e06c286e3a6c19cfe78d5c82
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Thu Jul 24 21:27:43 2014 +0200

    libreofficekit_tilederendering: test all 4 tiles.
    
    The use of VisPortChgd ensures that the tiles all render as
    expected, i.e. that the pixels match 1:1 irrespective of actual tile
    size (for identical zoom factors and document areas).
    
    Change-Id: Ib1e1df4f8257546c2f7993a8160c309a52037d8b

commit b5cb3cf52674d6f3562fd5344e593012f260749f
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Thu Jul 24 21:15:49 2014 +0200

    Tiled Rendering: ensure rendered area is visible without repaint.
    
    Change-Id: I8d206ab201167ea96a0ac853187861e8c3d541e5

commit 6f5f85300d853a34a6ada3057ec0281481bfb370
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Thu Jul 24 14:34:49 2014 +0200

    Revert "Tiled Rendering: ensure rendered area is visible."
    
    This reverts commit ff6a38b76df80d0f907f2f92cb851dea43c91d81.

commit 05f082dd45deb23d76410685c6c38e58d2a2d7fb
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Wed Jul 23 20:17:11 2014 +0200

    Revert "Use DLPre/PostPaint2 for Tiled Rendering (ensures viewport is set)."
    
    This reverts commit 1deb9f267d0cfe29d88166121f9dd4dd2416f5dc.

commit 1deb9f267d0cfe29d88166121f9dd4dd2416f5dc
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Wed Jul 23 08:03:45 2014 +0200

    Use DLPre/PostPaint2 for Tiled Rendering (ensures viewport is set).
    
    Without this we don't necessarily set the correct rendering region for
    our underlying SDRPageWindow, which can cause problems with rendering
    (i.e. the same region might not be painted identically for two
     overlapping tiles -- specifically the page borders seem to be drawn
     differently depending on whether the redraw region is set to be the
     same as the tile area -- with correctly set region, the page borders
     are always drawn the same and thus match as expected ).
    
    This was also causing an assert to fire when sometimes we would
    end up with an empty redraw region (and thus empty viewport in
    SwVirtFlyDrawObj).
    
    See:
    fb0b42b89af95b42cc6caadf8c22321e5c9386e8
    (now reverted)
    
    Change-Id: Ie0e46e571414f282699899371d3df8c7056021f6

commit bf42c36dcd45818f8efde5df59929e94290f68a0
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Mon Jul 21 21:16:09 2014 +0200

    Don't start Impress Remote server in headless mode.
    
    Change-Id: Ibafe57413a60745e949dc3146fbc843c52c029d6

commit 6d7981074b2cde4d305e4c71ee77ad5d676bd645
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Mon Jul 21 21:15:39 2014 +0200

    Lets not roll our own twip/mm100 conversions.
    
    Change-Id: Id1d0c2bed0359c35086d963dcfe9b765b6232b09

commit ef583698d9508eeea29bf52f745673ecd49206d3
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Mon Jul 21 21:13:15 2014 +0200

    Add Point and Size versions of convertMm100ToTwip/TwipToMm100.
    
    There seem to be quite a few cases where the individual components
    are being converted, this way we can just conver the entire
    object as one.
    
    Change-Id: I0043b6f40520d7497e6edc185187706b255f2354

commit 8ffe7f2b93620112319981957ab6bc27c0d4738d
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Mon Jul 21 19:46:16 2014 +0200

    DON'T USE: ignore unknown args instead of failure.
    
    The --protector flag ends up here in unit tests, which causes things
    to fail -- either we need to make --protector known, or filter
    it out before hand -- whereby I suspect filtering it out would be
    difficult to do in a reliable fashion.
    
    Change-Id: Iab47a6e24723604df75def2b963e82ba6479318e

commit f9b5b6a3ba9801f1becf5009f247ae7e5d1a79ce
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Mon Jul 21 19:39:49 2014 +0200

    gtktiledviewer: make sure we clean up the office instance.
    
    Change-Id: I12c3e9df8b8fcf8dcd6fb5fa781c2f7c10ab0a0c

commit 04d2906af2d29b18712eea31ef97f13e5186045b
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Mon Jul 21 19:36:11 2014 +0200

    Use gb_CppunitTest_use_confpreinit for LOK tiled rendering.
    
    Now that we use the event loop for LOK we need to make sure that
    it is able to run successfully first time, as unit tests start
    with a completely clean config.
    
    Change-Id: If9ddcb75fe8286381d71ecdc76ac7eb3697960d0

commit 166fe536be093cc24365b355d68b604fe8d46a1e
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Mon Jul 21 19:35:13 2014 +0200

    Add gb_CppunitTest_use_confpreinit:
    
    For unit tests that use the VCL event loop we can use this to
    avoid the otherwise required restart.
    
    Change-Id: I48265d7e7188a4efaa6f87432c762320331c0c78

commit e5607bb364fa916302c7f465129a1f3c2f9f85b2
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Mon Jul 21 19:34:09 2014 +0200

    Implement lokconf_init.
    
    This is a simple executable which can be used to ensure there is a
    pe-pared configuration for unit-tests to avoid the usually required
    re-start on the first run.
    
    Change-Id: I49b706e8daa93bc34db508a24615b63b9babddba

commit 3b88f95c0950629fb07876112519636b08823946
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Fri Jul 18 13:12:25 2014 +0200

    Fail LOK initialisation if restart is required.
    
    Change-Id: Ia13a3523666147f002b5a5177fd6962d55556f56

commit 91d3f92ff49924f70305accdc79fab714804d457
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Fri Jul 18 13:10:14 2014 +0200

    Add OfficeIPCThread::IsEnabled.
    
    This lets us easily check whether Desktop::Main has shut down,
    i.e. which happens on the first restart-requiring initialisation.
    
    Change-Id: I7fe5699a4bf59e2c3b891ac73abd9b147773d22e

commit 55b574c117977081b3da3fa2b89f1cb183837318
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Fri Jul 18 10:02:48 2014 +0200

    Use OfficeIPCThread::WaitForReady rather than sleeping.
    
    This way we actually continue when we're ready to, rather than
    dumbly hoping we wait for long enough.
    
    This isn't entirely unproblematic though -- if we have no config
    pre-prepared (i.e. first-run), then we just end up hanging on this
    since soffice_main exits without doing anything to the OfficeIPCThread.
    (Which is especially problematic for unit tests which specifically run
     on an empty config.)
    
    Change-Id: I064fb500a224cfe37a0d3ba24b6154ffd72a71a3

commit 19a8113f1f48765de92d0140191564739df43f9d
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Fri Jul 18 10:00:42 2014 +0200

    Bin outdated / incorrect comment.
    
    Change-Id: I7b8f97377b9606a2228f172f772d8051a64703d2

commit 2115dddd6ef81a148befce12f16459474964c927
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Fri Jul 18 09:48:47 2014 +0200

    Add OfficeIPCThread::WaitForReady.
    
    For LibreOfficeKit we need to start up the event loop, and can't continue
    initialisation until all the related (VCL etc.) setup is complete -- the
    OfficeIPCThread is also enabled as one of the last items, and can be
    used to indicate whether or not we can start actually working with VCL.
    
    Change-Id: I0450b65584ddf6e8d02ce0c6e66e06f47841d1b7

commit 3d9919dac283060de2433371539c6150b530774a
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Thu Jul 17 20:20:24 2014 +0200

    libreofficekit_tiledrendering test: force lock file removal
    
    If the lock file still exists when running this test, LOK will fail
    resulting in "documentLoad failed: unknown load failure"
    (the actual error is that the lock file dialog cannot be confirmed
     by the user in headless mode, resulting in loading failure, however
     this is then hidden by multiple layers of exception redirection
     in sfx2).
    
    Change-Id: I025ea6187c3d17805f25ab6f756eae9646f2c7c8

commit 552ac78e8529a9d052f376a080e00d15f460689c
Author: Matúš Kukan <matus.kukan at collabora.com>
Date:   Thu Jul 17 10:35:49 2014 +0200

    Fix some CppunitTest_libreofficekit_tiledrendering related problems
    
    Change-Id: Icdcde0af1b3d5744ef2842e4b4d2b85a094ac686

commit 88f36212b2d55e6ba176a332b73b6cd1ddda5702
Author: Jan Holesovsky <kendy at collabora.com>
Date:   Wed Jul 16 19:36:53 2014 +0200

    LibreOfficeKit: Check for libmerged too.
    
    And avoid some strcat's when at it.
    
    Change-Id: I0c70ee2a1abf0c9e2914f756b06bedc3a16df19b

commit a63c40a450efd9f33fac3df47f1df559ee72cfc6
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Thu Jul 17 16:13:49 2014 +0200

    DO NOT MERGE YET: hack soffice_main into LOK.
    
    Change-Id: I86e13192ddb5904afabca38d3a201f17f145de09

commit 5b8555a5f2202497904745b38bb3731d1cb1f4c9
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Tue Jul 15 09:50:47 2014 +0200

    Render slides by default.
    
    We should probably introduce an API to allow selecting notes instead, however
    the default mode is to open whichever view we had open last for a given
    document -- whereas for nowwe probably always want to render the slides.
    
    Change-Id: I26540613d1a510f23e5abfc8fee2ad743c180f34

commit fc6ad4cd33e3c98c3b634949502a477a54e4bfd8
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Tue Jul 15 09:49:24 2014 +0200

    Allow setting DrawViewShell PageKind directly.
    
    Currently the only way to change the PageKind is via the UI controls
    (i.e. via ExecCtrl) -- however for tiled rendering we want to select
    the PageKind directly.
    
    Change-Id: I3a3fa8f8cefaa0e0212832aef4026433fc596263

commit f831f00e1e10b57029225bf738f163f5a63a30be
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Mon Jul 14 13:12:56 2014 +0200

    LOK tiled rendering test: add some debug output.
    
    Change-Id: I0da29204809b6a1de42d5f0fc37705497a060493

commit 23f6b471de164643a5b22cb76b855317def6c0ab
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Sat Jul 12 05:45:28 2014 +0200

    GtkComboBoxText requires gtk >= 2.24.
    
    Seeing as this is only a test program, probably easiest just to disable
    this for gtk < 2.24, and rely on devs wanting to use it isntalling a new
    enough gtk version.

commit 7dede71c61ac16ce0012362d138d9137ff8027b1
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Fri Jul 11 16:35:58 2014 +0200

    More pixel->document coordinate scaling.
    
    Change-Id: Iea3877c024d66fa6b80d447c749246148f2dc11d

commit 609b53eeaeb1180d6245013002183eb2e3736272
Author: Andrzej Hunt <andrzej.hunt at collabora.com>
Date:   Fri Jul 11 10:23:15 2014 +0200

    Add png dumping to LOK tiled rendering test.
    
    This allows for easier visual comparisons (i.e. currently the test
    would be failing for some tiles).
    
    Change-Id: I5b174375b57ffe0edd2700fdec411a83669e4a34



More information about the Libreoffice-commits mailing list