[Libreoffice-commits] core.git: 5 commits - filter/source jurt/source sd/source writerfilter/source

Caolán McNamara caolanm at redhat.com
Wed Jun 4 07:14:03 PDT 2014


 filter/source/msfilter/svdfppt.cxx                                  |    4 ++++
 jurt/source/pipe/com_sun_star_lib_connections_pipe_PipeConnection.c |    1 +
 sd/source/filter/eppt/eppt.cxx                                      |    1 +
 writerfilter/source/dmapper/DomainMapper.cxx                        |    1 +
 4 files changed, 7 insertions(+)

New commits:
commit 322da54d74cfff7881f25d4ad41d95328f5205d4
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Jun 4 14:52:53 2014 +0100

    coverity#705337 Missing break in switch, probably not intentional
    
    Change-Id: I9bfb694c4034f01d93f35f0f7e72263909245811

diff --git a/writerfilter/source/dmapper/DomainMapper.cxx b/writerfilter/source/dmapper/DomainMapper.cxx
index 8ccba78..fb4a5dc 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -2679,6 +2679,7 @@ void DomainMapper::lcl_text(const sal_uInt8 * data_, size_t len)
                     return;
                 case 0x07:
                     m_pImpl->getTableManager().text(data_, len);
+                    return;
                 case 0x0d:
                     m_pImpl->finishParagraph(m_pImpl->GetTopContextOfType(CONTEXT_PARAGRAPH));
                     return;
commit 38ad9104efa09bab79fc65d64bd33ae750b28027
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Jun 4 14:27:42 2014 +0100

    coverity#1209650 Missing break in switch, probably intentional
    
    Change-Id: Iaa48a39cc86548dd2805703a97a90406663099ba

diff --git a/sd/source/filter/eppt/eppt.cxx b/sd/source/filter/eppt/eppt.cxx
index 77db284..e8165a9 100644
--- a/sd/source/filter/eppt/eppt.cxx
+++ b/sd/source/filter/eppt/eppt.cxx
@@ -194,6 +194,7 @@ void PPTWriter::ImplWriteSlide( sal_uInt32 nPageNum, sal_uInt32 nMasterNum, sal_
         {
             case 1 :        // automatic
                 mnDiaMode++;
+                // fall-through
             case 2 :        // semi-automatic
                 mnDiaMode++;
             default :
commit 57d6b95ce67719acd0b32a8ac0037c80e3aaaa0b
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Jun 4 13:20:01 2014 +0100

    coverity#705168 Missing break in switch
    
    Change-Id: I2fd40972e59fa55df48e48851315350fb012cdec

diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx
index e2fe2d8..7a956a0 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -6383,6 +6383,7 @@ PPTTextObj::PPTTextObj( SvStream& rIn, SdrPowerPointImport& rSdrPowerPointImport
                 {
                     case PPT_NOTEPAGE :
                         nInstance++;
+                        // fall-through
                     case PPT_MASTERPAGE :
                         nInstance++;
                     case PPT_SLIDEPAGE :
commit 6e581cc2515aeb4d19cda2a523598045b3ce3201
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Jun 4 13:17:13 2014 +0100

    coverity#705172 Missing break in switch
    
    Change-Id: I23663877212be93bffe16edfa4b0bb70c8ef5e2e

diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx
index 0c97eb3..e2fe2d8 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -738,8 +738,11 @@ SdrObject* SdrEscherImport::ProcessObj( SvStream& rSt, DffObjData& rObjData, voi
                             switch ( aPlaceholderAtom.nPlaceholderId )
                             {
                                 case PPT_PLACEHOLDER_MASTERSLIDENUMBER :    nHeaderFooterInstance++;
+                                // fall-through
                                 case PPT_PLACEHOLDER_MASTERFOOTER :         nHeaderFooterInstance++;
+                                // fall-through
                                 case PPT_PLACEHOLDER_MASTERHEADER :         nHeaderFooterInstance++;
+                                // fall-through
                                 case PPT_PLACEHOLDER_MASTERDATE :           nHeaderFooterInstance++; break;
                             }
                             if ( ! ( nHeaderFooterInstance & 0xfffc ) )     // is this a valid instance ( 0->3 )
commit b2c987f1a74e9f7bf6a0b8d32669e78d7eb3fcdd
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Jun 4 13:10:41 2014 +0100

    coverity#705190 Missing break in switch
    
    Change-Id: Icf74b016a05999814ae234caf850c808da23ce96

diff --git a/jurt/source/pipe/com_sun_star_lib_connections_pipe_PipeConnection.c b/jurt/source/pipe/com_sun_star_lib_connections_pipe_PipeConnection.c
index face82e..d47bfa0 100644
--- a/jurt/source/pipe/com_sun_star_lib_connections_pipe_PipeConnection.c
+++ b/jurt/source/pipe/com_sun_star_lib_connections_pipe_PipeConnection.c
@@ -432,6 +432,7 @@ JNICALL Java_com_sun_star_lib_connections_pipe_PipeConnection_readJNI
     {
         case GOTBUFFER:
             free(nbuff);
+            /* fall-through */
         case INMONITOR:
             (*env)->MonitorExit(env, obj_this);
         case START:


More information about the Libreoffice-commits mailing list