[Libreoffice-commits] core.git: 20 commits - connectivity/source dbaccess/source filter/source hwpfilter/source sc/source sd/source sfx2/source svtools/source svx/source sw/source toolkit/source
Caolán McNamara
caolanm at redhat.com
Thu Jun 5 05:36:22 PDT 2014
connectivity/source/parse/sqlnode.cxx | 1 +
dbaccess/source/ui/misc/HtmlReader.cxx | 1 +
dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx | 1 +
dbaccess/source/ui/tabledesign/TableDesignControl.cxx | 1 +
filter/source/graphicfilter/ios2met/ios2met.cxx | 2 ++
filter/source/graphicfilter/ipbm/ipbm.cxx | 3 +++
filter/source/msfilter/svdfppt.cxx | 2 ++
hwpfilter/source/formula.cxx | 2 ++
hwpfilter/source/hwpreader.cxx | 2 ++
sc/source/filter/dif/difimp.cxx | 1 +
sc/source/filter/excel/excform.cxx | 4 ++++
sc/source/ui/formdlg/dwfunctr.cxx | 2 +-
sd/source/core/drawdoc4.cxx | 1 +
sfx2/source/control/thumbnailview.cxx | 1 +
svtools/source/svhtml/parhtml.cxx | 1 +
svx/source/fmcomp/gridctrl.cxx | 1 +
sw/source/filter/html/swhtml.cxx | 1 +
toolkit/source/awt/vclxwindows.cxx | 2 +-
18 files changed, 27 insertions(+), 2 deletions(-)
New commits:
commit 231ae9c77c67197bba23efd2a7fd1c8b79926765
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 10:36:22 2014 +0100
coverity#1158175 Missing break in switch, assuming its intentional
Change-Id: Ia0f1951f1e3edcd858a37ea091550feb2b9fd451
diff --git a/connectivity/source/parse/sqlnode.cxx b/connectivity/source/parse/sqlnode.cxx
index 73bbbb9..af21509 100644
--- a/connectivity/source/parse/sqlnode.cxx
+++ b/connectivity/source/parse/sqlnode.cxx
@@ -502,6 +502,7 @@ void OSQLParseNode::impl_parseNodeToString_throw(OUStringBuffer& rString, const
}
bHandled = true;
}
+ //fall-through
case odbc_call_spec:
case subquery:
case term:
commit 32c37a7ae0b369356af0036fd22fd9c56d1a4a6f
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 10:33:49 2014 +0100
coverity#1103693 Missing break in switch, assuming its intentional
Change-Id: Ie61305f367e2a07a61599433bd83e1ea13bffd71
diff --git a/dbaccess/source/ui/misc/HtmlReader.cxx b/dbaccess/source/ui/misc/HtmlReader.cxx
index c57a852..67556a3 100644
--- a/dbaccess/source/ui/misc/HtmlReader.cxx
+++ b/dbaccess/source/ui/misc/HtmlReader.cxx
@@ -148,6 +148,7 @@ void OHTMLReader::NextToken( int nToken )
}
}
}
+ //fall-through
case HTML_THEAD_ON:
case HTML_TBODY_ON:
{
commit c2ddb22da9aaa208d7e4226c21ea16b2ad3b07a9
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 10:24:30 2014 +0100
coverity#1103692 Missing break in switch, assuming its intentional
Change-Id: I32450546541b15a974f28a78604a136cebb71c3c
diff --git a/sw/source/filter/html/swhtml.cxx b/sw/source/filter/html/swhtml.cxx
index 9521a19..1319faa 100644
--- a/sw/source/filter/html/swhtml.cxx
+++ b/sw/source/filter/html/swhtml.cxx
@@ -1229,6 +1229,7 @@ void SwHTMLParser::NextToken( int nToken )
case HTML_UNKNOWNCONTROL_OFF:
if( aUnknownToken != sSaveToken )
return;
+ //fall-through
case HTML_FRAMESET_ON:
case HTML_HEAD_OFF:
case HTML_BODY_ON:
commit a2d2c6d6bdc328683d959573404e6d0d405c75f0
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 10:23:27 2014 +0100
coverity#1103688 Missing break in switch, assuming its intentional
Change-Id: I9b619e4896d811c2fbb20e229f65bfa01bd05731
diff --git a/svtools/source/svhtml/parhtml.cxx b/svtools/source/svhtml/parhtml.cxx
index c9d70c9..7b04001 100644
--- a/svtools/source/svhtml/parhtml.cxx
+++ b/svtools/source/svhtml/parhtml.cxx
@@ -1599,6 +1599,7 @@ int HTMLParser::FilterPRE( int nToken )
// in Netscape they only have impact in not empty paragraphs
case HTML_PARABREAK_ON:
nToken = HTML_LINEBREAK;
+ //fall-through
case HTML_LINEBREAK:
case HTML_NEWPARA:
nPre_LinePos = 0;
commit 2484cda486334841fdfe92c82a8a7bf026e28768
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 10:19:11 2014 +0100
coverity#1000658 Missing break in switch, assuming its intentional
Change-Id: Id208942e98c8b8fc685aa77c3c11468ed2af832d
diff --git a/sfx2/source/control/thumbnailview.cxx b/sfx2/source/control/thumbnailview.cxx
index a392075..c34e2b6 100644
--- a/sfx2/source/control/thumbnailview.cxx
+++ b/sfx2/source/control/thumbnailview.cxx
@@ -621,6 +621,7 @@ void ThumbnailView::KeyInput( const KeyEvent& rKEvt )
if ( bFoundLast )
OnItemDblClicked( mFilteredItemList[nLastPos] );
}
+ //fall-through
default:
Control::KeyInput( rKEvt );
}
commit abf842e4b125b9f863ea4c2af17ad6ac7d82b15e
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 10:16:52 2014 +0100
coverity#705323 Missing break in switch, assuming its intentional
Change-Id: Ibb8fe4e1d13a24f810fbdf4978606c35890a9cfd
diff --git a/toolkit/source/awt/vclxwindows.cxx b/toolkit/source/awt/vclxwindows.cxx
index 9016b04..9752b37 100644
--- a/toolkit/source/awt/vclxwindows.cxx
+++ b/toolkit/source/awt/vclxwindows.cxx
@@ -2938,7 +2938,7 @@ void VCLXFixedHyperlink::ProcessWindowEvent( const VclWindowEvent& rVclWindowEve
}
}
}
-
+ //fall-through
default:
VCLXWindow::ProcessWindowEvent( rVclWindowEvent );
break;
commit 91eeea0cdf5e2bd7d6cd05348a8f777707fd69cc
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 10:14:56 2014 +0100
coverity#705261 Missing break in switch, assuming its intentional
Change-Id: Ia19f7790871dec7022c5d1f57f082638b70403fb
diff --git a/svx/source/fmcomp/gridctrl.cxx b/svx/source/fmcomp/gridctrl.cxx
index a85f86c..fd54088 100644
--- a/svx/source/fmcomp/gridctrl.cxx
+++ b/svx/source/fmcomp/gridctrl.cxx
@@ -2806,6 +2806,7 @@ void DbGridControl::Command(const CommandEvent& rEvt)
return;
}
}
+ //fall-through
default:
DbGridControl_Base::Command(rEvt);
}
commit a4d416a7c896b3973eef0486ae49ff7091513074
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 10:13:17 2014 +0100
coverity#705182 Missing break in switch, assuming its intentional
Change-Id: Ib8d2bc5a5772f6611f9d977376f6fef9505c6a59
diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index 82f9bd5..81779e0 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -3373,6 +3373,7 @@ void HwpReader::makeDateFormat(DateCode * hbox)
break;
case '_':
padd(ascii("number:style"), sXML_CDATA, ascii("long"));
+ //fall-through
case '6':
case '^':
rstartEl(ascii("number:day-of-week"), rList);
commit 402c55e510a1e25f318b91639ead8cca30fd4a36
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 10:12:49 2014 +0100
coverity#705181 Missing break in switch, assuming its intentional
Change-Id: I2b83f3e5a4fb65819244b88fdad7e48fe918b4bd
diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index 6cad266..82f9bd5 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -1796,6 +1796,7 @@ void HwpReader::makeColumns(ColumnDef *coldef)
{
case 1: /* ì–‡ì€ì„ */
padd(ascii("style:width"), sXML_CDATA, ascii("0.02mm"));
+ //fall-through
case 3: /* ì ì„ */
padd(ascii("style:style"), sXML_CDATA, ascii("dotted"));
padd(ascii("style:width"), sXML_CDATA, ascii("0.02mm"));
commit ef6e89155b109c742b4c94c907fc2e19be2baf6a
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 10:11:52 2014 +0100
coverity#705178 Missing break in switch, assuming its intentional
Change-Id: I3f0b7796b4ea28c55255327ccf5b2d523ecca053
diff --git a/hwpfilter/source/formula.cxx b/hwpfilter/source/formula.cxx
index 52bf27a..2bb52d9 100644
--- a/hwpfilter/source/formula.cxx
+++ b/hwpfilter/source/formula.cxx
@@ -180,8 +180,10 @@ void Formula::makeExpr(Node *res)
break;
case ID_BLOCK:
makeBlock(tmp);
+ //fall-through
case ID_BEGIN:
makeBegin(tmp);
+ //fall-through
case ID_END:
makeEnd(tmp);
break;
commit 699c171755ed8019ab8396c2cc837672f22ae4a7
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 10:10:10 2014 +0100
coverity#705169 Missing break in switch, assuming its intentional
Change-Id: Ib1d237591bd9cac1d4b81a04b753b2cf2c9759dd
diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx
index 7a956a0..bfa7eb4 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -6271,11 +6271,13 @@ void PPTFieldEntry::GetDateTime( const sal_uInt32 nVal, SvxDateFormat& eDateForm
break;
case 7:
eDateFormat = SVXDATEFORMAT_A;
+ //fall-through
case 9:
eTimeFormat = SVXTIMEFORMAT_24_HM;
break;
case 8:
eDateFormat = SVXDATEFORMAT_A;
+ //fall-through
case 11:
eTimeFormat = SVXTIMEFORMAT_12_HM;
break;
commit 18c7731bade6b5f9ac90faf7c9d36f0558e74ff6
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 10:08:25 2014 +0100
coverity#705164 Missing break in switch, assuming its intentional
Change-Id: I5cc112d7eb367f5dfe17fc39e3ef47784ae67e9b
diff --git a/filter/source/graphicfilter/ipbm/ipbm.cxx b/filter/source/graphicfilter/ipbm/ipbm.cxx
index e9b4809..01ebe5c 100644
--- a/filter/source/graphicfilter/ipbm/ipbm.cxx
+++ b/filter/source/graphicfilter/ipbm/ipbm.cxx
@@ -170,6 +170,7 @@ bool PBMReader::ImplReadHeader()
{
case '1' :
mbRaw = false;
+ //fall-through
case '4' :
mnMode = 0;
nMax = 2; // number of parameters in Header
@@ -177,12 +178,14 @@ bool PBMReader::ImplReadHeader()
break;
case '2' :
mbRaw = false;
+ //fall-through
case '5' :
mnMode = 1;
nMax = 3;
break;
case '3' :
mbRaw = false;
+ //fall-through
case '6' :
mnMode = 2;
nMax = 3;
commit 9e9c75cc2e15bcfd5e31c2a32a5168686e80c0b7
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 10:06:44 2014 +0100
coverity#705162 Missing break in switch, assuming its intentional
Change-Id: I3e0658ec26392abf5ad8de53d282b9cc35205025
diff --git a/filter/source/graphicfilter/ios2met/ios2met.cxx b/filter/source/graphicfilter/ios2met/ios2met.cxx
index aed623e..1a386e5 100644
--- a/filter/source/graphicfilter/ios2met/ios2met.cxx
+++ b/filter/source/graphicfilter/ios2met/ios2met.cxx
@@ -706,9 +706,11 @@ void OS2METReader::SetPen( const Color& rColor, sal_uInt16 nLineWidth, PenStyle
break;
case PEN_DASHDOT :
nDashCount++;
+ //fall-through
case PEN_DOT :
nDotCount++;
nDashCount--;
+ //fall-through
case PEN_DASH :
nDashCount++;
aLineInfo.SetDotCount( nDotCount );
commit 8d1063ce1eb94014a72ceabf46f0eb698c5d24b0
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 10:05:42 2014 +0100
coverity#705147 Missing break in switch, assuming its intentional
Change-Id: I9041f18eb4aae73b795245c589b28a3d02d8397e
diff --git a/dbaccess/source/ui/tabledesign/TableDesignControl.cxx b/dbaccess/source/ui/tabledesign/TableDesignControl.cxx
index e34c108..0cb8cdc 100644
--- a/dbaccess/source/ui/tabledesign/TableDesignControl.cxx
+++ b/dbaccess/source/ui/tabledesign/TableDesignControl.cxx
@@ -158,6 +158,7 @@ void OTableRowView::Command(const CommandEvent& rEvt)
}
}
+ //fall-through
default:
EditBrowseBox::Command(rEvt);
}
commit 65f1fcce567fbeb7be78421f40f9be9f1f576fd6
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 10:04:50 2014 +0100
coverity#705146 Missing break in switch, assuming its intentional
Change-Id: I09a2cacc3aa18796c06a1f1cc9315b3628865621
diff --git a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
index 26a156d..5d76c21 100644
--- a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
+++ b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
@@ -2010,6 +2010,7 @@ void OSelectionBrowseBox::Command(const CommandEvent& rEvt)
return;
}
}
+ //fall-through
default:
EditBrowseBox::Command(rEvt);
}
commit b370077f779ba966372e4f94eb1cf9cf8f8f8087
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 09:58:57 2014 +0100
coverity#736046 Missing break in switch
Change-Id: I1680d21b8f123ec1d937d699edee62b8ff0d6058
diff --git a/sc/source/filter/excel/excform.cxx b/sc/source/filter/excel/excform.cxx
index 8c9986b3..74f14a2 100644
--- a/sc/source/filter/excel/excform.cxx
+++ b/sc/source/filter/excel/excform.cxx
@@ -1004,6 +1004,7 @@ ConvErr ExcelToSc::Convert( _ScRangeListTabs& rRangeList, XclImpStream& aIn, sal
case EXC_BIFF3:
case EXC_BIFF4: nIgnore = 10; break;
case EXC_BIFF5: DBG_WARNING( "-ExcelToSc::Convert(): 0x1A does not exist in Biff5!" );
+ //fall-through
default: DBG_WARNING( "-ExcelToSc::Convert(): A little oblivious?" );
}
break;
@@ -1014,6 +1015,7 @@ ConvErr ExcelToSc::Convert( _ScRangeListTabs& rRangeList, XclImpStream& aIn, sal
case EXC_BIFF3:
case EXC_BIFF4: nIgnore = 4; break;
case EXC_BIFF5: DBG_WARNING( "-ExcelToSc::Convert(): 0x1B does not exist in Biff5!" );
+ //fall-through
default: DBG_WARNING( "-ExcelToSc::Convert(): A little oblivious?" );
}
break;
commit 1e9ce046a3b9e6b631fc8c31faeb758152a477af
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 09:57:08 2014 +0100
coverity#705215 Missing break in switch
Change-Id: I52cf32e9349e547e3445fbb266a74495d69aaa3f
diff --git a/sd/source/core/drawdoc4.cxx b/sd/source/core/drawdoc4.cxx
index c2e5f57..2b724a9 100644
--- a/sd/source/core/drawdoc4.cxx
+++ b/sd/source/core/drawdoc4.cxx
@@ -1054,6 +1054,7 @@ OUString SdDrawDocument::CreatePageNumValue(sal_uInt16 nNum) const
break;
case SVX_ROMAN_UPPER:
bUpper = true;
+ //fall-through
case SVX_ROMAN_LOWER:
aPageNumValue += SvxNumberFormat::CreateRomanString(nNum, bUpper);
break;
commit fd31c815b9ed30908d78d730c3e253ea83548cdc
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 09:56:31 2014 +0100
coverity#705211 Missing break in switch
Change-Id: I5adc00ba2f711a312c42b54014c465682a54e174
diff --git a/sc/source/ui/formdlg/dwfunctr.cxx b/sc/source/ui/formdlg/dwfunctr.cxx
index c59927b..7099fa3 100644
--- a/sc/source/ui/formdlg/dwfunctr.cxx
+++ b/sc/source/ui/formdlg/dwfunctr.cxx
@@ -695,7 +695,7 @@ SfxChildAlignment ScFunctionDockWin::CheckAlignment(SfxChildAlignment /* abla */
aString += "www";
aTxtSize = Size( aFiFuncDesc.GetTextWidth(aString),
aFiFuncDesc.GetTextHeight() );
-
+ // fall-through
default: Point aTopLeft=aCatBox.GetPosPixel();
nMinWidth=aTxtSize.Width()+aTopLeft.X()
+2*aFuncList.GetPosPixel().X();
commit 4d7827cf690ba3c6d5deb8eec63ac27aa43f600f
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 09:55:43 2014 +0100
coverity#705209 Missing break in switch
Change-Id: Ie9ecc13553e089197de24c8a151eb811e40bd56e
diff --git a/sc/source/filter/excel/excform.cxx b/sc/source/filter/excel/excform.cxx
index 2610eb4..8c9986b3 100644
--- a/sc/source/filter/excel/excform.cxx
+++ b/sc/source/filter/excel/excform.cxx
@@ -416,6 +416,7 @@ ConvErr ExcelToSc::Convert( const ScTokenArray*& pErgebnis, XclImpStream& aIn, s
case EXC_BIFF4: aIn.Ignore( 10 ); break;
case EXC_BIFF5:
DBG_WARNING( "-ExcelToSc::Convert(): 0x1A does not exist in Biff5!" );
+ //fall-through
default:
DBG_WARNING( "-ExcelToSc::Convert(): A little oblivious?" );
}
@@ -428,6 +429,7 @@ ConvErr ExcelToSc::Convert( const ScTokenArray*& pErgebnis, XclImpStream& aIn, s
case EXC_BIFF4: aIn.Ignore( 4 ); break;
case EXC_BIFF5:
DBG_WARNING( "-ExcelToSc::Convert(): 0x1B does not exist in Biff5!" );
+ //fall-through
default:
DBG_WARNING( "-ExcelToSc::Convert(): A little oblivious?" );
}
commit d6efbc4b7488bb2b9c4bcc29adc8cd3b6ed21d5d
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Jun 5 09:54:41 2014 +0100
coverity#705207 Missing break in switch
Change-Id: Iac1085e4dc7c68d69fafe76bd6d22470ebaf84ad
diff --git a/sc/source/filter/dif/difimp.cxx b/sc/source/filter/dif/difimp.cxx
index 8039d5d..3d39354 100644
--- a/sc/source/filter/dif/difimp.cxx
+++ b/sc/source/filter/dif/difimp.cxx
@@ -387,6 +387,7 @@ TOPIC DifParser::GetNextTopic( void )
case S_UNKNOWN:
// 2 Zeilen ueberlesen
ReadNextLine( aLine );
+ // fall-through
case S_ERROR_L2: // Fehler in Line 2 aufgetreten
// eine Zeile ueberlesen
ReadNextLine( aLine );
More information about the Libreoffice-commits
mailing list