[Libreoffice-commits] core.git: sdext/source vcl/osx

[Peter Senna Tschudin]

 sdext/source/pdfimport/tree/pdfiprocessor.cxx |    1 -
 vcl/osx/DataFlavorMapping.cxx                 |    1 -
 2 files changed, 2 deletions(-)

New commits:
commit f8018266ccff7ecceb26795aeb91a6ca560e8467
Author: Peter Senna Tschudin <peter.senna at gmail.com>
Date:   Sun Jun 29 22:52:08 2014 +0200

    Remove double assignment
    
    The semantic match that finds this problem is follows:
    (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @r@
    expression i,f;
    position p1,p2;
    @@
    (
    (<+...i++...+>) = ...;
    |
    (<+...++i...+>) = ...;
    |
    (<+...i--...+>) = ...;
    |
    (<+...--i...+>) = ...;
    |
    i = <+...f(...)...+>;
    |
    i at p1 = ...;
    (
    i = <+...i...+>;
    |
    i = <+...f(...)...+>;
    |
    i at p2 = ...;
    )
    )
    
    @@
    expression i;
    position r.p1,r.p2;
    @@
    
    * i at p1 = ...;
    i at p2 = ...;
    // </smpl>
    
    Change-Id: Ifacb878d58486f2645560592484ce24b2bc0bd6f
    Reviewed-on: https://gerrit.libreoffice.org/9968
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>
    Tested-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/sdext/source/pdfimport/tree/pdfiprocessor.cxx b/sdext/source/pdfimport/tree/pdfiprocessor.cxx
index 3a670a6..37f4126 100644
--- a/sdext/source/pdfimport/tree/pdfiprocessor.cxx
+++ b/sdext/source/pdfimport/tree/pdfiprocessor.cxx
@@ -638,7 +638,6 @@ void PDFIProcessor::emit( XmlEmitter&               rEmitter,
     aProps[ "xmlns:xsd"]          = "http://www.w3.org/2001/XMLSchema";
     aProps[ "xmlns:xsi"]          = "http://www.w3.org/2001/XMLSchema-instance";
     aProps[ "office:version" ]    = "1.0";
-    aProps[ "office:version" ]    = "1.0";
 
     aContext.rEmitter.beginTag( "office:document", aProps );
 
diff --git a/vcl/osx/DataFlavorMapping.cxx b/vcl/osx/DataFlavorMapping.cxx
index 95584bb..33bd19b 100644
--- a/vcl/osx/DataFlavorMapping.cxx
+++ b/vcl/osx/DataFlavorMapping.cxx
@@ -508,7 +508,6 @@ const NSString* DataFlavorMapper::openOfficeToSystemFlavor( const DataFlavor& oO
 {
     const NSString* sysFlavor = NULL;
     rbInternal = false;
-    rbInternal = false;
 
     for( size_t i = 0; i < SIZE_FLAVOR_MAP; ++i )
     {