[Libreoffice-commits] core.git: 2 commits - hwpfilter/source

Caolán McNamara caolanm at redhat.com
Sun Mar 9 09:57:28 PDT 2014


 hwpfilter/source/hbox.cxx |   27 +++++++++++++--------------
 1 file changed, 13 insertions(+), 14 deletions(-)

New commits:
commit f3a7250c3fc4cfa16a5f7236048b12c3b93b17ee
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sun Mar 9 16:50:40 2014 +0000

    coverity#707896 Uninitialized scalar field
    
    Change-Id: I353e450995eeff72d94d96d2e11f4224e9bd4824

diff --git a/hwpfilter/source/hbox.cxx b/hwpfilter/source/hbox.cxx
index 9b07683..7bf1d52 100644
--- a/hwpfilter/source/hbox.cxx
+++ b/hwpfilter/source/hbox.cxx
@@ -93,18 +93,19 @@ SkipData::~SkipData(void)
 
 
 // FieldCode [5]
-FieldCode::FieldCode(void) : HBox(CH_FIELD)
+FieldCode::FieldCode()
+    : HBox(CH_FIELD)
+    , location_info(0)
+    , str1(NULL)
+    , str2(NULL)
+    , str3(NULL)
+    , bin(NULL);
+    , m_pDate(NULL)
 {
-    str1 = 0;
-    str2 = 0;
-    str3 = 0;
-    bin = 0;
     reserved1 = new char[4];
     reserved2 = new char[22];
-     m_pDate = 0L;
 }
 
-
 FieldCode::~FieldCode(void)
 {
     delete[] str1;
@@ -113,8 +114,7 @@ FieldCode::~FieldCode(void)
     delete[] bin;
     delete[] reserved1;
     delete[] reserved2;
-     if( m_pDate )
-          delete m_pDate;
+    delete m_pDate;
 }
 
 // book mark(6)
commit 2d1da7cfc0eb3f34dfc0441c5b6c1bfade1e1dbc
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sun Mar 9 16:46:17 2014 +0000

    coverity#707895 Uninitialized scalar field
    
    Change-Id: I729b77264dbf9cda7f48aba66e622cc6ec7e1d71

diff --git a/hwpfilter/source/hbox.cxx b/hwpfilter/source/hbox.cxx
index 299e0c8..9b07683 100644
--- a/hwpfilter/source/hbox.cxx
+++ b/hwpfilter/source/hbox.cxx
@@ -129,7 +129,6 @@ Bookmark::~Bookmark(void)
 {
 }
 
-
 // date format(7)
 DateFormat::DateFormat()
     : HBox(CH_DATE_FORM)
@@ -137,14 +136,14 @@ DateFormat::DateFormat()
 {
 }
 
-
 // date code(8)
-
-DateCode::DateCode(void):HBox(CH_DATE_CODE)
+DateCode::DateCode()
+    : HBox(CH_DATE_CODE)
+    , dummy(0)
+    , key(0)
 {
 }
 
-
 #define _DATECODE_WEEK_DEFINES_
 #include "datecode.h"
 


More information about the Libreoffice-commits mailing list