[Libreoffice-commits] core.git: comphelper/source connectivity/source dbaccess/source include/comphelper include/connectivity
Noel Grandin
noel at peralex.com
Thu Mar 13 22:47:50 PDT 2014
comphelper/source/container/embeddedobjectcontainer.cxx | 4 ++--
comphelper/source/xml/ofopxmlhelper.cxx | 2 +-
connectivity/source/commontools/TColumnsHelper.cxx | 2 +-
connectivity/source/commontools/TIndexes.cxx | 2 +-
connectivity/source/commontools/TKeys.cxx | 2 +-
connectivity/source/drivers/ado/AColumns.cxx | 2 +-
connectivity/source/drivers/ado/AGroups.cxx | 2 +-
connectivity/source/drivers/ado/AIndexes.cxx | 2 +-
connectivity/source/drivers/ado/AKeys.cxx | 2 +-
connectivity/source/drivers/ado/ATables.cxx | 2 +-
connectivity/source/drivers/ado/AUsers.cxx | 2 +-
connectivity/source/drivers/ado/AViews.cxx | 2 +-
connectivity/source/drivers/dbase/DColumns.cxx | 2 +-
connectivity/source/drivers/dbase/DIndexes.cxx | 2 +-
connectivity/source/drivers/dbase/DTables.cxx | 2 +-
connectivity/source/drivers/firebird/Indexes.cxx | 4 ++--
connectivity/source/drivers/firebird/Indexes.hxx | 2 +-
connectivity/source/drivers/firebird/Keys.cxx | 4 ++--
connectivity/source/drivers/firebird/Keys.hxx | 4 ++--
connectivity/source/drivers/firebird/Tables.cxx | 4 ++--
connectivity/source/drivers/firebird/Tables.hxx | 4 ++--
connectivity/source/drivers/firebird/Users.cxx | 2 +-
connectivity/source/drivers/firebird/Users.hxx | 2 +-
connectivity/source/drivers/hsqldb/HTables.cxx | 2 +-
connectivity/source/drivers/hsqldb/HTools.cxx | 2 +-
connectivity/source/drivers/hsqldb/HUsers.cxx | 2 +-
connectivity/source/drivers/hsqldb/HViews.cxx | 2 +-
connectivity/source/drivers/jdbc/tools.cxx | 2 +-
connectivity/source/drivers/mork/MNSProfileDiscover.cxx | 2 +-
connectivity/source/drivers/mork/MNSProfileDiscover.hxx | 4 ++--
connectivity/source/drivers/mork/MQueryHelper.hxx | 6 +++---
connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx | 2 +-
connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.hxx | 4 ++--
connectivity/source/drivers/mysql/YTables.cxx | 2 +-
connectivity/source/drivers/mysql/YUsers.cxx | 2 +-
connectivity/source/drivers/mysql/YViews.cxx | 2 +-
connectivity/source/drivers/postgresql/pq_databasemetadata.cxx | 2 +-
connectivity/source/drivers/postgresql/pq_databasemetadata.hxx | 2 +-
connectivity/source/drivers/postgresql/pq_tools.cxx | 4 ++--
connectivity/source/drivers/postgresql/pq_tools.hxx | 2 +-
connectivity/source/inc/ado/AColumns.hxx | 2 +-
connectivity/source/inc/ado/AGroups.hxx | 2 +-
connectivity/source/inc/ado/AIndexes.hxx | 2 +-
connectivity/source/inc/ado/AKeys.hxx | 2 +-
connectivity/source/inc/ado/ATables.hxx | 2 +-
connectivity/source/inc/ado/AUsers.hxx | 2 +-
connectivity/source/inc/ado/AViews.hxx | 2 +-
connectivity/source/inc/dbase/DColumns.hxx | 2 +-
connectivity/source/inc/dbase/DIndexes.hxx | 2 +-
connectivity/source/inc/dbase/DTables.hxx | 2 +-
connectivity/source/inc/file/quotedstring.hxx | 2 +-
connectivity/source/inc/hsqldb/HTables.hxx | 2 +-
connectivity/source/inc/hsqldb/HTools.hxx | 2 +-
connectivity/source/inc/hsqldb/HUsers.hxx | 2 +-
connectivity/source/inc/hsqldb/HViews.hxx | 2 +-
connectivity/source/inc/java/util/Property.hxx | 2 +-
connectivity/source/inc/mysql/YTables.hxx | 2 +-
connectivity/source/inc/mysql/YUsers.hxx | 2 +-
connectivity/source/inc/mysql/YViews.hxx | 2 +-
connectivity/source/parse/sqliterator.cxx | 2 +-
connectivity/source/sdbcx/VCollection.cxx | 6 +++---
dbaccess/source/core/api/CIndexes.cxx | 2 +-
dbaccess/source/core/api/CIndexes.hxx | 2 +-
dbaccess/source/core/api/column.cxx | 2 +-
dbaccess/source/core/api/tablecontainer.cxx | 2 +-
dbaccess/source/core/api/viewcontainer.cxx | 2 +-
dbaccess/source/core/inc/column.hxx | 2 +-
dbaccess/source/core/inc/tablecontainer.hxx | 2 +-
dbaccess/source/core/inc/viewcontainer.hxx | 2 +-
include/comphelper/ofopxmlhelper.hxx | 2 +-
include/connectivity/TColumnsHelper.hxx | 2 +-
include/connectivity/TIndexes.hxx | 2 +-
include/connectivity/TKeys.hxx | 2 +-
include/connectivity/sdbcx/VCollection.hxx | 8 ++++----
74 files changed, 90 insertions(+), 90 deletions(-)
New commits:
commit 358be80f65d335910a4add147cd15e35d3505afd
Author: Noel Grandin <noel at peralex.com>
Date: Fri Mar 14 07:46:08 2014 +0200
comphelper,connectivity: prefer passing OUString by reference
Change-Id: I19b2613918ec62ee39bb3e447f3587c5dba1e36a
diff --git a/comphelper/source/container/embeddedobjectcontainer.cxx b/comphelper/source/container/embeddedobjectcontainer.cxx
index d296c9f..9ccd567 100644
--- a/comphelper/source/container/embeddedobjectcontainer.cxx
+++ b/comphelper/source/container/embeddedobjectcontainer.cxx
@@ -52,7 +52,7 @@ namespace comphelper
struct hashObjectName_Impl
{
- size_t operator()(const OUString Str) const
+ size_t operator()(const OUString & Str) const
{
return (size_t)Str.hashCode();
}
@@ -60,7 +60,7 @@ struct hashObjectName_Impl
struct eqObjectName_Impl
{
- bool operator()(const OUString Str1, const OUString Str2) const
+ bool operator()(const OUString & Str1, const OUString & Str2) const
{
return ( Str1 == Str2 );
}
diff --git a/comphelper/source/xml/ofopxmlhelper.cxx b/comphelper/source/xml/ofopxmlhelper.cxx
index b20d4f2..8a78fcb 100644
--- a/comphelper/source/xml/ofopxmlhelper.cxx
+++ b/comphelper/source/xml/ofopxmlhelper.cxx
@@ -38,7 +38,7 @@ using namespace ::com::sun::star;
namespace comphelper {
-uno::Sequence< uno::Sequence< beans::StringPair > > SAL_CALL OFOPXMLHelper::ReadRelationsInfoSequence( const uno::Reference< io::XInputStream >& xInStream, const OUString aStreamName, const uno::Reference< uno::XComponentContext > xContext )
+uno::Sequence< uno::Sequence< beans::StringPair > > SAL_CALL OFOPXMLHelper::ReadRelationsInfoSequence( const uno::Reference< io::XInputStream >& xInStream, const OUString & aStreamName, const uno::Reference< uno::XComponentContext > xContext )
throw( uno::Exception )
{
OUString aStringID = "_rels/";
diff --git a/connectivity/source/commontools/TColumnsHelper.cxx b/connectivity/source/commontools/TColumnsHelper.cxx
index 7705e5c..d9dcd3c 100644
--- a/connectivity/source/commontools/TColumnsHelper.cxx
+++ b/connectivity/source/commontools/TColumnsHelper.cxx
@@ -192,7 +192,7 @@ sdbcx::ObjectType OColumnsHelper::appendObject( const OUString& _rForName, const
}
// XDrop
-void OColumnsHelper::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName)
+void OColumnsHelper::dropObject(sal_Int32 /*_nPos*/, const OUString& _sElementName)
{
OSL_ENSURE(m_pTable,"OColumnsHelper::dropByName: Table is null!");
if ( m_pTable && !m_pTable->isNew() )
diff --git a/connectivity/source/commontools/TIndexes.cxx b/connectivity/source/commontools/TIndexes.cxx
index 165c2fd..acf70f2 100644
--- a/connectivity/source/commontools/TIndexes.cxx
+++ b/connectivity/source/commontools/TIndexes.cxx
@@ -209,7 +209,7 @@ sdbcx::ObjectType OIndexesHelper::appendObject( const OUString& _rForName, const
}
// XDrop
-void OIndexesHelper::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName)
+void OIndexesHelper::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{
Reference< XConnection> xConnection = m_pTable->getConnection();
if( xConnection.is() && !m_pTable->isNew())
diff --git a/connectivity/source/commontools/TKeys.cxx b/connectivity/source/commontools/TKeys.cxx
index 1841fd4..abdb2f0 100644
--- a/connectivity/source/commontools/TKeys.cxx
+++ b/connectivity/source/commontools/TKeys.cxx
@@ -260,7 +260,7 @@ OUString OKeysHelper::getDropForeignKey() const
}
// XDrop
-void OKeysHelper::dropObject(sal_Int32 _nPos,const OUString _sElementName)
+void OKeysHelper::dropObject(sal_Int32 _nPos, const OUString& _sElementName)
{
Reference< XConnection> xConnection = m_pTable->getConnection();
if ( xConnection.is() && !m_pTable->isNew() )
diff --git a/connectivity/source/drivers/ado/AColumns.cxx b/connectivity/source/drivers/ado/AColumns.cxx
index 08dda62..936510f1 100644
--- a/connectivity/source/drivers/ado/AColumns.cxx
+++ b/connectivity/source/drivers/ado/AColumns.cxx
@@ -127,7 +127,7 @@ sdbcx::ObjectType OColumns::appendObject( const OUString&, const Reference< XPro
}
// XDrop
-void OColumns::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName)
+void OColumns::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{
if(!m_aCollection.Delete(_sElementName))
ADOS::ThrowException(*m_pConnection->getConnection(),static_cast<XTypeProvider*>(this));
diff --git a/connectivity/source/drivers/ado/AGroups.cxx b/connectivity/source/drivers/ado/AGroups.cxx
index ba19dbe..4eae0dc 100644
--- a/connectivity/source/drivers/ado/AGroups.cxx
+++ b/connectivity/source/drivers/ado/AGroups.cxx
@@ -66,7 +66,7 @@ sdbcx::ObjectType OGroups::appendObject( const OUString& _rForName, const Refere
}
// XDrop
-void OGroups::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName)
+void OGroups::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{
m_aCollection.Delete(_sElementName);
}
diff --git a/connectivity/source/drivers/ado/AIndexes.cxx b/connectivity/source/drivers/ado/AIndexes.cxx
index e95fd3d..5dfc293 100644
--- a/connectivity/source/drivers/ado/AIndexes.cxx
+++ b/connectivity/source/drivers/ado/AIndexes.cxx
@@ -71,7 +71,7 @@ sdbcx::ObjectType OIndexes::appendObject( const OUString& _rForName, const Refer
}
// XDrop
-void OIndexes::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName)
+void OIndexes::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{
m_aCollection.Delete(_sElementName);
}
diff --git a/connectivity/source/drivers/ado/AKeys.cxx b/connectivity/source/drivers/ado/AKeys.cxx
index 735b8c6..b272dac 100644
--- a/connectivity/source/drivers/ado/AKeys.cxx
+++ b/connectivity/source/drivers/ado/AKeys.cxx
@@ -97,7 +97,7 @@ sdbcx::ObjectType OKeys::appendObject( const OUString&, const Reference< XProper
}
// XDrop
-void OKeys::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName)
+void OKeys::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{
if(!m_aCollection.Delete(OLEVariant(_sElementName)))
ADOS::ThrowException(*m_pConnection->getConnection(),static_cast<XTypeProvider*>(this));
diff --git a/connectivity/source/drivers/ado/ATables.cxx b/connectivity/source/drivers/ado/ATables.cxx
index d506ef2..cdd7df2 100644
--- a/connectivity/source/drivers/ado/ATables.cxx
+++ b/connectivity/source/drivers/ado/ATables.cxx
@@ -77,7 +77,7 @@ sdbcx::ObjectType OTables::appendObject( const OUString&, const Reference< XProp
}
// XDrop
-void OTables::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName)
+void OTables::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{
OSL_ENSURE(m_aCollection.IsValid(),"Collection isn't valid");
if ( !m_aCollection.Delete(_sElementName) )
diff --git a/connectivity/source/drivers/ado/AUsers.cxx b/connectivity/source/drivers/ado/AUsers.cxx
index 6c46432..e47ec19 100644
--- a/connectivity/source/drivers/ado/AUsers.cxx
+++ b/connectivity/source/drivers/ado/AUsers.cxx
@@ -66,7 +66,7 @@ sdbcx::ObjectType OUsers::appendObject( const OUString& _rForName, const Referen
}
// XDrop
-void OUsers::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName)
+void OUsers::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{
m_aCollection.Delete(_sElementName);
}
diff --git a/connectivity/source/drivers/ado/AViews.cxx b/connectivity/source/drivers/ado/AViews.cxx
index 1401d17..155866c 100644
--- a/connectivity/source/drivers/ado/AViews.cxx
+++ b/connectivity/source/drivers/ado/AViews.cxx
@@ -83,7 +83,7 @@ sdbcx::ObjectType OViews::appendObject( const OUString& _rForName, const Referen
}
// XDrop
-void OViews::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName)
+void OViews::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{
if(!m_aCollection.Delete(_sElementName))
ADOS::ThrowException(*m_pCatalog->getConnection()->getConnection(),static_cast<XTypeProvider*>(this));
diff --git a/connectivity/source/drivers/dbase/DColumns.cxx b/connectivity/source/drivers/dbase/DColumns.cxx
index 00888a0..c3b1997 100644
--- a/connectivity/source/drivers/dbase/DColumns.cxx
+++ b/connectivity/source/drivers/dbase/DColumns.cxx
@@ -70,7 +70,7 @@ sdbcx::ObjectType ODbaseColumns::appendObject( const OUString& _rForName, const
// XDrop
-void ODbaseColumns::dropObject(sal_Int32 _nPos,const OUString /*_sElementName*/)
+void ODbaseColumns::dropObject(sal_Int32 _nPos, const OUString& /*_sElementName*/)
{
if(!m_pTable->isNew())
m_pTable->dropColumn(_nPos);
diff --git a/connectivity/source/drivers/dbase/DIndexes.cxx b/connectivity/source/drivers/dbase/DIndexes.cxx
index 56dd8a7..67625a7 100644
--- a/connectivity/source/drivers/dbase/DIndexes.cxx
+++ b/connectivity/source/drivers/dbase/DIndexes.cxx
@@ -104,7 +104,7 @@ sdbcx::ObjectType ODbaseIndexes::appendObject( const OUString& _rForName, const
}
// XDrop
-void ODbaseIndexes::dropObject(sal_Int32 _nPos,const OUString /*_sElementName*/)
+void ODbaseIndexes::dropObject(sal_Int32 _nPos, const OUString& /*_sElementName*/)
{
Reference< XUnoTunnel> xTunnel(getObject(_nPos),UNO_QUERY);
if ( xTunnel.is() )
diff --git a/connectivity/source/drivers/dbase/DTables.cxx b/connectivity/source/drivers/dbase/DTables.cxx
index ef88e04..47ebfb8 100644
--- a/connectivity/source/drivers/dbase/DTables.cxx
+++ b/connectivity/source/drivers/dbase/DTables.cxx
@@ -92,7 +92,7 @@ sdbcx::ObjectType ODbaseTables::appendObject( const OUString& _rForName, const R
}
// XDrop
-void ODbaseTables::dropObject(sal_Int32 _nPos,const OUString _sElementName)
+void ODbaseTables::dropObject(sal_Int32 _nPos, const OUString& _sElementName)
{
Reference< XUnoTunnel> xTunnel;
try
diff --git a/connectivity/source/drivers/firebird/Indexes.cxx b/connectivity/source/drivers/firebird/Indexes.cxx
index fc03272..2b94d8e 100644
--- a/connectivity/source/drivers/firebird/Indexes.cxx
+++ b/connectivity/source/drivers/firebird/Indexes.cxx
@@ -26,8 +26,8 @@ Indexes::Indexes(Table* pTable, Mutex& rMutex, const vector< OUString>& rVector)
}
// XDrop
-void Indexes::dropObject(sal_Int32 /*nPosition*/, const OUString sIndexName)
+void Indexes::dropObject(sal_Int32 /*nPosition*/, const OUString& sIndexName)
{
OUString sSql("DROP INDEX \"" + sIndexName +"\"");
m_pTable->getConnection()->createStatement()->execute(sSql);
-}
\ No newline at end of file
+}
diff --git a/connectivity/source/drivers/firebird/Indexes.hxx b/connectivity/source/drivers/firebird/Indexes.hxx
index 32d035c..8938f66 100644
--- a/connectivity/source/drivers/firebird/Indexes.hxx
+++ b/connectivity/source/drivers/firebird/Indexes.hxx
@@ -30,7 +30,7 @@ namespace connectivity
protected:
// XDrop
virtual void dropObject(sal_Int32 nPosition,
- const ::rtl::OUString sIndexName);
+ const ::rtl::OUString& sIndexName);
public:
Indexes(Table* pTable,
::osl::Mutex& rMutex,
diff --git a/connectivity/source/drivers/firebird/Keys.cxx b/connectivity/source/drivers/firebird/Keys.cxx
index c187491..e677230 100644
--- a/connectivity/source/drivers/firebird/Keys.cxx
+++ b/connectivity/source/drivers/firebird/Keys.cxx
@@ -32,7 +32,7 @@ Keys::Keys(Table* pTable, Mutex& rMutex, const TStringVector& rNames):
}
//----- XDrop ----------------------------------------------------------------
-void Keys::dropObject(sal_Int32 nPosition, const OUString sName)
+void Keys::dropObject(sal_Int32 nPosition, const OUString& sName)
{
Reference< XConnection> xConnection = m_pTable->getConnection();
@@ -53,4 +53,4 @@ void Keys::dropObject(sal_Int32 nPosition, const OUString sName)
}
}
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
\ No newline at end of file
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/connectivity/source/drivers/firebird/Keys.hxx b/connectivity/source/drivers/firebird/Keys.hxx
index a99edbd..dd7489e 100644
--- a/connectivity/source/drivers/firebird/Keys.hxx
+++ b/connectivity/source/drivers/firebird/Keys.hxx
@@ -31,11 +31,11 @@ namespace connectivity
const ::connectivity::TStringVector& rNames);
// OKeysHelper / XDrop
- void dropObject(sal_Int32 nPosition, const ::rtl::OUString sName);
+ void dropObject(sal_Int32 nPosition, const ::rtl::OUString& sName);
};
}
}
#endif // CONNECTIVITY_FIREBIRD_KEYS_HXX
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
\ No newline at end of file
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/connectivity/source/drivers/firebird/Tables.cxx b/connectivity/source/drivers/firebird/Tables.cxx
index fc55d2a..63d9404 100644
--- a/connectivity/source/drivers/firebird/Tables.cxx
+++ b/connectivity/source/drivers/firebird/Tables.cxx
@@ -98,7 +98,7 @@ ObjectType Tables::appendObject(const OUString& rName,
}
//----- XDrop -----------------------------------------------------------------
-void Tables::dropObject(sal_Int32 nPosition, const OUString sName)
+void Tables::dropObject(sal_Int32 nPosition, const OUString& sName)
{
uno::Reference< XPropertySet > xTable(getObject(nPosition));
@@ -117,4 +117,4 @@ void Tables::dropObject(sal_Int32 nPosition, const OUString sName)
}
}
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
\ No newline at end of file
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/connectivity/source/drivers/firebird/Tables.hxx b/connectivity/source/drivers/firebird/Tables.hxx
index b2e570f..276f080 100644
--- a/connectivity/source/drivers/firebird/Tables.hxx
+++ b/connectivity/source/drivers/firebird/Tables.hxx
@@ -53,7 +53,7 @@ namespace connectivity
// XAppend, etc., but all are optional.
// XDrop
- virtual void dropObject(sal_Int32 nPosition, const ::rtl::OUString rName);
+ virtual void dropObject(sal_Int32 nPosition, const ::rtl::OUString& rName);
};
@@ -63,4 +63,4 @@ namespace connectivity
#endif // CONNECTIVITY_FIREBIRD_TABLES_HXX
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
\ No newline at end of file
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/connectivity/source/drivers/firebird/Users.cxx b/connectivity/source/drivers/firebird/Users.cxx
index b84d034..6e9f866 100644
--- a/connectivity/source/drivers/firebird/Users.cxx
+++ b/connectivity/source/drivers/firebird/Users.cxx
@@ -75,7 +75,7 @@ ObjectType Users::appendObject(const OUString& rName,
}
//----- XDrop -----------------------------------------------------------------
-void Users::dropObject(sal_Int32 nPosition, const OUString sName)
+void Users::dropObject(sal_Int32 nPosition, const OUString& sName)
{
uno::Reference< XPropertySet > xUser(getObject(nPosition));
diff --git a/connectivity/source/drivers/firebird/Users.hxx b/connectivity/source/drivers/firebird/Users.hxx
index ce35368..fc60381 100644
--- a/connectivity/source/drivers/firebird/Users.hxx
+++ b/connectivity/source/drivers/firebird/Users.hxx
@@ -49,7 +49,7 @@ namespace connectivity
// XAppend, etc., but all are optional.
// XDrop
- virtual void dropObject(sal_Int32 nPosition, const ::rtl::OUString rName);
+ virtual void dropObject(sal_Int32 nPosition, const ::rtl::OUString& rName);
};
diff --git a/connectivity/source/drivers/hsqldb/HTables.cxx b/connectivity/source/drivers/hsqldb/HTables.cxx
index 055445f..eed4ffa 100644
--- a/connectivity/source/drivers/hsqldb/HTables.cxx
+++ b/connectivity/source/drivers/hsqldb/HTables.cxx
@@ -116,7 +116,7 @@ sdbcx::ObjectType OTables::appendObject( const OUString& _rForName, const Refere
}
// XDrop
-void OTables::dropObject(sal_Int32 _nPos,const OUString _sElementName)
+void OTables::dropObject(sal_Int32 _nPos,const OUString& _sElementName)
{
Reference< XInterface > xObject( getObject( _nPos ) );
sal_Bool bIsNew = connectivity::sdbcx::ODescriptor::isNew( xObject );
diff --git a/connectivity/source/drivers/hsqldb/HTools.cxx b/connectivity/source/drivers/hsqldb/HTools.cxx
index af568aa..0288a7b 100644
--- a/connectivity/source/drivers/hsqldb/HTools.cxx
+++ b/connectivity/source/drivers/hsqldb/HTools.cxx
@@ -27,7 +27,7 @@ namespace connectivity { namespace hsqldb
void HTools::appendTableFilterCrit( OUStringBuffer& _inout_rBuffer, const OUString& _rCatalog,
- const OUString _rSchema, const OUString _rName, bool _bShortForm )
+ const OUString& _rSchema, const OUString& _rName, bool _bShortForm )
{
_inout_rBuffer.appendAscii( " WHERE " );
if ( !_rCatalog.isEmpty() )
diff --git a/connectivity/source/drivers/hsqldb/HUsers.cxx b/connectivity/source/drivers/hsqldb/HUsers.cxx
index ffb34e7..947cde1 100644
--- a/connectivity/source/drivers/hsqldb/HUsers.cxx
+++ b/connectivity/source/drivers/hsqldb/HUsers.cxx
@@ -87,7 +87,7 @@ sdbcx::ObjectType OUsers::appendObject( const OUString& _rForName, const Referen
}
// XDrop
-void OUsers::dropObject(sal_Int32 /*nPos*/,const OUString _sElementName)
+void OUsers::dropObject(sal_Int32 /*nPos*/,const OUString& _sElementName)
{
{
OUString aSql( "REVOKE ALL ON * FROM " );
diff --git a/connectivity/source/drivers/hsqldb/HViews.cxx b/connectivity/source/drivers/hsqldb/HViews.cxx
index ef3922e..2a01e30 100644
--- a/connectivity/source/drivers/hsqldb/HViews.cxx
+++ b/connectivity/source/drivers/hsqldb/HViews.cxx
@@ -99,7 +99,7 @@ sdbcx::ObjectType HViews::appendObject( const OUString& _rForName, const Referen
}
// XDrop
-void HViews::dropObject(sal_Int32 _nPos,const OUString /*_sElementName*/)
+void HViews::dropObject(sal_Int32 _nPos,const OUString& /*_sElementName*/)
{
if ( m_bInDrop )
return;
diff --git a/connectivity/source/drivers/jdbc/tools.cxx b/connectivity/source/drivers/jdbc/tools.cxx
index c443b22..1bc79f7 100644
--- a/connectivity/source/drivers/jdbc/tools.cxx
+++ b/connectivity/source/drivers/jdbc/tools.cxx
@@ -35,7 +35,7 @@ using namespace ::com::sun::star::sdbc;
using namespace ::com::sun::star::container;
using namespace ::com::sun::star::lang;
-void java_util_Properties::setProperty(const OUString key, const OUString& value)
+void java_util_Properties::setProperty(const OUString& key, const OUString& value)
{
SDBThreadAttach t; OSL_ENSURE(t.pEnv,"Java Enviroment geloescht worden!");
jobject out(0);
diff --git a/connectivity/source/drivers/mork/MNSProfileDiscover.cxx b/connectivity/source/drivers/mork/MNSProfileDiscover.cxx
index 579d7ce..4b7ac55 100644
--- a/connectivity/source/drivers/mork/MNSProfileDiscover.cxx
+++ b/connectivity/source/drivers/mork/MNSProfileDiscover.cxx
@@ -27,7 +27,7 @@ namespace connectivity
{
namespace mork
{
- ProfileStruct::ProfileStruct(MozillaProductType aProduct,OUString aProfileName,
+ ProfileStruct::ProfileStruct(MozillaProductType aProduct, const OUString& aProfileName,
const OUString& aProfilePath
)
{
diff --git a/connectivity/source/drivers/mork/MNSProfileDiscover.hxx b/connectivity/source/drivers/mork/MNSProfileDiscover.hxx
index 2ad9843..26a8ece 100644
--- a/connectivity/source/drivers/mork/MNSProfileDiscover.hxx
+++ b/connectivity/source/drivers/mork/MNSProfileDiscover.hxx
@@ -49,7 +49,7 @@ namespace connectivity
class ProfileStruct
{
public:
- ProfileStruct(MozillaProductType aProduct,OUString aProfileName,
+ ProfileStruct(MozillaProductType aProduct, const OUString& aProfileName,
const OUString &aProfilePath
);
MozillaProductType getProductType() { return product;}
@@ -64,7 +64,7 @@ namespace connectivity
class ProductStruct
{
public:
- void setCurrentProfile(OUString aProfileName){mCurrentProfileName = aProfileName;}
+ void setCurrentProfile(const OUString& aProfileName){mCurrentProfileName = aProfileName;}
OUString mCurrentProfileName;
diff --git a/connectivity/source/drivers/mork/MQueryHelper.hxx b/connectivity/source/drivers/mork/MQueryHelper.hxx
index 70e9502..52ee78c 100644
--- a/connectivity/source/drivers/mork/MQueryHelper.hxx
+++ b/connectivity/source/drivers/mork/MQueryHelper.hxx
@@ -81,9 +81,9 @@ namespace connectivity
public:
- MQueryExpressionString( OUString& lhs,
+ MQueryExpressionString( const OUString& lhs,
MQueryOp::cond_type cond,
- OUString rhs )
+ const OUString& rhs )
: MQueryExpressionBase( MQueryExpressionBase::StringExpr )
, m_aName( lhs )
, m_aBooleanCondition( cond )
@@ -91,7 +91,7 @@ namespace connectivity
{
}
- MQueryExpressionString( OUString& lhs,
+ MQueryExpressionString( const OUString& lhs,
MQueryOp::cond_type cond )
: MQueryExpressionBase( MQueryExpressionBase::StringExpr )
, m_aName( lhs )
diff --git a/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx b/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx
index 7fcd034..0280568 100644
--- a/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx
+++ b/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx
@@ -85,7 +85,7 @@ namespace connectivity
{
namespace mozab
{
- ProfileStruct::ProfileStruct(MozillaProductType aProduct,OUString aProfileName,
+ ProfileStruct::ProfileStruct(MozillaProductType aProduct, const OUString& aProfileName,
#ifdef MINIMAL_PROFILEDISCOVER
const OUString& aProfilePath
#else
diff --git a/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.hxx b/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.hxx
index 7a4afef..bb88a8d 100644
--- a/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.hxx
+++ b/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.hxx
@@ -51,7 +51,7 @@ namespace connectivity
class ProfileStruct
{
public:
- ProfileStruct(MozillaProductType aProduct,OUString aProfileName,
+ ProfileStruct(MozillaProductType aProduct, const OUString& aProfileName,
#ifdef MINIMAL_PROFILEDISCOVER
const OUString &aProfilePath
#else
@@ -77,7 +77,7 @@ namespace connectivity
class ProductStruct
{
public:
- void setCurrentProfile(OUString aProfileName){mCurrentProfileName = aProfileName;}
+ void setCurrentProfile(const OUString& aProfileName){mCurrentProfileName = aProfileName;}
OUString mCurrentProfileName;
diff --git a/connectivity/source/drivers/mysql/YTables.cxx b/connectivity/source/drivers/mysql/YTables.cxx
index eb9156a..c48a998 100644
--- a/connectivity/source/drivers/mysql/YTables.cxx
+++ b/connectivity/source/drivers/mysql/YTables.cxx
@@ -121,7 +121,7 @@ sdbcx::ObjectType OTables::appendObject( const OUString& _rForName, const Refere
}
// XDrop
-void OTables::dropObject(sal_Int32 _nPos,const OUString _sElementName)
+void OTables::dropObject(sal_Int32 _nPos,const OUString& _sElementName)
{
Reference< XInterface > xObject( getObject( _nPos ) );
sal_Bool bIsNew = connectivity::sdbcx::ODescriptor::isNew( xObject );
diff --git a/connectivity/source/drivers/mysql/YUsers.cxx b/connectivity/source/drivers/mysql/YUsers.cxx
index 6791435..ff8e9fe 100644
--- a/connectivity/source/drivers/mysql/YUsers.cxx
+++ b/connectivity/source/drivers/mysql/YUsers.cxx
@@ -91,7 +91,7 @@ sdbcx::ObjectType OUsers::appendObject( const OUString& _rForName, const Referen
}
// XDrop
-void OUsers::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName)
+void OUsers::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName)
{
OUString aSql( "DROP USER " );
OUString aQuote = m_xConnection->getMetaData()->getIdentifierQuoteString( );
diff --git a/connectivity/source/drivers/mysql/YViews.cxx b/connectivity/source/drivers/mysql/YViews.cxx
index 12fa1da..4a87c34 100644
--- a/connectivity/source/drivers/mysql/YViews.cxx
+++ b/connectivity/source/drivers/mysql/YViews.cxx
@@ -93,7 +93,7 @@ sdbcx::ObjectType OViews::appendObject( const OUString& _rForName, const Referen
}
// XDrop
-void OViews::dropObject(sal_Int32 _nPos,const OUString /*_sElementName*/)
+void OViews::dropObject(sal_Int32 _nPos,const OUString& /*_sElementName*/)
{
if ( m_bInDrop )
return;
diff --git a/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx b/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
index e17dde6..f782371 100644
--- a/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
+++ b/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
@@ -910,7 +910,7 @@ sal_Int32 DatabaseMetaData::getMaxCharLiteralLength( ) throw (SQLException, Run
}
// Copied / adapted / simplified from JDBC driver
-sal_Int32 DatabaseMetaData::getIntSetting(OUString settingName)
+sal_Int32 DatabaseMetaData::getIntSetting(const OUString& settingName)
throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException)
{
MutexGuard guard( m_refMutex->mutex );
diff --git a/connectivity/source/drivers/postgresql/pq_databasemetadata.hxx b/connectivity/source/drivers/postgresql/pq_databasemetadata.hxx
index 84ceafb..be1357b 100644
--- a/connectivity/source/drivers/postgresql/pq_databasemetadata.hxx
+++ b/connectivity/source/drivers/postgresql/pq_databasemetadata.hxx
@@ -57,7 +57,7 @@ class DatabaseMetaData :
::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XPreparedStatement > m_getColumnPrivs_stmt;
void checkClosed() throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException);
- sal_Int32 getIntSetting(OUString settingName) throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException);
+ sal_Int32 getIntSetting(const OUString& settingName) throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException);
sal_Int32 getMaxIndexKeys() throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException);
sal_Int32 getMaxNameLength() throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException);
::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XResultSet > getImportedExportedKeys(
diff --git a/connectivity/source/drivers/postgresql/pq_tools.cxx b/connectivity/source/drivers/postgresql/pq_tools.cxx
index b7a5411..f95d02a 100644
--- a/connectivity/source/drivers/postgresql/pq_tools.cxx
+++ b/connectivity/source/drivers/postgresql/pq_tools.cxx
@@ -92,12 +92,12 @@ OUString concatQualified( const OUString & a, const OUString &b)
return buf.makeStringAndClear();
}
-static inline OString iOUStringToOString( const OUString str, ConnectionSettings *settings) {
+static inline OString iOUStringToOString( const OUString& str, ConnectionSettings *settings) {
OSL_ENSURE(settings, "pgsql-sdbc: OUStringToOString got NULL settings");
return OUStringToOString( str, settings->encoding );
}
-OString OUStringToOString( const OUString str, ConnectionSettings *settings) {
+OString OUStringToOString( const OUString& str, ConnectionSettings *settings) {
return iOUStringToOString( str, settings );
}
diff --git a/connectivity/source/drivers/postgresql/pq_tools.hxx b/connectivity/source/drivers/postgresql/pq_tools.hxx
index ae4a4d3..2375704 100644
--- a/connectivity/source/drivers/postgresql/pq_tools.hxx
+++ b/connectivity/source/drivers/postgresql/pq_tools.hxx
@@ -53,7 +53,7 @@ bool isWhitespace( sal_Unicode c );
OUString concatQualified( const OUString & a, const OUString &b);
-OString OUStringToOString( OUString str, ConnectionSettings *settings);
+OString OUStringToOString( const OUString& str, ConnectionSettings *settings);
void bufferQuoteConstant( OUStringBuffer & buf, const OUString & str, ConnectionSettings *settings );
void bufferQuoteAnyConstant( OUStringBuffer & buf, const com::sun::star::uno::Any &val, ConnectionSettings *settings );
diff --git a/connectivity/source/inc/ado/AColumns.hxx b/connectivity/source/inc/ado/AColumns.hxx
index 21ecda5..475b03d 100644
--- a/connectivity/source/inc/ado/AColumns.hxx
+++ b/connectivity/source/inc/ado/AColumns.hxx
@@ -40,7 +40,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public:
OColumns( ::cppu::OWeakObject& _rParent,
::osl::Mutex& _rMutex,
diff --git a/connectivity/source/inc/ado/AGroups.hxx b/connectivity/source/inc/ado/AGroups.hxx
index 296de95..0d5c964 100644
--- a/connectivity/source/inc/ado/AGroups.hxx
+++ b/connectivity/source/inc/ado/AGroups.hxx
@@ -38,7 +38,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public:
OGroups(OCatalog* _pParent,
::osl::Mutex& _rMutex,
diff --git a/connectivity/source/inc/ado/AIndexes.hxx b/connectivity/source/inc/ado/AIndexes.hxx
index 16347b2..0ef7c7a 100644
--- a/connectivity/source/inc/ado/AIndexes.hxx
+++ b/connectivity/source/inc/ado/AIndexes.hxx
@@ -37,7 +37,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public:
OIndexes(::cppu::OWeakObject& _rParent,
::osl::Mutex& _rMutex,
diff --git a/connectivity/source/inc/ado/AKeys.hxx b/connectivity/source/inc/ado/AKeys.hxx
index c93ffc1..bbd80eb 100644
--- a/connectivity/source/inc/ado/AKeys.hxx
+++ b/connectivity/source/inc/ado/AKeys.hxx
@@ -38,7 +38,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public:
OKeys(::cppu::OWeakObject& _rParent,
::osl::Mutex& _rMutex,
diff --git a/connectivity/source/inc/ado/ATables.hxx b/connectivity/source/inc/ado/ATables.hxx
index 5c8b4a1..81e6441 100644
--- a/connectivity/source/inc/ado/ATables.hxx
+++ b/connectivity/source/inc/ado/ATables.hxx
@@ -38,7 +38,7 @@ namespace connectivity
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
void setComments(const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ) throw(::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException);
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public:
OTables(OCatalog* _pParent, ::osl::Mutex& _rMutex,
const TStringVector &_rVector,
diff --git a/connectivity/source/inc/ado/AUsers.hxx b/connectivity/source/inc/ado/AUsers.hxx
index 761071b..65365db 100644
--- a/connectivity/source/inc/ado/AUsers.hxx
+++ b/connectivity/source/inc/ado/AUsers.hxx
@@ -38,7 +38,7 @@ namespace connectivity
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public:
OUsers( OCatalog* _pParent,
::osl::Mutex& _rMutex,
diff --git a/connectivity/source/inc/ado/AViews.hxx b/connectivity/source/inc/ado/AViews.hxx
index b94f965..02a3ba3 100644
--- a/connectivity/source/inc/ado/AViews.hxx
+++ b/connectivity/source/inc/ado/AViews.hxx
@@ -40,7 +40,7 @@ namespace connectivity
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
void setComments(const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ) throw(::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException);
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public:
OViews(OCatalog* _pParent, ::osl::Mutex& _rMutex,
const TStringVector &_rVector,
diff --git a/connectivity/source/inc/dbase/DColumns.hxx b/connectivity/source/inc/dbase/DColumns.hxx
index 1abf173..c016046 100644
--- a/connectivity/source/inc/dbase/DColumns.hxx
+++ b/connectivity/source/inc/dbase/DColumns.hxx
@@ -33,7 +33,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
public:
ODbaseColumns(file::OFileTable* _pTable,
::osl::Mutex& _rMutex,
diff --git a/connectivity/source/inc/dbase/DIndexes.hxx b/connectivity/source/inc/dbase/DIndexes.hxx
index 773797f..14e397c 100644
--- a/connectivity/source/inc/dbase/DIndexes.hxx
+++ b/connectivity/source/inc/dbase/DIndexes.hxx
@@ -39,7 +39,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
public:
ODbaseIndexes(ODbaseTable* _pTable, ::osl::Mutex& _rMutex,
const TStringVector &_rVector) : ODbaseIndexes_BASE(*_pTable,_pTable->getConnection()->getMetaData()->supportsMixedCaseQuotedIdentifiers(),_rMutex,_rVector)
diff --git a/connectivity/source/inc/dbase/DTables.hxx b/connectivity/source/inc/dbase/DTables.hxx
index 4c05ae1..52e7d19 100644
--- a/connectivity/source/inc/dbase/DTables.hxx
+++ b/connectivity/source/inc/dbase/DTables.hxx
@@ -36,7 +36,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
public:
ODbaseTables(const ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XDatabaseMetaData >& _rMetaData,::cppu::OWeakObject& _rParent, ::osl::Mutex& _rMutex,
const TStringVector &_rVector) : ODbaseTables_BASE(_rMetaData,_rParent,_rMutex,_rVector)
diff --git a/connectivity/source/inc/file/quotedstring.hxx b/connectivity/source/inc/file/quotedstring.hxx
index 77c7b7a..9f27eb3 100644
--- a/connectivity/source/inc/file/quotedstring.hxx
+++ b/connectivity/source/inc/file/quotedstring.hxx
@@ -39,7 +39,7 @@ namespace connectivity
sal_Int32 GetTokenCount( sal_Unicode cTok , sal_Unicode cStrDel ) const;
OUString GetTokenSpecial(sal_Int32& nStartPos, sal_Unicode cTok = ';', sal_Unicode cStrDel = '\0') const;
inline OUString& GetString() { return m_sString; }
- inline void SetString(OUString aStr) { m_sString = aStr;}
+ inline void SetString(const OUString& aStr) { m_sString = aStr;}
inline sal_Int32 Len() const { return m_sString.getLength(); }
inline operator OUString&() { return m_sString; }
};
diff --git a/connectivity/source/inc/hsqldb/HTables.hxx b/connectivity/source/inc/hsqldb/HTables.hxx
index e0a90ba..2ed5007 100644
--- a/connectivity/source/inc/hsqldb/HTables.hxx
+++ b/connectivity/source/inc/hsqldb/HTables.hxx
@@ -34,7 +34,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
void createTable( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual OUString getNameForObject(const sdbcx::ObjectType& _xObject);
diff --git a/connectivity/source/inc/hsqldb/HTools.hxx b/connectivity/source/inc/hsqldb/HTools.hxx
index 77a6a4a..bedef91 100644
--- a/connectivity/source/inc/hsqldb/HTools.hxx
+++ b/connectivity/source/inc/hsqldb/HTools.hxx
@@ -42,7 +42,7 @@ namespace connectivity { namespace hsqldb
*/
static void appendTableFilterCrit(
OUStringBuffer& _inout_rBuffer, const OUString& _rCatalog,
- const OUString _rSchema, const OUString _rName,
+ const OUString& _rSchema, const OUString& _rName,
bool _bShortForm
);
};
diff --git a/connectivity/source/inc/hsqldb/HUsers.hxx b/connectivity/source/inc/hsqldb/HUsers.hxx
index b9a4a4b..7ba5744 100644
--- a/connectivity/source/inc/hsqldb/HUsers.hxx
+++ b/connectivity/source/inc/hsqldb/HUsers.hxx
@@ -39,7 +39,7 @@ namespace connectivity
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
public:
OUsers( ::cppu::OWeakObject& _rParent,
::osl::Mutex& _rMutex,
diff --git a/connectivity/source/inc/hsqldb/HViews.hxx b/connectivity/source/inc/hsqldb/HViews.hxx
index a4fc4b3..fc2cc72 100644
--- a/connectivity/source/inc/hsqldb/HViews.hxx
+++ b/connectivity/source/inc/hsqldb/HViews.hxx
@@ -36,7 +36,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
void createView( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
public:
diff --git a/connectivity/source/inc/java/util/Property.hxx b/connectivity/source/inc/java/util/Property.hxx
index 6e330b6..af2a5c3 100644
--- a/connectivity/source/inc/java/util/Property.hxx
+++ b/connectivity/source/inc/java/util/Property.hxx
@@ -34,7 +34,7 @@ namespace connectivity
// A ctor that is needed for returning the object
java_util_Properties( JNIEnv * pEnv, jobject myObj ) : java_lang_Object( pEnv, myObj ){}
java_util_Properties( );
- void setProperty(const OUString key, const OUString& value);
+ void setProperty(const OUString& key, const OUString& value);
};
}
diff --git a/connectivity/source/inc/mysql/YTables.hxx b/connectivity/source/inc/mysql/YTables.hxx
index 6ebd507..c6ae4b1 100644
--- a/connectivity/source/inc/mysql/YTables.hxx
+++ b/connectivity/source/inc/mysql/YTables.hxx
@@ -36,7 +36,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
void createTable( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
virtual OUString getNameForObject(const sdbcx::ObjectType& _xObject);
diff --git a/connectivity/source/inc/mysql/YUsers.hxx b/connectivity/source/inc/mysql/YUsers.hxx
index 6121dda..6927b5c 100644
--- a/connectivity/source/inc/mysql/YUsers.hxx
+++ b/connectivity/source/inc/mysql/YUsers.hxx
@@ -39,7 +39,7 @@ namespace connectivity
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public:
OUsers( ::cppu::OWeakObject& _rParent,
::osl::Mutex& _rMutex,
diff --git a/connectivity/source/inc/mysql/YViews.hxx b/connectivity/source/inc/mysql/YViews.hxx
index 83fa235..12b33ce 100644
--- a/connectivity/source/inc/mysql/YViews.hxx
+++ b/connectivity/source/inc/mysql/YViews.hxx
@@ -35,7 +35,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
void createView( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
public:
diff --git a/connectivity/source/parse/sqliterator.cxx b/connectivity/source/parse/sqliterator.cxx
index d024784..491fca4 100644
--- a/connectivity/source/parse/sqliterator.cxx
+++ b/connectivity/source/parse/sqliterator.cxx
@@ -119,7 +119,7 @@ namespace connectivity
OUString m_sForbiddenQueryName;
public:
- ForbidQueryName( OSQLParseTreeIteratorImpl& _rIteratorImpl, const OUString _rForbiddenQueryName )
+ ForbidQueryName( OSQLParseTreeIteratorImpl& _rIteratorImpl, const OUString& _rForbiddenQueryName )
:m_rpAllForbiddenNames( _rIteratorImpl.m_pForbiddenQueryNames )
,m_sForbiddenQueryName( _rForbiddenQueryName )
{
diff --git a/connectivity/source/sdbcx/VCollection.cxx b/connectivity/source/sdbcx/VCollection.cxx
index 597ca6a..0aec95b 100644
--- a/connectivity/source/sdbcx/VCollection.cxx
+++ b/connectivity/source/sdbcx/VCollection.cxx
@@ -118,7 +118,7 @@ namespace
m_aElements.push_back(m_aNameMap.insert(m_aNameMap.begin(), ObjectEntry(*i,ObjectType())));
}
- virtual bool rename(const OUString _sOldName,const OUString _sNewName)
+ virtual bool rename(const OUString& _sOldName, const OUString& _sNewName)
{
bool bRet = false;
ObjectIter aIter = m_aNameMap.find(_sOldName);
@@ -518,7 +518,7 @@ void OCollection::insertElement(const OUString& _sElementName,const ObjectType&
m_pElements->insert(_sElementName,_xElement);
}
-void OCollection::renameObject(const OUString _sOldName,const OUString _sNewName)
+void OCollection::renameObject(const OUString& _sOldName, const OUString& _sNewName)
{
OSL_ENSURE(m_pElements->exists(_sOldName),"Element doesn't exist");
OSL_ENSURE(!m_pElements->exists(_sNewName),"Element already exists");
@@ -583,7 +583,7 @@ ObjectType OCollection::appendObject( const OUString& /*_rForName*/, const Refer
return cloneDescriptor( descriptor );
}
-void OCollection::dropObject(sal_Int32 /*_nPos*/,const OUString /*_sElementName*/)
+void OCollection::dropObject(sal_Int32 /*_nPos*/, const OUString& /*_sElementName*/)
{
}
diff --git a/dbaccess/source/core/api/CIndexes.cxx b/dbaccess/source/core/api/CIndexes.cxx
index 8d6203c..66f62f1 100644
--- a/dbaccess/source/core/api/CIndexes.cxx
+++ b/dbaccess/source/core/api/CIndexes.cxx
@@ -70,7 +70,7 @@ ObjectType OIndexes::appendObject( const OUString& _rForName, const Reference< X
}
// XDrop
-void OIndexes::dropObject(sal_Int32 _nPos,const OUString _sElementName)
+void OIndexes::dropObject(sal_Int32 _nPos, const OUString& _sElementName)
{
if ( m_xIndexes.is() )
{
diff --git a/dbaccess/source/core/api/CIndexes.hxx b/dbaccess/source/core/api/CIndexes.hxx
index 87c44cf..0bfdf3d 100644
--- a/dbaccess/source/core/api/CIndexes.hxx
+++ b/dbaccess/source/core/api/CIndexes.hxx
@@ -31,7 +31,7 @@ namespace dbaccess
virtual connectivity::sdbcx::ObjectType createObject(const OUString& _rName);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual connectivity::sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
public:
OIndexes(connectivity::OTableHelper* _pTable,
::osl::Mutex& _rMutex,
diff --git a/dbaccess/source/core/api/column.cxx b/dbaccess/source/core/api/column.cxx
index 737f5a0..b998686 100644
--- a/dbaccess/source/core/api/column.cxx
+++ b/dbaccess/source/core/api/column.cxx
@@ -390,7 +390,7 @@ sdbcx::ObjectType OColumns::appendObject( const OUString& _rForName, const Refer
}
// XDrop
-void OColumns::dropObject(sal_Int32 _nPos,const OUString _sElementName)
+void OColumns::dropObject(sal_Int32 _nPos, const OUString& _sElementName)
{
Reference< XDrop > xDrop( m_xDrvColumns, UNO_QUERY );
if ( xDrop.is() )
diff --git a/dbaccess/source/core/api/tablecontainer.cxx b/dbaccess/source/core/api/tablecontainer.cxx
index 6855916..083f5d2 100644
--- a/dbaccess/source/core/api/tablecontainer.cxx
+++ b/dbaccess/source/core/api/tablecontainer.cxx
@@ -348,7 +348,7 @@ ObjectType OTableContainer::appendObject( const OUString& _rForName, const Refer
}
// XDrop
-void OTableContainer::dropObject(sal_Int32 _nPos,const OUString _sElementName)
+void OTableContainer::dropObject(sal_Int32 _nPos, const OUString& _sElementName)
{
SAL_INFO("dbaccess", "dbaccess Ocke.Janssen at sun.com OTableContainer::dropObject" );
m_bInDrop = sal_True;
diff --git a/dbaccess/source/core/api/viewcontainer.cxx b/dbaccess/source/core/api/viewcontainer.cxx
index 9646595..ad70477 100644
--- a/dbaccess/source/core/api/viewcontainer.cxx
+++ b/dbaccess/source/core/api/viewcontainer.cxx
@@ -163,7 +163,7 @@ ObjectType OViewContainer::appendObject( const OUString& _rForName, const Refere
}
// XDrop
-void OViewContainer::dropObject(sal_Int32 _nPos,const OUString _sElementName)
+void OViewContainer::dropObject(sal_Int32 _nPos, const OUString& _sElementName)
{
if ( !m_bInElementRemoved )
{
diff --git a/dbaccess/source/core/inc/column.hxx b/dbaccess/source/core/inc/column.hxx
index baeccd8..5a5443f 100644
--- a/dbaccess/source/core/inc/column.hxx
+++ b/dbaccess/source/core/inc/column.hxx
@@ -165,7 +165,7 @@ namespace dbaccess
virtual connectivity::sdbcx::ObjectType createObject(const OUString& _rName);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual connectivity::sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
public:
connectivity::sdbcx::ObjectType createBaseObject(const OUString& _rName)
diff --git a/dbaccess/source/core/inc/tablecontainer.hxx b/dbaccess/source/core/inc/tablecontainer.hxx
index e7ea64e..cec890a 100644
--- a/dbaccess/source/core/inc/tablecontainer.hxx
+++ b/dbaccess/source/core/inc/tablecontainer.hxx
@@ -59,7 +59,7 @@ namespace dbaccess
virtual connectivity::sdbcx::ObjectType createObject(const OUString& _rName);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual connectivity::sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
virtual void SAL_CALL disposing();
diff --git a/dbaccess/source/core/inc/viewcontainer.hxx b/dbaccess/source/core/inc/viewcontainer.hxx
index b41f11c..f045b3b 100644
--- a/dbaccess/source/core/inc/viewcontainer.hxx
+++ b/dbaccess/source/core/inc/viewcontainer.hxx
@@ -90,7 +90,7 @@ namespace dbaccess
virtual ::connectivity::sdbcx::ObjectType createObject(const OUString& _rName);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual connectivity::sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
using OFilteredContainer::disposing;
diff --git a/include/comphelper/ofopxmlhelper.hxx b/include/comphelper/ofopxmlhelper.hxx
index af6c7c0..3ad91ec 100644
--- a/include/comphelper/ofopxmlhelper.hxx
+++ b/include/comphelper/ofopxmlhelper.hxx
@@ -72,7 +72,7 @@ public:
SAL_CALL
ReadRelationsInfoSequence(
const ::com::sun::star::uno::Reference< ::com::sun::star::io::XInputStream >& xInStream,
- const OUString aStreamName,
+ const OUString & aStreamName,
const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext > xContext )
throw( ::com::sun::star::uno::Exception );
diff --git a/include/connectivity/TColumnsHelper.hxx b/include/connectivity/TColumnsHelper.hxx
index 8e27287..1b095a0 100644
--- a/include/connectivity/TColumnsHelper.hxx
+++ b/include/connectivity/TColumnsHelper.hxx
@@ -41,7 +41,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
public:
OColumnsHelper( ::cppu::OWeakObject& _rParent
,sal_Bool _bCase
diff --git a/include/connectivity/TIndexes.hxx b/include/connectivity/TIndexes.hxx
index 2359e94..2ed5922 100644
--- a/include/connectivity/TIndexes.hxx
+++ b/include/connectivity/TIndexes.hxx
@@ -35,7 +35,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName);
public:
OIndexesHelper(OTableHelper* _pTable,
::osl::Mutex& _rMutex,
diff --git a/include/connectivity/TKeys.hxx b/include/connectivity/TKeys.hxx
index 3602de8..1422600 100644
--- a/include/connectivity/TKeys.hxx
+++ b/include/connectivity/TKeys.hxx
@@ -36,7 +36,7 @@ namespace connectivity
virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor();
virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
virtual OUString getDropForeignKey() const;
diff --git a/include/connectivity/sdbcx/VCollection.hxx b/include/connectivity/sdbcx/VCollection.hxx
index ae7f635..52fb708 100644
--- a/include/connectivity/sdbcx/VCollection.hxx
+++ b/include/connectivity/sdbcx/VCollection.hxx
@@ -71,8 +71,8 @@ namespace connectivity
virtual void swap() = 0;
virtual void clear() = 0;
virtual void reFill(const TStringVector &_rVector) = 0;
- virtual void insert(const OUString& _sName,const ObjectType& _xObject) = 0;
- virtual bool rename(const OUString _sOldName,const OUString _sNewName) = 0;
+ virtual void insert(const OUString& _sName, const ObjectType& _xObject) = 0;
+ virtual bool rename(const OUString& _sOldName, const OUString& _sNewName) = 0;
virtual sal_Int32 size() = 0;
virtual ::com::sun::star::uno::Sequence< OUString > getElementNames() = 0;
virtual OUString getName(sal_Int32 _nIndex) = 0;
@@ -126,7 +126,7 @@ namespace connectivity
virtual ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor );
// called when XDrop was called
- virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName);
+ virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName);
/** returns the name for the object. The default implementation ask for the property NAME. If this doesn't satisfy, it has to be overloaded.
@param _xObject The object where the name should be extracted.
@@ -182,7 +182,7 @@ namespace connectivity
void reFill(const TStringVector &_rVector);
inline sal_Bool isCaseSensitive() const { return m_pElements->isCaseSensitive(); }
- void renameObject(const OUString _sOldName,const OUString _sNewName);
+ void renameObject(const OUString& _sOldName, const OUString& _sNewName);
// only the name is identical to ::cppu::OComponentHelper
virtual void SAL_CALL disposing(void);
More information about the Libreoffice-commits
mailing list