[Libreoffice-commits] core.git: 8 commits - extensions/source include/vcl l10ntools/source sal/qa sfx2/source vcl/source vcl/unx writerfilter/source
Caolán McNamara
caolanm at redhat.com
Wed Mar 19 13:23:16 PDT 2014
extensions/source/plugin/base/plctrl.cxx | 14 ++++++--------
include/vcl/animate.hxx | 4 ----
l10ntools/source/xmlparse.cxx | 4 +++-
sal/qa/osl/file/osl_File.cxx | 9 +++++++--
sfx2/source/dialog/dinfdlg.cxx | 1 +
vcl/source/window/toolbox.cxx | 22 ++++++++++------------
vcl/unx/generic/app/sm.cxx | 14 ++++++++++----
writerfilter/source/rtftok/rtfdocumentimpl.cxx | 1 +
8 files changed, 38 insertions(+), 31 deletions(-)
New commits:
commit 43f74365f9a3cc913618e55cae0b050f4b0ca58c
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Mar 19 16:10:57 2014 +0000
coverity#984140 Uninitialized pointer field
Change-Id: Icba06e9bfa85b67a9e2a5f6952d023d6655267d4
diff --git a/sfx2/source/dialog/dinfdlg.cxx b/sfx2/source/dialog/dinfdlg.cxx
index 121534e..4c1b055 100644
--- a/sfx2/source/dialog/dinfdlg.cxx
+++ b/sfx2/source/dialog/dinfdlg.cxx
@@ -1390,6 +1390,7 @@ CustomPropertiesWindow::CustomPropertiesWindow(Window* pParent,
m_aYesNoButton ( this, SfxResId( SFX_WIN_PROPERTY_YESNO ) ),
m_aRemoveButton ( this, SfxResId( SFX_PB_PROPERTY_REMOVE ) ),
m_nScrollPos (0),
+ m_pCurrentLine (NULL),
m_aNumberFormatter( ::comphelper::getProcessComponentContext(),
Application::GetSettings().GetLanguageTag().getLanguageType() )
commit 7a958026f3526468a0c949fcceb116b33e29b903
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Mar 19 16:09:15 2014 +0000
coverity#984119 Uninitialized pointer field
Change-Id: I6bbb181b892f22d05be76fc75506d94543eb7ee7
diff --git a/sal/qa/osl/file/osl_File.cxx b/sal/qa/osl/file/osl_File.cxx
index 63b9bcb..5256303 100644
--- a/sal/qa/osl/file/osl_File.cxx
+++ b/sal/qa/osl/file/osl_File.cxx
@@ -2460,6 +2460,11 @@ namespace osl_FileStatus
::osl::DirectoryItem rItem_file, rItem_link;
public:
+ isValid()
+ : pDir(NULL)
+ {
+ }
+
// initialization
void setUp()
{
@@ -2477,8 +2482,8 @@ namespace osl_FileStatus
void tearDown()
{
- ::osl::FileBase::RC nError1 = pDir->close();
- delete pDir;
+ ::osl::FileBase::RC nError1 = pDir->close();
+ delete pDir;
CPPUNIT_ASSERT_MESSAGE( errorToStr(nError1).getStr(), ::osl::FileBase::E_None == nError1 );
// remove the tempfile in $TEMP/tmpdir/tmpname.
commit f8ee482b92638d3acfa944d305f87a34e5fc6e95
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Mar 19 16:07:03 2014 +0000
coverity#984098 Uninitialized pointer field
Change-Id: I671f7c98bdcfa828e7252ec13fd1b6b998ff7a87
diff --git a/l10ntools/source/xmlparse.cxx b/l10ntools/source/xmlparse.cxx
index 0431111..1a7559b 100644
--- a/l10ntools/source/xmlparse.cxx
+++ b/l10ntools/source/xmlparse.cxx
@@ -825,7 +825,9 @@ static OUString lcl_pathnameToAbsoluteUrl(const OString& rPathname)
SimpleXMLParser::SimpleXMLParser()
- : m_pXMLFile( NULL )
+ : m_pXMLFile(NULL)
+ , m_pCurNode(NULL)
+ , m_pCurData(NULL)
{
m_aParser = XML_ParserCreate( NULL );
XML_SetUserData( m_aParser, this );
commit b0ff06a5bc78839f43c73ac529c91a23293e93e8
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Mar 19 16:05:03 2014 +0000
coverity#984088 Uninitialized pointer field
Change-Id: I228f7c8f99b0cc3117fbeab78efbeddd74896d54
diff --git a/extensions/source/plugin/base/plctrl.cxx b/extensions/source/plugin/base/plctrl.cxx
index 9fe7821..fc19c0d 100644
--- a/extensions/source/plugin/base/plctrl.cxx
+++ b/extensions/source/plugin/base/plctrl.cxx
@@ -37,22 +37,20 @@
#include <vcl/syschild.hxx>
#include <toolkit/helper/vclunohelper.hxx>
-
-
-PluginControl_Impl::PluginControl_Impl() :
- _pMultiplexer( NULL )
+PluginControl_Impl::PluginControl_Impl()
+ : _pMultiplexer( NULL )
, _nX( 0 )
, _nY( 0 )
, _nWidth( 100 )
, _nHeight( 100 )
, _nFlags( WINDOW_POSSIZE_ALL )
- , _bVisible( sal_False )
- , _bInDesignMode( sal_False )
- , _bEnable( sal_True )
+ , _bVisible(false)
+ , _bInDesignMode(false)
+ , _bEnable(true)
+ , _pSysChild(NULL)
{
}
-
PluginControl_Impl::~PluginControl_Impl()
{
}
commit d4abe5ea0f89f9dbff49c1acf5f424f6afd9b5b2
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Mar 19 15:55:30 2014 +0000
coverity#738947 Uninitialized pointer field
Change-Id: I817c0e494bef9f112e1bdc30253fac9bcf472c6a
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index ab4c3c9..7e971a1 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -238,6 +238,7 @@ RTFDocumentImpl::RTFDocumentImpl(uno::Reference<uno::XComponentContext> const& x
m_xDstDoc(xDstDoc),
m_xFrame(xFrame),
m_xStatusIndicator(xStatusIndicator),
+ m_pMapperStream(NULL),
m_aDefaultState(this),
m_bSkipUnknown(false),
m_aFontIndexes(),
commit 2e252aaf1bee9b5db42ef9c0e3a6c7caf75129a7
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Mar 19 15:54:10 2014 +0000
coverity#738941 Uninitialized pointer field
Change-Id: Id7d9e1700c513ffe72ffc4fa8d369d07370a4db9
diff --git a/vcl/unx/generic/app/sm.cxx b/vcl/unx/generic/app/sm.cxx
index f0d1387..f92b6ed 100644
--- a/vcl/unx/generic/app/sm.cxx
+++ b/vcl/unx/generic/app/sm.cxx
@@ -124,10 +124,16 @@ class ICEConnectionObserver
public:
osl::Mutex m_ICEMutex;
- ICEConnectionObserver():
- m_pFilehandles(NULL), m_nConnections(0), m_pConnections(NULL),
- m_ICEThread(NULL)
- { m_nWakeupFiles[0] = m_nWakeupFiles[1] = 0; }
+ ICEConnectionObserver()
+ : m_pFilehandles(NULL)
+ , m_nConnections(0)
+ , m_pConnections(NULL)
+ , m_ICEThread(NULL)
+ , m_origIOErrorHandler(NULL)
+ , m_origErrorHandler(NULL)
+ {
+ m_nWakeupFiles[0] = m_nWakeupFiles[1] = 0;
+ }
void activate();
void deactivate();
commit 03108f65a998feb06d9510dac4c8cbfb92dac030
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Mar 19 15:52:02 2014 +0000
coverity#738939 Uninitialized pointer field
Change-Id: I244409a35c8b2eaa2360e91e31656fedd9ee8f82
diff --git a/vcl/source/window/toolbox.cxx b/vcl/source/window/toolbox.cxx
index 77c0e3d..3cb7322 100644
--- a/vcl/source/window/toolbox.cxx
+++ b/vcl/source/window/toolbox.cxx
@@ -1171,25 +1171,23 @@ sal_uInt16 ToolBox::ImplFindItemPos( ToolBox* pBox, const Point& rPos )
return nPos;
}
-
-
ImplTBDragMgr::ImplTBDragMgr()
+ : mpBoxList(new ImplTBList())
+ , mpDragBox(NULL)
+ , mnMinWidth(0)
+ , mnMaxWidth(0)
+ , mnLineMode(0)
+ , mnStartLines(0)
+ , mpCustomizeData(NULL)
+ , mbCustomizeMode(false)
+ , mbResizeMode(false)
+ , mbShowDragRect(false)
{
- mpBoxList = new ImplTBList();
- mnLineMode = 0;
- mnStartLines = 0;
- mbCustomizeMode = false;
- mbResizeMode = false;
- mbShowDragRect = false;
- mpDragBox = NULL;
-
maAccel.InsertItem( KEY_RETURN, KeyCode( KEY_RETURN ) );
maAccel.InsertItem( KEY_ESCAPE, KeyCode( KEY_ESCAPE ) );
maAccel.SetSelectHdl( LINK( this, ImplTBDragMgr, SelectHdl ) );
}
-
-
ImplTBDragMgr::~ImplTBDragMgr()
{
delete mpBoxList;
commit ce45e1d25e8d9b0fa4247e0b7efaaa4dbcf225c1
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Mar 19 15:47:11 2014 +0000
coverity#738931 unused members
Change-Id: Ia94a95c6fb3aed34f41e435b023783fc16730834
diff --git a/include/vcl/animate.hxx b/include/vcl/animate.hxx
index 7c3b8e4..a8bcfec 100644
--- a/include/vcl/animate.hxx
+++ b/include/vcl/animate.hxx
@@ -130,15 +130,11 @@ class VCL_DLLPUBLIC Animation
BitmapEx maBitmapEx;
Timer maTimer;
Size maGlobalSize;
- void* mpExtraData;
long mnLoopCount;
long mnLoops;
size_t mnPos;
- Disposal meLastDisposal;
CycleMode meCycleMode;
- bool mbFirst;
bool mbIsInAnimation;
- bool mbWithSize;
bool mbLoopTerminated;
bool mbIsWaiting;
More information about the Libreoffice-commits
mailing list