[Libreoffice-commits] core.git: 10 commits - cui/source extensions/source framework/source include/cppuhelper include/oox include/svl sfx2/source shell/source slideshow/source

Caolán McNamara caolanm at redhat.com
Sat Mar 22 13:57:32 PDT 2014


 cui/source/dialogs/cuigaldlg.cxx                                     |    2 ++
 extensions/source/propctrlr/propertyeditor.cxx                       |    2 ++
 framework/source/accelerators/presethandler.cxx                      |    7 ++++---
 include/cppuhelper/typeprovider.hxx                                  |    2 ++
 include/oox/ppt/animationspersist.hxx                                |    7 +++++--
 include/svl/ondemand.hxx                                             |    1 +
 sfx2/source/control/request.cxx                                      |    8 ++------
 shell/source/unix/sysshell/recently_used_file_handler.cxx            |    5 +++--
 slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx |    3 ++-
 9 files changed, 23 insertions(+), 14 deletions(-)

New commits:
commit bc13d935e6c6e194f7704f94aa964daf6f4a368e
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sat Mar 22 20:56:28 2014 +0000

    coverity#708176 Uninitialized scalar field
    
    Change-Id: I1d7b005c563a17b31a3bf565dd27d43868b3129c

diff --git a/shell/source/unix/sysshell/recently_used_file_handler.cxx b/shell/source/unix/sysshell/recently_used_file_handler.cxx
index c6c02ba..b5dbcc1 100644
--- a/shell/source/unix/sysshell/recently_used_file_handler.cxx
+++ b/shell/source/unix/sysshell/recently_used_file_handler.cxx
@@ -61,8 +61,9 @@ namespace /* private */ {
 
     struct recently_used_item
     {
-        recently_used_item() :
-            is_private_(false)
+        recently_used_item()
+            : timestamp_(-1)
+            , is_private_(false)
         {}
 
         recently_used_item(
commit 60c2b472de80fbc5c7acad515b524395f498bb4f
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sat Mar 22 20:53:48 2014 +0000

    coverity#708183 Uninitialized scalar field
    
    Change-Id: I45563c32a75ec2c95d4ea13d1cf9179c44cf1fd8

diff --git a/include/cppuhelper/typeprovider.hxx b/include/cppuhelper/typeprovider.hxx
index b82ed96..ca21dbf 100644
--- a/include/cppuhelper/typeprovider.hxx
+++ b/include/cppuhelper/typeprovider.hxx
@@ -214,9 +214,11 @@ public:
     */
     inline OImplementationId( const ::com::sun::star::uno::Sequence< sal_Int8 > & rSeq ) SAL_THROW(())
         : _pSeq( new ::com::sun::star::uno::Sequence< sal_Int8 >( rSeq ) )
+        , _bUseEthernetAddress( false )
         {}
     inline OImplementationId( const OImplementationId & rId ) SAL_THROW(())
         : _pSeq( new ::com::sun::star::uno::Sequence< sal_Int8 >( rId.getImplementationId() ) )
+        , _bUseEthernetAddress( false )
         {}
 
     /** Get implementation id.
commit 461ee0418a3f9a3d642f33144961b6d9eeb28207
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sat Mar 22 20:52:00 2014 +0000

    coverity#708177 Uninitialized scalar field
    
    Change-Id: I62fd8593c7c5cc0e04d54666103159a8d8932689

diff --git a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx
index 0450f1c..f93c292 100644
--- a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx
+++ b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx
@@ -280,7 +280,8 @@ SceneObject::~SceneObject()
 }
 
 Iris::Iris()
-    : SceneObject ()
+    : SceneObject()
+    , maTexture(0)
 {
 }
 
commit 8db09cdcd5056ded34e5f4bdd380177971c8b80d
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sat Mar 22 20:50:50 2014 +0000

    coverity#708190 Uninitialized scalar field
    
    Change-Id: Ieadb392a68afa58362e6d2c8f6534f1824a404c4

diff --git a/include/svl/ondemand.hxx b/include/svl/ondemand.hxx
index 6b6473c..adc8ba4 100644
--- a/include/svl/ondemand.hxx
+++ b/include/svl/ondemand.hxx
@@ -249,6 +249,7 @@ class OnDemandTransliterationWrapper
 public:
                                 OnDemandTransliterationWrapper()
                                     : eLanguage( LANGUAGE_SYSTEM )
+                                    , nType(::com::sun::star::i18n::TransliterationModules_END_OF_MODULE)
                                     , pPtr(0)
                                     , bValid(false)
                                     , bInitialized(false)
commit 06d44ce1d6a2a5d57699381c9dbd0707e63e1faa
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sat Mar 22 20:46:00 2014 +0000

    coverity#708156 Uninitialized scalar field
    
    Change-Id: I0ef0047684bf97453c7f0bd958aee73ec5af26a6

diff --git a/sfx2/source/control/request.cxx b/sfx2/source/control/request.cxx
index b2fe778..dfa3573 100644
--- a/sfx2/source/control/request.cxx
+++ b/sfx2/source/control/request.cxx
@@ -77,6 +77,8 @@ struct SfxRequest_Impl: public SfxListener
                         , pShell(0)
                         , pSlot(0)
                         , nModifier(0)
+                        , bDone(false)
+                        , bIgnored(false)
                         , bCancelled(false)
                         , nCallMode( SFX_CALLMODE_SYNCHRON )
                         , bAllowRecording( false )
commit 893e6f6ac6aab9e86d499d90d9e4b3e5ff9017e8
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sat Mar 22 20:45:09 2014 +0000

    bUseTarget is never read
    
    Change-Id: I1a21cfd62de2e188c93453f7eebb4d322010de3a

diff --git a/sfx2/source/control/request.cxx b/sfx2/source/control/request.cxx
index c96fc99..b2fe778 100644
--- a/sfx2/source/control/request.cxx
+++ b/sfx2/source/control/request.cxx
@@ -63,7 +63,6 @@ struct SfxRequest_Impl: public SfxListener
     bool            bDone;       // at all executed
     bool            bIgnored;    // Cancelled by the User
     bool            bCancelled;  // no longer notify
-    bool            bUseTarget;  // aTarget was set by Application
     sal_uInt16      nCallMode;   // Synch/Asynch/API/Record
     bool            bAllowRecording;
     SfxAllItemSet*  pInternalArgs;
@@ -150,7 +149,6 @@ SfxRequest::SfxRequest
     pImp->pShell = 0;
     pImp->pSlot = 0;
     pImp->nCallMode = rOrig.pImp->nCallMode;
-    pImp->bUseTarget = rOrig.pImp->bUseTarget;
     pImp->aTarget = rOrig.pImp->aTarget;
     pImp->nModifier = rOrig.pImp->nModifier;
 
@@ -192,7 +190,6 @@ SfxRequest::SfxRequest
     pImp->pShell = 0;
     pImp->pSlot = 0;
     pImp->nCallMode = SFX_CALLMODE_SYNCHRON;
-    pImp->bUseTarget = false;
     pImp->pViewFrame = pViewFrame;
     if( pImp->pViewFrame->GetDispatcher()->GetShellAndSlot_Impl( nSlotId, &pImp->pShell, &pImp->pSlot, true, true ) )
     {
@@ -233,7 +230,6 @@ SfxRequest::SfxRequest
     pImp->pShell = 0;
     pImp->pSlot = 0;
     pImp->nCallMode = nMode;
-    pImp->bUseTarget = false;
 }
 
 SfxRequest::SfxRequest
@@ -254,7 +250,6 @@ SfxRequest::SfxRequest
     pImp->pShell = 0;
     pImp->pSlot = 0;
     pImp->nCallMode = nMode;
-    pImp->bUseTarget = false;
     TransformParameters( nSlot, rArgs, *pArgs, pSlot );
 }
 
@@ -280,7 +275,6 @@ SfxRequest::SfxRequest
     pImp->pShell = 0;
     pImp->pSlot = 0;
     pImp->nCallMode = nMode;
-    pImp->bUseTarget = false;
 }
 
 
commit 1f1a0af795dec9c6de8611b276070ec99d0bab6b
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sat Mar 22 20:43:05 2014 +0000

    coverity#707872 Uninitialized scalar field
    
    Change-Id: I1dda581122caff16ab6d00a5f241d032cd021499

diff --git a/framework/source/accelerators/presethandler.cxx b/framework/source/accelerators/presethandler.cxx
index 8302086..a57771d 100644
--- a/framework/source/accelerators/presethandler.cxx
+++ b/framework/source/accelerators/presethandler.cxx
@@ -85,10 +85,11 @@ OUString PresetHandler::RESOURCETYPE_STATUSBAR()
 
 
 PresetHandler::PresetHandler(const css::uno::Reference< css::uno::XComponentContext >& xContext)
-    : m_xContext         (xContext                                )
-    , m_aSharedStorages  (                                     )
+    : m_xContext(xContext)
+    , m_eConfigType(E_GLOBAL)
+    , m_aSharedStorages()
     , m_lDocumentStorages()
-    , m_aLanguageTag     (LANGUAGE_USER_PRIV_NOTRANSLATE)
+    , m_aLanguageTag(LANGUAGE_USER_PRIV_NOTRANSLATE)
 {
 }
 
commit ae97d0c4f364f4085d027c1770be6896627f41d2
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sat Mar 22 20:40:50 2014 +0000

    covertity#707954 Uninitialized scalar field
    
    Change-Id: I837a2065e0f604ca53b5ebb7464bff9db0cbaf6b

diff --git a/include/oox/ppt/animationspersist.hxx b/include/oox/ppt/animationspersist.hxx
index 8b05268..1c39272 100644
--- a/include/oox/ppt/animationspersist.hxx
+++ b/include/oox/ppt/animationspersist.hxx
@@ -55,8 +55,11 @@ namespace oox { namespace ppt {
     struct ShapeTargetElement
     {
         ShapeTargetElement()
-            : mnType( 0 )
-            {}
+            : mnType(0)
+            , mnRangeType(0)
+        {
+            maRange.start = maRange.end = 0;
+        }
         void convert( ::com::sun::star::uno::Any & aAny, sal_Int16 & rSubType ) const;
 
         sal_Int32               mnType;
commit fb7fb4a9fdac60a004ec4c86afc451a5b5585955
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sat Mar 22 20:38:29 2014 +0000

    coverity#738582 Uninitialized pointer field
    
    Change-Id: I8b717acba8e5b7e04258a6e76111fc6e867b3057

diff --git a/cui/source/dialogs/cuigaldlg.cxx b/cui/source/dialogs/cuigaldlg.cxx
index b1d359d..a2d26e0 100644
--- a/cui/source/dialogs/cuigaldlg.cxx
+++ b/cui/source/dialogs/cuigaldlg.cxx
@@ -695,10 +695,12 @@ SfxTabPage* TPGalleryThemeGeneral::Create( Window* pParent, const SfxItemSet& rS
 // - TPGalleryThemeProperties -
 TPGalleryThemeProperties::TPGalleryThemeProperties( Window* pWindow, const SfxItemSet& rSet )
     : SfxTabPage(pWindow, "GalleryFilesPage", "cui/ui/galleryfilespage.ui", rSet)
+    , pData(NULL)
     , nCurFilterPos(0)
     , nFirstExtFilterPos(0)
     , bEntriesFound(false)
     , bInputAllowed(true)
+    , bTakeAll(false)
     , bSearchRecursive(false)
     , xDialogListener(new ::svt::DialogClosedListener())
 {
commit 51bef3b727bfbd2dd4eae974e6840e4ace216a61
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sat Mar 22 20:36:28 2014 +0000

    coverity#738626 Uninitialized pointer field
    
    Change-Id: I8468009fafff845c249bddb88417a5ceeb556fb0

diff --git a/extensions/source/propctrlr/propertyeditor.cxx b/extensions/source/propctrlr/propertyeditor.cxx
index 0cf8dff..c302e44 100644
--- a/extensions/source/propctrlr/propertyeditor.cxx
+++ b/extensions/source/propctrlr/propertyeditor.cxx
@@ -44,6 +44,8 @@ namespace pcr
     OPropertyEditor::OPropertyEditor( Window* pParent, WinBits nWinStyle)
             :Control(pParent, nWinStyle)
             ,m_aTabControl( this )
+            ,m_pListener(NULL)
+            ,m_pObserver(NULL)
             ,m_nNextId(1)
             ,m_bHasHelpSection( false )
             ,m_nMinHelpLines( 0 )


More information about the Libreoffice-commits mailing list