[Libreoffice-commits] dev-tools.git: scripts/gerrit-filter-domain

Miklos Vajna vmiklos at collabora.co.uk
Mon Mar 24 02:44:33 PDT 2014


 scripts/gerrit-filter-domain |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit f4a7adb7f11182d7005f9216d7e4b4665ac9cb27
Author: Miklos Vajna <vmiklos at collabora.co.uk>
Date:   Mon Mar 24 10:44:05 2014 +0100

    gerrit-filter-domain: consider -2 as negative review and allow regexes
    
    Change-Id: I8c0c487044661af9c8655ec6d4a010a950498d4f

diff --git a/scripts/gerrit-filter-domain b/scripts/gerrit-filter-domain
index 69eca4c..1b1e464 100755
--- a/scripts/gerrit-filter-domain
+++ b/scripts/gerrit-filter-domain
@@ -12,6 +12,7 @@
 #
 
 import json
+import re
 import subprocess
 import sys
 
@@ -23,7 +24,7 @@ def dumpChange(change):
 def filterDomain(changes, domain):
     ret = []
     for i in changes:
-        if i['owner']['email'].endswith(domain):
+        if re.match(domain, i['owner']['email']):
             ret.append(i)
     return ret
 
@@ -59,8 +60,8 @@ def main(argv):
                     break
             if not skip:
                 for j in i['patchSets'][-1]['approvals']:
-                    if j['value'] == "-1":
-                        skippedChanges.append((i, "-1 review"))
+                    if j['value'] in ("-1", "-2"):
+                        skippedChanges.append((i, "negative review"))
                         skip = True
                         break
         except:


More information about the Libreoffice-commits mailing list