[Libreoffice-commits] core.git: 2 commits - include/cppuhelper include/osl

Caolán McNamara caolanm at redhat.com
Thu May 1 01:00:22 PDT 2014


 include/cppuhelper/weak.hxx |    1 +
 include/osl/file.hxx        |    9 ++++-----
 2 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 66a777c3d4c926aa2bd3d40da4852e769ad6ddc2
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Apr 30 21:12:09 2014 +0100

    coverity#707976 Uninitialized pointer field
    
    Change-Id: I6e62d97dc1c7020320aa9a0b58a692ca2dc6f617

diff --git a/include/osl/file.hxx b/include/osl/file.hxx
index a797da0..7dfafdc 100644
--- a/include/osl/file.hxx
+++ b/include/osl/file.hxx
@@ -680,16 +680,15 @@ public:
         @param nMask
         Set of flags decribing the demanded information.
     */
-
-    FileStatus( sal_uInt32 nMask ): _nMask( nMask )
+    FileStatus(sal_uInt32 nMask)
+        : _nMask(nMask)
     {
-        _aStatus.uStructSize = sizeof( oslFileStatus );
-        memset( &_aStatus.uValidFields, 0, sizeof( oslFileStatus ) - sizeof( sal_uInt32 ) );
+        memset(&_aStatus, 0, sizeof(_aStatus));
+        _aStatus.uStructSize = sizeof(_aStatus);
     }
 
     /** Destructor.
     */
-
     ~FileStatus()
     {
         if ( _aStatus.ustrFileURL )
commit aa668984f6a1f6e5c4d3d23dc89bab59f66baa5c
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Apr 30 21:04:14 2014 +0100

    coverity#707714: Uninitialized pointer
    
    Change-Id: I98e21ad28ea31bae41894d1804cbafe0c247035d

diff --git a/include/cppuhelper/weak.hxx b/include/cppuhelper/weak.hxx
index dcddbb6..03399fe 100644
--- a/include/cppuhelper/weak.hxx
+++ b/include/cppuhelper/weak.hxx
@@ -102,6 +102,7 @@ public:
     inline OWeakObject() SAL_THROW(())
         : m_refCount( 0 )
         , m_pWeakConnectionPoint( 0 )
+        , m_pReserved(0)
         {}
 #endif
     /** Dummy copy constructor.  Set the reference count to zero.


More information about the Libreoffice-commits mailing list