[Libreoffice-commits] core.git: sal/qa

Chris Sherlock chris.sherlock79 at gmail.com
Thu May 1 06:27:28 PDT 2014


 sal/qa/osl/file/osl_File.cxx |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit bd22c1ca588147dd522542fcc39ba8b3f5c3b16c
Author: Chris Sherlock <chris.sherlock79 at gmail.com>
Date:   Thu May 1 23:19:43 2014 +1000

    coverity#1209781 Resource leak
    
    We should free pTV_modify when we're done with it.
    
    Change-Id: I7eaf64df2f7bdf6bd899d3a31cad499c4066c990

diff --git a/sal/qa/osl/file/osl_File.cxx b/sal/qa/osl/file/osl_File.cxx
index 8888261..5e5093b 100644
--- a/sal/qa/osl/file/osl_File.cxx
+++ b/sal/qa/osl/file/osl_File.cxx
@@ -1860,7 +1860,7 @@ namespace osl_FileStatus
             CPPUNIT_ASSERT( nError == FileBase::E_None );
 
             //get modify time
-            TimeValue *pTV_modify = NULL;
+            TimeValue* pTV_modify = NULL;
             CPPUNIT_ASSERT( ( pTV_modify = ( TimeValue* )malloc( sizeof( TimeValue ) ) ) != NULL );
             *pTV_modify = rFileStatus.getModifyTime();
 
@@ -1868,6 +1868,7 @@ namespace osl_FileStatus
             //delete file
             deleteTestFile( aTypeURL );
             free( pTV_current );
+            free( pTV_modify );
 
             CPPUNIT_ASSERT_MESSAGE( "test for getModifyTime function: This test turns out that UNX pricision is no more than 1 sec, don't know how to improve this function.  ",
                                     bOK );


More information about the Libreoffice-commits mailing list