[Libreoffice-commits] core.git: 51 commits - avmedia/source basic/source editeng/source filter/source formula/source framework/source hwpfilter/source include/filter include/oox lotuswordpro/source odk/qa oox/source registry/source rsc/source sal/qa sax/source sc/qa sc/source sd/source sfx2/source slideshow/source stoc/source svl/source svtools/source svx/source sw/source tools/source vcl/generic vcl/source
Caolán McNamara
caolanm at redhat.com
Sat May 10 13:13:38 PDT 2014
avmedia/source/opengl/oglmanager.cxx | 3
basic/source/basmgr/basmgr.cxx | 6 +
editeng/source/misc/svxacorr.cxx | 15 ++-
filter/source/graphicfilter/icgm/cgm.cxx | 1
filter/source/graphicfilter/icgm/chart.cxx | 28 +----
filter/source/graphicfilter/icgm/chart.hxx | 47 ++++++++-
filter/source/msfilter/escherex.cxx | 9 +
formula/source/core/api/FormulaCompiler.cxx | 8 +
framework/source/loadenv/loadenv.cxx | 1
framework/source/uielement/controlmenucontroller.cxx | 7 +
hwpfilter/source/hbox.cxx | 3
hwpfilter/source/hinfo.cxx | 29 ++++-
hwpfilter/source/hinfo.h | 60 ++++++++----
hwpfilter/source/hwpread.cxx | 12 +-
include/filter/msfilter/svdfppt.hxx | 1
include/oox/crypto/CryptTools.hxx | 2
lotuswordpro/source/filter/lwppara.cxx | 1
odk/qa/checkapi/strings.cxx | 4
oox/source/crypto/CryptTools.cxx | 9 +
registry/source/reflwrit.cxx | 1
rsc/source/tools/rscdef.cxx | 4
sal/qa/osl/file/osl_File.cxx | 6 +
sax/source/expatwrap/xml2utf.cxx | 3
sc/qa/unit/ucalc.cxx | 3
sc/source/core/data/dociter.cxx | 4
sc/source/core/tool/adiasync.cxx | 4
sc/source/core/tool/queryparam.cxx | 3
sc/source/filter/excel/xilink.cxx | 9 +
sc/source/filter/inc/scflt.hxx | 73 +++++++++++++++
sc/source/filter/starcalc/scflt.cxx | 39 ++++----
sc/source/filter/xml/XMLExportIterator.cxx | 1
sc/source/ui/cctrl/checklistmenu.cxx | 7 +
sd/source/ui/slideshow/slideshowimpl.cxx | 1
sfx2/source/dialog/templdlg.cxx | 8 -
slideshow/source/engine/shapes/drawinglayeranimation.cxx | 3
stoc/source/security/lru_cache.h | 2
svl/source/misc/adrparse.cxx | 4
svtools/source/dialogs/addresstemplate.cxx | 3
svtools/source/svrtf/svparser.cxx | 1
svx/source/customshapes/EnhancedCustomShape3d.cxx | 2
svx/source/xoutdev/xattr.cxx | 5 -
sw/source/core/uibase/dbui/mmconfigitem.cxx | 4
sw/source/core/undo/unmove.cxx | 3
sw/source/filter/ww8/ww8scan.hxx | 3
tools/source/generic/bigint.cxx | 3
vcl/generic/print/common_gfx.cxx | 31 +++---
vcl/generic/print/printerjob.cxx | 4
vcl/source/filter/wmf/wmfwr.cxx | 4
48 files changed, 354 insertions(+), 130 deletions(-)
New commits:
commit 51251205e6b7a84912dc002694a9195497c4a818
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 21:00:26 2014 +0100
coverity#1202962 Uninitialized scalar field
Change-Id: I3e85ecd27e5ee7a1b449bf7e63a7fcdfe9b2fc46
diff --git a/filter/source/graphicfilter/icgm/cgm.cxx b/filter/source/graphicfilter/icgm/cgm.cxx
index d168101..a9808b7 100644
--- a/filter/source/graphicfilter/icgm/cgm.cxx
+++ b/filter/source/graphicfilter/icgm/cgm.cxx
@@ -36,6 +36,7 @@ CGM::CGM( sal_uInt32 nMode, uno::Reference< frame::XModel > & rModel )
: mnOutdx(28000)
, mnOutdy(21000)
, mnVDCXadd(0)
+ , mnVDCYadd(0)
, mnVDCXmul(0)
, mnVDCYmul(0)
, mnVDCdx(0)
commit cbde35dd94d26cf6c2423eda448c04efbafaaf4b
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:59:04 2014 +0100
coverity#707812 Uninitialized scalar field
Change-Id: I738ed7b2a5c311a71f8dd7a638808acc98b31b7f
diff --git a/filter/source/graphicfilter/icgm/chart.cxx b/filter/source/graphicfilter/icgm/chart.cxx
index 5421af80..f5e179a 100644
--- a/filter/source/graphicfilter/icgm/chart.cxx
+++ b/filter/source/graphicfilter/icgm/chart.cxx
@@ -17,14 +17,13 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
-
#include <main.hxx>
#include <chart.hxx>
-
-CGMChart::CGMChart( CGM& rCGM ) :
- mpCGM ( &rCGM )
+CGMChart::CGMChart(CGM& rCGM)
+ : mpCGM(&rCGM)
+ , mnCurrentFileType(0)
{
for ( sal_Int8 i = 0; i < 7; i++ )
{
@@ -33,9 +32,7 @@ CGMChart::CGMChart( CGM& rCGM ) :
mDataNode[ i ].nZoneEnum = i;
}
-};
-
-
+}
CGMChart::~CGMChart()
{
@@ -45,9 +42,7 @@ CGMChart::~CGMChart()
{
DeleteTextEntry( maTextEntryList[ 0 ] );
}
-};
-
-
+}
void CGMChart::DeleteTextEntry( TextEntry* pTextEntry )
{
@@ -71,28 +66,21 @@ void CGMChart::DeleteTextEntry( TextEntry* pTextEntry )
}
delete pTextEntry;
}
-};
-
-
+}
void CGMChart::InsertTextEntry( TextEntry* pTextEntry )
{
maTextEntryList.push_back( pTextEntry );
-};
-
-
-
+}
void CGMChart::ResetAnnotation()
{
mDataNode[ 0 ].nZoneEnum = 0;
}
-
-
bool CGMChart::IsAnnotation()
{
return ( mDataNode[ 0 ].nZoneEnum == 0 );
-};
+}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/filter/source/graphicfilter/icgm/chart.hxx b/filter/source/graphicfilter/icgm/chart.hxx
index 6d16dc3..3fced99 100644
--- a/filter/source/graphicfilter/icgm/chart.hxx
+++ b/filter/source/graphicfilter/icgm/chart.hxx
@@ -143,13 +143,20 @@ struct BulletOption
}
};
-typedef struct BulDef
+struct BulDef
{
char btype;
char bsize;
char bcolor;
char bnumber;
-} BulDef;
+ BulDef()
+ : btype(0)
+ , bsize(0)
+ , bcolor(0)
+ , bnumber(0)
+ {
+ }
+};
typedef struct BulletLines
{
@@ -179,24 +186,39 @@ struct IntSettings
}
};
-typedef struct PageOrientDim
+struct PageOrientDim
{
char nOrientation;
char nDimension;
float nPageX;
float nPageY;
-} PageOrientDim;
+ PageOrientDim()
+ : nOrientation(0)
+ , nDimension(0)
+ , nPageX(0.0)
+ , nPageY(0.0)
+ {
+ }
+};
-typedef struct DataNode
+struct DataNode
{
sal_Int16 nBoxX1;
sal_Int16 nBoxY1;
sal_Int16 nBoxX2;
sal_Int16 nBoxY2;
sal_Int8 nZoneEnum;
-} DataNode;
+ DataNode()
+ : nBoxX1(0)
+ , nBoxY1(0)
+ , nBoxX2(0)
+ , nBoxY2(0)
+ , nZoneEnum(0)
+ {
+ }
+};
-typedef struct ChartZone
+struct ChartZone
{
sal_Int16 nMinX;
sal_Int16 nMinY;
@@ -204,7 +226,16 @@ typedef struct ChartZone
sal_Int16 nMaxY;
char nUserDef;
char nPad1;
-} ChartZone;
+ ChartZone()
+ : nMinX(0)
+ , nMinY(0)
+ , nMaxX(0)
+ , nMaxY(0)
+ , nUserDef(0)
+ , nPad1(0)
+ {
+ }
+};
class CGM;
class CGMImpressOutAct;
commit 634fcdfef2dd8d1bb2dc119fa170db282fabeab8
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:52:27 2014 +0100
coverity#707836 Uninitialized pointer field
Change-Id: Id7cc5781e2f12b726a410ab2b4527f4103019334
diff --git a/filter/source/msfilter/escherex.cxx b/filter/source/msfilter/escherex.cxx
index 8c13dd8..7217ec1 100644
--- a/filter/source/msfilter/escherex.cxx
+++ b/filter/source/msfilter/escherex.cxx
@@ -151,12 +151,13 @@ void EscherPropertyContainer::ImplInit()
pSortStruct = new EscherPropSortStruct[ nSortBufSize ];
}
-EscherPropertyContainer::EscherPropertyContainer() :
- pGraphicProvider ( NULL ),
- pPicOutStrm ( NULL )
+EscherPropertyContainer::EscherPropertyContainer()
+ : pGraphicProvider(NULL)
+ , pPicOutStrm(NULL)
+ , pShapeBoundRect(NULL)
{
ImplInit();
-};
+}
EscherPropertyContainer::EscherPropertyContainer(
EscherGraphicProvider& rGraphProv,
commit 90c644a8629f098dd4936d92173202fdc3f21e4a
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:51:29 2014 +0100
coverity#707866 Uninitialized pointer field
Change-Id: Ia80922b1819d41e4963689fda87750f0f507fd57
diff --git a/formula/source/core/api/FormulaCompiler.cxx b/formula/source/core/api/FormulaCompiler.cxx
index 58a8961..7064e0f 100644
--- a/formula/source/core/api/FormulaCompiler.cxx
+++ b/formula/source/core/api/FormulaCompiler.cxx
@@ -540,22 +540,24 @@ FormulaCompiler::FormulaCompiler( FormulaTokenArray& rArr )
bCompileForFAP( false ),
bIgnoreErrors( false ),
glSubTotal( false )
-
{
}
FormulaCompiler::FormulaCompiler()
:
pArr( NULL ),
+ pCode( NULL ),
pStack( NULL ),
+ eLastOp( ocPush ),
nRecursion(0),
nNumFmt( NUMBERFORMAT_UNDEFINED ),
+ pc( 0 ),
meGrammar( formula::FormulaGrammar::GRAM_UNSPECIFIED ),
bAutoCorrect( false ),
bCorrected( false ),
bCompileForFAP( false ),
- bIgnoreErrors( false )
-
+ bIgnoreErrors( false ),
+ glSubTotal( false )
{
}
commit 4d9009f3107f4a00069f3325819f6d6005911ff5
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:50:12 2014 +0100
coverity#707880 Uninitialized scalar field
Change-Id: I71c15e00228a6eb4ceb2019ee4ae6d14438fe831
diff --git a/framework/source/loadenv/loadenv.cxx b/framework/source/loadenv/loadenv.cxx
index 9d0c445..ed4bb45 100644
--- a/framework/source/loadenv/loadenv.cxx
+++ b/framework/source/loadenv/loadenv.cxx
@@ -131,6 +131,7 @@ LoadEnv::LoadEnv(const css::uno::Reference< css::uno::XComponentContext >& xCont
, m_eContentType(E_UNSUPPORTED_CONTENT)
, m_bCloseFrameOnError(false)
, m_bReactivateControllerOnError(false)
+ , m_bLoaded( 0 )
, m_pQuietInteraction( 0 )
{
}
commit 3c29c3bd70b01a894e67b1910976e0e5cc3f24cd
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:49:06 2014 +0100
coverity#984094 Uninitialized scalar field
Change-Id: Ied78aaa315da9bbcbd5b26a223f41da4526e2384
diff --git a/hwpfilter/source/hbox.cxx b/hwpfilter/source/hbox.cxx
index c3c7eca..006dc4c 100644
--- a/hwpfilter/source/hbox.cxx
+++ b/hwpfilter/source/hbox.cxx
@@ -76,16 +76,15 @@ hunit HBox::Height(CharShape *csty)
return( csty->size );
}
-
// skip block
SkipData::SkipData(hchar hch)
: HBox(hch)
, data_block_len(0)
+ , dummy(0)
, data_block(0)
{
}
-
SkipData::~SkipData(void)
{
delete[]data_block;
commit 50104ef4ab7102d03a2f4a30f8c7267cb668d7b5
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:48:04 2014 +0100
coverity#707916 Uninitialized scalar field
Change-Id: I42a2c556739d41728c68516646facd2009232ae2
diff --git a/hwpfilter/source/hwpread.cxx b/hwpfilter/source/hwpread.cxx
index c98b85d..5763a5b 100644
--- a/hwpfilter/source/hwpread.cxx
+++ b/hwpfilter/source/hwpread.cxx
@@ -775,15 +775,16 @@ bool TocMark::Read(HWPFile & hwpf)
return !hwpf.State();
}
-
// index mark(26)
IndexMark::IndexMark()
: HBox(CH_INDEX_MARK)
+ , pgno(0)
, dummy(0)
{
+ memset(keyword1, 0, sizeof(keyword1));
+ memset(keyword2, 0, sizeof(keyword2));
}
-
bool IndexMark::Read(HWPFile & hwpf)
{
hwpf.Read2b(&keyword1, 60);
commit 7c0abbbf18a3328b98afbdc182a32f721165009d
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:46:54 2014 +0100
coverity#707918 Uninitialized scalar field
Change-Id: I2d54b7afa9dd2639d36cdead4e4e94866d775c8d
diff --git a/hwpfilter/source/hwpread.cxx b/hwpfilter/source/hwpread.cxx
index dd9bc91..c98b85d 100644
--- a/hwpfilter/source/hwpread.cxx
+++ b/hwpfilter/source/hwpread.cxx
@@ -698,13 +698,14 @@ bool PageNumCtrl::Read(HWPFile & hwpf)
return !hwpf.State();
}
-
// mail merge(22)
-MailMerge::MailMerge():HBox(CH_MAIL_MERGE)
+MailMerge::MailMerge()
+ : HBox(CH_MAIL_MERGE)
+ , dummy(0)
{
+ memset(field_name, 0, sizeof(field_name));
}
-
bool MailMerge::Read(HWPFile & hwpf)
{
hwpf.Read1b(field_name, 20);
commit 2732f2b18d7883d31214d4f0e887168c1dec68c5
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:44:43 2014 +0100
coverity#707784 Uninitialized scalar field
Change-Id: Ibbe836d360fad481f2828b703871c8a242767cef
diff --git a/include/filter/msfilter/svdfppt.hxx b/include/filter/msfilter/svdfppt.hxx
index 1ce1814..809b96a 100644
--- a/include/filter/msfilter/svdfppt.hxx
+++ b/include/filter/msfilter/svdfppt.hxx
@@ -936,6 +936,7 @@ struct ImplPPTCharPropSet
: mnRefCount ( 1 )
, mnAttrSet( 0 )
, mnFlags( 0 )
+ , mnColor( 0 )
, mnFont( 0 )
, mnAsianOrComplexFont( 0 )
, mnANSITypeface( 0 )
commit 77e1ece55cd378eff27c68b701a7b85a4f091964
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:43:35 2014 +0100
coverity#738741 Uninitialized scalar field
Change-Id: Ia603fd0fca212d4c67daaab87199906c29e3cec7
diff --git a/lotuswordpro/source/filter/lwppara.cxx b/lotuswordpro/source/filter/lwppara.cxx
index 961f111..25a36fb 100644
--- a/lotuswordpro/source/filter/lwppara.cxx
+++ b/lotuswordpro/source/filter/lwppara.cxx
@@ -108,6 +108,7 @@ LwpPara::LwpPara(LwpObjectHeader& objHdr, LwpSvStream* pStrm)
, m_pProps(NULL)
, m_pBreaks(NULL)
, m_pIndentOverride(NULL)
+ , m_FontID(0)
, m_AllText("")
, m_bHasBullet(false)
, m_pSilverBullet(NULL)
commit 92da838efc86c40c78fb6e993b937117b6393af7
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:41:38 2014 +0100
coverity#1079343 Uninitialized pointer field
Change-Id: I05ec88144273c15181e9afa8f616b0ab11695f04
diff --git a/include/oox/crypto/CryptTools.hxx b/include/oox/crypto/CryptTools.hxx
index a724f64..86bfb79 100644
--- a/include/oox/crypto/CryptTools.hxx
+++ b/include/oox/crypto/CryptTools.hxx
@@ -53,6 +53,7 @@ public:
};
protected:
+ CryptoType mType;
#if USE_TLS_OPENSSL
EVP_CIPHER_CTX mContext;
#endif
@@ -61,7 +62,6 @@ protected:
SECItem* mSecParam;
PK11SymKey* mSymKey;
#endif
- CryptoType mType;
#if USE_TLS_OPENSSL
const EVP_CIPHER* getCipher(CryptoType type);
diff --git a/oox/source/crypto/CryptTools.cxx b/oox/source/crypto/CryptTools.cxx
index 6994ca4..1d8a432 100644
--- a/oox/source/crypto/CryptTools.cxx
+++ b/oox/source/crypto/CryptTools.cxx
@@ -16,8 +16,13 @@ namespace core {
using namespace std;
-Crypto::Crypto(CryptoType type) :
- mType(type)
+Crypto::Crypto(CryptoType type)
+ : mType(type)
+#if USE_TLS_NSS
+ , mContext(NULL)
+ , mSecParam(NULL)
+ , mSymKey(NULL)
+#endif
{
#if USE_TLS_NSS
// Initialize NSS, database functions are not needed
commit 106d1621119b919b7f88d1ca34223ac3ba7d7909
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:39:59 2014 +0100
coverity#707966 Uninitialized pointer field
Change-Id: I9aa3bbae431c5fb3f1713a7c48350e82c6618927
diff --git a/registry/source/reflwrit.cxx b/registry/source/reflwrit.cxx
index a4161ec..e463a1f 100644
--- a/registry/source/reflwrit.cxx
+++ b/registry/source/reflwrit.cxx
@@ -700,6 +700,7 @@ TypeWriter::TypeWriter(typereg_Version version,
, m_fileName(fileName)
, m_fieldCount(fieldCount)
, m_methodCount(methodCount)
+ , m_methods(NULL)
, m_referenceCount(referenceCount)
, m_references(NULL)
, m_blop(NULL)
commit 2ae1345e408b6ed3ee041d3413f26103f76918e5
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:38:39 2014 +0100
coverity#984128 Uninitialized scalar field
Change-Id: I4daff986c15bd6fce03fbcfcb8aa4f6e5df967f7
diff --git a/sal/qa/osl/file/osl_File.cxx b/sal/qa/osl/file/osl_File.cxx
index 5e5093b..a403d33 100644
--- a/sal/qa/osl/file/osl_File.cxx
+++ b/sal/qa/osl/file/osl_File.cxx
@@ -2871,7 +2871,11 @@ namespace osl_File
::rtl::ByteSequence aSequence;
public:
- readLine() :nError1(FileBase::E_None) {}
+ readLine()
+ : nError1(FileBase::E_None)
+ , nCount_write(0)
+ {
+ }
// initialization
void setUp() SAL_OVERRIDE
{
commit 1c40075cac0c4ceaf5aafc9ffb15fbaf8d1e5e0a
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:37:24 2014 +0100
coverity#984106 Uninitialized scalar field
Change-Id: Idf7c0e9a71b53990155f962628d0f79659f9ffec
diff --git a/rsc/source/tools/rscdef.cxx b/rsc/source/tools/rscdef.cxx
index c2500f1..7ecbe58 100644
--- a/rsc/source/tools/rscdef.cxx
+++ b/rsc/source/tools/rscdef.cxx
@@ -129,6 +129,7 @@ RscDefine::RscDefine( sal_uLong lKey, const OString& rDefName, sal_Int32 lDefId
RscDefine::RscDefine( sal_uLong lKey, const OString& rDefName,
RscExpression * pExpression )
: StringNode( rDefName )
+ , lId(0)
{
nRefCount = 0;
lFileKey = lKey;
@@ -138,8 +139,7 @@ RscDefine::RscDefine( sal_uLong lKey, const OString& rDefName,
RscDefine::~RscDefine()
{
- if( pExp )
- delete pExp;
+ delete pExp;
if( nRefCount )
RscExit( 14 );
}
commit 11dbe5eede868303dcc7ea4931040adea8ac14c3
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:34:36 2014 +0100
coverity#707979 Uninitialized pointer field
Change-Id: Id41ba6ab2c6f0a43f439c2b45d20d7d76a3cbe82
diff --git a/sax/source/expatwrap/xml2utf.cxx b/sax/source/expatwrap/xml2utf.cxx
index 8a13823..168b3e7 100644
--- a/sax/source/expatwrap/xml2utf.cxx
+++ b/sax/source/expatwrap/xml2utf.cxx
@@ -350,6 +350,9 @@ void XMLFile2UTFConverter::initializeDecoding()
Text2UnicodeConverter::Text2UnicodeConverter( const OString &sEncoding )
+ : m_convText2Unicode(NULL)
+ , m_contextText2Unicode(NULL)
+ , m_rtlEncoding(RTL_TEXTENCODING_DONTKNOW)
{
rtl_TextEncoding encoding = rtl_getTextEncodingFromMimeCharset( sEncoding.getStr() );
if( RTL_TEXTENCODING_DONTKNOW == encoding )
commit 4beb6136bd93e7e8c59a94e372a8c1320ed1b3b7
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:32:53 2014 +0100
coverity#707994 Uninitialized scalar field
Change-Id: I65c96e12bb75cc7ee7db9643be2c385891f80c75
diff --git a/sc/source/core/data/dociter.cxx b/sc/source/core/data/dociter.cxx
index 817ff13..3c9d15d 100644
--- a/sc/source/core/data/dociter.cxx
+++ b/sc/source/core/data/dociter.cxx
@@ -2406,6 +2406,8 @@ ScUsedAreaIterator::ScUsedAreaIterator( ScDocument* pDocument, SCTAB nTable,
, aAttrIter( pDocument, nTable, nCol1, nRow1, nCol2, nRow2 )
, nNextCol( nCol1 )
, nNextRow( nRow1 )
+ , nCellCol( 0 )
+ , nCellRow( 0 )
, nFoundStartCol( 0 )
, nFoundEndCol( 0 )
, nFoundRow( 0 )
commit 5090939e279c044e408463b73448528a1f482cd2
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:30:38 2014 +0100
coverity#707996 Uninitialized scalar field
Change-Id: Id7027b2e511729e5d70c628e75545dc307e429a5
diff --git a/sc/source/core/data/dociter.cxx b/sc/source/core/data/dociter.cxx
index 6763509..817ff13 100644
--- a/sc/source/core/data/dociter.cxx
+++ b/sc/source/core/data/dociter.cxx
@@ -357,10 +357,12 @@ ScDBQueryDataIterator::DataAccessInternal::DataAccessInternal(const ScDBQueryDat
, mpDoc(pDoc)
, pAttrArray(0)
, nNumFormat(0) // Initialized in GetNumberFormat
+ , nNumFmtIndex(0)
, nCol(mpParam->mnField)
, nRow(mpParam->nRow1)
, nAttrEndRow(0)
, nTab(mpParam->nTab)
+ , nNumFmtType(0)
, bCalcAsShown(pDoc->GetDocOptions().IsCalcAsShown())
{
SCSIZE i;
commit db2734880fedd61b02ec6c7c45a194759d55a7a5
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:27:56 2014 +0100
coverity#708014 Uninitialized scalar field
Change-Id: Ie645acc85e43f1b4dc9dade09228b967e2e19fa9
diff --git a/sc/source/core/tool/adiasync.cxx b/sc/source/core/tool/adiasync.cxx
index ad41cfd..727ae42 100644
--- a/sc/source/core/tool/adiasync.cxx
+++ b/sc/source/core/tool/adiasync.cxx
@@ -40,7 +40,9 @@ ScAddInAsync::ScAddInAsync() :
SvtBroadcaster(),
pDocs( NULL ),
mpFuncData( NULL ),
- nHandle( 0 )
+ nHandle( 0 ),
+ meType( NONE ),
+ bValid( false )
{ // nur fuer aSeekObj !
}
commit 74676ec5838e0d408ce37052a1359981ab1555ef
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:25:20 2014 +0100
coverity#1130486 Uninitialized scalar field
Change-Id: I53722c446d5cc651f4e912f21c3e35e40f0e0c7a
diff --git a/sc/source/filter/excel/xilink.cxx b/sc/source/filter/excel/xilink.cxx
index 6bcbdc3..4891dbd 100644
--- a/sc/source/filter/excel/xilink.cxx
+++ b/sc/source/filter/excel/xilink.cxx
@@ -325,11 +325,12 @@ const ScMatrix& XclImpExtName::MOper::GetCache() const
return *mxCached;
}
-XclImpExtName::XclImpExtName( XclImpSupbook& rSupbook, XclImpStream& rStrm, XclSupbookType eSubType, ExcelToSc* pFormulaConv ) :
- mpMOper(NULL)
+XclImpExtName::XclImpExtName( XclImpSupbook& rSupbook, XclImpStream& rStrm, XclSupbookType eSubType, ExcelToSc* pFormulaConv )
+ : mpMOper(NULL)
+ , mnStorageId(0)
{
- sal_uInt16 nFlags;
- sal_uInt8 nLen;
+ sal_uInt16 nFlags(0);
+ sal_uInt8 nLen(0);
rStrm >> nFlags >> mnStorageId >> nLen ;
maName = rStrm.ReadUniString( nLen );
commit d2712feb7f828870f2aac3bf42c3c3ce19aeceae
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:23:05 2014 +0100
coverity#984136 Uninitialized scalar field
Change-Id: I1568b9bf7fdd21dacf100577bcccba588212ae50
diff --git a/sc/source/filter/inc/scflt.hxx b/sc/source/filter/inc/scflt.hxx
index 9824eb6..157fb7b 100644
--- a/sc/source/filter/inc/scflt.hxx
+++ b/sc/source/filter/inc/scflt.hxx
@@ -192,6 +192,11 @@ struct Sc10ValueFormat
{
sal_uInt8 Format; // Zahl, Waehrung, Prozent etc.
sal_uInt8 Info; // Anzahl Nachkommastellen, Anzahl Stellen, bzw. Datums/Zeitformat
+ Sc10ValueFormat()
+ : Format(0)
+ , Info(0)
+ {
+ }
};
// Fontbeschreibung
@@ -212,6 +217,24 @@ struct Sc10LogFont
sal_uInt8 lfPitchAndFamily;
sal_Char lfFaceName[32];
+ Sc10LogFont()
+ : lfHeight(0)
+ , lfWidth(0)
+ , lfEscapement(0)
+ , lfOrientation(0)
+ , lfWeight(0)
+ , lfItalic(0)
+ , lfUnderline(0)
+ , lfStrikeOut(0)
+ , lfCharSet(0)
+ , lfOutPrecision(0)
+ , lfClipPrecision(0)
+ , lfQuality(0)
+ , lfPitchAndFamily(0)
+ {
+ memset(lfFaceName, 0, sizeof(lfFaceName));
+ }
+
bool operator==( const Sc10LogFont& rData ) const;
};
diff --git a/sc/source/filter/starcalc/scflt.cxx b/sc/source/filter/starcalc/scflt.cxx
index b9251bf..4bb7f17 100644
--- a/sc/source/filter/starcalc/scflt.cxx
+++ b/sc/source/filter/starcalc/scflt.cxx
@@ -490,26 +490,33 @@ Sc10NameCollection::Sc10NameCollection(SvStream& rStream) :
// Vorlagen
-
-
Sc10PatternData::Sc10PatternData(SvStream& rStream)
+ : Attr(0)
+ , Justify(0)
+ , Frame(0)
+ , Raster(0)
+ , nColor(0)
+ , FrameColor(0)
+ , Flags(0)
+ , FormatFlags(0)
{
- lcl_ReadFixedString( rStream, Name, sizeof(Name));
- lcl_ReadValueFormat(rStream, ValueFormat);
- lcl_ReadLogFont(rStream, LogFont);
-
- rStream.ReadUInt16( Attr );
- rStream.ReadUInt16( Justify );
- rStream.ReadUInt16( Frame );
- rStream.ReadUInt16( Raster );
- rStream.ReadUInt16( nColor );
- rStream.ReadUInt16( FrameColor );
- rStream.ReadUInt16( Flags );
- rStream.ReadUInt16( FormatFlags );
- rStream.Read(Reserved, sizeof(Reserved));
+ memset(Name, 0, sizeof(Name));
+ memset(Reserved, 0, sizeof(Reserved));
+ lcl_ReadFixedString( rStream, Name, sizeof(Name));
+ lcl_ReadValueFormat(rStream, ValueFormat);
+ lcl_ReadLogFont(rStream, LogFont);
+
+ rStream.ReadUInt16( Attr );
+ rStream.ReadUInt16( Justify );
+ rStream.ReadUInt16( Frame );
+ rStream.ReadUInt16( Raster );
+ rStream.ReadUInt16( nColor );
+ rStream.ReadUInt16( FrameColor );
+ rStream.ReadUInt16( Flags );
+ rStream.ReadUInt16( FormatFlags );
+ rStream.Read(Reserved, sizeof(Reserved));
}
-
Sc10PatternCollection::Sc10PatternCollection(SvStream& rStream) :
ScCollection (4, 4),
nError (0)
commit 96585a0aa342bb0fc494abd15d3b4352e8cd46c9
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 20:18:45 2014 +0100
coverity#984137 Uninitialized scalar field
Change-Id: Ia818abdcab65dc5b950c6b6a29b71910b6eb665e
diff --git a/sc/source/filter/inc/scflt.hxx b/sc/source/filter/inc/scflt.hxx
index fff1d48..9824eb6 100644
--- a/sc/source/filter/inc/scflt.hxx
+++ b/sc/source/filter/inc/scflt.hxx
@@ -239,6 +239,13 @@ struct Sc10BlockRect
sal_Int16 y1;
sal_Int16 x2;
sal_Int16 y2;
+ Sc10BlockRect()
+ : x1(0)
+ , y1(0)
+ , x2(0)
+ , y2(0)
+ {
+ }
};
// Datenbank-Bereich
@@ -272,6 +279,36 @@ struct Sc10DataBaseRec
sal_uInt8 QueryByString2;
sal_Char QueryString2[64];
double QueryValue2;
+ Sc10DataBaseRec()
+ : Tab(0)
+ , RowHeader(0)
+ , SortField0(0)
+ , SortUpOrder0(0)
+ , SortField1(0)
+ , SortUpOrder1(0)
+ , SortField2(0)
+ , SortUpOrder2(0)
+ , IncludeFormat(0)
+ , QueryField0(0)
+ , QueryOp0(0)
+ , QueryByString0(0)
+ , QueryValue0(0.0)
+ , QueryConnect1(0)
+ , QueryField1(0)
+ , QueryOp1(0)
+ , QueryByString1(0)
+ , QueryValue1(0.0)
+ , QueryConnect2(0)
+ , QueryField2(0)
+ , QueryOp2(0)
+ , QueryByString2(0)
+ , QueryValue2(0.0)
+ {
+ memset(Name, 0, sizeof(Name));
+ memset(QueryString0, 0, sizeof(QueryString0));
+ memset(QueryString1, 0, sizeof(QueryString1));
+ memset(QueryString2, 0, sizeof(QueryString2));
+ }
};
// Kopf/Fusszeilen-Beschreibung
commit 88110ed0dc1bf4396d3df7e40b6fda9944c4520c
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:41:17 2014 +0100
coverity#708064 Uninitialized scalar field
Change-Id: Ib9cd4b00d07c25b8a5ab4d5b42f48842a02a2e3d
diff --git a/sc/source/filter/xml/XMLExportIterator.cxx b/sc/source/filter/xml/XMLExportIterator.cxx
index efb9da3..a863e58 100644
--- a/sc/source/filter/xml/XMLExportIterator.cxx
+++ b/sc/source/filter/xml/XMLExportIterator.cxx
@@ -578,6 +578,7 @@ ScMyCell::ScMyCell() :
nValidationIndex(-1),
nStyleIndex(-1),
nNumberFormat(-1),
+ nType(table::CellContentType_EMPTY),
bIsAutoStyle( false ),
bHasShape( false ),
bIsMergedBase( false ),
commit 40a4d8892df998fa835e45091d6ffc105161d47c
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:39:45 2014 +0100
coverity#1079327 Uninitialized pointer field
Change-Id: Ica88a170d1de3298dfa0cc7fad9ed63a46e31d8d
diff --git a/sc/source/ui/cctrl/checklistmenu.cxx b/sc/source/ui/cctrl/checklistmenu.cxx
index 1cc5566..095e11b 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -860,8 +860,11 @@ ScCheckListMenuWindow::Config::Config() :
{
}
-ScCheckListMenuWindow::Member::Member() :
- mbVisible(true), mbDate(false), mbLeaf(false)
+ScCheckListMenuWindow::Member::Member()
+ : mbVisible(true)
+ , mbDate(false)
+ , mbLeaf(false)
+ , mpParent(NULL)
{
}
commit cf0eb5f78a70d311ca2e420c2b045da36b3cb042
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:36:25 2014 +0100
coverity#738826 Uninitialized scalar field
Change-Id: I2d978ca49330e537e19ef19de636fa27b74ff423
diff --git a/sd/source/ui/slideshow/slideshowimpl.cxx b/sd/source/ui/slideshow/slideshowimpl.cxx
index e9dd1f6..f615b87 100644
--- a/sd/source/ui/slideshow/slideshowimpl.cxx
+++ b/sd/source/ui/slideshow/slideshowimpl.cxx
@@ -518,6 +518,7 @@ SlideshowImpl::SlideshowImpl( const Reference< XPresentation2 >& xPresentation,
, mbSlideBorderVisible(false)
, mbSetOnlineSpelling(false)
, mbDisposed(false)
+, mbAutoSaveWasOn(false)
, mbRehearseTimings(false)
, mbDesignMode(false)
, mbIsPaused(false)
commit 6f57a7b93467f0da7be4d22020dfe09d9331d00f
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:35:18 2014 +0100
coverity#1028545 Uninitialized pointer field
Change-Id: Idd4e1497737b8afb5eda283fe82754346f98814d
diff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx
index a5597e8..fd6b5ef 100644
--- a/sfx2/source/dialog/templdlg.cxx
+++ b/sfx2/source/dialog/templdlg.cxx
@@ -783,6 +783,7 @@ SfxCommonTemplateDialog_Impl::SfxCommonTemplateDialog_Impl( SfxBindings* pB, Win
pModule ( NULL ),
pTimer ( NULL ),
m_pStyleFamiliesId ( NULL ),
+ pStyleFamilies ( NULL ),
pStyleSheetPool ( NULL ),
pTreeBox ( NULL ),
pCurObjShell ( NULL ),
@@ -821,9 +822,10 @@ SfxCommonTemplateDialog_Impl::SfxCommonTemplateDialog_Impl( SfxBindings* pB, Win
Font aFont = aFmtLb.GetFont();
aFont.SetWeight( WEIGHT_NORMAL );
aFmtLb.SetFont( aFont );
-}
-
+ memset(pBoundItems, 0, sizeof(pBoundItems));
+ memset(pFamilyState, 0, sizeof(pFamilyState));
+}
sal_uInt16 SfxCommonTemplateDialog_Impl::StyleNrToInfoOffset(sal_uInt16 nId)
{
@@ -831,8 +833,6 @@ sal_uInt16 SfxCommonTemplateDialog_Impl::StyleNrToInfoOffset(sal_uInt16 nId)
return SfxFamilyIdToNId(pItem->GetFamily())-1;
}
-
-
void SfxTemplateDialog_Impl::EnableEdit(bool bEnable)
{
SfxCommonTemplateDialog_Impl::EnableEdit( bEnable );
commit 5fe41a6113c03becb38a63f5fb1aa8f040d7b815
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:32:42 2014 +0100
coverity#738843 Uninitialized scalar field
Change-Id: I59ce41c7191d8506c40018c09d38212ed1988bf9
diff --git a/slideshow/source/engine/shapes/drawinglayeranimation.cxx b/slideshow/source/engine/shapes/drawinglayeranimation.cxx
index fa5299b..5657f2b 100644
--- a/slideshow/source/engine/shapes/drawinglayeranimation.cxx
+++ b/slideshow/source/engine/shapes/drawinglayeranimation.cxx
@@ -754,7 +754,8 @@ ActivityImpl::ActivityImpl(
meAnimKind(drawing::TextAnimationKind_NONE),
mbVisibleWhenStopped(false),
mbVisibleWhenStarted(false),
- mnStartTime(0L)
+ mnStartTime(0L),
+ mnStepWidth(0)
{
// get doctreenode:
sal_Int32 const nNodes = pParentDrawShape->getNumberOfTreeNodes(
commit 2d6b33baed25d674f47bc29c8983eacd74cc85df
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:31:18 2014 +0100
coverity#708240 Uninitialized pointer field
Change-Id: I82bb1587d74f7b1f012ff01d0f68ea8cffd16112
diff --git a/stoc/source/security/lru_cache.h b/stoc/source/security/lru_cache.h
index 56f4710..70f2227 100644
--- a/stoc/source/security/lru_cache.h
+++ b/stoc/source/security/lru_cache.h
@@ -136,6 +136,8 @@ template< typename t_key, typename t_val, typename t_hashKey, typename t_equalKe
inline lru_cache< t_key, t_val, t_hashKey, t_equalKey >::lru_cache() SAL_THROW(())
: m_size( 0 )
, m_block( 0 )
+ , m_head( 0 )
+ , m_tail( 0 )
{
}
commit 0b799c7a2dc25702be6c1acde750b99d7c2ff3d3
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:30:10 2014 +0100
coverity#738855 Uninitialized pointer field
Change-Id: If45c6b7399e19e9414a5ba24a1f6d2e5bb3f82a8
diff --git a/svl/source/misc/adrparse.cxx b/svl/source/misc/adrparse.cxx
index 3b74063..07488a7 100644
--- a/svl/source/misc/adrparse.cxx
+++ b/svl/source/misc/adrparse.cxx
@@ -441,7 +441,9 @@ OUString SvAddressParser_Impl::reparseComment(sal_Unicode const * pBegin,
SvAddressParser_Impl::SvAddressParser_Impl(SvAddressParser * pParser,
const OUString& rInput)
- : m_pCurTokenContentBegin(NULL)
+ : m_pCurTokenBegin(NULL)
+ , m_pCurTokenEnd(NULL)
+ , m_pCurTokenContentBegin(NULL)
, m_pCurTokenContentEnd(NULL)
{
m_pInputPos = rInput.getStr();
commit 828fcdd2705fcdaab7f99e1286a073dde72585bd
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:27:22 2014 +0100
coverity#708306 Uninitialized pointer field
Change-Id: Ia249608d5166273bb6be7b52185d48dffbc918d9
diff --git a/svtools/source/dialogs/addresstemplate.cxx b/svtools/source/dialogs/addresstemplate.cxx
index b3e0883..6c33b4f 100644
--- a/svtools/source/dialogs/addresstemplate.cxx
+++ b/svtools/source/dialogs/addresstemplate.cxx
@@ -481,9 +481,10 @@ void AssignmentPersistentData::Commit()
,bWorkingPersistent( true )
,pConfigData( new AssignmentPersistentData )
{
+ memset(pFieldLabels, 0, sizeof(pFieldLabels));
+ memset(pFields, 0, sizeof(pFields));
}
-
AddressBookSourceDialogData( const Reference< XDataSource >& _rxTransientDS, const OUString& _rDataSourceName,
const OUString& _rTableName, const Sequence< AliasProgrammaticPair >& _rFields )
:m_xTransientDataSource( _rxTransientDS )
commit 2ab8d88ca91654c637e3603816b3dd6ee84aaa3d
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:24:08 2014 +0100
coverity#708336 Uninitialized scalar field
Change-Id: Ie4b6ea734d8ab77060848cd813b44d0727eb47c4
diff --git a/svtools/source/svrtf/svparser.cxx b/svtools/source/svrtf/svparser.cxx
index 890060d..6000dde 100644
--- a/svtools/source/svrtf/svparser.cxx
+++ b/svtools/source/svrtf/svparser.cxx
@@ -69,6 +69,7 @@ SvParser::SvParser( SvStream& rIn, sal_uInt8 nStackSize )
, eState( SVPAR_NOTSTARTED )
, eSrcEnc( RTL_TEXTENCODING_DONTKNOW )
, nNextChPos(0)
+ , nNextCh(0)
, bDownloadingFile(false)
, bUCS2BSrcEnc(false)
, bSwitchToUCS2(false)
commit 84e818dbd33d0a10d125e2cbd04bf2d963f2b5fd
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:22:34 2014 +0100
coverity#708341 Uninitialized scalar field
Change-Id: I1169024f243e447f315f796fdc9c53e8b9006602
diff --git a/svx/source/customshapes/EnhancedCustomShape3d.cxx b/svx/source/customshapes/EnhancedCustomShape3d.cxx
index 9f4c4e7..62249f8 100644
--- a/svx/source/customshapes/EnhancedCustomShape3d.cxx
+++ b/svx/source/customshapes/EnhancedCustomShape3d.cxx
@@ -188,6 +188,8 @@ drawing::Direction3D GetDirection3D( SdrCustomShapeGeometryItem& rItem, const OU
EnhancedCustomShape3d::Transformation2D::Transformation2D( const SdrObject* pCustomShape, const Rectangle& /*rBoundRect*/, const double *pM )
: aCenter( pCustomShape->GetSnapRect().Center() )
, eProjectionMode( drawing::ProjectionMode_PARALLEL )
+ , fSkewAngle(0.0)
+ , fSkew(0.0)
, fZScreen(0.0)
, fOriginX(0.0)
, fOriginY(0.0)
commit fed275bb020ab052153c6ed789f0eea67603d7ad
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:20:59 2014 +0100
coverity#984153 Uninitialized scalar field
Change-Id: I25581ff4471d8a7f50849335dd7bd0ccad7b0742
diff --git a/svx/source/xoutdev/xattr.cxx b/svx/source/xoutdev/xattr.cxx
index a8f6a1b..e302c46 100644
--- a/svx/source/xoutdev/xattr.cxx
+++ b/svx/source/xoutdev/xattr.cxx
@@ -90,8 +90,9 @@ NameOrIndex::NameOrIndex(sal_uInt16 _nWhich, const OUString& rName) :
{
}
-NameOrIndex::NameOrIndex(sal_uInt16 _nWhich, SvStream& rIn) :
- SfxStringItem(_nWhich, rIn)
+NameOrIndex::NameOrIndex(sal_uInt16 _nWhich, SvStream& rIn)
+ : SfxStringItem(_nWhich, rIn)
+ , nPalIndex(-1)
{
rIn.ReadInt32( nPalIndex );
}
commit 59d7d8674a638fb9da41bc34b9963b90ca85c3a8
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:18:45 2014 +0100
coverity#708472 Uninitialized scalar field
Change-Id: I09767fe28069e195b568ce91c62770a85cc7c6ab
diff --git a/sw/source/core/undo/unmove.cxx b/sw/source/core/undo/unmove.cxx
index 52f90df..c7ff4f3 100644
--- a/sw/source/core/undo/unmove.cxx
+++ b/sw/source/core/undo/unmove.cxx
@@ -100,6 +100,9 @@ SwUndoMove::SwUndoMove( SwDoc* pDoc, const SwNodeRange& rRg,
, nDestEndNode(0)
, nInsPosNode(0)
, nMvDestNode(rMvPos.GetIndex())
+ , nDestSttCntnt(0)
+ , nDestEndCntnt(0)
+ , nInsPosCntnt(0)
, bMoveRedlines(false)
{
bMoveRange = true;
commit b5078c327ac3f0fac95b46bcb5349c745209bc03
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:15:59 2014 +0100
coverity#708513 Uninitialized pointer field
Change-Id: Ifcc2356717de7227c52649351f6c7b29568269fe
diff --git a/sw/source/filter/ww8/ww8scan.hxx b/sw/source/filter/ww8/ww8scan.hxx
index 587b8f9..2c3c3d4 100644
--- a/sw/source/filter/ww8/ww8scan.hxx
+++ b/sw/source/filter/ww8/ww8scan.hxx
@@ -833,7 +833,8 @@ struct WW8PLCFxDesc
//GetSprms will not search for the sprms, but instead take the
//existing ones.
WW8PLCFxDesc()
- : pIdStk(0)
+ : pPLCFx(0)
+ , pIdStk(0)
, pMemPos(0)
, nOrigSprmsLen(0)
, nStartPos(WW8_CP_MAX)
commit fec6711974ed856075890bbdcfe8fd9738654498
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:15:11 2014 +0100
coverity#708544 Uninitialized scalar field
Change-Id: If5813e0321ff68ddf2cdbce3cdd216fda2830849
diff --git a/tools/source/generic/bigint.cxx b/tools/source/generic/bigint.cxx
index 5298cd9..e7a98b5 100644
--- a/tools/source/generic/bigint.cxx
+++ b/tools/source/generic/bigint.cxx
@@ -531,6 +531,7 @@ BigInt::BigInt( double nValue )
{
bIsBig = false;
nVal = 0;
+ nLen = 0;
}
else
{
commit b34267cea16020a80b2c809e29a84c94b99add04
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:14:15 2014 +0100
coverity#708545 Uninitialized scalar field
Change-Id: I97efb9c1f3bb6554dfded43129a13f93d1cdd4be
diff --git a/tools/source/generic/bigint.cxx b/tools/source/generic/bigint.cxx
index 07f1806..5298cd9 100644
--- a/tools/source/generic/bigint.cxx
+++ b/tools/source/generic/bigint.cxx
@@ -570,7 +570,9 @@ BigInt::BigInt( sal_uInt32 nValue )
else
{
bIsBig = false;
+ bIsNeg = false;
nVal = nValue;
+ nLen = 0;
}
}
commit 64d1fb5ae94f03f2f470af0407fd257c04a85687
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:12:47 2014 +0100
coverity#708673 Uninitialized pointer field
Change-Id: Idb82efd1548dda067703b2ad077c83f0f6d5a7e5
diff --git a/vcl/generic/print/printerjob.cxx b/vcl/generic/print/printerjob.cxx
index 19b19e8..41a8741 100644
--- a/vcl/generic/print/printerjob.cxx
+++ b/vcl/generic/print/printerjob.cxx
@@ -177,11 +177,11 @@ PrinterJob::GetCurrentPageBody ()
/*
* public methods of PrinterJob: the actual job / spool handling
*/
-
-PrinterJob::PrinterJob ()
+PrinterJob::PrinterJob()
: mnFileMode(0)
, mpJobHeader(NULL)
, mpJobTrailer(NULL)
+ , m_pGraphics(NULL)
, mnResolution(96)
, mnWidthPt(0)
, mnHeightPt(0)
commit c779eec2e2dfac5208cadd4b37833c4eeb31a426
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:11:39 2014 +0100
coverity#708321 Uninitialized scalar field
Change-Id: Ide820b6648579f8d9cbc395843aff602cf895f15
diff --git a/vcl/source/filter/wmf/wmfwr.cxx b/vcl/source/filter/wmf/wmfwr.cxx
index a74555a..dab173c 100644
--- a/vcl/source/filter/wmf/wmfwr.cxx
+++ b/vcl/source/filter/wmf/wmfwr.cxx
@@ -132,7 +132,9 @@
#define PRIVATE_ESCAPE_UNICODE 2
WMFWriter::WMFWriter()
- : pWMF(NULL)
+ : bStatus(false)
+ , nLastPercent(0)
+ , pWMF(NULL)
, pVirDev(NULL)
, nMetafileHeaderPos(0)
, nMaxRecordSize(0)
commit cbe85c63d64d952696aa2643a07ce3af29555c57
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 14:03:22 2014 +0100
coverity#707899 Uninitialized pointer field
Change-Id: Iacdd82589eb56bda653ceb84a0a6a2677f0aabd6
diff --git a/hwpfilter/source/hinfo.cxx b/hwpfilter/source/hinfo.cxx
index 2b81362..0068cf6 100644
--- a/hwpfilter/source/hinfo.cxx
+++ b/hwpfilter/source/hinfo.cxx
@@ -37,14 +37,33 @@ static bool HWPReadInfoBlock(void *ptr, int len, HWPFile & hwpf)
// Document Information
-
-HWPInfo::HWPInfo(void)
+HWPInfo::HWPInfo()
+ : cur_col(0)
+ , cur_row(0)
+ , readonly(false)
+ , encrypted(false)
+ , beginpagenum(0)
+ , beginfnnum(0)
+ , countfn(0)
+ , splinetext(0)
+ , splinefn(0)
+ , spfnfn(0)
+ , fnchar(0)
+ , fnlinetype(0)
+ , borderline(0)
+ , empty_line_hide(0)
+ , table_move(0)
+ , compressed(0)
+ , reserved3(0)
+ , info_block_len(0)
+ , info_block(NULL)
{
- info_block = 0;
- back_info.isset = false;
+ back_info.isset = false;
+ memset(reserved1, 0, sizeof(reserved1));
+ memset(annotation, 0, sizeof(annotation));
+ memset(bordermargin, 0, sizeof(bordermargin));
}
-
HWPInfo::~HWPInfo(void)
{
if (info_block)
diff --git a/hwpfilter/source/hinfo.h b/hwpfilter/source/hinfo.h
index 0b1a45e..d3591b5 100644
--- a/hwpfilter/source/hinfo.h
+++ b/hwpfilter/source/hinfo.h
@@ -21,6 +21,7 @@
#define INCLUDED_HWPFILTER_SOURCE_HINFO_H
#include "hwplib.h"
+#include "string.h"
#define CHAIN_MAX_PATH 40
#define ANNOTATION_LEN 24
@@ -87,12 +88,18 @@ struct PaperBackInfo
/**
* Information of printing for chained page
*/
-typedef struct
+struct DocChainInfo
{
unsigned char chain_page_no;
unsigned char chain_footnote_no;
unsigned char chain_filename[CHAIN_MAX_PATH];
-} DocChainInfo;
+ DocChainInfo()
+ : chain_page_no(0)
+ , chain_footnote_no(0)
+ {
+ memset(chain_filename, 0, sizeof(chain_filename));
+ }
+};
/* ???? ???? */
/**
commit 9be0aaa9d7a489e8e828c4ff4ba665ceb8e5e167
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 13:17:51 2014 +0100
coverity#707899 Uninitialized pointer field
Change-Id: I6efcb9ea5af93ad2b22f974fb0fcf2ddb6d21663
diff --git a/hwpfilter/source/hinfo.h b/hwpfilter/source/hinfo.h
index 81517db..0b1a45e 100644
--- a/hwpfilter/source/hinfo.h
+++ b/hwpfilter/source/hinfo.h
@@ -48,23 +48,40 @@ typedef struct
} PaperInfo;
/* ?????? ??????, ???????? ???? */
-typedef struct
+struct PaperBackInfo
{
- char type; // 0- background color, 1 - external image, 2- embedded image
- char reserved1[8];
- int luminance; /* ???? ( -100 ~ 100 ) */
- int contrast; /* ???? ( -100 ~ 100 ) */
- char effect; /* 0-????????, 1-????????????, 2-???? */
- char reserved2[8];
- char filename[260 + 1]; // filename
- unsigned char color[3]; //0 - red, 1 - green, 2 - blue
- unsigned short flag; /* 0 - ????????, 1 - ????????, 2 - ??????, 3 - ???????? */
- int range; /* 0-????, 1-????????, 3-??????, 4-?????? */
- char reserved3[27];
- int size;
- char *data; // image data
- bool isset;
-} PaperBackInfo;
+ char type; // 0- background color, 1 - external image, 2- embedded image
+ char reserved1[8];
+ int luminance; /* ???? ( -100 ~ 100 ) */
+ int contrast; /* ???? ( -100 ~ 100 ) */
+ char effect; /* 0-????????, 1-????????????, 2-???? */
+ char reserved2[8];
+ char filename[260 + 1]; // filename
+ unsigned char color[3]; //0 - red, 1 - green, 2 - blue
+ unsigned short flag; /* 0 - ????????, 1 - ????????, 2 - ??????, 3 - ???????? */
+ int range; /* 0-????, 1-????????, 3-??????, 4-?????? */
+ char reserved3[27];
+ int size;
+ char *data; // image data
+ bool isset;
+ PaperBackInfo()
+ : type(0)
+ , luminance(0)
+ , contrast(0)
+ , effect(0)
+ , flag(0)
+ , range(0)
+ , size(0)
+ , data(NULL)
+ , isset(false)
+ {
+ memset(reserved1, 0, sizeof(reserved1));
+ memset(reserved2, 0, sizeof(reserved2));
+ memset(filename, 0, sizeof(filename));
+ memset(color, 0, sizeof(color));
+ memset(reserved3, 0, sizeof(reserved3));
+ }
+};
/* ???????? ???? */
/**
commit 9c33cbe903a08ff9e76677fefa335bf3db8417ee
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 13:09:24 2014 +0100
coverity#708020 Uninitialized scalar field
Change-Id: I5354c893039ea3d636d667ceb79c38067213b09e
diff --git a/sc/source/core/tool/queryparam.cxx b/sc/source/core/tool/queryparam.cxx
index 487a577..3e65c4f 100644
--- a/sc/source/core/tool/queryparam.cxx
+++ b/sc/source/core/tool/queryparam.cxx
@@ -227,7 +227,8 @@ void ScQueryParamBase::FillInExcelSyntax(
}
}
-ScQueryParamTable::ScQueryParamTable()
+ScQueryParamTable::ScQueryParamTable() :
+ nCol1(0),nRow1(0),nCol2(0),nRow2(0),nTab(0)
{
}
commit 89d56e950122673b53b653a9776a1053b5baa0c1
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 13:07:03 2014 +0100
coverity#708055 Uninitialized scalar field
Change-Id: Id699d408faca97360a7ae9cb27d0d425dff47750
diff --git a/sc/source/filter/inc/scflt.hxx b/sc/source/filter/inc/scflt.hxx
index 19e331c..fff1d48 100644
--- a/sc/source/filter/inc/scflt.hxx
+++ b/sc/source/filter/inc/scflt.hxx
@@ -223,6 +223,13 @@ struct Sc10Color
sal_uInt8 Green;
sal_uInt8 Red;
bool operator==( const Sc10Color& rColor ) const;
+ Sc10Color()
+ : Dummy(0)
+ , Blue(0)
+ , Green(0)
+ , Red(0)
+ {
+ }
};
// Blockbeschreibung
@@ -334,6 +341,12 @@ struct Sc10SheetProtect
sal_Char PassWord[16];
sal_uInt16 Flags;
sal_uInt8 Protect;
+ Sc10SheetProtect()
+ : Flags(0)
+ , Protect(0)
+ {
+ memset(PassWord, 0, sizeof(PassWord));
+ }
};
// Dateikopf StarCalc 1.0 Datei
commit 061ef06e04d530504d906c1b4b622d2a72f6cd53
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 13:04:11 2014 +0100
coverity#708670 Uninitialized scalar field
Change-Id: I9d864ba345a2ce04bc70715ec548307335cd2f18
diff --git a/vcl/generic/print/common_gfx.cxx b/vcl/generic/print/common_gfx.cxx
index 1463492..7ff3a11 100644
--- a/vcl/generic/print/common_gfx.cxx
+++ b/vcl/generic/print/common_gfx.cxx
@@ -93,18 +93,25 @@ PrinterGfx::GetBitCount ()
return mnDepth;
}
-PrinterGfx::PrinterGfx() :
- mpPageHeader (NULL),
- mpPageBody (NULL),
- mnFontID (0),
- mnFallbackID (0),
- mnTextAngle (0),
- mbTextVertical (false),
- mrFontMgr (PrintFontManager::get()),
- mbCompressBmp (true),
- maFillColor (0xff,0,0),
- maTextColor (0,0,0),
- maLineColor (0, 0xff, 0)
+PrinterGfx::PrinterGfx()
+ : mfScaleX(0.0)
+ , mfScaleY(0.0)
+ , mnDpi(0)
+ , mnDepth(0)
+ , mnPSLevel(0)
+ , mbColor(false)
+ , mbUploadPS42Fonts(false)
+ , mpPageHeader(NULL)
+ , mpPageBody(NULL)
+ , mnFontID(0)
+ , mnFallbackID(0)
+ , mnTextAngle(0)
+ , mbTextVertical(false)
+ , mrFontMgr(PrintFontManager::get())
+ , mbCompressBmp(true)
+ , maFillColor(0xff,0,0)
+ , maTextColor(0,0,0)
+ , maLineColor(0, 0xff, 0)
{
maVirtualStatus.mfLineWidth = 1.0;
maVirtualStatus.mnTextHeight = 12;
commit 989791341686cd143545aa3f1610920145049f10
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 10:06:47 2014 +0100
coverity#1213247 Dereference null return value
Change-Id: I039536322fd1c9c786c4cd7088807aee7e2e929d
diff --git a/framework/source/uielement/controlmenucontroller.cxx b/framework/source/uielement/controlmenucontroller.cxx
index d7446a1..2604b66 100644
--- a/framework/source/uielement/controlmenucontroller.cxx
+++ b/framework/source/uielement/controlmenucontroller.cxx
@@ -321,10 +321,13 @@ void SAL_CALL ControlMenuController::statusChanged( const FeatureStateEvent& Eve
}
}
+ VCLXPopupMenu* pPopupMenu = NULL;
+
if ( nMenuId )
- {
- VCLXPopupMenu* pPopupMenu = (VCLXPopupMenu *)VCLXMenu::GetImplementation( m_xPopupMenu );
+ pPopupMenu = (VCLXPopupMenu *)VCLXMenu::GetImplementation( m_xPopupMenu );
+ if (pPopupMenu)
+ {
SolarMutexGuard aSolarMutexGuard;
PopupMenu* pVCLPopupMenu = (PopupMenu *)pPopupMenu->GetMenu();
commit 3e40e67b09a9ab46bd4dc3a7df29135f6726b02e
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 09:59:07 2014 +0100
coverity#1213270 Parse warning
Change-Id: I60d723e6baebcdb64daaa108a7e1a73554941940
diff --git a/odk/qa/checkapi/strings.cxx b/odk/qa/checkapi/strings.cxx
index 87526ac..9cbf667 100644
--- a/odk/qa/checkapi/strings.cxx
+++ b/odk/qa/checkapi/strings.cxx
@@ -23,9 +23,9 @@
#include "allheaders.hxx"
CPPUNIT_PLUGIN_IMPLEMENT();
-extern "C" SAL_DLLPUBLIC_EXPORT sal_Bool SAL_CALL firstfunc( sal_Bool bRes )
+extern "C" SAL_DLLPUBLIC_EXPORT sal_Bool SAL_CALL firstfunc(sal_Bool)
{
- return ( bRes = sal_True );
+ return sal_True;
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit 34509a0805d408cd45c1b95f5afdafdc46c1501e
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 09:58:09 2014 +0100
coverity#1213276 Resource leak
Change-Id: I4f63964c38bd825ceecdbd8ace1a0e56ccdab8e9
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 65be210..d442741 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -5950,6 +5950,7 @@ void Test::testIconSet()
m_pDoc->SetValue(0,0,0,aTests[i].nVal);
ScIconSetInfo* pInfo = pEntry->GetIconSetInfo(ScAddress(0,0,0));
CPPUNIT_ASSERT_EQUAL(aTests[i].nIndex, pInfo->nIconIndex);
+ delete pInfo;
}
delete pEntry;
commit 85b0d143554bac407fae1c0e4eb2863aabc63400
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 09:56:22 2014 +0100
coverity#1213277 Resource leak
Change-Id: If4db1ed1a2c8a4767859855a2b5ed9223e9ccea7
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 4a9fb2f..65be210 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -5951,6 +5951,8 @@ void Test::testIconSet()
ScIconSetInfo* pInfo = pEntry->GetIconSetInfo(ScAddress(0,0,0));
CPPUNIT_ASSERT_EQUAL(aTests[i].nIndex, pInfo->nIconIndex);
}
+
+ delete pEntry;
}
void Test::testImportStream()
commit 0f137d7181f4aeed5ae8fa5cfa31c25c2226f7e3
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 09:55:00 2014 +0100
coverity#1213288 Resource leak
Change-Id: I96ee704cc438e02cef95facc28d550644bf03d67
diff --git a/avmedia/source/opengl/oglmanager.cxx b/avmedia/source/opengl/oglmanager.cxx
index 96676ab..f55553f 100644
--- a/avmedia/source/opengl/oglmanager.cxx
+++ b/avmedia/source/opengl/oglmanager.cxx
@@ -34,7 +34,10 @@ uno::Reference< media::XPlayer > SAL_CALL OGLManager::createPlayer( const OUStri
if( pPlayer->create(rURL) )
return uno::Reference< media::XPlayer >(pPlayer);
else
+ {
+ delete pPlayer;
return uno::Reference< media::XPlayer >();
+ }
}
OUString SAL_CALL OGLManager::getImplementationName() throw ( uno::RuntimeException, std::exception )
commit 97bfac4861bf9d8f3223b66474fa24d185d1223a
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 09:22:27 2014 +0100
coverity#1213529 Uncaught exception
and a gadzillion more, e.g. coverity#1213526, coverity#1213527
Change-Id: I08a9cb078963b4adf0ea6e201e31ae7eefbf92d9
diff --git a/basic/source/basmgr/basmgr.cxx b/basic/source/basmgr/basmgr.cxx
index 09486cf..3e41094 100644
--- a/basic/source/basmgr/basmgr.cxx
+++ b/basic/source/basmgr/basmgr.cxx
@@ -63,6 +63,7 @@
#include <com/sun/star/script/ModuleInfo.hpp>
#include <com/sun/star/script/vba/XVBACompatibility.hpp>
#include <com/sun/star/script/vba/XVBAModuleInfo.hpp>
+#include <com/sun/star/ucb/ContentCreationException.hpp>
#include <cppuhelper/implbase1.hxx>
@@ -1033,6 +1034,7 @@ BasicLibInfo* BasicManager::CreateLibInfo()
bool BasicManager::ImpLoadLibrary( BasicLibInfo* pLibInfo, SotStorage* pCurStorage, bool bInfosOnly )
{
+ try {
DBG_ASSERT( pLibInfo, "LibInfo!?" );
OUString aStorageName( pLibInfo->GetStorageName() );
@@ -1132,6 +1134,10 @@ bool BasicManager::ImpLoadLibrary( BasicLibInfo* pLibInfo, SotStorage* pCurStora
return bLoaded;
}
}
+ }
+ catch (const css::ucb::ContentCreationException&)
+ {
+ }
return false;
}
commit 128941bfe04d9333c538fded6ca4f161e864bf79
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 09:34:02 2014 +0100
coverity#1213528 Uncaught exception
Change-Id: Ieaa7a7312cb50622f0c1b03f9e2a491b81ddc8ea
diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx
index b04a777..cc320e5 100644
--- a/editeng/source/misc/svxacorr.cxx
+++ b/editeng/source/misc/svxacorr.cxx
@@ -2200,11 +2200,16 @@ bool SvxAutoCorrectLanguageLists::AddToWrdSttExceptList(const OUString& rNew)
SvStringsISortDtor* SvxAutoCorrectLanguageLists::LoadCplSttExceptList()
{
- SotStorageRef xStg = new SotStorage( sShareAutoCorrFile, STREAM_READ | STREAM_SHARE_DENYNONE, sal_True );
- OUString sTemp ( pXMLImplCplStt_ExcptLstStr );
- if( xStg.Is() && xStg->IsContained( sTemp ) )
- LoadXMLExceptList_Imp( pCplStt_ExcptLst, pXMLImplCplStt_ExcptLstStr, xStg );
-
+ try
+ {
+ SotStorageRef xStg = new SotStorage( sShareAutoCorrFile, STREAM_READ | STREAM_SHARE_DENYNONE, sal_True );
+ OUString sTemp ( pXMLImplCplStt_ExcptLstStr );
+ if( xStg.Is() && xStg->IsContained( sTemp ) )
+ LoadXMLExceptList_Imp( pCplStt_ExcptLst, pXMLImplCplStt_ExcptLstStr, xStg );
+ }
+ catch (const css::ucb::ContentCreationException&)
+ {
+ }
return pCplStt_ExcptLst;
}
commit 139130e5729cf1430823c458e94d4e79d9704ce7
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat May 10 09:15:02 2014 +0100
coverity#1213553 Uninitialized scalar field
Change-Id: Ia15102812846956fe5ac4c6aee710e845baf4715
diff --git a/sw/source/core/uibase/dbui/mmconfigitem.cxx b/sw/source/core/uibase/dbui/mmconfigitem.cxx
index ba4db37..58f17ec 100644
--- a/sw/source/core/uibase/dbui/mmconfigitem.cxx
+++ b/sw/source/core/uibase/dbui/mmconfigitem.cxx
@@ -186,10 +186,12 @@ SwMailMergeConfigItem_Impl::SwMailMergeConfigItem_Impl() :
bIsOutputToLetter(true),
bIncludeCountry(false),
bIsGreetingLine(true),
+ bIsIndividualGreetingLine(false),
nCurrentFemaleGreeting(0),
nCurrentMaleGreeting(0),
nCurrentNeutralGreeting(0),
-
+ bIsGreetingLineInMail(false),
+ bIsIndividualGreetingLineInMail(false),
bIsSMPTAfterPOP(false),
nInServerPort( POP_PORT ),
bInServerPOP( true ),
More information about the Libreoffice-commits
mailing list