[Libreoffice-commits] core.git: bridges/source
Stephan Bergmann
sbergman at redhat.com
Mon May 12 06:30:43 PDT 2014
bridges/source/jni_uno/jni_info.h | 6 ++++++
1 file changed, 6 insertions(+)
New commits:
commit 43fba707c11c853875168d6255333d6c510f131f
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Mon May 12 15:00:39 2014 +0200
Coverity 441351, 441352: JNI_type_info's real dtor is "destroy"
...as it needs a JNIEnv passed in, so cannot use the dtor directly. Maybe this
code clarification helps silence Coverity's false resource leak reports.
Change-Id: I32e043e3fa9097263302a6c639e6815512410f4e
diff --git a/bridges/source/jni_uno/jni_info.h b/bridges/source/jni_uno/jni_info.h
index c92cd33..10263b2 100644
--- a/bridges/source/jni_uno/jni_info.h
+++ b/bridges/source/jni_uno/jni_info.h
@@ -82,6 +82,9 @@ struct JNI_interface_type_info : public JNI_type_info
virtual void destroy( JNIEnv * jni_env ) SAL_OVERRIDE;
explicit JNI_interface_type_info(
JNI_context const & jni, typelib_TypeDescription * td );
+
+private:
+ virtual ~JNI_interface_type_info() {}
};
struct JNI_compound_type_info : public JNI_type_info
@@ -95,6 +98,9 @@ struct JNI_compound_type_info : public JNI_type_info
virtual void destroy( JNIEnv * jni_env ) SAL_OVERRIDE;
explicit JNI_compound_type_info(
JNI_context const & jni, typelib_TypeDescription * td );
+
+private:
+ virtual ~JNI_compound_type_info() {}
};
struct JNI_type_info_holder
More information about the Libreoffice-commits
mailing list