[Libreoffice-commits] core.git: extensions/source

Stephan Bergmann sbergman at redhat.com
Tue May 13 03:41:51 PDT 2014


 extensions/source/nsplugin/source/npshell.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit d62b6d845c75e9c6074d821b425035fbee9c1559
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue May 13 12:38:55 2014 +0200

    Related fdo#60338: do not call umask(3) in a MT program
    
    ...and it is unclear what this call was supposed to help for; if a user
    deliberately sets its umask too strong, then better live with the consequences
    than to silently "fix" it.
    
    Change-Id: I0d84a7d1bd6f007794a65e1f7cc4ea09ebd9d4af

diff --git a/extensions/source/nsplugin/source/npshell.cxx b/extensions/source/nsplugin/source/npshell.cxx
index ae0714b..242c39d 100644
--- a/extensions/source/nsplugin/source/npshell.cxx
+++ b/extensions/source/nsplugin/source/npshell.cxx
@@ -772,7 +772,6 @@ NPP_StreamAsFile(NPP instance, NPStream *stream, const char* fname)
                 return;
         }
         remove(localPathNew);
-        umask(0);
         if  (0 > (fdDst = open(localPathNew, O_WRONLY|O_CREAT,
                         S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH))){
             close( fdSrc);


More information about the Libreoffice-commits mailing list