[Libreoffice-commits] core.git: 55 commits - avmedia/source chart2/source desktop/source editeng/source framework/source hwpfilter/source include/comphelper oox/source registry/source sal/qa sc/qa sc/source sd/source slideshow/source svtools/source svx/source sw/source ucb/source vcl/workben
Caolán McNamara
caolanm at redhat.com
Fri May 23 06:16:42 PDT 2014
avmedia/source/opengl/oglplayer.cxx | 1
chart2/source/view/inc/GL3DRenderer.hxx | 37 ++++-
desktop/source/splash/splash.cxx | 2
editeng/source/items/bulitem.cxx | 4
editeng/source/items/numitem.cxx | 1
framework/source/xml/imagesdocumenthandler.cxx | 3
hwpfilter/source/hinfo.cxx | 3
hwpfilter/source/hinfo.h | 20 ++-
include/comphelper/accessibleselectionhelper.hxx | 2
oox/source/export/drawingml.cxx | 24 +--
registry/source/reflwrit.cxx | 1
sal/qa/osl/file/osl_File.cxx | 66 ++++++++--
sc/qa/unit/ucalc_sharedformula.cxx | 3
sc/source/core/data/dociter.cxx | 3
sc/source/core/opencl/op_addin.cxx | 6
sc/source/core/tool/interpr4.cxx | 37 +++--
sc/source/filter/xml/xmlcelli.cxx | 4
sc/source/ui/inc/printfun.hxx | 15 ++
sc/source/ui/view/preview.cxx | 3
sd/source/ui/dlg/sdtreelb.cxx | 3
sd/source/ui/docshell/docshel4.cxx | 2
sd/source/ui/func/fuexpand.cxx | 3
sd/source/ui/func/fuinsfil.cxx | 15 +-
sd/source/ui/func/fusel.cxx | 1
slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx | 4
svtools/source/dialogs/addresstemplate.cxx | 2
svx/source/accessibility/charmapacc.cxx | 3
svx/source/inc/charmapacc.hxx | 4
sw/source/core/access/accnotextframe.cxx | 7 -
sw/source/core/crsr/swcrsr.cxx | 4
sw/source/core/docnode/ndcopy.cxx | 10 -
sw/source/core/docnode/nodedump.cxx | 4
sw/source/core/txtnode/ndtxt.cxx | 15 +-
sw/source/core/unocore/unocoll.cxx | 2
sw/source/ui/chrdlg/numpara.cxx | 15 +-
ucb/source/ucp/webdav-neon/webdavcontent.cxx | 8 -
ucb/source/ucp/webdav-neon/webdavcontent.hxx | 8 -
ucb/source/ucp/webdav/DAVException.hxx | 2
vcl/workben/svpclient.cxx | 1
vcl/workben/svptest.cxx | 2
40 files changed, 252 insertions(+), 98 deletions(-)
New commits:
commit 882bafb8d83d76f15a42b02fa50f83524b0f2197
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 13:30:58 2014 +0100
coverity#1078598 Unchecked dynamic_cast
Change-Id: I939e6718d785f96ad7726d59e7c1a5b5666e873f
diff --git a/sw/source/core/docnode/nodedump.cxx b/sw/source/core/docnode/nodedump.cxx
index 83768c4..5de57f2 100644
--- a/sw/source/core/docnode/nodedump.cxx
+++ b/sw/source/core/docnode/nodedump.cxx
@@ -258,9 +258,11 @@ void SwFldTypes::dumpAsXml( xmlTextWriterPtr w )
}
writer.startElement(name);
writer.writeFormatAttribute("ptr", "%p", pCurFldFmt->GetField());
+ const SwPostItField* pField = NULL;
if (pCurFldFmt->GetField()->GetTyp()->Which() == RES_POSTITFLD)
+ pField = dynamic_cast<const SwPostItField*>(pCurFldFmt->GetField());
+ if (pField)
{
- const SwPostItField* pField = dynamic_cast<const SwPostItField*>(pCurFldFmt->GetField());
OString txt8 = OUStringToOString(pField->GetName(), RTL_TEXTENCODING_UTF8);
writer.writeFormatAttribute("name", "%s", BAD_CAST( txt8.getStr()));
}
commit 2fc3b4173f3e5a539a7cf596dffe7067a8a3ec09
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 13:16:52 2014 +0100
coverity#1078582 Dereference after null check
Change-Id: I3b972510871f36a3c7877b38d3a012aa88acf4c5
diff --git a/sd/source/ui/docshell/docshel4.cxx b/sd/source/ui/docshell/docshel4.cxx
index 654d6a8..2882d0c 100644
--- a/sd/source/ui/docshell/docshel4.cxx
+++ b/sd/source/ui/docshell/docshel4.cxx
@@ -823,7 +823,7 @@ bool DrawDocShell::GotoBookmark(const OUString& rBookmark)
}
}
- SfxBindings& rBindings = (pDrawViewShell->GetViewFrame()!=NULL
+ SfxBindings& rBindings = ((pDrawViewShell && pDrawViewShell->GetViewFrame()!=NULL)
? pDrawViewShell->GetViewFrame()
: SfxViewFrame::Current() )->GetBindings();
commit a5a1f885f080bc6e2053b86cc3a71bfa912f9bbd
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 13:02:21 2014 +0100
coverity#1078575 Unchecked dynamic_cast
Change-Id: Ib4b7c2dcfa42aea0866806684a3949d35e796b27
diff --git a/sw/source/core/access/accnotextframe.cxx b/sw/source/core/access/accnotextframe.cxx
index c88eef7..10c312d 100644
--- a/sw/source/core/access/accnotextframe.cxx
+++ b/sw/source/core/access/accnotextframe.cxx
@@ -109,12 +109,13 @@ void SwAccessibleNoTextFrame::Modify( const SfxPoolItem* pOld, const SfxPoolItem
// #i73249#
case RES_TITLE_CHANGED:
{
- OUString sOldTitle;
+ OUString sOldTitle, sNewTitle;
const SwStringMsgPoolItem* pOldItem = dynamic_cast<const SwStringMsgPoolItem*>(pOld);
if (pOldItem)
sOldTitle = pOldItem->GetString();
- const OUString& sNewTitle(
- dynamic_cast<const SwStringMsgPoolItem*>(pNew)->GetString() );
+ const SwStringMsgPoolItem* pNewItem = dynamic_cast<const SwStringMsgPoolItem*>(pNew);
+ if (pNewItem)
+ sNewTitle = pNewItem->GetString();
if ( sOldTitle == sNewTitle )
{
break;
commit 7ebbd60b140c7b1ea4ad707d22d5c12000a3daa4
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 12:43:29 2014 +0100
coverity#705475 Dereference null return value
Change-Id: I75c4525bf6e04ac25c0d9ab2f926faf40b82739b
diff --git a/sd/source/ui/func/fuexpand.cxx b/sd/source/ui/func/fuexpand.cxx
index 4ab706d..2467e1a 100644
--- a/sd/source/ui/func/fuexpand.cxx
+++ b/sd/source/ui/func/fuexpand.cxx
@@ -180,6 +180,9 @@ void FuExpandPage::DoExecute( SfxRequest& )
// create title text objects
SdrTextObj* pTextObj = (SdrTextObj*) pPage->GetPresObj(PRESOBJ_TITLE);
+ assert(pTextObj);
+ if (!pTextObj)
+ continue;
OutlinerParaObject* pOutlinerParaObject = pOutl->CreateParaObject( nParaPos, 1);
pOutlinerParaObject->SetOutlinerMode(OUTLINERMODE_TITLEOBJECT);
commit df184a5352c37b839e6dea9c7145aa8501eb74fc
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 12:40:27 2014 +0100
coverity#705484 Dereference null return value
Change-Id: I8bdce34356b50e3b0add4ddedd26bb47d67114ad
diff --git a/sw/source/core/crsr/swcrsr.cxx b/sw/source/core/crsr/swcrsr.cxx
index 3233cd0..b2b6dde 100644
--- a/sw/source/core/crsr/swcrsr.cxx
+++ b/sw/source/core/crsr/swcrsr.cxx
@@ -2174,9 +2174,9 @@ SwCursor* SwTableCursor::MakeBoxSels( SwCursor* pAktCrsr )
pNd = rNds.GoPrevSection( &aIdx, true, false );
pPos = pCur->GetPoint();
- if( pNd != &pPos->nNode.GetNode() )
+ if (pNd && pNd != &pPos->nNode.GetNode())
pPos->nNode = *pNd;
- pPos->nContent.Assign( (SwCntntNode*)pNd, ((SwCntntNode*)pNd)->Len() );
+ pPos->nContent.Assign((SwCntntNode*)pNd, pNd ? ((SwCntntNode*)pNd)->Len() : 0);
aTmp.erase( aTmp.begin() + nPos );
}
commit 32ee6a4f6481342f63088592be12bb50e5e80e76
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 12:38:13 2014 +0100
coverity#705519 Dereference null return value
Change-Id: Ieb164e6c7349120311ab8cb6f74cec7b6851132c
diff --git a/sw/source/ui/chrdlg/numpara.cxx b/sw/source/ui/chrdlg/numpara.cxx
index ab8bdac..c549fb3 100644
--- a/sw/source/ui/chrdlg/numpara.cxx
+++ b/sw/source/ui/chrdlg/numpara.cxx
@@ -109,11 +109,14 @@ bool SwParagraphNumTabPage::FillItemSet( SfxItemSet& rSet )
{
const sal_uInt16 aOutlineLv = m_pOutlineLvLB->GetSelectEntryPos();
const SfxUInt16Item* pOldOutlineLv = (const SfxUInt16Item*)GetOldItem( rSet, SID_ATTR_PARA_OUTLINE_LEVEL);
- SfxUInt16Item* pOutlineLv = (SfxUInt16Item*)pOldOutlineLv->Clone();
- pOutlineLv->SetValue( aOutlineLv );
- rSet.Put(*pOutlineLv);
- delete pOutlineLv;
- bModified = true;
+ if (pOldOutlineLv)
+ {
+ SfxUInt16Item* pOutlineLv = (SfxUInt16Item*)pOldOutlineLv->Clone();
+ pOutlineLv->SetValue( aOutlineLv );
+ rSet.Put(*pOutlineLv);
+ delete pOutlineLv;
+ bModified = true;
+ }
}
if( m_pNumberStyleLB->IsValueChangedFromSaved())
@@ -122,7 +125,7 @@ bool SwParagraphNumTabPage::FillItemSet( SfxItemSet& rSet )
if(m_pNumberStyleLB->GetSelectEntryPos())
aStyle = m_pNumberStyleLB->GetSelectEntry();
const SfxStringItem* pOldRule = (const SfxStringItem*)GetOldItem( rSet, SID_ATTR_PARA_NUMRULE);
- SfxStringItem* pRule = (SfxStringItem*)pOldRule->Clone();
+ SfxStringItem* pRule = pOldRule ? (SfxStringItem*)pOldRule->Clone() : NULL;
if (pRule)
{
pRule->SetValue(aStyle);
commit cb20d7c3e397a483abeb5eb94ec63a009b3d0cd2
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 12:36:01 2014 +0100
coverity#1187682 Dereference null return value
Change-Id: I52740129dc7c6c8d6f47850cf32702ead4643e63
diff --git a/sc/source/filter/xml/xmlcelli.cxx b/sc/source/filter/xml/xmlcelli.cxx
index 4e4c552..def27a9 100644
--- a/sc/source/filter/xml/xmlcelli.cxx
+++ b/sc/source/filter/xml/xmlcelli.cxx
@@ -1066,7 +1066,7 @@ void ScXMLTableRowCellContext::PutTextCell( const ScAddress& rCurrentPos,
if(!aCellString.isEmpty())
{
- if (bDoIncrement && !IsPossibleErrorString())
+ if (bDoIncrement && !IsPossibleErrorString() && pFCell)
{
ScDocument* pDoc = rXMLImport.GetDocument();
pFCell->SetHybridString(pDoc->GetSharedStringPool().intern(aCellString));
@@ -1075,7 +1075,7 @@ void ScXMLTableRowCellContext::PutTextCell( const ScAddress& rCurrentPos,
else
{
ScAddress aTopLeftMatrixCell;
- if(pFCell->GetMatrixOrigin(aTopLeftMatrixCell))
+ if (pFCell && pFCell->GetMatrixOrigin(aTopLeftMatrixCell))
{
ScFormulaCell* pMatrixCell = rXMLImport.GetDocument()->GetFormulaCell(aTopLeftMatrixCell);
if (pMatrixCell)
commit c5920fe23a0e4b2cb333125f3315063d4a58f2b5
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 12:34:26 2014 +0100
coverity#1187686 Dereference null return value
Change-Id: Ibbebba7bf421bf7f328a940c7f3d5295c975573c
diff --git a/sc/qa/unit/ucalc_sharedformula.cxx b/sc/qa/unit/ucalc_sharedformula.cxx
index d3fc16b..76ba05e 100644
--- a/sc/qa/unit/ucalc_sharedformula.cxx
+++ b/sc/qa/unit/ucalc_sharedformula.cxx
@@ -125,6 +125,7 @@ void Test::testSharedFormulas()
CPPUNIT_ASSERT_MESSAGE("This cell should have been emptied.", m_pDoc->GetCellType(aPos) == CELLTYPE_NONE);
aPos.SetRow(12); // B13
pFC = m_pDoc->GetFormulaCell(aPos);
+ CPPUNIT_ASSERT(pFC);
// B13:B18 should be shared.
CPPUNIT_ASSERT_EQUAL(static_cast<SCROW>(12), pFC->GetSharedTopRow());
CPPUNIT_ASSERT_EQUAL(static_cast<SCROW>(6), pFC->GetSharedLength());
@@ -146,6 +147,7 @@ void Test::testSharedFormulas()
// B15:B18 should be shared.
aPos.SetRow(14); // B15
pFC = m_pDoc->GetFormulaCell(aPos);
+ CPPUNIT_ASSERT(pFC);
CPPUNIT_ASSERT_EQUAL(static_cast<SCROW>(14), pFC->GetSharedTopRow());
CPPUNIT_ASSERT_EQUAL(static_cast<SCROW>(4), pFC->GetSharedLength());
CPPUNIT_ASSERT_MESSAGE("The token is expected to be shared.", pFC->GetCode() == pFC->GetSharedCode());
@@ -155,6 +157,7 @@ void Test::testSharedFormulas()
m_pDoc->SetValue(aPos, 1.2);
aPos.SetRow(15);
pFC = m_pDoc->GetFormulaCell(aPos);
+ CPPUNIT_ASSERT(pFC);
// B16:B18 should be shared.
CPPUNIT_ASSERT_EQUAL(static_cast<SCROW>(15), pFC->GetSharedTopRow());
CPPUNIT_ASSERT_EQUAL(static_cast<SCROW>(3), pFC->GetSharedLength());
commit 6ae8ade6410881f2f01d57968abc8463750f18a8
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 12:23:36 2014 +0100
coverity#705865 Dereference before null check
Change-Id: Ib7b57da47d891725cd33073a8e7ed2f4baba74e9
diff --git a/sd/source/ui/func/fusel.cxx b/sd/source/ui/func/fusel.cxx
index 82c1c45..bf10d9f 100644
--- a/sd/source/ui/func/fusel.cxx
+++ b/sd/source/ui/func/fusel.cxx
@@ -305,7 +305,6 @@ bool FuSelection::MouseButtonDown(const MouseEvent& rMEvt)
// New: double click on selected Group object
// enter group
if ( ! bSelectionOnly
- && pObj
&& pObj->GetPage() == pPV->GetPage())
bReturn = pPV->EnterGroup(pObj);
}
commit 71d21de098ef0c4d6a8f553868f62f8ef4d5fa87
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 12:21:30 2014 +0100
coverity#705860 Dereference before null check
Change-Id: I05f23c5d1581f6673660d59f7fe7e5f89d7d0919
diff --git a/sd/source/ui/dlg/sdtreelb.cxx b/sd/source/ui/dlg/sdtreelb.cxx
index 72f6e7d..980af63 100644
--- a/sd/source/ui/dlg/sdtreelb.cxx
+++ b/sd/source/ui/dlg/sdtreelb.cxx
@@ -1522,7 +1522,7 @@ SvTreeListEntry* SdPageObjsTLB::GetDropTarget (const Point& rLocation)
// Advance to next sibling.
SvTreeListEntry* pNext;
sal_uInt16 nDepth (0);
- while (pEntry != NULL)
+ do
{
pNext = dynamic_cast<SvTreeListEntry*>(NextVisible(pEntry, &nDepth));
if (pNext != NULL && nDepth > 0 && nDepth!=0xffff)
@@ -1530,6 +1530,7 @@ SvTreeListEntry* SdPageObjsTLB::GetDropTarget (const Point& rLocation)
else
break;
}
+ while (pEntry != NULL);
}
return pEntry;
commit afe26bb8942fa8ff45c0403c933169a94aaa26cf
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 12:00:56 2014 +0100
coverity#705818 Dereference before null check
Change-Id: Ie34e0df8ce38c58f5397942e53c55f6cc091b69d
diff --git a/framework/source/xml/imagesdocumenthandler.cxx b/framework/source/xml/imagesdocumenthandler.cxx
index 89dd9d9..ac52c55 100644
--- a/framework/source/xml/imagesdocumenthandler.cxx
+++ b/framework/source/xml/imagesdocumenthandler.cxx
@@ -362,8 +362,7 @@ void SAL_CALL OReadImagesDocumentHandler::startElement(
throw SAXException( aErrorMessage, Reference< XInterface >(), Any() );
}
- if ( m_pImages )
- m_pImages->pImageItemList->push_back( pItem );
+ m_pImages->pImageItemList->push_back( pItem );
}
break;
commit fdca2dd57d23d197bf45bf3f980d5b16b0977cf6
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 11:19:19 2014 +0100
coverity#1079283 Uninitialized scalar field
Change-Id: Ib849ff0839bba80d5695c0f78dd18448b668ec78
diff --git a/sal/qa/osl/file/osl_File.cxx b/sal/qa/osl/file/osl_File.cxx
index 61830ec..c46f2fe 100644
--- a/sal/qa/osl/file/osl_File.cxx
+++ b/sal/qa/osl/file/osl_File.cxx
@@ -2987,7 +2987,12 @@ namespace osl_File
sal_uInt64 nCount_write;
public:
- copy() :nError1(FileBase::E_None) {}
+ copy()
+ : nError1(FileBase::E_None)
+ , nCount_write(0)
+ {
+ }
+
// initialization
void setUp() SAL_OVERRIDE
{
commit 1bbf556fd32db23266b074b85e9932f98c3a61ee
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 11:18:49 2014 +0100
coverity#1079282 Uninitialized scalar field
Change-Id: If20b1108af89dec75d8c6a232290ab28e51d09d4
diff --git a/sal/qa/osl/file/osl_File.cxx b/sal/qa/osl/file/osl_File.cxx
index 4422e2e..61830ec 100644
--- a/sal/qa/osl/file/osl_File.cxx
+++ b/sal/qa/osl/file/osl_File.cxx
@@ -2546,7 +2546,12 @@ namespace osl_File
sal_uInt64 nCount_write;
public:
- isEndOfFile() :nError1(FileBase::E_None) {}
+ isEndOfFile()
+ : nError1(FileBase::E_None)
+ , nCount_write(0)
+ {
+ }
+
// initialization
void setUp() SAL_OVERRIDE
{
commit cd0ad2bfcd8f7cefbe0d00c525847d12e8044247
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 11:17:53 2014 +0100
coverity#1079281 Uninitialized scalar field
Change-Id: I17dc424d485053d3eb09e8eb0dd01dd4b4672bfd
diff --git a/sal/qa/osl/file/osl_File.cxx b/sal/qa/osl/file/osl_File.cxx
index 4c159ab..4422e2e 100644
--- a/sal/qa/osl/file/osl_File.cxx
+++ b/sal/qa/osl/file/osl_File.cxx
@@ -2638,7 +2638,12 @@ namespace osl_File
sal_uInt64 nCount_write;
public:
- setSize() :nError1(FileBase::E_None) {}
+ setSize()
+ : nError1(FileBase::E_None)
+ , nCount_write(0)
+ {
+ }
+
// initialization
void setUp() SAL_OVERRIDE
{
commit f67b571c3baf14b206f6177d1d7e75a28d068439
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 11:17:13 2014 +0100
coverity#1079280 Uninitialized scalar field
Change-Id: I57de2b441c6a1d04c0ea54ad4ff1a66989e0cac8
diff --git a/sal/qa/osl/file/osl_File.cxx b/sal/qa/osl/file/osl_File.cxx
index b49778a..4c159ab 100644
--- a/sal/qa/osl/file/osl_File.cxx
+++ b/sal/qa/osl/file/osl_File.cxx
@@ -2368,7 +2368,12 @@ namespace osl_File
sal_uInt64 nCount_write, nCount_read;
public:
- setPos() :nError1(FileBase::E_None) {}
+ setPos()
+ : nError1(FileBase::E_None)
+ , nCount_write(0)
+ , nCount_read(0)
+ {
+ }
// initialization
void setUp() SAL_OVERRIDE
commit 7fd719f9ad0698daa10ccb6b65cfcc9c8d0c2d3c
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 11:15:12 2014 +0100
coverity#1079279 Uninitialized scalar field
Change-Id: I8b9ac5da3a7c137edec3688cc712079685039c26
diff --git a/sal/qa/osl/file/osl_File.cxx b/sal/qa/osl/file/osl_File.cxx
index b416987..b49778a 100644
--- a/sal/qa/osl/file/osl_File.cxx
+++ b/sal/qa/osl/file/osl_File.cxx
@@ -3238,7 +3238,13 @@ namespace osl_File
sal_uInt64 nCount_write;
public:
- remove() :nError1(FileBase::E_None),nError2(FileBase::E_None) {}
+ remove()
+ : nError1(FileBase::E_None)
+ , nError2(FileBase::E_None)
+ , nCount_write(0)
+ {
+ }
+
// initialization
void setUp() SAL_OVERRIDE
{
commit 127eeaa09f8ef744bedf366b6f66e01d23c9e7da
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 11:13:01 2014 +0100
coverity#1079278 Uninitialized scalar field
Change-Id: Ie5f9629340632b8ab17e3fc940dff8195f7673ce
diff --git a/sal/qa/osl/file/osl_File.cxx b/sal/qa/osl/file/osl_File.cxx
index d51cb93..b416987 100644
--- a/sal/qa/osl/file/osl_File.cxx
+++ b/sal/qa/osl/file/osl_File.cxx
@@ -2472,7 +2472,12 @@ namespace osl_File
sal_uInt64 nCount_write;
public:
- getPos() :nError1(FileBase::E_None) {}
+ getPos()
+ : nError1(FileBase::E_None)
+ , nCount_write(0)
+ {
+ }
+
// initialization
void setUp() SAL_OVERRIDE
{
commit c755ddf70bc06c841354458ff131c681291eadd7
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 11:11:13 2014 +0100
coverity#1079277 Uninitialized scalar field
Change-Id: Ic7c05f298fec49f1336ab55dde31574a39ebe73b
diff --git a/sal/qa/osl/file/osl_File.cxx b/sal/qa/osl/file/osl_File.cxx
index c5ffa70..d51cb93 100644
--- a/sal/qa/osl/file/osl_File.cxx
+++ b/sal/qa/osl/file/osl_File.cxx
@@ -2815,7 +2815,13 @@ namespace osl_File
sal_uInt64 nCount_write, nCount_read;
public:
- write() :nError1(FileBase::E_None) {}
+ write()
+ : nError1(FileBase::E_None)
+ , nCount_write(0)
+ , nCount_read(0)
+ {
+ }
+
// initialization
void setUp() SAL_OVERRIDE
{
commit 748c65b1f19d5e7426cf93c82bcc5d2de4fcf2b8
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 11:06:34 2014 +0100
coverity#708104 Uninitialized scalar field
Change-Id: I3b35046fd10a779b3a0f6efeadf0ea7f4d3132da
diff --git a/sc/source/ui/inc/printfun.hxx b/sc/source/ui/inc/printfun.hxx
index 00e6c96..e2147cd 100644
--- a/sc/source/ui/inc/printfun.hxx
+++ b/sc/source/ui/inc/printfun.hxx
@@ -83,6 +83,21 @@ struct ScPrintState // Save Variables from ScPrintFunc
long nTotalPages;
long nPageStart;
long nDocPages;
+ ScPrintState()
+ : nPrintTab(0)
+ , nStartCol(0)
+ , nStartRow(0)
+ , nEndCol(0)
+ , nEndRow(0)
+ , nZoom(0)
+ , nPagesX(0)
+ , nPagesY(0)
+ , nTabPages(0)
+ , nTotalPages(0)
+ , nPageStart(0)
+ , nDocPages(0)
+ {
+ }
};
class ScPageRowEntry
diff --git a/sc/source/ui/view/preview.cxx b/sc/source/ui/view/preview.cxx
index 3380ebc..0735c42 100644
--- a/sc/source/ui/view/preview.cxx
+++ b/sc/source/ui/view/preview.cxx
@@ -89,10 +89,12 @@ ScPreview::ScPreview( Window* pParent, ScDocShell* pDocSh, ScPreviewShell* pView
Window( pParent ),
nPageNo( 0 ),
nZoom( 100 ),
+ nTabCount( 0 ),
nTabsTested( 0 ),
nPages(),
nFirstAttr(),
nTab( 0 ),
+ nTabPage( 0 ),
nTabStart( 0 ),
nDisplayStart( 0 ),
aDate( Date::SYSTEM ),
@@ -123,6 +125,7 @@ ScPreview::ScPreview( Window* pParent, ScDocShell* pDocSh, ScPreviewShell* pView
bPageMargin ( false ),
bColRulerMove( false ),
mbHasEmptyRangeTable(false),
+ nLeftPosition( 0 ),
mnScale( 0 ),
nColNumberButttonDown( 0 ),
nHeaderHeight ( 0 ),
commit 612848165794c8ed982125aacae9e4c2467d0d7d
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 11:00:00 2014 +0100
coverity#708018 Uninitialized pointer field
Change-Id: Iea2f47a8a65447ebe9d25cfa1f4704426872c093
diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index 09ea671..f0f7c3a 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -3727,18 +3727,31 @@ void ScInterpreter::ScTTT()
ScInterpreter::ScInterpreter( ScFormulaCell* pCell, ScDocument* pDoc,
- const ScAddress& rPos, ScTokenArray& r ) :
- aCode( r ),
- aPos( rPos ),
- rArr( r ),
- pDok( pDoc ),
- mrStrPool(pDoc->GetSharedStringPool()),
- pTokenMatrixMap( NULL ),
- pMyFormulaCell( pCell ),
- pFormatter( pDoc->GetFormatTable() ),
- mnStringNoValueError( errNoValue),
- bCalcAsShown( pDoc->GetDocOptions().IsCalcAsShown() ),
- meVolatileType(r.IsRecalcModeAlways() ? VOLATILE : NOT_VOLATILE)
+ const ScAddress& rPos, ScTokenArray& r )
+ : aCode(r)
+ , aPos(rPos)
+ , rArr(r)
+ , pDok(pDoc)
+ , mrStrPool(pDoc->GetSharedStringPool())
+ , pJumpMatrix(NULL)
+ , pTokenMatrixMap(NULL)
+ , pMyFormulaCell(pCell)
+ , pFormatter(pDoc->GetFormatTable())
+ , pCur(NULL)
+ , nGlobalError(0)
+ , sp(0)
+ , maxsp(0)
+ , nFuncFmtIndex(0)
+ , nCurFmtIndex(0)
+ , nRetFmtIndex(0)
+ , nFuncFmtType(0)
+ , nCurFmtType(0)
+ , nRetFmtType(0)
+ , mnStringNoValueError(errNoValue)
+ , glSubTotal(false)
+ , cPar(0)
+ , bCalcAsShown(pDoc->GetDocOptions().IsCalcAsShown())
+ , meVolatileType(r.IsRecalcModeAlways() ? VOLATILE : NOT_VOLATILE)
{
MergeCalcConfig();
commit f056fd9852927f6c4aceb8b17b7a595238401aa0
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:48:54 2014 +0100
coverity#707758 Uninitialized scalar field
Change-Id: I39954506deafc42e854d556170417af67f5461b2
diff --git a/editeng/source/items/numitem.cxx b/editeng/source/items/numitem.cxx
index 55b68c0..129197e 100644
--- a/editeng/source/items/numitem.cxx
+++ b/editeng/source/items/numitem.cxx
@@ -179,6 +179,7 @@ SvxNumberFormat::SvxNumberFormat(const SvxNumberFormat& rFormat) :
SvxNumberFormat::SvxNumberFormat( SvStream &rStream )
: nStart(0)
+ , nBulletRelSize(100)
, nFirstLineOffset(0)
, nAbsLSpace(0)
, nLSpace(0)
commit d733a88e61631094bece5d1490ecf8f71877536c
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:46:53 2014 +0100
coverity#707899 Uninitialized scalar field
Change-Id: I49c6e56412e10155ddb2b8f4b492a3420e1b6718
diff --git a/hwpfilter/source/hinfo.cxx b/hwpfilter/source/hinfo.cxx
index 98f66a5..38d3b22 100644
--- a/hwpfilter/source/hinfo.cxx
+++ b/hwpfilter/source/hinfo.cxx
@@ -66,8 +66,7 @@ HWPInfo::HWPInfo()
HWPInfo::~HWPInfo(void)
{
- if (info_block)
- delete[]info_block;
+ delete[] info_block;
info_block = 0;
}
diff --git a/hwpfilter/source/hinfo.h b/hwpfilter/source/hinfo.h
index d3591b5..00bc604 100644
--- a/hwpfilter/source/hinfo.h
+++ b/hwpfilter/source/hinfo.h
@@ -33,7 +33,7 @@ class CHTMLOut;
/**
* Information of page (phisical)
*/
-typedef struct
+struct PaperInfo
{
unsigned char paper_kind;
unsigned char paper_direction;
@@ -46,7 +46,21 @@ typedef struct
hunit header_length;
hunit footer_length;
hunit gutter_length;
-} PaperInfo;
+ PaperInfo()
+ : paper_kind(0)
+ , paper_direction(0)
+ , paper_height(0)
+ , paper_width(0)
+ , top_margin(0)
+ , bottom_margin(0)
+ , left_margin(0)
+ , right_margin(0)
+ , header_length(0)
+ , footer_length(0)
+ , gutter_length(0)
+ {
+ }
+};
/* ?????? ??????, ???????? ???? */
struct PaperBackInfo
@@ -146,7 +160,7 @@ class DLLEXPORT HWPInfo
*/
PaperInfo paper;
- PaperBackInfo back_info;
+ PaperBackInfo back_info;
/**
* Sets the attribute of read-only or read/write.
*/
commit 0bf59c89ce739892ed55854acdf6e9dde2681cd1
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:44:22 2014 +0100
coverity#707966 Uninitialized pointer field
Change-Id: I0484afe60697f8b414591eb0efc5284439a7052f
diff --git a/registry/source/reflwrit.cxx b/registry/source/reflwrit.cxx
index e463a1f..3cbcc2f 100644
--- a/registry/source/reflwrit.cxx
+++ b/registry/source/reflwrit.cxx
@@ -699,6 +699,7 @@ TypeWriter::TypeWriter(typereg_Version version,
, m_doku(documentation)
, m_fileName(fileName)
, m_fieldCount(fieldCount)
+ , m_fields(NULL)
, m_methodCount(methodCount)
, m_methods(NULL)
, m_referenceCount(referenceCount)
commit 8f36da26141b38b8976981d6673c64c43f38430b
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:42:21 2014 +0100
coverity#707994 Uninitialized scalar field
Change-Id: I295cbb23529f614c35f39c756c555dd9eabe8623
diff --git a/sc/source/core/data/dociter.cxx b/sc/source/core/data/dociter.cxx
index d928586..235e0d2 100644
--- a/sc/source/core/data/dociter.cxx
+++ b/sc/source/core/data/dociter.cxx
@@ -2408,6 +2408,9 @@ ScUsedAreaIterator::ScUsedAreaIterator( ScDocument* pDocument, SCTAB nTable,
, nNextRow( nRow1 )
, nCellCol( 0 )
, nCellRow( 0 )
+ , nAttrCol1( 0 )
+ , nAttrCol2( 0 )
+ , nAttrRow( 0 )
, nFoundStartCol( 0 )
, nFoundEndCol( 0 )
, nFoundRow( 0 )
commit bc9bcceb2e4646b15fff64b365ea2ff48ed00666
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:40:56 2014 +0100
coverity#708305 Uninitialized pointer field
Change-Id: I2c04b004e190e071e5977c06a8f5d878870bc966
diff --git a/svtools/source/dialogs/addresstemplate.cxx b/svtools/source/dialogs/addresstemplate.cxx
index 16b4520..d39b8da 100644
--- a/svtools/source/dialogs/addresstemplate.cxx
+++ b/svtools/source/dialogs/addresstemplate.cxx
@@ -494,6 +494,8 @@ void AssignmentPersistentData::Commit()
,bWorkingPersistent( false )
,pConfigData( new AssigmentTransientData( m_xTransientDataSource, _rDataSourceName, _rTableName, _rFields ) )
{
+ memset(pFieldLabels, 0, sizeof(pFieldLabels));
+ memset(pFields, 0, sizeof(pFields));
}
~AddressBookSourceDialogData()
commit 77f79f29f03541fef0b6ab0373371ecbf504d8f1
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:39:58 2014 +0100
coverity#984086 Uninitialized scalar field
Change-Id: Iba162efd0b582541199f343b64ac3b8c59dcc3d8
diff --git a/editeng/source/items/bulitem.cxx b/editeng/source/items/bulitem.cxx
index 4492db1..2faf308 100644
--- a/editeng/source/items/bulitem.cxx
+++ b/editeng/source/items/bulitem.cxx
@@ -114,6 +114,8 @@ SvxBulletItem::SvxBulletItem( SvStream& rStrm, sal_uInt16 _nWhich )
, pGraphicObject(NULL)
, nStart(0)
, nStyle(0)
+ , nScale(0)
+ , nJustify(0)
{
rStrm.ReadUInt16( nStyle );
@@ -149,7 +151,7 @@ SvxBulletItem::SvxBulletItem( SvStream& rStrm, sal_uInt16 _nWhich )
rStrm.ReadUInt16( nStart );
rStrm.ReadUChar( nJustify );
- char cTmpSymbol;
+ char cTmpSymbol(0);
rStrm.ReadChar( cTmpSymbol );
//convert single byte to unicode
cSymbol = OUString(&cTmpSymbol, 1, aFont.GetCharSet()).toChar();
commit 8eec77cbbc8c5093d95382c8da851a4adccfaa52
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:36:51 2014 +0100
coverity#984143 Uninitialized scalar field
Change-Id: I23774c0e1d463284a389e8cdcad06a4915dafd06
diff --git a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx
index a5e9dcc..36c1dd0 100644
--- a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx
+++ b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx
@@ -1361,9 +1361,13 @@ OGLTransitionerImpl::OGLTransitionerImpl()
#endif
, maSlideBitmapLayout()
, maSlideSize()
+ , mbBrokenTexturesATI(false)
+ , mnGLVersion(0)
#ifdef UNX
, mnGLXVersion(0.0)
#endif
+ , mbGLXPresent(false)
+ , mbMesa(false)
, mbTextureFromPixmap(false)
, mbGenerateMipmap(false)
, mbHasTFPVisual(false)
commit 3c5f582e635357f5820edd65d98d060734efa272
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:29:18 2014 +0100
coverity#1079284 Uninitialized scalar field
Change-Id: I0d39b2c7b39761fb89b9e7787fd3145ff3daa3a4
diff --git a/sal/qa/osl/file/osl_File.cxx b/sal/qa/osl/file/osl_File.cxx
index 0c0fd58..c5ffa70 100644
--- a/sal/qa/osl/file/osl_File.cxx
+++ b/sal/qa/osl/file/osl_File.cxx
@@ -3086,7 +3086,13 @@ namespace osl_File
sal_uInt64 nCount_write;
public:
- move() :nError1(FileBase::E_None),nError2(FileBase::E_None) {}
+ move()
+ : nError1(FileBase::E_None)
+ , nError2(FileBase::E_None)
+ , nCount_write(0)
+ {
+ }
+
// initialization
void setUp() SAL_OVERRIDE
{
commit e0688029e0b0a8e40aabda16c604ef2bc19b949b
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:28:45 2014 +0100
coverity#1079285 Uninitialized scalar field
Change-Id: Icca0d21a67f1322a84220cde3d10acd5230c9fdd
diff --git a/sal/qa/osl/file/osl_File.cxx b/sal/qa/osl/file/osl_File.cxx
index ba0a3a0..0c0fd58 100644
--- a/sal/qa/osl/file/osl_File.cxx
+++ b/sal/qa/osl/file/osl_File.cxx
@@ -2724,7 +2724,12 @@ namespace osl_File
sal_uInt64 nCount_write, nCount_read;
public:
- read() :nError1(FileBase::E_None) {}
+ read()
+ : nError1(FileBase::E_None)
+ , nCount_write(0)
+ , nCount_read(0)
+ {
+ }
// initialization
void setUp() SAL_OVERRIDE
{
commit 81a053769f2a6798da869ec3e8d93502440917b9
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:27:01 2014 +0100
coverity#1210188 Uninitialized pointer field
Change-Id: Ifbf29a8601d0527695951acea57b75f25a85ed89
diff --git a/avmedia/source/opengl/oglplayer.cxx b/avmedia/source/opengl/oglplayer.cxx
index 323242a..00e1f1a 100644
--- a/avmedia/source/opengl/oglplayer.cxx
+++ b/avmedia/source/opengl/oglplayer.cxx
@@ -25,6 +25,7 @@ namespace avmedia { namespace ogl {
OGLPlayer::OGLPlayer()
: Player_BASE(m_aMutex)
, m_pHandle(NULL)
+ , m_pOGLWindow(NULL)
{
}
commit 6944f888a996b9938b07526b996e6f0b5fde51c1
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:21:16 2014 +0100
coverity#704941 Unchecked dynamic_cast
Change-Id: I86eba45b6671f32682fbba8bf0cbbaae6fd174bd
diff --git a/sw/source/core/txtnode/ndtxt.cxx b/sw/source/core/txtnode/ndtxt.cxx
index 36d82612..cf0e1c9 100644
--- a/sw/source/core/txtnode/ndtxt.cxx
+++ b/sw/source/core/txtnode/ndtxt.cxx
@@ -4451,7 +4451,7 @@ namespace {
{
const SfxBoolItem* pListIsRestartItem =
dynamic_cast<const SfxBoolItem*>(pItem);
- if ( pListIsRestartItem->GetValue() != mrTxtNode.IsListRestart() )
+ if (pListIsRestartItem && pListIsRestartItem->GetValue() != mrTxtNode.IsListRestart())
{
mbUpdateListRestart = true;
}
commit 7c79237e6555ecb54665cbc93e94adaf05c669b8
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:20:44 2014 +0100
coverity#704942 Unchecked dynamic_cast
Change-Id: I1090150b9cf5998549dabf73353a78e7e51e34ea
diff --git a/sw/source/core/txtnode/ndtxt.cxx b/sw/source/core/txtnode/ndtxt.cxx
index 27a0351..36d82612 100644
--- a/sw/source/core/txtnode/ndtxt.cxx
+++ b/sw/source/core/txtnode/ndtxt.cxx
@@ -4440,7 +4440,7 @@ namespace {
{
const SfxInt16Item* pListLevelItem =
dynamic_cast<const SfxInt16Item*>(pItem);
- if ( pListLevelItem->GetValue() != mrTxtNode.GetAttrListLevel() )
+ if (pListLevelItem && pListLevelItem->GetValue() != mrTxtNode.GetAttrListLevel())
{
mbUpdateListLevel = true;
}
commit 620032dc7b67f051e9c89b3cd12f4b898179fd49
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:19:43 2014 +0100
coverity#704943 Unchecked dynamic_cast
Change-Id: I8d537f765e41e01c9855cd2000aa762951e2c974
diff --git a/sw/source/core/txtnode/ndtxt.cxx b/sw/source/core/txtnode/ndtxt.cxx
index 62a729b..27a0351 100644
--- a/sw/source/core/txtnode/ndtxt.cxx
+++ b/sw/source/core/txtnode/ndtxt.cxx
@@ -4462,8 +4462,8 @@ namespace {
{
const SfxInt16Item* pListRestartValueItem =
dynamic_cast<const SfxInt16Item*>(pItem);
- if ( !mrTxtNode.HasAttrListRestartValue() ||
- pListRestartValueItem->GetValue() != mrTxtNode.GetAttrListRestartValue() )
+ if ( !mrTxtNode.HasAttrListRestartValue() || (pListRestartValueItem &&
+ pListRestartValueItem->GetValue() != mrTxtNode.GetAttrListRestartValue()) )
{
mbUpdateListRestart = true;
}
commit 79971ea4774749dec23f2c6e916b6cfdc1725341
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:18:13 2014 +0100
coverity#704944 Unchecked dynamic_cast
Change-Id: If9c493eef1b8964a57c6ef28bf90c3fcde3a804f
diff --git a/sw/source/core/txtnode/ndtxt.cxx b/sw/source/core/txtnode/ndtxt.cxx
index 5b42a20..62a729b 100644
--- a/sw/source/core/txtnode/ndtxt.cxx
+++ b/sw/source/core/txtnode/ndtxt.cxx
@@ -4474,8 +4474,8 @@ namespace {
{
const SfxBoolItem* pIsCountedInListItem =
dynamic_cast<const SfxBoolItem*>(pItem);
- if ( pIsCountedInListItem && pIsCountedInListItem->GetValue() !=
- mrTxtNode.IsCountedInList() )
+ if (pIsCountedInListItem && pIsCountedInListItem->GetValue() !=
+ mrTxtNode.IsCountedInList())
{
mbUpdateListCount = true;
}
@@ -4487,7 +4487,8 @@ namespace {
{
const SfxUInt16Item* pOutlineLevelItem =
dynamic_cast<const SfxUInt16Item*>(pItem);
- if ( pOutlineLevelItem->GetValue() != mrTxtNode.GetAttrOutlineLevel() )
+ if (pOutlineLevelItem && pOutlineLevelItem->GetValue() !=
+ mrTxtNode.GetAttrOutlineLevel())
{
mbOutlineLevelSet = true;
}
commit e8eb9e9557e9b31cbf80f0b3ff553ad921de8c1b
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:12:58 2014 +0100
coverity#982428 Division or modulo by float zero
Change-Id: I2aee3d84387736195c29534761846f69d616753d
diff --git a/desktop/source/splash/splash.cxx b/desktop/source/splash/splash.cxx
index be9c078..e268b16 100644
--- a/desktop/source/splash/splash.cxx
+++ b/desktop/source/splash/splash.cxx
@@ -524,7 +524,7 @@ void SplashScreen::determineProgressRatioValues(
Rectangle aScreenArea = Application::GetScreenPosSizePixel((unsigned int)0);
nWidth = aScreenArea.GetWidth();
nHeight = aScreenArea.GetHeight();
- nScreenRatio = sal_Int32( math::round( double( nWidth ) / double( nHeight ), 2 ) * 100 );
+ nScreenRatio = nHeight ? sal_Int32( math::round( double( nWidth ) / double( nHeight ), 2 ) * 100 ) : 0;
}
char szFullScreenProgressRatio[] = "FullScreenProgressRatio0";
commit efc9dffda369723f6fac5d508c48c57dffc5279b
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:09:40 2014 +0100
coverity#982479 Unchecked dynamic_cast
Change-Id: I79f02538a44edb7fb7c1b94dbec365a30d896bb4
diff --git a/sw/source/core/docnode/ndcopy.cxx b/sw/source/core/docnode/ndcopy.cxx
index 73ebdc4..624bbc2 100644
--- a/sw/source/core/docnode/ndcopy.cxx
+++ b/sw/source/core/docnode/ndcopy.cxx
@@ -187,9 +187,10 @@ namespace
// copying additional attributes for bookmarks or fieldmarks
::sw::mark::IBookmark* const pNewBookmark =
dynamic_cast< ::sw::mark::IBookmark* const >(pNewMark);
- if(pNewBookmark)
+ const ::sw::mark::IBookmark* const pOldBookmark =
+ dynamic_cast< const ::sw::mark::IBookmark* >(pMark);
+ if (pNewBookmark && pOldBookmark)
{
- const ::sw::mark::IBookmark* const pOldBookmark = dynamic_cast< const ::sw::mark::IBookmark* >(pMark);
pNewBookmark->SetKeyCode(pOldBookmark->GetKeyCode());
pNewBookmark->SetShortName(pOldBookmark->GetShortName());
}
commit 04d6fa930dc0db76c4b4bb5bbdb21eb50d456552
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:06:43 2014 +0100
coverity#982480 Unchecked dynamic_cast
Change-Id: If8d52b0ff94377301fdc323f17cd5dc52b63214f
diff --git a/sw/source/core/docnode/ndcopy.cxx b/sw/source/core/docnode/ndcopy.cxx
index fc39655..73ebdc4 100644
--- a/sw/source/core/docnode/ndcopy.cxx
+++ b/sw/source/core/docnode/ndcopy.cxx
@@ -195,9 +195,10 @@ namespace
}
::sw::mark::IFieldmark* const pNewFieldmark =
dynamic_cast< ::sw::mark::IFieldmark* const >(pNewMark);
- if(pNewFieldmark)
+ const ::sw::mark::IFieldmark* const pOldFieldmark =
+ dynamic_cast< const ::sw::mark::IFieldmark* >(pMark);
+ if (pNewFieldmark && pOldFieldmark)
{
- const ::sw::mark::IFieldmark* const pOldFieldmark = dynamic_cast< const ::sw::mark::IFieldmark* >(pMark);
pNewFieldmark->SetFieldname(pOldFieldmark->GetFieldname());
pNewFieldmark->SetFieldHelptext(pOldFieldmark->GetFieldHelptext());
::sw::mark::IFieldmark::parameter_map_t* pNewParams = pNewFieldmark->GetParameters();
commit cc6f2fe9a9a78ccc831f5cde29a8045fdfe2f364
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 10:04:30 2014 +0100
coverity#983942 coverity gold, busted throw spec
Change-Id: Id8e024df91e99f327386571ea4773bc5c7991aee
diff --git a/sw/source/core/unocore/unocoll.cxx b/sw/source/core/unocore/unocoll.cxx
index 42f0a1e..6a6fb94 100644
--- a/sw/source/core/unocore/unocoll.cxx
+++ b/sw/source/core/unocore/unocoll.cxx
@@ -1035,7 +1035,7 @@ namespace
}
// runtime adapter for lcl_UnoWrapFrame
- static uno::Any lcl_UnoWrapFrame(SwFrmFmt* pFmt, FlyCntType eType) throw(uno::RuntimeException())
+ static uno::Any lcl_UnoWrapFrame(SwFrmFmt* pFmt, FlyCntType eType) throw(uno::RuntimeException)
{
switch(eType)
{
commit 461af812918b35a7f0c37c486813ca553bb9d840
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 09:57:21 2014 +0100
coverity#1210079 Uncaught exception
Change-Id: I135e6f7e744afbf6acdb1cfd636e301219ef1420
diff --git a/include/comphelper/accessibleselectionhelper.hxx b/include/comphelper/accessibleselectionhelper.hxx
index 161797f..dbc4c20 100644
--- a/include/comphelper/accessibleselectionhelper.hxx
+++ b/include/comphelper/accessibleselectionhelper.hxx
@@ -63,7 +63,7 @@ namespace comphelper
// select the specified child => watch for special ChildIndexes (ACCESSIBLE_SELECTION_CHILD_xxx)
virtual void
implSelect( sal_Int32 nAccessibleChildIndex, sal_Bool bSelect )
- throw (::com::sun::star::lang::IndexOutOfBoundsException, ::com::sun::star::uno::RuntimeException) = 0;
+ throw (css::lang::IndexOutOfBoundsException, css::uno::RuntimeException, std::exception) = 0;
protected:
diff --git a/svx/source/accessibility/charmapacc.cxx b/svx/source/accessibility/charmapacc.cxx
index 8019849..5dddac9 100644
--- a/svx/source/accessibility/charmapacc.cxx
+++ b/svx/source/accessibility/charmapacc.cxx
@@ -324,7 +324,8 @@ bool SvxShowCharSetAcc::implIsSelected( sal_Int32 nAccessibleChildIndex ) throw
}
// select the specified child => watch for special ChildIndexes (ACCESSIBLE_SELECTION_CHILD_xxx)
-void SvxShowCharSetAcc::implSelect( sal_Int32 nAccessibleChildIndex, sal_Bool bSelect ) throw (IndexOutOfBoundsException, RuntimeException)
+void SvxShowCharSetAcc::implSelect(sal_Int32 nAccessibleChildIndex, sal_Bool bSelect)
+ throw (IndexOutOfBoundsException, RuntimeException, std::exception)
{
if ( m_pParent )
{
diff --git a/svx/source/inc/charmapacc.hxx b/svx/source/inc/charmapacc.hxx
index 2ef144f..85951f1 100644
--- a/svx/source/inc/charmapacc.hxx
+++ b/svx/source/inc/charmapacc.hxx
@@ -196,7 +196,9 @@ namespace svx
// select the specified child => watch for special ChildIndexes (ACCESSIBLE_SELECTION_CHILD_xxx)
virtual void
implSelect( sal_Int32 nAccessibleChildIndex, sal_Bool bSelect )
- throw (::com::sun::star::lang::IndexOutOfBoundsException, ::com::sun::star::uno::RuntimeException) SAL_OVERRIDE;
+ throw (css::lang::IndexOutOfBoundsException,
+ css::uno::RuntimeException,
+ std::exception) SAL_OVERRIDE;
// OCommonAccessibleComponent
/// implements the calculation of the bounding rectangle - still waiting to be overwritten
commit c5d6aab13783aaa671b099f0813a1dd26ee9cdde
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 09:52:34 2014 +0100
coverity#1215279 Explicit null dereferenced
Change-Id: I543cde8225a78be9a9cefeaa7ebf6a5674caf9d0
diff --git a/sd/source/ui/func/fuinsfil.cxx b/sd/source/ui/func/fuinsfil.cxx
index 3959348..0dbe5f1 100644
--- a/sd/source/ui/func/fuinsfil.cxx
+++ b/sd/source/ui/func/fuinsfil.cxx
@@ -348,13 +348,16 @@ bool FuInsertFile::InsSDDinDrMode(SfxMedium* pMedium)
SdPage* pPage = NULL;
::sd::View* pView = mpViewShell ? mpViewShell->GetView() : NULL;
- if (pView->ISA(OutlineView))
+ if (pView)
{
- pPage = static_cast<OutlineView*>(pView)->GetActualPage();
- }
- else
- {
- pPage = static_cast<SdPage*>(pView->GetSdrPageView()->GetPage());
+ if (pView->ISA(OutlineView))
+ {
+ pPage = static_cast<OutlineView*>(pView)->GetActualPage();
+ }
+ else
+ {
+ pPage = static_cast<SdPage*>(pView->GetSdrPageView()->GetPage());
+ }
}
sal_uInt16 nPos = 0xFFFF;
commit 6a2017b9e9c17a1b64ea0c6770cbea2008c32f70
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 09:50:12 2014 +0100
coverity#1215280 Unchecked dynamic_cast
Change-Id: Ie03bb8a870c544eef656594f5ebab35bc61b9030
diff --git a/sc/source/core/opencl/op_addin.cxx b/sc/source/core/opencl/op_addin.cxx
index 1cc2fe1..e3bc13e 100644
--- a/sc/source/core/opencl/op_addin.cxx
+++ b/sc/source/core/opencl/op_addin.cxx
@@ -221,9 +221,9 @@ void OpGestep::GenSlidingWindowFunction(
if (pCur->GetType() == formula::svSingleVectorRef)
{
#ifdef ISNAN
- const formula::SingleVectorRefToken* pSVR =
- dynamic_cast< const formula::SingleVectorRefToken* >(pCur);
- ss << " if (gid0 < " << pSVR->GetArrayLength() << ")\n";
+ const formula::SingleVectorRefToken& rSVR =
+ dynamic_cast< const formula::SingleVectorRefToken& >(*pCur);
+ ss << " if (gid0 < " << rSVR.GetArrayLength() << ")\n";
ss << " {\n";
#endif
}
commit 505c7801bc660ebf8edb7e1467906f6e2afe3f42
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 09:49:00 2014 +0100
coverity#1215289 Resource leak
Change-Id: Ie4a0334ddb393726d982e9f4e51a45e391a1b1f0
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index df1d858..00a8876 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -2117,6 +2117,7 @@ void DrawingML::WriteShapeEffect( const OUString& sName, const Sequence< Propert
sal_Int32 nAlpha = MAX_PERCENT;
Sequence< PropertyValue > aTransformations;
sax_fastparser::FastAttributeList *aOuterShdwAttrList = mpFS->createAttrList();
+ sax_fastparser::XFastAttributeListRef xOuterShdwAttrList( aOuterShdwAttrList );
for( sal_Int32 i=0; i < aEffectProps.getLength(); ++i )
{
if( aEffectProps[i].Name == "Attribs" )
@@ -2247,8 +2248,7 @@ void DrawingML::WriteShapeEffect( const OUString& sName, const Sequence< Propert
if( nEffectToken > 0 )
{
- sax_fastparser::XFastAttributeListRef xAttrList( aOuterShdwAttrList );
- mpFS->startElement( nEffectToken, xAttrList );
+ mpFS->startElement( nEffectToken, xOuterShdwAttrList );
if( bContainsColor )
{
commit 56152538a80d143485a5e14477433cb5e682f550
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 09:47:41 2014 +0100
coverity#1215290 Resource leak
Change-Id: Ia49f4e99e6663ea95dc85d4dd09e161413a2f419
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 652b0b8..df1d858 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -2322,6 +2322,7 @@ void DrawingML::WriteShape3DEffects( Reference< XPropertySet > xPropSet )
bool bCameraRotationPresent = false;
sax_fastparser::FastAttributeList *aCameraAttrList = mpFS->createAttrList();
+ sax_fastparser::XFastAttributeListRef xCameraAttrList( aCameraAttrList );
sax_fastparser::FastAttributeList *aCameraRotationAttrList = mpFS->createAttrList();
for( sal_Int32 i=0; i < aEffectProps.getLength(); ++i )
{
@@ -2399,8 +2400,7 @@ void DrawingML::WriteShape3DEffects( Reference< XPropertySet > xPropSet )
if( aEffectProps.getLength() > 0 )
{
- sax_fastparser::XFastAttributeListRef xAttrList( aCameraAttrList );
- mpFS->startElementNS( XML_a, XML_camera, xAttrList );
+ mpFS->startElementNS( XML_a, XML_camera, xCameraAttrList );
if( bCameraRotationPresent )
{
sax_fastparser::XFastAttributeListRef xRotAttrList( aCameraRotationAttrList );
commit 354411e83afae22b22a5f7b9ff2e8762045c0667
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 09:40:06 2014 +0100
coverity#1215291 Resource leak
Change-Id: Ia62459945cd45f493754a1412b74242d3994f7f0
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 373c3b2..652b0b8 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -2362,6 +2362,7 @@ void DrawingML::WriteShape3DEffects( Reference< XPropertySet > xPropSet )
bool bLightRigRotationPresent = false;
sax_fastparser::FastAttributeList *aLightRigAttrList = mpFS->createAttrList();
+ sax_fastparser::XFastAttributeListRef xLightAttrList( aLightRigAttrList );
sax_fastparser::FastAttributeList *aLightRigRotationAttrList = mpFS->createAttrList();
sax_fastparser::XFastAttributeListRef xLightRotAttrList( aLightRigRotationAttrList );
for( sal_Int32 i=0; i < aLightRigProps.getLength(); ++i )
@@ -2413,8 +2414,7 @@ void DrawingML::WriteShape3DEffects( Reference< XPropertySet > xPropSet )
if( aEffectProps.getLength() > 0 )
{
- sax_fastparser::XFastAttributeListRef xAttrList( aLightRigAttrList );
- mpFS->startElementNS( XML_a, XML_lightRig, xAttrList );
+ mpFS->startElementNS( XML_a, XML_lightRig, xLightAttrList );
if( bLightRigRotationPresent )
{
mpFS->singleElementNS( XML_a, XML_rot, xLightRotAttrList );
commit 16e425425f2496c6320ad1b01114a07e62b8d074
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 09:35:40 2014 +0100
coverity#1215292 Resource leak
Change-Id: Ibabd73d06135a3ee500ce9d52fef42caa3ad7f35
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 994cd9b..373c3b2 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -2363,6 +2363,7 @@ void DrawingML::WriteShape3DEffects( Reference< XPropertySet > xPropSet )
bool bLightRigRotationPresent = false;
sax_fastparser::FastAttributeList *aLightRigAttrList = mpFS->createAttrList();
sax_fastparser::FastAttributeList *aLightRigRotationAttrList = mpFS->createAttrList();
+ sax_fastparser::XFastAttributeListRef xLightRotAttrList( aLightRigRotationAttrList );
for( sal_Int32 i=0; i < aLightRigProps.getLength(); ++i )
{
if( aLightRigProps[i].Name == "rig" || aLightRigProps[i].Name == "dir" )
@@ -2416,8 +2417,7 @@ void DrawingML::WriteShape3DEffects( Reference< XPropertySet > xPropSet )
mpFS->startElementNS( XML_a, XML_lightRig, xAttrList );
if( bLightRigRotationPresent )
{
- sax_fastparser::XFastAttributeListRef xRotAttrList( aLightRigRotationAttrList );
- mpFS->singleElementNS( XML_a, XML_rot, xRotAttrList );
+ mpFS->singleElementNS( XML_a, XML_rot, xLightRotAttrList );
}
mpFS->endElementNS( XML_a, XML_lightRig );
}
commit b89524f740e7320778b11e3f3d9e4912f6c00d13
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 09:34:43 2014 +0100
coverity#1215293 Resource leak
Change-Id: I4a74eb76e5fcda915e5d12257fedf3ee84b62baa
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 5c36ef3..994cd9b 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -2433,8 +2433,9 @@ void DrawingML::WriteShape3DEffects( Reference< XPropertySet > xPropSet )
bool bBevelTPresent = false, bBevelBPresent = false;
Sequence< PropertyValue > aExtrusionColorProps, aContourColorProps;
sax_fastparser::FastAttributeList *aBevelTAttrList = mpFS->createAttrList();
+ sax_fastparser::XFastAttributeListRef xBevelTAttrList( aBevelTAttrList );
sax_fastparser::FastAttributeList *aBevelBAttrList = mpFS->createAttrList();
- sax_fastparser::XFastAttributeListRef xBevelAttrList( aBevelBAttrList );
+ sax_fastparser::XFastAttributeListRef xBevelBAttrList( aBevelBAttrList );
sax_fastparser::FastAttributeList *aShape3DAttrList = mpFS->createAttrList();
for( sal_Int32 i=0; i < aShape3DProps.getLength(); ++i )
{
@@ -2509,12 +2510,11 @@ void DrawingML::WriteShape3DEffects( Reference< XPropertySet > xPropSet )
mpFS->startElementNS( XML_a, XML_sp3d, xAttrList );
if( bBevelTPresent )
{
- sax_fastparser::XFastAttributeListRef xBevelAttrList( aBevelTAttrList );
- mpFS->singleElementNS( XML_a, XML_bevelT, xBevelAttrList );
+ mpFS->singleElementNS( XML_a, XML_bevelT, xBevelTAttrList );
}
if( bBevelBPresent )
{
- mpFS->singleElementNS( XML_a, XML_bevelB, xBevelAttrList );
+ mpFS->singleElementNS( XML_a, XML_bevelB, xBevelBAttrList );
}
if( aExtrusionColorProps.getLength() > 0 )
{
commit be02c2b458dedc8b3f4129c5a46604d1902641cd
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 09:32:35 2014 +0100
coverity#1215294 Resource leak
Change-Id: I6fc18afd6189060de6943b003dea933713e19773
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 05faa6d..5c36ef3 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -2434,6 +2434,7 @@ void DrawingML::WriteShape3DEffects( Reference< XPropertySet > xPropSet )
Sequence< PropertyValue > aExtrusionColorProps, aContourColorProps;
sax_fastparser::FastAttributeList *aBevelTAttrList = mpFS->createAttrList();
sax_fastparser::FastAttributeList *aBevelBAttrList = mpFS->createAttrList();
+ sax_fastparser::XFastAttributeListRef xBevelAttrList( aBevelBAttrList );
sax_fastparser::FastAttributeList *aShape3DAttrList = mpFS->createAttrList();
for( sal_Int32 i=0; i < aShape3DProps.getLength(); ++i )
{
@@ -2513,7 +2514,6 @@ void DrawingML::WriteShape3DEffects( Reference< XPropertySet > xPropSet )
}
if( bBevelBPresent )
{
- sax_fastparser::XFastAttributeListRef xBevelAttrList( aBevelBAttrList );
mpFS->singleElementNS( XML_a, XML_bevelB, xBevelAttrList );
}
if( aExtrusionColorProps.getLength() > 0 )
commit 6ab75ecf62ddd505e366612c3221d9bfc933c465
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 09:28:28 2014 +0100
coverity#1215298 Resource leak
Change-Id: I50d248cea3d209e133f0c87d98304d4e80309a57
diff --git a/vcl/workben/svpclient.cxx b/vcl/workben/svpclient.cxx
index c9c52f5..e026c4c 100644
--- a/vcl/workben/svpclient.cxx
+++ b/vcl/workben/svpclient.cxx
@@ -201,6 +201,7 @@ OString MyWin::processCommand( const OString& rCommand )
aAnswer.append( buf, nBytes );
} while( nBytes == sizeof( buf ) );
}
+ close(nSocket);
}
else
perror( "SvpElementContainer: socket() failed\n" );
commit 1eb3c57ad1ccbfe4b41409d69d7095b8cc86a948
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 09:26:33 2014 +0100
coverity#1215302 Arguments in wrong order
Change-Id: I197e9abda098ef842f9a4d3d1bf96fbf51b5b178
diff --git a/vcl/workben/svptest.cxx b/vcl/workben/svptest.cxx
index 8ba8277..019398a 100644
--- a/vcl/workben/svptest.cxx
+++ b/vcl/workben/svptest.cxx
@@ -108,7 +108,7 @@ MyWin::MyWin( Window* pParent, WinBits nWinStyle ) :
double fBlue = 255.0-1.5*sqrt((double)((128-nX)*(128-nX)+(255-nY)*(255-nY)));
if( fBlue < 0.0 )
fBlue = 0.0;
- pAcc->SetPixel( nX, nY, BitmapColor( sal_uInt8(fRed), sal_uInt8(fGreen), sal_uInt8(fBlue) ) );
+ pAcc->SetPixel( nY, nX, BitmapColor( sal_uInt8(fRed), sal_uInt8(fGreen), sal_uInt8(fBlue) ) );
}
}
m_aBitmap.ReleaseAccess( pAcc );
commit cb30efc79f46cbd57fd138a38b483b19ba9bdd4e
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 09:23:47 2014 +0100
coverity#1215314 Uncaught exception
Change-Id: I1e3e7db0a9dc29c991f4f8ddbdcb4f3564410fba
diff --git a/ucb/source/ucp/webdav-neon/webdavcontent.cxx b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
index 60e0396..f67c852 100644
--- a/ucb/source/ucp/webdav-neon/webdavcontent.cxx
+++ b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
@@ -1939,7 +1939,7 @@ uno::Sequence< uno::Any > Content::setPropertyValues(
uno::Any Content::open(
const ucb::OpenCommandArgument3 & rArg,
const uno::Reference< ucb::XCommandEnvironment > & xEnv )
- throw( uno::Exception )
+ throw (uno::Exception, std::exception)
{
uno::Any aRet;
diff --git a/ucb/source/ucp/webdav-neon/webdavcontent.hxx b/ucb/source/ucp/webdav-neon/webdavcontent.hxx
index 060a3f5..d738ce2 100644
--- a/ucb/source/ucp/webdav-neon/webdavcontent.hxx
+++ b/ucb/source/ucp/webdav-neon/webdavcontent.hxx
@@ -154,7 +154,7 @@ private:
const com::sun::star::ucb::OpenCommandArgument3 & rArg,
const com::sun::star::uno::Reference<
com::sun::star::ucb::XCommandEnvironment > & xEnv )
- throw( ::com::sun::star::uno::Exception );
+ throw (css::uno::Exception, std::exception);
// Command "post"
void post( const com::sun::star::ucb::PostCommandArgument2 & rArg,
commit 9b62a5207745da6b926d2a311e5ddd16da1ae05b
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 09:22:44 2014 +0100
coverity#1215315 Uncaught exception
Change-Id: I0313bfc4f2d8cb30d98c32c55fd25a98f2f84f77
diff --git a/ucb/source/ucp/webdav-neon/webdavcontent.cxx b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
index cfd9abf..60e0396 100644
--- a/ucb/source/ucp/webdav-neon/webdavcontent.cxx
+++ b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
@@ -762,7 +762,8 @@ void Content::addProperty( const ucb::PropertyCommandArgument& aCmdArg,
throw( beans::PropertyExistException,
beans::IllegalTypeException,
lang::IllegalArgumentException,
- uno::RuntimeException )
+ uno::RuntimeException,
+ std::exception )
{
// if ( m_bTransient )
// @@@ ???
diff --git a/ucb/source/ucp/webdav-neon/webdavcontent.hxx b/ucb/source/ucp/webdav-neon/webdavcontent.hxx
index 5c0d104..060a3f5 100644
--- a/ucb/source/ucp/webdav-neon/webdavcontent.hxx
+++ b/ucb/source/ucp/webdav-neon/webdavcontent.hxx
@@ -211,7 +211,8 @@ private:
throw( com::sun::star::beans::PropertyExistException,
com::sun::star::beans::IllegalTypeException,
com::sun::star::lang::IllegalArgumentException,
- com::sun::star::uno::RuntimeException );
+ com::sun::star::uno::RuntimeException,
+ std::exception );
void removeProperty( const OUString& Name,
const com::sun::star::uno::Reference<
commit 1e19c72ff12f1f8bd194a843900820db4f9513f6
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 09:21:35 2014 +0100
coverity#1215316 Uncaught exception
Change-Id: Ifb688e60ef613a3735260f978dd3ae46a95430f5
diff --git a/ucb/source/ucp/webdav-neon/webdavcontent.cxx b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
index ff1b86c..cfd9abf 100644
--- a/ucb/source/ucp/webdav-neon/webdavcontent.cxx
+++ b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
@@ -900,7 +900,8 @@ void Content::removeProperty( const OUString& Name,
const uno::Reference< ucb::XCommandEnvironment >& xEnv )
throw( beans::UnknownPropertyException,
beans::NotRemoveableException,
- uno::RuntimeException )
+ uno::RuntimeException,
+ std::exception )
{
// Try to remove property from server.
diff --git a/ucb/source/ucp/webdav-neon/webdavcontent.hxx b/ucb/source/ucp/webdav-neon/webdavcontent.hxx
index 7e9c851..5c0d104 100644
--- a/ucb/source/ucp/webdav-neon/webdavcontent.hxx
+++ b/ucb/source/ucp/webdav-neon/webdavcontent.hxx
@@ -218,7 +218,8 @@ private:
com::sun::star::ucb::XCommandEnvironment >& Environment )
throw( com::sun::star::beans::UnknownPropertyException,
com::sun::star::beans::NotRemoveableException,
- com::sun::star::uno::RuntimeException );
+ com::sun::star::uno::RuntimeException,
+ std::exception );
public:
Content( const ::com::sun::star::uno::Reference<
commit b01f64852c6b613dcbcd582fa045adf432fb611f
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 09:17:20 2014 +0100
inherit the other DAVException from std::exception too
Change-Id: I692ad423b2fea0cc38b2859855f32f286423f02d
diff --git a/ucb/source/ucp/webdav/DAVException.hxx b/ucb/source/ucp/webdav/DAVException.hxx
index 5d3700a..0d9e561 100644
--- a/ucb/source/ucp/webdav/DAVException.hxx
+++ b/ucb/source/ucp/webdav/DAVException.hxx
@@ -95,7 +95,7 @@ const sal_uInt16 SC_INSUFFICIENT_STORAGE = 507;
-class DAVException
+class DAVException : public std::exception
{
public:
enum ExceptionCode {
commit 9de3fd2da6d77da6a7abc105712696f183bf6bc3
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 09:07:49 2014 +0100
coverity#1215398 Uninitialized scalar field
Change-Id: I5e18b4d824931e489af3d8625e06974f2b488e75
diff --git a/chart2/source/view/inc/GL3DRenderer.hxx b/chart2/source/view/inc/GL3DRenderer.hxx
index c1cfdcf..cf19979 100644
--- a/chart2/source/view/inc/GL3DRenderer.hxx
+++ b/chart2/source/view/inc/GL3DRenderer.hxx
@@ -249,11 +249,29 @@ private:
GLint m_RenderVertexID;
GLint m_RenderTexCoordID;
- ShaderResources():
- m_3DProID(0),
- m_TextProID(0),
- m_CommonProID(0),
- m_RenderProID(0) {}
+ ShaderResources()
+ : m_3DProID(0)
+ , m_3DProjectionID(0)
+ , m_3DViewID(0)
+ , m_3DModelID(0)
+ , m_3DNormalMatrixID(0)
+ , m_3DVertexID(0)
+ , m_3DNormalID(0)
+ , m_TextProID(0)
+ , m_TextMatrixID(0)
+ , m_TextVertexID(0)
+ , m_TextTexCoordID(0)
+ , m_TextTexID(0)
+ , m_CommonProID(0)
+ , m_2DVertexID(0)
+ , m_2DColorID(0)
+ , m_MatrixID(0)
+ , m_RenderProID(0)
+ , m_RenderTexID(0)
+ , m_RenderVertexID(0)
+ , m_RenderTexCoordID(0)
+ {
+ }
~ShaderResources()
{
commit 50304242900eb256ad5d0168f7a9448dd4b82616
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri May 23 09:04:40 2014 +0100
coverity#1215399 Uninitialized scalar field
Change-Id: If043310b3a4ac8dcc0ed63aeeeaffdfc9af8b46f
diff --git a/chart2/source/view/inc/GL3DRenderer.hxx b/chart2/source/view/inc/GL3DRenderer.hxx
index 6943012..c1cfdcf 100644
--- a/chart2/source/view/inc/GL3DRenderer.hxx
+++ b/chart2/source/view/inc/GL3DRenderer.hxx
@@ -274,8 +274,13 @@ private:
GLint m_2DColorID;
GLint m_MatrixID;
- PickingShaderResources():
- m_CommonProID(0) {}
+ PickingShaderResources()
+ : m_CommonProID(0)
+ , m_2DVertexID(0)
+ , m_2DColorID(0)
+ , m_MatrixID(0)
+ {
+ }
~PickingShaderResources()
{
More information about the Libreoffice-commits
mailing list