[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sc/source

Caolán McNamara caolanm at redhat.com
Wed May 28 09:24:14 PDT 2014


 sc/source/core/data/dpgroup.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dd2013f9d2926e65baeb1ba681f29ebc1286d8aa
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed May 28 16:19:36 2014 +0100

    coverity#1078626 Missing break in switch
    
    Change-Id: I4b9b846049d9802a319b403e1f45734b7bd604f2
    (cherry picked from commit 4e3e1420af51f7776dceb6b2800b761e57ddfe63)
    Reviewed-on: https://gerrit.libreoffice.org/9529
    Tested-by: Kohei Yoshida <libreoffice at kohei.us>
    Reviewed-by: Kohei Yoshida <libreoffice at kohei.us>

diff --git a/sc/source/core/data/dpgroup.cxx b/sc/source/core/data/dpgroup.cxx
index e5da799..2936939 100644
--- a/sc/source/core/data/dpgroup.cxx
+++ b/sc/source/core/data/dpgroup.cxx
@@ -287,7 +287,7 @@ bool isDateInGroup(const ScDPItemData& rGroupItem, const ScDPItemData& rChildIte
             if (nGroupPart == com::sun::star::sheet::DataPilotFieldGroupBy::QUARTERS)
                 // months and quarters are both 1-based
                 return (nGroupValue - 1 == (nChildValue - 1) / 3);
-
+            break;
         case com::sun::star::sheet::DataPilotFieldGroupBy::DAYS:
             // a day is only contained in its quarter or month
             if (nGroupPart == com::sun::star::sheet::DataPilotFieldGroupBy::MONTHS ||


More information about the Libreoffice-commits mailing list