[Libreoffice-commits] core.git: 26 commits - rsc/source sd/source sfx2/source soltools/cpp soltools/mkdepend starmath/source svx/source sw/source

Caolán McNamara caolanm at redhat.com
Fri May 30 06:19:35 PDT 2014


 rsc/source/parser/erscerr.cxx                |    1 +
 rsc/source/parser/rsclex.cxx                 |    1 +
 rsc/source/rscpp/cpp2.c                      |    1 +
 sd/source/filter/ppt/pptin.cxx               |    2 ++
 sfx2/source/dialog/templdlg.cxx              |   15 ++++++++-------
 soltools/cpp/_lex.c                          |    1 +
 soltools/mkdepend/parse.c                    |    2 ++
 starmath/source/mathtype.cxx                 |    2 ++
 svx/source/customshapes/tbxcustomshapes.cxx  |    3 +--
 sw/source/core/layout/calcmove.cxx           |    2 +-
 sw/source/core/layout/pagechg.cxx            |    2 +-
 sw/source/core/layout/tabfrm.cxx             |    2 +-
 sw/source/filter/html/htmlgrin.cxx           |    3 +++
 sw/source/filter/html/htmltab.cxx            |    4 ++++
 sw/source/filter/html/parcss1.cxx            |    1 +
 sw/source/uibase/docvw/edtwin.cxx            |    6 +++---
 sw/source/uibase/shells/langhelper.cxx       |    4 ++--
 sw/source/uibase/uiview/viewling.cxx         |    2 +-
 sw/source/uibase/uno/SwXDocumentSettings.cxx |    1 +
 19 files changed, 37 insertions(+), 18 deletions(-)

New commits:
commit c3c1cf88f2e6982604c885b108ff72881213f3d8
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 13:27:43 2014 +0100

    coverity#705195 Missing break in switch
    
    Change-Id: I7374fbcd6b89569530db5053fe2d9ac301ffbb80

diff --git a/rsc/source/parser/erscerr.cxx b/rsc/source/parser/erscerr.cxx
index f11425d..c5a9fd7 100644
--- a/rsc/source/parser/erscerr.cxx
+++ b/rsc/source/parser/erscerr.cxx
@@ -124,6 +124,7 @@ void RscError::WriteError( const ERRTYPE& rError, const char * pMessage )
 
         case ERR_NOINPUT:
             StdLstErr( "Input file was not specified.\n");
+            //fall-through
         case ERR_USAGE:
             StdLstOut( "Copyright (C) 2000 - 2012 LibreOffice contributors.\n" );
             {
commit 813d4d3b8d9b67bb5892ab28f081c3d77fd30ba0
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 13:27:09 2014 +0100

    coverity#705196 Missing break in switch
    
    Change-Id: Ib757a4cf5c6bf6fa59b2eb1a3cb3c9c3c55431bc

diff --git a/rsc/source/parser/rsclex.cxx b/rsc/source/parser/rsclex.cxx
index bcfb796..09830852 100644
--- a/rsc/source/parser/rsclex.cxx
+++ b/rsc/source/parser/rsclex.cxx
@@ -254,6 +254,7 @@ int MakeToken( YYSTYPE * pTokenVal )
                     break;
                 case INCLUDE:
                     bLastInclude = true;
+                    //fall-through
                 default:
                     pTokenVal->value = aKey.yylval;
                 }
commit cf28ba611b467b248cfa57b846c74a40ad41ef98
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 13:26:19 2014 +0100

    coverity#705197 Missing break in switch
    
    Change-Id: I3a171be59989b53e1a96f0e4c640142bb8e64321

diff --git a/rsc/source/rscpp/cpp2.c b/rsc/source/rscpp/cpp2.c
index 578052c..b7224ac 100644
--- a/rsc/source/rscpp/cpp2.c
+++ b/rsc/source/rscpp/cpp2.c
@@ -110,6 +110,7 @@ control(int counter)
         case L_nodebug: tp = "nodebug";         break;
 #endif
         default:        hash = L_nogood;
+        /*fall-through*/
         case L_nogood:  tp = "";                break;
         }
         if (!streq(tp, token))
commit 7b75f9a1447607c99ed67fb8ccf081097a2a495e
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 13:25:09 2014 +0100

    coverity#705222 Missing break in switch
    
    Change-Id: Ie127c5238fd2f69f52fb3cbe4090929eb23566f4

diff --git a/sd/source/filter/ppt/pptin.cxx b/sd/source/filter/ppt/pptin.cxx
index ea65385..862c6bb 100644
--- a/sd/source/filter/ppt/pptin.cxx
+++ b/sd/source/filter/ppt/pptin.cxx
@@ -1213,6 +1213,7 @@ bool ImplSdPPTImport::Import()
                     break;
                     case 10 :   // titlemaster
                         nSelectedPage = 1;
+                        //fall-through
                     case 2 :    // master
                     {
                         ePageKind = PK_STANDARD;
commit 8ce36c373635cc3571622063d253aadafdecd229
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 13:24:43 2014 +0100

    coverity#705223 Missing break in switch
    
    Change-Id: I7b6f64fccc0fc16dff2d060c035fbad0ebb73335

diff --git a/sd/source/filter/ppt/pptin.cxx b/sd/source/filter/ppt/pptin.cxx
index 80653bc..ea65385 100644
--- a/sd/source/filter/ppt/pptin.cxx
+++ b/sd/source/filter/ppt/pptin.cxx
@@ -1221,6 +1221,7 @@ bool ImplSdPPTImport::Import()
                     break;
                     case 5 :    // notes master
                         eEditMode = EM_MASTERPAGE;
+                        //fall-through
                     case 3 :    // notes
                         ePageKind = PK_NOTES;
                     break;
commit 67502178f189f4550834ef4177ca050202c81cc3
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 13:23:09 2014 +0100

    coverity#705235 Missing break in switch
    
    Change-Id: I19e8e6aa08dc879f273f2a0177b40435c0ac553d

diff --git a/soltools/cpp/_lex.c b/soltools/cpp/_lex.c
index f8157a8..1975d19 100644
--- a/soltools/cpp/_lex.c
+++ b/soltools/cpp/_lex.c
@@ -392,6 +392,7 @@ continue2:
                 case S_SELF:
                     ip += runelen;
                     runelen = 1;
+                    /*fall-through*/
                 case S_SELFB:
                     tp->type = (unsigned char) GETACT(state);
                     tp->len = ip - tp->t;
commit 2ac988e04200985170b783d9cf087b9548a0be5a
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 13:22:34 2014 +0100

    coverity#705236 Missing break in switch
    
    Change-Id: I8065789618f806d01cdb69a18502dfafd962b9f3

diff --git a/soltools/mkdepend/parse.c b/soltools/mkdepend/parse.c
index 4cb1f37..7d95f0a 100644
--- a/soltools/mkdepend/parse.c
+++ b/soltools/mkdepend/parse.c
@@ -111,6 +111,7 @@ int find_includes(struct filepointer *filep, struct inclist *file, struct inclis
         case ELIF:
             if (!recursion)
                 gobble(filep, file, file_red, symbols);
+            /*fall-through*/
         case ENDIF:
             if (recursion)
                 return(type);
commit 19492508b5aa7262fd80db240b0c8efbcd8709e2
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 13:22:04 2014 +0100

    coverity#705237 Missing break in switch
    
    Change-Id: I1f8c9aa6c7b4403346ee43501a3555abbccf1cfb

diff --git a/soltools/mkdepend/parse.c b/soltools/mkdepend/parse.c
index 0acc9ea..4cb1f37 100644
--- a/soltools/mkdepend/parse.c
+++ b/soltools/mkdepend/parse.c
@@ -114,6 +114,7 @@ int find_includes(struct filepointer *filep, struct inclist *file, struct inclis
         case ENDIF:
             if (recursion)
                 return(type);
+            /*fall-through*/
         case DEFINE:
             define(line, &symbols);
             break;
commit 861e3a23b94c9ff359ceeb3a512e12de5081282c
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 13:20:37 2014 +0100

    coverity#705239 Missing break in switch
    
    Change-Id: Ic11f6640b6c60feed06ee988796823aaada76739

diff --git a/starmath/source/mathtype.cxx b/starmath/source/mathtype.cxx
index 42e7f28..fb2ca532 100644
--- a/starmath/source/mathtype.cxx
+++ b/starmath/source/mathtype.cxx
@@ -2635,11 +2635,13 @@ void MathType::HandleOperator(SmNode *pNode,int nLevel)
         pS->WriteUChar( sal_uInt8(CHAR) );
         pS->WriteUChar( sal_uInt8(0x86) );
         pS->WriteUInt16( sal_uInt16(0x222B) );
+        ///fall-through
     case TIINT:
     case TLLINT:
         pS->WriteUChar( sal_uInt8(CHAR) );
         pS->WriteUChar( sal_uInt8(0x86) );
         pS->WriteUInt16( sal_uInt16(0x222B) );
+        ///fall-through
     case TINT:
     case TINTD:
     case TLINT:
commit b19043b89b52140733a94a4e12f0054fbc9add6c
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 13:17:59 2014 +0100

    coverity#705256 Missing break in switch
    
    Change-Id: I173926b7966d0d75b51652a3983d73923fa2e575

diff --git a/svx/source/customshapes/tbxcustomshapes.cxx b/svx/source/customshapes/tbxcustomshapes.cxx
index 4a8fff2..bb25d07 100644
--- a/svx/source/customshapes/tbxcustomshapes.cxx
+++ b/svx/source/customshapes/tbxcustomshapes.cxx
@@ -42,9 +42,8 @@ SvxTbxCtlCustomShapes::SvxTbxCtlCustomShapes( sal_uInt16 nSlotId, sal_uInt16 nId
     switch( nSlotId )
     {
         default :
-        {
             DBG_ASSERT( false, "SvxTbxCtlCustomShapes: unknown slot executed. ?" );
-        }
+            //fall-through
         case SID_DRAWTBX_CS_BASIC :
         {
             m_aCommand = ".uno:BasicShapes.diamond";
commit 87574542fc953a60bc2bafe8ed725500f9322521
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 13:09:28 2014 +0100

    coverity#736074 Missing break in switch
    
    Change-Id: Ie60f70e992323b9841c854edc083f686bbeda1f5

diff --git a/sw/source/uibase/uno/SwXDocumentSettings.cxx b/sw/source/uibase/uno/SwXDocumentSettings.cxx
index a9cfec8..d9ea5ad 100644
--- a/sw/source/uibase/uno/SwXDocumentSettings.cxx
+++ b/sw/source/uibase/uno/SwXDocumentSettings.cxx
@@ -777,6 +777,7 @@ void SwXDocumentSettings::_setSingleValue( const comphelper::PropertyInfo & rInf
             bool bTmp = *(sal_Bool*)rValue.getValue();
             mpDoc->set(IDocumentSettingAccess::EMBED_FONTS, bTmp);
         }
+        break;
         case HANDLE_EMBED_SYSTEM_FONTS:
         {
             bool bTmp = *(sal_Bool*)rValue.getValue();
commit 580fe11522da7691c2bb6901554c95516679df01
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 13:04:12 2014 +0100

    coverity#1078633 Missing break in switch
    
    Change-Id: I37c46fd88bbc7a66a6c5691dbd79754fa5078ea5

diff --git a/sw/source/filter/html/parcss1.cxx b/sw/source/filter/html/parcss1.cxx
index c980427..1a96cfd 100644
--- a/sw/source/filter/html/parcss1.cxx
+++ b/sw/source/filter/html/parcss1.cxx
@@ -1052,6 +1052,7 @@ CSS1Expression *CSS1Parser::ParseDeclaration( OUString& rProperty )
         case CSS1_EMX:
             if( '-'==cSign )
                 nValue = -nValue;
+            //fall-through
         case CSS1_STRING:
         case CSS1_PERCENTAGE:
         case CSS1_IDENT:
commit 1401a888575ffeff36e83d2213d8e3d6d85380a0
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 13:01:06 2014 +0100

    coverity#1130413 Missing break in switch
    
    Change-Id: Idb20ce02b720b3d464b0b6138eee0017f1a3b44c

diff --git a/sw/source/filter/html/htmlgrin.cxx b/sw/source/filter/html/htmlgrin.cxx
index c6a3f46..30d9dd1 100644
--- a/sw/source/filter/html/htmlgrin.cxx
+++ b/sw/source/filter/html/htmlgrin.cxx
@@ -1102,6 +1102,7 @@ void SwHTMLParser::NewAnchor()
 
             case HTML_O_SDONCLICK:
                 eScriptType2 = STARBASIC;
+                //fall-through
             case HTML_O_ONCLICK:
                 nEvent = SFX_EVENT_MOUSECLICK_OBJECT;
                 goto ANCHOR_SETEVENT;
commit 8ec75cc1c47ca7a8cb87263060f868c68a152b01
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 13:00:37 2014 +0100

    coverity#1130414 Missing break in switch
    
    Change-Id: I2a1a6e39fce01a7b6039cc3da2ce34255d6f2168

diff --git a/sw/source/filter/html/htmlgrin.cxx b/sw/source/filter/html/htmlgrin.cxx
index 14f5328..c6a3f46 100644
--- a/sw/source/filter/html/htmlgrin.cxx
+++ b/sw/source/filter/html/htmlgrin.cxx
@@ -1115,6 +1115,7 @@ void SwHTMLParser::NewAnchor()
 
             case HTML_O_SDONMOUSEOUT:
                 eScriptType2 = STARBASIC;
+                //fall-through
             case HTML_O_ONMOUSEOUT:
                 nEvent = SFX_EVENT_MOUSEOUT_OBJECT;
                 goto ANCHOR_SETEVENT;
commit 79842696cdcba7d5561abc803c8e30f11fe648b5
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 12:59:20 2014 +0100

    coverity#1130415 Missing break in switch
    
    Change-Id: I6a424343456e6f794823b5994fbf135fb3daf034

diff --git a/sw/source/filter/html/htmlgrin.cxx b/sw/source/filter/html/htmlgrin.cxx
index be1ac1c..14f5328 100644
--- a/sw/source/filter/html/htmlgrin.cxx
+++ b/sw/source/filter/html/htmlgrin.cxx
@@ -1108,6 +1108,7 @@ void SwHTMLParser::NewAnchor()
 
             case HTML_O_SDONMOUSEOVER:
                 eScriptType2 = STARBASIC;
+                //fall-through
             case HTML_O_ONMOUSEOVER:
                 nEvent = SFX_EVENT_MOUSEOVER_OBJECT;
                 goto ANCHOR_SETEVENT;
commit 31a480cf714e9238b327c275666628499c331ffc
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 12:54:11 2014 +0100

    coverity#1202815 Missing break in switch
    
    Change-Id: Ic18a984c4c05367ac1a863a27620c83391d5bac5

diff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx
index 6fcc9de..56396a7 100644
--- a/sfx2/source/dialog/templdlg.cxx
+++ b/sfx2/source/dialog/templdlg.cxx
@@ -2643,13 +2643,14 @@ void SfxTemplateDialog_Impl::EnableItem(sal_uInt16 nMesId, bool bCheck)
     OUString aEmpty;
     switch(nMesId)
     {
-      case SID_STYLE_WATERCAN :
-          if(!bCheck && IsCheckedItem(SID_STYLE_WATERCAN))
-            Execute_Impl(SID_STYLE_WATERCAN, aEmpty, aEmpty, 0);
-      case SID_STYLE_NEW_BY_EXAMPLE:
-      case SID_STYLE_UPDATE_BY_EXAMPLE:
-        m_aActionTbR.EnableItem(nMesId,bCheck);
-        break;
+        case SID_STYLE_WATERCAN :
+            if(!bCheck && IsCheckedItem(SID_STYLE_WATERCAN))
+                Execute_Impl(SID_STYLE_WATERCAN, aEmpty, aEmpty, 0);
+            //fall-through
+        case SID_STYLE_NEW_BY_EXAMPLE:
+        case SID_STYLE_UPDATE_BY_EXAMPLE:
+            m_aActionTbR.EnableItem(nMesId,bCheck);
+            break;
     }
 }
 
commit 3f2cf1cbd5e8e56cf65ec8c987fface7690d6b7f
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 12:51:08 2014 +0100

    coverity#1213143 Missing break in switch
    
    Change-Id: Ief8178f5aa829fba40134d92e686910f1e8f0c54

diff --git a/sw/source/filter/html/htmltab.cxx b/sw/source/filter/html/htmltab.cxx
index 4d82189..7be47f0 100644
--- a/sw/source/filter/html/htmltab.cxx
+++ b/sw/source/filter/html/htmltab.cxx
@@ -3876,6 +3876,7 @@ void SwHTMLParser::BuildTableCell( HTMLTable *pCurTable, bool bReadOptions,
         case HTML_TBODY_OFF:
         case HTML_TABLE_OFF:
             SkipToken(-1);
+            //fall-through
         case HTML_TABLEHEADER_OFF:
         case HTML_TABLEDATA_OFF:
             bDone = true;
commit 4c34e45e72ea4537efe5bd66308783b1568b0d74
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 12:50:18 2014 +0100

    coverity#1213145 Missing break in switch
    
    Change-Id: I88e75d08db68417a931e47c1747900dd3fd1adad

diff --git a/sw/source/filter/html/htmltab.cxx b/sw/source/filter/html/htmltab.cxx
index 8bddcc9..4d82189 100644
--- a/sw/source/filter/html/htmltab.cxx
+++ b/sw/source/filter/html/htmltab.cxx
@@ -4278,6 +4278,7 @@ void SwHTMLParser::BuildTableRow( HTMLTable *pCurTable, bool bReadOptions,
         case HTML_TFOOT_OFF:
         case HTML_TABLE_OFF:
             SkipToken( -1 );
+            //fall-through
         case HTML_TABLEROW_OFF:
             bDone = true;
             break;
commit 2b4b5684a6f0bfb29d4e7ed94f1afc3adc4d6815
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 12:49:42 2014 +0100

    coverity#1213146 Missing break in switch
    
    Change-Id: Ib3e5476cf764862f29e6c964bf0f8879b0f416c1

diff --git a/sw/source/filter/html/htmltab.cxx b/sw/source/filter/html/htmltab.cxx
index 1d36227..8bddcc9 100644
--- a/sw/source/filter/html/htmltab.cxx
+++ b/sw/source/filter/html/htmltab.cxx
@@ -4450,6 +4450,7 @@ void SwHTMLParser::BuildTableSection( HTMLTable *pCurTable,
         case HTML_TBODY_ON:
         case HTML_TABLE_OFF:
             SkipToken( -1 );
+            //fall-through
         case HTML_THEAD_OFF:
         case HTML_TBODY_OFF:
         case HTML_TFOOT_OFF:
commit 60c70bb44a9e757217d122a2ab5d8a2f68acbe46
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 12:48:10 2014 +0100

    coverity#1213147 Missing break in switch
    
    Change-Id: Icafdcadb22da84d9f8cdb8928aa5e2c148993384

diff --git a/sw/source/filter/html/htmltab.cxx b/sw/source/filter/html/htmltab.cxx
index efa34d8..1d36227 100644
--- a/sw/source/filter/html/htmltab.cxx
+++ b/sw/source/filter/html/htmltab.cxx
@@ -4645,6 +4645,7 @@ void SwHTMLParser::BuildTableColGroup( HTMLTable *pCurTable,
         case HTML_TABLEROW_ON:
         case HTML_TABLE_OFF:
             SkipToken( -1 );
+            //fall-through
         case HTML_COLGROUP_OFF:
             bDone = true;
             break;
commit 87b991cac047bbbb41f37465e1a509077f4d2f5b
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 12:30:47 2014 +0100

    coverity#705031 Unchecked dynamic_cast
    
    Change-Id: I492db48ee0b3098dddad638736f3d2e062dc6ceb

diff --git a/sw/source/uibase/uiview/viewling.cxx b/sw/source/uibase/uiview/viewling.cxx
index 329f7e5..dfdf331 100644
--- a/sw/source/uibase/uiview/viewling.cxx
+++ b/sw/source/uibase/uiview/viewling.cxx
@@ -712,7 +712,7 @@ bool SwView::ExecSpellPopup(const Point& rPt)
                         OUString aCommand = ((PopupMenu*)pMenu)->GetItemCommand(nId);
                         if (aCommand.isEmpty() )
                         {
-                            if(!ExecuteMenuCommand( *dynamic_cast<PopupMenu*>(pMenu), *GetViewFrame(), nId ))
+                            if(!ExecuteMenuCommand(dynamic_cast<PopupMenu&>(*pMenu), *GetViewFrame(), nId ))
                                 pPopup->Execute(nId);
                         }
                         else
commit ddff02a6cb58cba8a98b6edf234ad413b1a4eaa7
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 12:30:00 2014 +0100

    coverity#705026 Unchecked dynamic_cast
    
    Change-Id: I76aeefc705481249b0197839a9db3eecb34adc92

diff --git a/sw/source/uibase/shells/langhelper.cxx b/sw/source/uibase/shells/langhelper.cxx
index e3d7178..d7fa3f5 100644
--- a/sw/source/uibase/shells/langhelper.cxx
+++ b/sw/source/uibase/shells/langhelper.cxx
@@ -425,12 +425,12 @@ namespace SwLangHelper
         if (nState > SFX_ITEM_DEFAULT && pItem)
         {
             // the item is set and can be used
-            nLang = (dynamic_cast< const SvxLanguageItem* >(pItem))->GetLanguage();
+            nLang = (dynamic_cast<const SvxLanguageItem&>(*pItem)).GetLanguage();
         }
         else if (nState == SFX_ITEM_DEFAULT)
         {
             // since the attribute is not set: retrieve the default value
-            nLang = (dynamic_cast< const SvxLanguageItem& >(aSet.GetPool()->GetDefaultItem( nLangWhichId ))).GetLanguage();
+            nLang = (dynamic_cast<const SvxLanguageItem&>(aSet.GetPool()->GetDefaultItem( nLangWhichId ))).GetLanguage();
         }
         else if (nState == SFX_ITEM_DONTCARE)
         {
commit 911fbff985dfc6ef08e13eb2136c70f65b221259
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 12:24:48 2014 +0100

    coverity#705014 Unchecked dynamic_cast
    
    Change-Id: Iec924d7697c2ccdf63f4d6748b819943d0870d48

diff --git a/sw/source/uibase/docvw/edtwin.cxx b/sw/source/uibase/docvw/edtwin.cxx
index 5b96f79..bf7f537 100644
--- a/sw/source/uibase/docvw/edtwin.cxx
+++ b/sw/source/uibase/docvw/edtwin.cxx
@@ -4534,9 +4534,9 @@ void SwEditWin::MouseButtonUp(const MouseEvent& rMEvt)
                                     IFieldmark *fieldBM = const_cast< IFieldmark* > ( aCntntAtPos.aFnd.pFldmark );
                                     if ( fieldBM->GetFieldname( ) == ODF_FORMCHECKBOX )
                                     {
-                                        ICheckboxFieldmark* pCheckboxFm = dynamic_cast<ICheckboxFieldmark*>(fieldBM);
-                                        pCheckboxFm->SetChecked(!pCheckboxFm->IsChecked());
-                                        pCheckboxFm->Invalidate();
+                                        ICheckboxFieldmark& rCheckboxFm = dynamic_cast<ICheckboxFieldmark&>(*fieldBM);
+                                        rCheckboxFm.SetChecked(!rCheckboxFm.IsChecked());
+                                        rCheckboxFm.Invalidate();
                                         rSh.InvalidateWindows( m_rView.GetVisArea() );
                                     } else if ( fieldBM->GetFieldname() == ODF_FORMDROPDOWN ) {
                                         m_rView.ExecFieldPopup( aDocPt, fieldBM );
commit 371f730829cbd51500556bf462f2ea7ad288eead
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 12:22:14 2014 +0100

    coverity#704917 Unchecked dynamic_cast
    
    Change-Id: I031b249a2b074c6ba8eb291fa2ade8df0ae74112

diff --git a/sw/source/core/layout/tabfrm.cxx b/sw/source/core/layout/tabfrm.cxx
index 110459d..94aaa6c 100644
--- a/sw/source/core/layout/tabfrm.cxx
+++ b/sw/source/core/layout/tabfrm.cxx
@@ -1593,7 +1593,7 @@ static bool lcl_NoPrev( const SwFrm& rFrm )
         const SwFrm* pPrev( rFrm.GetPrev() );
         while ( pPrev &&
                 pPrev->IsSctFrm() &&
-                !dynamic_cast<const SwSectionFrm*>(pPrev)->GetSection() )
+                !dynamic_cast<const SwSectionFrm&>(*pPrev).GetSection() )
         {
             pPrev = pPrev->GetPrev();
             bSkippedDirectPrevEmptySection = true;
commit f1c705da1642e4f637be3610856e5b10e509aa4e
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 12:16:15 2014 +0100

    coverity#704912 Unchecked dynamic_cast
    
    Change-Id: I1383d63d3513dfcb8763857a49742a756836987f

diff --git a/sw/source/core/layout/pagechg.cxx b/sw/source/core/layout/pagechg.cxx
index f1307bc..4808dd5 100644
--- a/sw/source/core/layout/pagechg.cxx
+++ b/sw/source/core/layout/pagechg.cxx
@@ -2208,7 +2208,7 @@ bool SwRootFrm::IsLeftToRightViewLayout() const
     // #i88036#
     // Only ask a non-empty page frame for its layout direction
     const SwPageFrm& rPage =
-                    dynamic_cast<const SwPageFrm*>(Lower())->GetFormatPage();
+                    dynamic_cast<const SwPageFrm&>(*Lower()).GetFormatPage();
     return !rPage.IsRightToLeft() && !rPage.IsVertical();
 }
 
commit b89069a863431538612b1bbb6b44cf9126d231a5
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 30 12:14:44 2014 +0100

    coverity#704896 704896 Unchecked dynamic_cast
    
    Change-Id: Ibc24125d90d324033673988567cd5925dee9ee53

diff --git a/sw/source/core/layout/calcmove.cxx b/sw/source/core/layout/calcmove.cxx
index 5400d14..85a09bb 100644
--- a/sw/source/core/layout/calcmove.cxx
+++ b/sw/source/core/layout/calcmove.cxx
@@ -1122,7 +1122,7 @@ void SwCntntFrm::MakeAll()
          HasFollow() &&
          GetFollow()->GetFrm() == GetNext() )
     {
-        dynamic_cast<SwTxtFrm*>(this)->JoinFrm();
+        dynamic_cast<SwTxtFrm&>(*this).JoinFrm();
     }
 
     // #i28701# - move master forward, if it has to move,


More information about the Libreoffice-commits mailing list